All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-07 14:06 ` sarha
  0 siblings, 0 replies; 11+ messages in thread
From: sarha @ 2023-03-07 14:06 UTC (permalink / raw)
  To: Thomas Zimmermann, javierm, maarten.lankhorst, mripard, airlied,
	daniel, andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer,
	kernel, festevam, linux-imx, p.zabel, anitha.chrisanthus,
	edmund.j.dea, khilman, jbrunet, martin.blumenstingl,
	alain.volmat, yannick.fertre, raphael.gallais-pou,
	philippe.cornu, mcoquelin.stm32, alexandre.torgue,
	jernej.skrabec, samuel, jyri.sarha, tomba, linus.walleij,
	hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi

March 1, 2023 at 5:30 PM, "Thomas Zimmermann" <tzimmermann@suse.de mailto:tzimmermann@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote:

> 
> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> 

Acked-by: Jyri Sarha <jyri.s

> 
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4ca426007dc8..fe56beea3e93 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -16,7 +16,7 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_debugfs.h>
> #include <drm/drm_drv.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_dma.h>
> #include <drm/drm_fourcc.h>
> #include <drm/drm_gem_dma_helper.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> @@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
> goto init_failed;
> priv->is_registered = true;
> 
> - drm_fbdev_generic_setup(ddev, bpp);
> + drm_fbdev_dma_setup(ddev, bpp);
> return 0;
> 
> init_failed:
> -- 
> 2.39.2
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-07 14:06 ` sarha
  0 siblings, 0 replies; 11+ messages in thread
From: sarha @ 2023-03-07 14:06 UTC (permalink / raw)
  To: Thomas Zimmermann, javierm, maarten.lankhorst, mripard, airlied,
	daniel, andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer,
	kernel, festevam, linux-imx, p.zabel, anitha.chrisanthus,
	edmund.j.dea, khilman, jbrunet, martin.blumenstingl,
	alain.volmat, yannick.fertre, raphael.gallais-pou,
	philippe.cornu, mcoquelin.stm32, alexandre.torgue,
	jernej.skrabec, samuel, jyri.sarha, tomba, linus.walleij,
	hyun.kwon, laurent.pinchart
  Cc: linux-aspeed, dri-devel, linux-stm32, linux-amlogic, linux-sunxi,
	linux-arm-kernel

March 1, 2023 at 5:30 PM, "Thomas Zimmermann" <tzimmermann@suse.de mailto:tzimmermann@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote:

> 
> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> 

Acked-by: Jyri Sarha <jyri.s

> 
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4ca426007dc8..fe56beea3e93 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -16,7 +16,7 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_debugfs.h>
> #include <drm/drm_drv.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_dma.h>
> #include <drm/drm_fourcc.h>
> #include <drm/drm_gem_dma_helper.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> @@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
> goto init_failed;
> priv->is_registered = true;
> 
> - drm_fbdev_generic_setup(ddev, bpp);
> + drm_fbdev_dma_setup(ddev, bpp);
> return 0;
> 
> init_failed:
> -- 
> 2.39.2
>

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-07 14:06 ` sarha
  0 siblings, 0 replies; 11+ messages in thread
From: sarha @ 2023-03-07 14:06 UTC (permalink / raw)
  To: Thomas Zimmermann, javierm, maarten.lankhorst, mripard, airlied,
	daniel, andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer,
	kernel, festevam, linux-imx, p.zabel, anitha.chrisanthus,
	edmund.j.dea, khilman, jbrunet, martin.blumenstingl,
	alain.volmat, yannick.fertre, raphael.gallais-pou,
	philippe.cornu, mcoquelin.stm32, alexandre.torgue,
	jernej.skrabec, samuel, jyri.sarha, tomba, linus.walleij,
	hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi

March 1, 2023 at 5:30 PM, "Thomas Zimmermann" <tzimmermann@suse.de mailto:tzimmermann@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote:

> 
> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> 

Acked-by: Jyri Sarha <jyri.s

> 
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4ca426007dc8..fe56beea3e93 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -16,7 +16,7 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_debugfs.h>
> #include <drm/drm_drv.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_dma.h>
> #include <drm/drm_fourcc.h>
> #include <drm/drm_gem_dma_helper.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> @@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
> goto init_failed;
> priv->is_registered = true;
> 
> - drm_fbdev_generic_setup(ddev, bpp);
> + drm_fbdev_dma_setup(ddev, bpp);
> return 0;
> 
> init_failed:
> -- 
> 2.39.2
>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
  2023-03-01 15:30   ` Thomas Zimmermann
  (?)
  (?)
@ 2023-03-09 11:27     ` Javier Martinez Canillas
  -1 siblings, 0 replies; 11+ messages in thread
From: Javier Martinez Canillas @ 2023-03-09 11:27 UTC (permalink / raw)
  To: Thomas Zimmermann, maarten.lankhorst, mripard, airlied, daniel,
	andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel,
	festevam, linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea,
	khilman, jbrunet, martin.blumenstingl, alain.volmat,
	yannick.fertre, raphael.gallais-pou, philippe.cornu,
	mcoquelin.stm32, alexandre.torgue, jernej.skrabec, samuel,
	jyri.sarha, tomba, linus.walleij, hyun.kwon, laurent.pinchart
  Cc: linux-aspeed, dri-devel, linux-stm32, Thomas Zimmermann,
	linux-amlogic, linux-sunxi, linux-arm-kernel

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-09 11:27     ` Javier Martinez Canillas
  0 siblings, 0 replies; 11+ messages in thread
From: Javier Martinez Canillas @ 2023-03-09 11:27 UTC (permalink / raw)
  To: Thomas Zimmermann, maarten.lankhorst, mripard, airlied, daniel,
	andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel,
	festevam, linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea,
	khilman, jbrunet, martin.blumenstingl, alain.volmat,
	yannick.fertre, raphael.gallais-pou, philippe.cornu,
	mcoquelin.stm32, alexandre.torgue, jernej.skrabec, samuel,
	jyri.sarha, tomba, linus.walleij, hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi, Thomas Zimmermann

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-09 11:27     ` Javier Martinez Canillas
  0 siblings, 0 replies; 11+ messages in thread
From: Javier Martinez Canillas @ 2023-03-09 11:27 UTC (permalink / raw)
  To: Thomas Zimmermann, maarten.lankhorst, mripard, airlied, daniel,
	andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel,
	festevam, linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea,
	khilman, jbrunet, martin.blumenstingl, alain.volmat,
	yannick.fertre, raphael.gallais-pou, philippe.cornu,
	mcoquelin.stm32, alexandre.torgue, jernej.skrabec, samuel,
	jyri.sarha, tomba, linus.walleij, hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi, Thomas Zimmermann

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-09 11:27     ` Javier Martinez Canillas
  0 siblings, 0 replies; 11+ messages in thread
From: Javier Martinez Canillas @ 2023-03-09 11:27 UTC (permalink / raw)
  To: Thomas Zimmermann, maarten.lankhorst, mripard, airlied, daniel,
	andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel,
	festevam, linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea,
	khilman, jbrunet, martin.blumenstingl, alain.volmat,
	yannick.fertre, raphael.gallais-pou, philippe.cornu,
	mcoquelin.stm32, alexandre.torgue, jernej.skrabec, samuel,
	jyri.sarha, tomba, linus.walleij, hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi, Thomas Zimmermann

Thomas Zimmermann <tzimmermann@suse.de> writes:

> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
  2023-03-01 15:30 [PATCH 00/22] drm/dma-helper: Add dedicated " Thomas Zimmermann
  2023-03-01 15:30   ` Thomas Zimmermann
  (?)
@ 2023-03-01 15:30   ` Thomas Zimmermann
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Zimmermann @ 2023-03-01 15:30 UTC (permalink / raw)
  To: javierm, maarten.lankhorst, mripard, airlied, daniel, andrew,
	laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel, festevam,
	linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea, khilman,
	jbrunet, martin.blumenstingl, alain.volmat, yannick.fertre,
	raphael.gallais-pou, philippe.cornu, mcoquelin.stm32,
	alexandre.torgue, jernej.skrabec, samuel, jyri.sarha, tomba,
	linus.walleij, hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi, Thomas Zimmermann

Use the fbdev emulation that is optimized for DMA helpers. Avoids
possible shadow buffering and makes the code simpler.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4ca426007dc8..fe56beea3e93 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_dma.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
@@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
 		goto init_failed;
 	priv->is_registered = true;
 
-	drm_fbdev_generic_setup(ddev, bpp);
+	drm_fbdev_dma_setup(ddev, bpp);
 	return 0;
 
 init_failed:
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-01 15:30   ` Thomas Zimmermann
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Zimmermann @ 2023-03-01 15:30 UTC (permalink / raw)
  To: javierm, maarten.lankhorst, mripard, airlied, daniel, andrew,
	laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel, festevam,
	linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea, khilman,
	jbrunet, martin.blumenstingl, alain.volmat, yannick.fertre,
	raphael.gallais-pou, philippe.cornu, mcoquelin.stm32,
	alexandre.torgue, jernej.skrabec, samuel, jyri.sarha, tomba,
	linus.walleij, hyun.kwon, laurent.pinchart
  Cc: linux-aspeed, dri-devel, linux-stm32, Thomas Zimmermann,
	linux-amlogic, linux-sunxi, linux-arm-kernel

Use the fbdev emulation that is optimized for DMA helpers. Avoids
possible shadow buffering and makes the code simpler.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4ca426007dc8..fe56beea3e93 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_dma.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
@@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
 		goto init_failed;
 	priv->is_registered = true;
 
-	drm_fbdev_generic_setup(ddev, bpp);
+	drm_fbdev_dma_setup(ddev, bpp);
 	return 0;
 
 init_failed:
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-01 15:30   ` Thomas Zimmermann
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Zimmermann @ 2023-03-01 15:30 UTC (permalink / raw)
  To: javierm, maarten.lankhorst, mripard, airlied, daniel, andrew,
	laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel, festevam,
	linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea, khilman,
	jbrunet, martin.blumenstingl, alain.volmat, yannick.fertre,
	raphael.gallais-pou, philippe.cornu, mcoquelin.stm32,
	alexandre.torgue, jernej.skrabec, samuel, jyri.sarha, tomba,
	linus.walleij, hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi, Thomas Zimmermann

Use the fbdev emulation that is optimized for DMA helpers. Avoids
possible shadow buffering and makes the code simpler.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4ca426007dc8..fe56beea3e93 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_dma.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
@@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
 		goto init_failed;
 	priv->is_registered = true;
 
-	drm_fbdev_generic_setup(ddev, bpp);
+	drm_fbdev_dma_setup(ddev, bpp);
 	return 0;
 
 init_failed:
-- 
2.39.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-01 15:30   ` Thomas Zimmermann
  0 siblings, 0 replies; 11+ messages in thread
From: Thomas Zimmermann @ 2023-03-01 15:30 UTC (permalink / raw)
  To: javierm, maarten.lankhorst, mripard, airlied, daniel, andrew,
	laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel, festevam,
	linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea, khilman,
	jbrunet, martin.blumenstingl, alain.volmat, yannick.fertre,
	raphael.gallais-pou, philippe.cornu, mcoquelin.stm32,
	alexandre.torgue, jernej.skrabec, samuel, jyri.sarha, tomba,
	linus.walleij, hyun.kwon, laurent.pinchart
  Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
	linux-stm32, linux-sunxi, Thomas Zimmermann

Use the fbdev emulation that is optimized for DMA helpers. Avoids
possible shadow buffering and makes the code simpler.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4ca426007dc8..fe56beea3e93 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -16,7 +16,7 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_debugfs.h>
 #include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_dma.h>
 #include <drm/drm_fourcc.h>
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_gem_framebuffer_helper.h>
@@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
 		goto init_failed;
 	priv->is_registered = true;
 
-	drm_fbdev_generic_setup(ddev, bpp);
+	drm_fbdev_dma_setup(ddev, bpp);
 	return 0;
 
 init_failed:
-- 
2.39.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-03-19 16:02 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 14:06 [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation sarha
2023-03-07 14:06 ` sarha
2023-03-07 14:06 ` sarha
  -- strict thread matches above, loose matches on Subject: below --
2023-03-01 15:30 [PATCH 00/22] drm/dma-helper: Add dedicated " Thomas Zimmermann
2023-03-01 15:30 ` [PATCH 18/22] drm/tilcdc: Use GEM DMA " Thomas Zimmermann
2023-03-01 15:30   ` Thomas Zimmermann
2023-03-01 15:30   ` Thomas Zimmermann
2023-03-01 15:30   ` Thomas Zimmermann
2023-03-09 11:27   ` Javier Martinez Canillas
2023-03-09 11:27     ` Javier Martinez Canillas
2023-03-09 11:27     ` Javier Martinez Canillas
2023-03-09 11:27     ` Javier Martinez Canillas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.