From: Joe Perches <joe@perches.com> To: Julia Lawall <julia.lawall@inria.fr> Cc: "Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>, "Valdis Klētnieks" <valdis.kletnieks@vt.edu>, "Thomas Gleixner" <tglx@linutronix.de>, kernel-janitors@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/18] [ARM] pata_icside: use semicolons rather than commas to separate statements Date: Mon, 28 Sep 2020 10:57:22 -0700 [thread overview] Message-ID: <25aa56e1f7943f9ac535fa184465a752aa00a4b4.camel@perches.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2009281909000.2650@hadrien> On Mon, 2020-09-28 at 19:11 +0200, Julia Lawall wrote: > > On Mon, 28 Sep 2020, Joe Perches wrote: > > > On Sun, 2020-09-27 at 21:12 +0200, Julia Lawall wrote: > > > Replace commas with semicolons. What is done is essentially described by > > > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > > > Hi Julia. > > > > How did you decide on this patch subject header line? > > > > It's certainly reasonable, but not what I would expect > > from any automation. > > Most of the patches on this file touch other files as well. There are > four that only touch this file. One has no subsystem. One has dma as the > subsystem. Two have pata_icside, so that was chosen. So did you select the patch subject without any automation or did you create a tool that looks only at commits for individual files? > > $ git log --no-merges --format='%s' drivers/ata/pata_icside.c | \ > > cut -f1 -d":" | sort | uniq -c | sort -rn > > 10 libata > > 5 libata-sff > > 2 [ARM] pata_icside > > 2 [ARM] ecard > > 2 [ARM] dma Yeah... Something like the script below and some examples of its use? $ cat find_best_header.sh #!/bin/bash # Show possible patch subject prefixes for a file in git # use commits that modify only the single file argument and # emit up to the 5 most common commit prefixes git log --no-merges --format='%h' -- $1 | while read commit ; do if [[ $(git log --format='%h' --name-only -1 $commit | wc -l) == 3 ]] ; then git log --format='%s' -1 $commit fi done | cut -f1 -d":" | cut -f1-3 -d" " | sort | uniq -c | sort -rn | head -5 $ ./find_best_header.sh drivers/ata/pata_icside.c 2 [ARM] pata_icside 1 Fix pata_icside build 1 [ARM] dma $ ./find_best_header.sh kernel/fork.c 36 fork 14 kernel/fork.c 6 mm 4 pidns 4 [PATCH] unshare system $ ./find_best_header.sh kernel/sched/core.c 150 sched 110 sched/core 12 sched/uclamp 12 sched/debug 10 sched/deadline $ ./find_best_header.sh drivers/iio/pressure/mpl115.c 3 iio
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Julia Lawall <julia.lawall@inria.fr> Cc: "Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>, "Valdis Klētnieks" <valdis.kletnieks@vt.edu>, "Thomas Gleixner" <tglx@linutronix.de>, kernel-janitors@vger.kernel.org, "Jens Axboe" <axboe@kernel.dk>, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/18] [ARM] pata_icside: use semicolons rather than commas to separate statements Date: Mon, 28 Sep 2020 17:57:22 +0000 [thread overview] Message-ID: <25aa56e1f7943f9ac535fa184465a752aa00a4b4.camel@perches.com> (raw) In-Reply-To: <alpine.DEB.2.22.394.2009281909000.2650@hadrien> On Mon, 2020-09-28 at 19:11 +0200, Julia Lawall wrote: > > On Mon, 28 Sep 2020, Joe Perches wrote: > > > On Sun, 2020-09-27 at 21:12 +0200, Julia Lawall wrote: > > > Replace commas with semicolons. What is done is essentially described by > > > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > > > Hi Julia. > > > > How did you decide on this patch subject header line? > > > > It's certainly reasonable, but not what I would expect > > from any automation. > > Most of the patches on this file touch other files as well. There are > four that only touch this file. One has no subsystem. One has dma as the > subsystem. Two have pata_icside, so that was chosen. So did you select the patch subject without any automation or did you create a tool that looks only at commits for individual files? > > $ git log --no-merges --format='%s' drivers/ata/pata_icside.c | \ > > cut -f1 -d":" | sort | uniq -c | sort -rn > > 10 libata > > 5 libata-sff > > 2 [ARM] pata_icside > > 2 [ARM] ecard > > 2 [ARM] dma Yeah... Something like the script below and some examples of its use? $ cat find_best_header.sh #!/bin/bash # Show possible patch subject prefixes for a file in git # use commits that modify only the single file argument and # emit up to the 5 most common commit prefixes git log --no-merges --format='%h' -- $1 | while read commit ; do if [[ $(git log --format='%h' --name-only -1 $commit | wc -l) = 3 ]] ; then git log --format='%s' -1 $commit fi done | cut -f1 -d":" | cut -f1-3 -d" " | sort | uniq -c | sort -rn | head -5 $ ./find_best_header.sh drivers/ata/pata_icside.c 2 [ARM] pata_icside 1 Fix pata_icside build 1 [ARM] dma $ ./find_best_header.sh kernel/fork.c 36 fork 14 kernel/fork.c 6 mm 4 pidns 4 [PATCH] unshare system $ ./find_best_header.sh kernel/sched/core.c 150 sched 110 sched/core 12 sched/uclamp 12 sched/debug 10 sched/deadline $ ./find_best_header.sh drivers/iio/pressure/mpl115.c 3 iio
next prev parent reply other threads:[~2020-09-28 17:57 UTC|newest] Thread overview: 195+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-27 19:12 [PATCH 00/18] use semicolons rather than commas to separate statements Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` [PATCH 01/18] clk: uniphier: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-14 0:44 ` Stephen Boyd 2020-10-14 0:44 ` Stephen Boyd 2020-10-14 0:44 ` Stephen Boyd 2020-09-27 19:12 ` [PATCH 02/18] ipmi:bt-bmc: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` [PATCH 03/18] [ARM] pata_icside: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-28 16:47 ` Joe Perches 2020-09-28 16:47 ` Joe Perches 2020-09-28 17:11 ` Julia Lawall 2020-09-28 17:11 ` Julia Lawall 2020-09-28 17:57 ` Joe Perches [this message] 2020-09-28 17:57 ` Joe Perches 2020-09-27 19:12 ` [PATCH 04/18] hwrng: stm32 - " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-02 11:55 ` Herbert Xu 2020-10-02 11:55 ` Herbert Xu 2020-10-02 11:55 ` Herbert Xu 2020-09-27 19:12 ` [PATCH 05/18] bcma: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-01 13:24 ` Kalle Valo 2020-10-01 13:24 ` Kalle Valo 2020-09-27 19:12 ` [PATCH 06/18] hwrng: iproc-rng200 - " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-28 1:42 ` Florian Fainelli 2020-09-28 1:42 ` Florian Fainelli 2020-09-28 1:42 ` Florian Fainelli 2020-10-02 11:55 ` Herbert Xu 2020-10-02 11:55 ` Herbert Xu 2020-10-02 11:55 ` Herbert Xu 2020-09-27 19:12 ` [PATCH 07/18] hwrng: mxc-rnga " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-02 11:55 ` Herbert Xu 2020-10-02 11:55 ` Herbert Xu 2020-09-27 19:12 ` [PATCH 08/18] agp: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` [PATCH 09/18] clk: mvebu: ap80x-cpu: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-14 0:44 ` Stephen Boyd 2020-10-14 0:44 ` Stephen Boyd 2020-09-27 19:12 ` [PATCH 10/18] clk: meson: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-28 9:47 ` Jerome Brunet 2020-09-28 9:47 ` Jerome Brunet 2020-09-28 9:47 ` Jerome Brunet 2020-09-28 9:47 ` Jerome Brunet 2020-10-08 1:54 ` Stephen Boyd 2020-10-08 1:54 ` Stephen Boyd 2020-10-08 1:54 ` Stephen Boyd 2020-10-08 1:54 ` Stephen Boyd 2020-10-14 0:44 ` Stephen Boyd 2020-10-14 0:44 ` Stephen Boyd 2020-10-14 0:44 ` Stephen Boyd 2020-10-14 0:44 ` Stephen Boyd 2020-09-27 19:12 ` [PATCH 11/18] clocksource/drivers/mps2-timer: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` [PATCH 11/18] clocksource/drivers/mps2-timer: use semicolons rather than commas to separate statemen Julia Lawall 2020-10-01 8:13 ` [tip: timers/core] clocksource/drivers/mps2-timer: Use semicolons rather than commas to separate statements tip-bot2 for Julia Lawall 2020-09-27 19:12 ` [PATCH 12/18] ACPI: use " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 20:27 ` Christophe JAILLET 2020-09-27 20:27 ` Christophe JAILLET 2020-09-27 19:12 ` [PATCH 13/18] crypto: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-02 11:56 ` Herbert Xu 2020-10-02 11:56 ` Herbert Xu 2020-09-27 19:12 ` [PATCH 14/18] regmap: debugfs: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` [PATCH 15/18] counter: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-28 15:37 ` David Lechner 2020-09-28 15:37 ` David Lechner 2020-09-29 15:27 ` Jonathan Cameron 2020-09-29 15:27 ` Jonathan Cameron 2020-09-27 19:12 ` [PATCH 16/18] clocksource/drivers: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-02 14:29 ` [tip: timers/core] clocksource/drivers/armada-370-xp: Use " tip-bot2 for Julia Lawall 2020-09-27 19:12 ` [PATCH 17/18] crypto: atmel-tdes - use " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-10-02 11:56 ` Herbert Xu 2020-10-02 11:56 ` Herbert Xu 2020-10-02 11:56 ` Herbert Xu 2020-09-27 19:12 ` [PATCH 18/18] drbd: " Julia Lawall 2020-09-27 19:12 ` Julia Lawall 2020-09-27 20:08 ` [PATCH 00/18] " Joe Perches 2020-09-27 20:08 ` Joe Perches 2020-09-27 20:08 ` Joe Perches 2020-09-27 20:08 ` Joe Perches 2020-09-28 19:35 ` Mark Brown 2020-09-28 19:35 ` Mark Brown 2020-09-29 0:45 ` Joe Perches 2020-09-29 0:45 ` Joe Perches 2020-09-29 0:45 ` Joe Perches 2020-09-29 0:45 ` Joe Perches 2020-09-29 11:37 ` Mark Brown 2020-09-29 11:37 ` Mark Brown 2020-09-29 11:37 ` Mark Brown 2020-09-29 11:37 ` Mark Brown 2020-09-29 11:46 ` Julia Lawall 2020-09-29 11:46 ` Julia Lawall 2020-09-29 11:46 ` Julia Lawall 2020-09-29 11:46 ` Julia Lawall 2020-09-29 12:37 ` Mark Brown 2020-09-29 12:37 ` Mark Brown 2020-09-29 12:37 ` Mark Brown 2020-09-29 12:37 ` Mark Brown 2020-09-29 12:44 ` Julia Lawall 2020-09-29 12:44 ` Julia Lawall 2020-09-29 12:44 ` Julia Lawall 2020-09-29 12:44 ` Julia Lawall 2020-09-30 19:33 ` Joe Perches 2020-09-30 19:33 ` Joe Perches 2020-09-30 19:33 ` Joe Perches 2020-09-30 19:33 ` Joe Perches 2020-10-01 11:01 ` Mark Brown 2020-10-01 11:01 ` Mark Brown 2020-10-01 11:01 ` Mark Brown 2020-10-01 11:01 ` Mark Brown 2020-10-03 18:40 ` Joe Perches 2020-10-03 18:40 ` Joe Perches 2020-10-03 18:40 ` Joe Perches 2020-10-03 18:40 ` Joe Perches 2020-10-03 19:15 ` Konstantin Ryabitsev 2020-10-03 19:15 ` Konstantin Ryabitsev 2020-10-03 19:15 ` Konstantin Ryabitsev 2020-10-03 19:15 ` Konstantin Ryabitsev 2020-10-03 19:18 ` Julia Lawall 2020-10-03 19:18 ` Julia Lawall 2020-10-03 19:18 ` Julia Lawall 2020-10-03 19:18 ` Julia Lawall 2020-10-03 19:31 ` Konstantin Ryabitsev 2020-10-03 19:31 ` Konstantin Ryabitsev 2020-10-03 19:31 ` Konstantin Ryabitsev 2020-10-03 19:31 ` Konstantin Ryabitsev 2020-10-03 19:43 ` Joe Perches 2020-10-03 19:43 ` Joe Perches 2020-10-03 19:43 ` Joe Perches 2020-10-03 19:43 ` Joe Perches 2020-10-05 16:52 ` Mark Brown 2020-10-05 16:52 ` Mark Brown 2020-10-05 16:52 ` Mark Brown 2020-10-05 16:52 ` Mark Brown 2020-10-05 16:52 ` Mark Brown 2020-10-03 19:27 ` Joe Perches 2020-10-03 19:27 ` Joe Perches 2020-10-03 19:27 ` Joe Perches 2020-10-03 19:27 ` Joe Perches 2020-10-03 19:36 ` Joe Perches 2020-10-03 19:36 ` Joe Perches 2020-10-03 19:36 ` Joe Perches 2020-10-03 19:36 ` Joe Perches 2020-09-29 12:20 ` Ard Biesheuvel 2020-09-29 12:20 ` Ard Biesheuvel 2020-09-29 12:20 ` Ard Biesheuvel 2020-09-29 12:20 ` Ard Biesheuvel 2020-09-29 12:36 ` Julia Lawall 2020-09-29 12:36 ` Julia Lawall 2020-09-29 12:36 ` Julia Lawall 2020-09-29 12:36 ` Julia Lawall 2020-09-29 12:41 ` Dan Carpenter 2020-09-29 12:41 ` Dan Carpenter 2020-09-29 12:41 ` Dan Carpenter 2020-09-29 12:41 ` Dan Carpenter 2020-09-29 12:47 ` Julia Lawall 2020-09-29 12:47 ` Julia Lawall 2020-09-29 12:47 ` Julia Lawall 2020-09-29 12:47 ` Julia Lawall 2020-09-29 13:34 ` Joe Perches 2020-09-29 13:34 ` Joe Perches 2020-09-29 13:34 ` Joe Perches 2020-09-29 13:34 ` Joe Perches 2020-09-29 13:42 ` Julia Lawall 2020-09-29 13:42 ` Julia Lawall 2020-09-29 13:42 ` Julia Lawall 2020-09-29 13:42 ` Julia Lawall 2020-09-29 13:42 ` Shuah Khan 2020-09-29 13:42 ` Shuah Khan 2020-09-29 13:42 ` Shuah Khan 2020-09-29 13:42 ` Shuah Khan 2020-10-02 16:47 ` Shuah Khan 2020-10-02 16:47 ` Shuah Khan 2020-10-02 16:47 ` Shuah Khan 2020-10-02 16:47 ` Shuah Khan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=25aa56e1f7943f9ac535fa184465a752aa00a4b4.camel@perches.com \ --to=joe@perches.com \ --cc=axboe@kernel.dk \ --cc=b.zolnierkie@samsung.com \ --cc=julia.lawall@inria.fr \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tglx@linutronix.de \ --cc=valdis.kletnieks@vt.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.