All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@codeaurora.org>
To: Sinan Kaya <okaya@codeaurora.org>, linux-pci@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function
Date: Wed, 22 Nov 2017 00:08:45 -0600	[thread overview]
Message-ID: <25ec431a-2c1b-d352-f9ef-c663864664b6@codeaurora.org> (raw)
In-Reply-To: <6a78596e-720a-80a2-9d96-dcc79a32f677@codeaurora.org>

On 11/21/17 11:55 PM, Sinan Kaya wrote:
> For places where domain number information is available, I extracted domain number
> and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers.

My suggestion is that you restrict your first patch set to only these 
patches.

> The assumption at this point is for pci_get_bus_and_slot() usages to be caught
> in code-review.

How about this:

static inline struct pci_dev * __deprecated 
pci_get_bus_and_slot(unsigned int bus,
						   unsigned int devfn)
{
	return pci_get_domain_bus_and_slot(0, bus, devfn);
}


-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@codeaurora.org>
To: Sinan Kaya <okaya@codeaurora.org>, linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-msm@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function
Date: Wed, 22 Nov 2017 00:08:45 -0600	[thread overview]
Message-ID: <25ec431a-2c1b-d352-f9ef-c663864664b6@codeaurora.org> (raw)
In-Reply-To: <6a78596e-720a-80a2-9d96-dcc79a32f677@codeaurora.org>

On 11/21/17 11:55 PM, Sinan Kaya wrote:
> For places where domain number information is available, I extracted domain number
> and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers.

My suggestion is that you restrict your first patch set to only these 
patches.

> The assumption at this point is for pci_get_bus_and_slot() usages to be caught
> in code-review.

How about this:

static inline struct pci_dev * __deprecated 
pci_get_bus_and_slot(unsigned int bus,
						   unsigned int devfn)
{
	return pci_get_domain_bus_and_slot(0, bus, devfn);
}


-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function
Date: Wed, 22 Nov 2017 00:08:45 -0600	[thread overview]
Message-ID: <25ec431a-2c1b-d352-f9ef-c663864664b6@codeaurora.org> (raw)
In-Reply-To: <6a78596e-720a-80a2-9d96-dcc79a32f677@codeaurora.org>

On 11/21/17 11:55 PM, Sinan Kaya wrote:
> For places where domain number information is available, I extracted domain number
> and added into pci_get_domain_bus_and_slot() call such as xen or bn drivers.

My suggestion is that you restrict your first patch set to only these 
patches.

> The assumption at this point is for pci_get_bus_and_slot() usages to be caught
> in code-review.

How about this:

static inline struct pci_dev * __deprecated 
pci_get_bus_and_slot(unsigned int bus,
						   unsigned int devfn)
{
	return pci_get_domain_bus_and_slot(0, bus, devfn);
}


-- 
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc.  Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

  reply	other threads:[~2017-11-22  6:08 UTC|newest]

Thread overview: 180+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-22  5:30 [PATCH 00/30] PCI: deprecate pci_get_bus_and_slot() Sinan Kaya
2017-11-22  5:30 ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 01/30] alpha/PCI: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 02/30] powerpc/PCI: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 03/30] x86/PCI: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 04/30] ata: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 05/30] agp: nvidia: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 06/30] edd: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 07/30] ibft: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 08/30] drm/gma500: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 09/30] drm/i915: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  7:52   ` Joonas Lahtinen
2017-11-22 16:28     ` Sinan Kaya
2017-11-22 19:50       ` Jani Nikula
2017-11-22 19:58         ` Timur Tabi
2017-11-23  7:14           ` Jani Nikula
2017-11-23  7:42       ` Joonas Lahtinen
2017-11-23 18:37         ` Sinan Kaya
2017-11-27  8:56           ` Joonas Lahtinen
2017-11-27 14:05             ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 10/30] drm/nouveau: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 11/30] hwmon: (coretemp) " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22 15:07   ` [11/30] " Guenter Roeck
2017-11-22 15:07     ` Guenter Roeck
2017-11-22 15:07     ` Guenter Roeck
2017-11-22  5:30 ` [PATCH 12/30] Drivers: ide: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  7:53   ` Greg KH
2017-11-22  7:53     ` Greg KH
2017-11-22  7:53     ` Greg KH
2017-11-22 16:24     ` Sinan Kaya
2017-11-22 16:24       ` Sinan Kaya
2017-11-22 16:24       ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 13/30] iommu/amd: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30 ` [PATCH 14/30] powerpc/powermac: " Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:30   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 15/30] bnx2x: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 16/30] pch_gbe: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 17/30] PCI: cpqhp: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 18/30] PCI: ibmphp: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 19/30] PCI/quirks: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 20/30] PCI/syscall: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 21/30] xen: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22 12:53   ` Juergen Gross
2017-11-22 12:53   ` Juergen Gross
2017-11-22 12:53     ` Juergen Gross
2017-11-22 12:53     ` Juergen Gross
2017-11-22  5:31 ` [PATCH 22/30] openprom: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 23/30] [media] atomisp: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22 12:20   ` Alan Cox
2017-11-22 12:20     ` Alan Cox
2017-11-22 12:20     ` Alan Cox
2017-11-22 12:20     ` Alan Cox
2017-11-22 14:05     ` Sinan Kaya
2017-11-22 14:05       ` Sinan Kaya
2017-11-22 14:05       ` Sinan Kaya
2017-11-22 14:05       ` Sinan Kaya
2017-11-22 14:06       ` Sinan Kaya
2017-11-22 14:06         ` Sinan Kaya
2017-11-22 14:06         ` Sinan Kaya
2017-11-22 14:06         ` Sinan Kaya
2017-11-22 17:00     ` Alan Cox
2017-11-22  5:31 ` [PATCH 24/30] staging: rts5208: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  7:54   ` Greg Kroah-Hartman
2017-11-22  7:54     ` Greg Kroah-Hartman
2017-11-22  5:31 ` [PATCH 25/30] backlight: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 26/30] video: fbdev: intelfb: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 27/30] video: fbdev: nvidia: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 28/30] video: fbdev: riva: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31 ` [PATCH 29/30] i7300_idle: " Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  7:53   ` Greg Kroah-Hartman
2017-11-22  7:53     ` Greg Kroah-Hartman
2017-11-22  7:53     ` Greg Kroah-Hartman
2017-11-22 16:15     ` Sinan Kaya
2017-11-22 16:15       ` Sinan Kaya
2017-11-22 16:15       ` Sinan Kaya
2017-11-22 16:45       ` Greg Kroah-Hartman
2017-11-22 16:45         ` Greg Kroah-Hartman
2017-11-22 16:50         ` Sinan Kaya
2017-11-22 16:50           ` Sinan Kaya
2017-11-22 16:50           ` Sinan Kaya
2017-11-22 16:58           ` Greg Kroah-Hartman
2017-11-22 16:58             ` Greg Kroah-Hartman
2017-11-22 16:58             ` Greg Kroah-Hartman
2017-11-22  5:31 ` [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:31   ` Sinan Kaya
2017-11-22  5:45   ` Timur Tabi
2017-11-22  5:45     ` Timur Tabi
2017-11-22  5:45     ` Timur Tabi
2017-11-22  5:55     ` Sinan Kaya
2017-11-22  5:55       ` Sinan Kaya
2017-11-22  5:55       ` Sinan Kaya
2017-11-22  6:08       ` Timur Tabi [this message]
2017-11-22  6:08         ` Timur Tabi
2017-11-22  6:08         ` Timur Tabi
2017-11-22  7:51         ` Greg KH
2017-11-22  7:51           ` Greg KH
2017-11-22  7:51           ` Greg KH
2017-11-22 14:42           ` Timur Tabi
2017-11-22 14:42             ` Timur Tabi
2017-11-22 14:42             ` Timur Tabi
2017-11-22 14:49             ` Greg KH
2017-11-22 14:49               ` Greg KH
2017-11-22 15:18               ` Sinan Kaya
2017-11-22 15:18                 ` Sinan Kaya
2017-11-22 15:18                 ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25ec431a-2c1b-d352-f9ef-c663864664b6@codeaurora.org \
    --to=timur@codeaurora.org \
    --cc=bhelgaas@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=okaya@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.