All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: "open list:IDE" <qemu-block@nongnu.org>,
	armbru@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 04/12] tests: Pass literal format strings directly to qmp_FOO()
Date: Wed, 26 Jul 2017 19:28:02 -0400	[thread overview]
Message-ID: <25f12e18-b096-99b9-e235-1f8f93466107@redhat.com> (raw)
In-Reply-To: <20170725211523.3998-5-eblake@redhat.com>



On 07/25/2017 05:15 PM, Eric Blake wrote:
> From: Markus Armbruster <armbru@redhat.com>
> 
> The qmp_FOO() take a printf-like format string.  In a few places, we
> assign a string literal to a variable and pass that instead of simply
> passing the literal.  Clean that up.
> 
> Bonus: gets rid of non-literal format strings.  A step towards
> compile-time format string checking without triggering
> -Wformat-nonliteral.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Message-Id: <1500645206-13559-4-git-send-email-armbru@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

Reviewed-by: John Snow <jsnow@redhat.com>

  reply	other threads:[~2017-07-26 23:28 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-25 21:15 [Qemu-devel] [PATCH v3 00/12] Clean up around qmp() and hmp() Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 01/12] qobject: Accept "%"PRId64 in qobject_from_jsonf() Eric Blake
2017-07-28 18:13   ` Markus Armbruster
2017-07-28 18:56     ` Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 02/12] qtest: Avoid passing raw strings through hmp() Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions Eric Blake
2017-07-28 12:26   ` Stefan Hajnoczi
2017-07-28 18:32   ` Markus Armbruster
2017-07-28 19:00     ` Eric Blake
2017-07-31  8:20       ` Markus Armbruster
2017-07-31 12:22         ` Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 04/12] tests: Pass literal format strings directly to qmp_FOO() Eric Blake
2017-07-26 23:28   ` John Snow [this message]
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 05/12] tests: Clean up string interpolation into QMP input (simple cases) Eric Blake
2017-07-28 12:32   ` Stefan Hajnoczi
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 06/12] tests/libqos/usb: Clean up string interpolation into QMP input Eric Blake
2017-07-28 12:33   ` Stefan Hajnoczi
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends Eric Blake
2017-07-28 12:57   ` Stefan Hajnoczi
2017-07-28 13:06     ` Eric Blake
2017-07-28 16:33       ` Eric Blake
2017-07-31  8:16         ` Markus Armbruster
2017-07-31 12:34           ` Eric Blake
2017-07-31 18:56             ` Eric Blake
2017-08-01  5:48               ` Markus Armbruster
2017-08-01 14:13                 ` Eric Blake
2017-07-28 18:45   ` Markus Armbruster
2017-07-28 18:53     ` Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 08/12] qtests: convert tests to use qmp_cmd Eric Blake
2017-07-28 12:59   ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-28 18:53   ` [Qemu-devel] " Markus Armbruster
2017-07-28 19:08     ` Eric Blake
2017-07-31  7:28       ` Markus Armbruster
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input Eric Blake
2017-07-28 13:05   ` Stefan Hajnoczi
2017-07-28 16:35     ` Eric Blake
2017-07-28 16:37       ` Eric Blake
2017-07-31  7:29         ` Markus Armbruster
2017-07-31 18:33           ` Eric Blake
2017-08-01  5:40             ` Markus Armbruster
2017-07-28 17:42     ` Markus Armbruster
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 10/12] tests: Clean up wait for event Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 11/12] tests/libqtest: Clean up how we read the QMP greeting Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 12/12] tests/libqtest: Enable compile-time format string checking Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25f12e18-b096-99b9-e235-1f8f93466107@redhat.com \
    --to=jsnow@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.