From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
stefanha@redhat.com, qemu-devel@nongnu.org,
"open list:virtio-blk" <qemu-block@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input
Date: Mon, 31 Jul 2017 09:29:35 +0200 [thread overview]
Message-ID: <878tj5awtc.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <307cae51-da45-4968-f6c9-4fa1ad4b22f8@redhat.com> (Eric Blake's message of "Fri, 28 Jul 2017 11:37:25 -0500")
Eric Blake <eblake@redhat.com> writes:
> On 07/28/2017 11:35 AM, Eric Blake wrote:
>>>> + QObject *extra_args = qobject_from_jsonf("{ 'shm': '%s', 'size': '1M' }",
>>>> + tmpshm);
>>>
>
>> Passing '%s' through qobject_from_jsonf() is generally wrong (it would
>> produce ''...'' instead of the intended '...').
>>
>> Looks like something to fix on the next round.
>>
>
> What's scary is that the testsuite didn't start failing. That's not
> good; we'll want to figure out why the bug didn't impact the test.
Good idea.
next prev parent reply other threads:[~2017-07-31 7:29 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 21:15 [Qemu-devel] [PATCH v3 00/12] Clean up around qmp() and hmp() Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 01/12] qobject: Accept "%"PRId64 in qobject_from_jsonf() Eric Blake
2017-07-28 18:13 ` Markus Armbruster
2017-07-28 18:56 ` Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 02/12] qtest: Avoid passing raw strings through hmp() Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions Eric Blake
2017-07-28 12:26 ` Stefan Hajnoczi
2017-07-28 18:32 ` Markus Armbruster
2017-07-28 19:00 ` Eric Blake
2017-07-31 8:20 ` Markus Armbruster
2017-07-31 12:22 ` Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 04/12] tests: Pass literal format strings directly to qmp_FOO() Eric Blake
2017-07-26 23:28 ` John Snow
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 05/12] tests: Clean up string interpolation into QMP input (simple cases) Eric Blake
2017-07-28 12:32 ` Stefan Hajnoczi
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 06/12] tests/libqos/usb: Clean up string interpolation into QMP input Eric Blake
2017-07-28 12:33 ` Stefan Hajnoczi
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends Eric Blake
2017-07-28 12:57 ` Stefan Hajnoczi
2017-07-28 13:06 ` Eric Blake
2017-07-28 16:33 ` Eric Blake
2017-07-31 8:16 ` Markus Armbruster
2017-07-31 12:34 ` Eric Blake
2017-07-31 18:56 ` Eric Blake
2017-08-01 5:48 ` Markus Armbruster
2017-08-01 14:13 ` Eric Blake
2017-07-28 18:45 ` Markus Armbruster
2017-07-28 18:53 ` Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 08/12] qtests: convert tests to use qmp_cmd Eric Blake
2017-07-28 12:59 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-07-28 18:53 ` [Qemu-devel] " Markus Armbruster
2017-07-28 19:08 ` Eric Blake
2017-07-31 7:28 ` Markus Armbruster
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input Eric Blake
2017-07-28 13:05 ` Stefan Hajnoczi
2017-07-28 16:35 ` Eric Blake
2017-07-28 16:37 ` Eric Blake
2017-07-31 7:29 ` Markus Armbruster [this message]
2017-07-31 18:33 ` Eric Blake
2017-08-01 5:40 ` Markus Armbruster
2017-07-28 17:42 ` Markus Armbruster
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 10/12] tests: Clean up wait for event Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 11/12] tests/libqtest: Clean up how we read the QMP greeting Eric Blake
2017-07-25 21:15 ` [Qemu-devel] [PATCH v3 12/12] tests/libqtest: Enable compile-time format string checking Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tj5awtc.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.