* [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
@ 2021-03-02 11:19 Werner Sembach
2021-03-02 14:06 ` Takashi Iwai
0 siblings, 1 reply; 11+ messages in thread
From: Werner Sembach @ 2021-03-02 11:19 UTC (permalink / raw)
To: wse, perex, tiwai, alsa-devel, linux-kernel
From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
fixes the issue of the device not recognizing a pluged in microphone.
The device has both, a microphone only jack, and a speaker + microphone
combo jack. The combo jack already works. The microphone-only jack does
not recognize when a device is pluged in without this patch.
Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
Hi,
this is my first ever submitted kernel patch, feel free to criticise me if I made an error or missed a best practise bullet point.
Also: I'm unsure if this would fit the requirements for stable@vger.kernel.org and/or trivial@kernel.org, but I think not (correct me if I'm wrong).
Kind regards
Werner Sembach
From 2835edd753fd19c72a644dccb7e941cfc0ecdf8e Mon Sep 17 00:00:00 2001
From: Werner Sembach <wse@tuxedocomputers.com>
Date: Fri, 26 Feb 2021 13:50:15 +0100
Subject: [PATCH] Fix device detection on microphone jack of Clevo NH55RZQ
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 290645516313..8014e80d72c3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8089,6 +8089,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1558, 0x8562, "Clevo NH[5|7][0-9]RZ[Q]", ALC269_FIXUP_DMIC),
SND_PCI_QUIRK(0x1558, 0x8668, "Clevo NP50B[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8680, "Clevo NJ50LU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8686, "Clevo NH50[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
2021-03-02 11:19 [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ Werner Sembach
@ 2021-03-02 14:06 ` Takashi Iwai
0 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2021-03-02 14:06 UTC (permalink / raw)
To: Werner Sembach; +Cc: perex, tiwai, alsa-devel, linux-kernel
On Tue, 02 Mar 2021 12:19:03 +0100,
Werner Sembach wrote:
>
> From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
>
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
>
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
>
> The device has both, a microphone only jack, and a speaker + microphone
> combo jack. The combo jack already works. The microphone-only jack does
> not recognize when a device is pluged in without this patch.
>
> Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> Hi,
> this is my first ever submitted kernel patch, feel free to criticise me if I made an error or missed a best practise bullet point.
The patch isn't cleanly applicable. Could you try to submit via
git-send-email instead?
> Also: I'm unsure if this would fit the requirements for stable@vger.kernel.org and/or trivial@kernel.org, but I think not (correct me if I'm wrong).
Cc to stable is worthwhile. You can simply add
Cc: <stable@vger.kernel.org>
around your signed-off-by lines in the patch.
thanks,
Takashi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
@ 2021-03-02 14:06 ` Takashi Iwai
0 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2021-03-02 14:06 UTC (permalink / raw)
To: Werner Sembach; +Cc: linux-kernel, alsa-devel, tiwai
On Tue, 02 Mar 2021 12:19:03 +0100,
Werner Sembach wrote:
>
> From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
>
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
>
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
>
> The device has both, a microphone only jack, and a speaker + microphone
> combo jack. The combo jack already works. The microphone-only jack does
> not recognize when a device is pluged in without this patch.
>
> Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> Hi,
> this is my first ever submitted kernel patch, feel free to criticise me if I made an error or missed a best practise bullet point.
The patch isn't cleanly applicable. Could you try to submit via
git-send-email instead?
> Also: I'm unsure if this would fit the requirements for stable@vger.kernel.org and/or trivial@kernel.org, but I think not (correct me if I'm wrong).
Cc to stable is worthwhile. You can simply add
Cc: <stable@vger.kernel.org>
around your signed-off-by lines in the patch.
thanks,
Takashi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
2021-03-02 14:06 ` Takashi Iwai
@ 2021-03-02 16:51 ` Werner Sembach
-1 siblings, 0 replies; 11+ messages in thread
From: Werner Sembach @ 2021-03-02 16:51 UTC (permalink / raw)
To: Takashi Iwai; +Cc: perex, tiwai, alsa-devel, linux-kernel
Hello Takashi,
> The patch isn't cleanly applicable. Could you try to submit via
> git-send-email instead?
I'm sorry the editor + mailer i used replaced tabs with spaces and made a html mail.
Already resend the patch with tabs, but only after that I realized that even the "plain" mails are converted to html.
It's probably still broken so don't waste your time with it, i will read the man page of git send-mail now ^^.
> Cc to stable is worthwhile. You can simply add
> Cc: <stable@vger.kernel.org>
>
> around your signed-off-by lines in the patch.
Ok (also forgot that in my resend patch)
Kind regards,
Werner Sembach
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
@ 2021-03-02 16:51 ` Werner Sembach
0 siblings, 0 replies; 11+ messages in thread
From: Werner Sembach @ 2021-03-02 16:51 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-kernel, alsa-devel, tiwai
Hello Takashi,
> The patch isn't cleanly applicable. Could you try to submit via
> git-send-email instead?
I'm sorry the editor + mailer i used replaced tabs with spaces and made a html mail.
Already resend the patch with tabs, but only after that I realized that even the "plain" mails are converted to html.
It's probably still broken so don't waste your time with it, i will read the man page of git send-mail now ^^.
> Cc to stable is worthwhile. You can simply add
> Cc: <stable@vger.kernel.org>
>
> around your signed-off-by lines in the patch.
Ok (also forgot that in my resend patch)
Kind regards,
Werner Sembach
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
2021-03-02 17:33 ` Takashi Iwai
@ 2021-03-02 18:10 ` Werner Sembach
-1 siblings, 0 replies; 11+ messages in thread
From: Werner Sembach @ 2021-03-02 18:10 UTC (permalink / raw)
To: Takashi Iwai; +Cc: perex, tiwai, alsa-devel, linux-kernel
> Thanks, now I could apply it.
Missed your reply: I have now sent it a third time using git send-email.
One change: I added Cc: stable this time.
> Could you resubmit the NUC10 patch as well? Takashi
Done.
Hope everything is correct now.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
@ 2021-03-02 18:10 ` Werner Sembach
0 siblings, 0 replies; 11+ messages in thread
From: Werner Sembach @ 2021-03-02 18:10 UTC (permalink / raw)
To: Takashi Iwai; +Cc: linux-kernel, alsa-devel, tiwai
> Thanks, now I could apply it.
Missed your reply: I have now sent it a third time using git send-email.
One change: I added Cc: stable this time.
> Could you resubmit the NUC10 patch as well? Takashi
Done.
Hope everything is correct now.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
@ 2021-03-02 18:00 Werner Sembach
0 siblings, 0 replies; 11+ messages in thread
From: Werner Sembach @ 2021-03-02 18:00 UTC (permalink / raw)
To: wse, perex, tiwai, alsa-devel, linux-kernel, alsa-devel
Cc: Eckhart Mohr, stable
From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
fixes the issue of the device not recognizing a pluged in microphone.
The device has both, a microphone only jack, and a speaker + microphone
combo jack. The combo jack already works. The microphone-only jack does
not recognize when a device is pluged in without this patch.
Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Cc: <stable@vger.kernel.org>
---
Third time's the charm, now using git send-email, I'm really sorry for the spam.
From 2835edd753fd19c72a644dccb7e941cfc0ecdf8e Mon Sep 17 00:00:00 2001
From: Werner Sembach <wse@tuxedocomputers.com>
Date: Fri, 26 Feb 2021 13:50:15 +0100
Subject: [PATCH] Fix device detection on microphone jack of Clevo NH55RZQ
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 290645516313..8014e80d72c3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8089,6 +8089,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1558, 0x8562, "Clevo NH[5|7][0-9]RZ[Q]", ALC269_FIXUP_DMIC),
SND_PCI_QUIRK(0x1558, 0x8668, "Clevo NP50B[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8680, "Clevo NJ50LU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8686, "Clevo NH50[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
2021-03-02 16:25 Werner Sembach
@ 2021-03-02 17:33 ` Takashi Iwai
0 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2021-03-02 17:33 UTC (permalink / raw)
To: Werner Sembach; +Cc: perex, tiwai, alsa-devel, linux-kernel
On Tue, 02 Mar 2021 17:25:22 +0100,
Werner Sembach wrote:
>
> From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
>
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
>
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
>
> The device has both, a microphone only jack, and a speaker + microphone
> combo jack. The combo jack already works. The microphone-only jack does
> not recognize when a device is pluged in without this patch.
>
> Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> This is a resend of the patch because I missed that the editor I used to write the commit message replaced tabs with spaces.
Thanks, now I could apply it.
Could you resubmit the NUC10 patch as well?
Takashi
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
@ 2021-03-02 17:33 ` Takashi Iwai
0 siblings, 0 replies; 11+ messages in thread
From: Takashi Iwai @ 2021-03-02 17:33 UTC (permalink / raw)
To: Werner Sembach; +Cc: linux-kernel, alsa-devel, tiwai
On Tue, 02 Mar 2021 17:25:22 +0100,
Werner Sembach wrote:
>
> From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
>
> ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
>
> This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
> fixes the issue of the device not recognizing a pluged in microphone.
>
> The device has both, a microphone only jack, and a speaker + microphone
> combo jack. The combo jack already works. The microphone-only jack does
> not recognize when a device is pluged in without this patch.
>
> Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
> Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> This is a resend of the patch because I missed that the editor I used to write the commit message replaced tabs with spaces.
Thanks, now I could apply it.
Could you resubmit the NUC10 patch as well?
Takashi
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
@ 2021-03-02 16:25 Werner Sembach
2021-03-02 17:33 ` Takashi Iwai
0 siblings, 1 reply; 11+ messages in thread
From: Werner Sembach @ 2021-03-02 16:25 UTC (permalink / raw)
To: wse, perex, tiwai, alsa-devel, linux-kernel
From: Eckhart Mohr <e.mohr@tuxedocomputers.com>
ALSA: hda/realtek: Add quirk for Clevo NH55RZQ
This applies a SND_PCI_QUIRK(...) to the Clevo NH55RZQ barebone. This
fixes the issue of the device not recognizing a pluged in microphone.
The device has both, a microphone only jack, and a speaker + microphone
combo jack. The combo jack already works. The microphone-only jack does
not recognize when a device is pluged in without this patch.
Signed-off-by: Eckhart Mohr <e.mohr@tuxedocomputers.com>
Co-developed-by: Werner Sembach <wse@tuxedocomputers.com>
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
This is a resend of the patch because I missed that the editor I used to write the commit message replaced tabs with spaces.
From 2835edd753fd19c72a644dccb7e941cfc0ecdf8e Mon Sep 17 00:00:00 2001
From: Werner Sembach <wse@tuxedocomputers.com>
Date: Fri, 26 Feb 2021 13:50:15 +0100
Subject: [PATCH] Fix device detection on microphone jack of Clevo NH55RZQ
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 290645516313..8014e80d72c3 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -8089,6 +8089,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1558, 0x8551, "System76 Gazelle (gaze14)", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8560, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
SND_PCI_QUIRK(0x1558, 0x8561, "System76 Gazelle (gaze14)", ALC269_FIXUP_HEADSET_MIC),
+ SND_PCI_QUIRK(0x1558, 0x8562, "Clevo NH[5|7][0-9]RZ[Q]", ALC269_FIXUP_DMIC),
SND_PCI_QUIRK(0x1558, 0x8668, "Clevo NP50B[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8680, "Clevo NJ50LU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0x8686, "Clevo NH50[CZ]U", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
--
2.25.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2021-03-02 22:37 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-02 11:19 [PATCH] ALSA: hda/realtek: Add quirk for Clevo NH55RZQ Werner Sembach
2021-03-02 14:06 ` Takashi Iwai
2021-03-02 14:06 ` Takashi Iwai
2021-03-02 16:51 ` Werner Sembach
2021-03-02 16:51 ` Werner Sembach
2021-03-02 16:25 Werner Sembach
2021-03-02 17:33 ` Takashi Iwai
2021-03-02 17:33 ` Takashi Iwai
2021-03-02 18:10 ` Werner Sembach
2021-03-02 18:10 ` Werner Sembach
2021-03-02 18:00 Werner Sembach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.