* [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset
@ 2017-12-31 12:37 ` Himanshu Jha
0 siblings, 0 replies; 5+ messages in thread
From: Himanshu Jha @ 2017-12-31 12:25 UTC (permalink / raw)
To: b.zolnierkie; +Cc: dri-devel, linux-fbdev, linux-kernel, Himanshu Jha
Use vzalloc for allocating zeroed memory and remove unnecessary
memset function.
Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.
Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/video/fbdev/auo_k190x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/auo_k190x.c b/drivers/video/fbdev/auo_k190x.c
index 0d060383..b889401 100644
--- a/drivers/video/fbdev/auo_k190x.c
+++ b/drivers/video/fbdev/auo_k190x.c
@@ -1056,13 +1056,12 @@ int auok190x_common_probe(struct platform_device *pdev,
/* videomemory handling */
videomemorysize = roundup((panel->w * panel->h) * 2, PAGE_SIZE);
- videomemory = vmalloc(videomemorysize);
+ videomemory = vzalloc(videomemorysize);
if (!videomemory) {
ret = -ENOMEM;
goto err_irq;
}
- memset(videomemory, 0, videomemorysize);
info->screen_base = (char *)videomemory;
info->fix.smem_len = videomemorysize;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset
@ 2017-12-31 12:37 ` Himanshu Jha
0 siblings, 0 replies; 5+ messages in thread
From: Himanshu Jha @ 2017-12-31 12:37 UTC (permalink / raw)
To: b.zolnierkie; +Cc: dri-devel, linux-fbdev, linux-kernel, Himanshu Jha
Use vzalloc for allocating zeroed memory and remove unnecessary
memset function.
Done using Coccinelle.
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
0-day tested with no failures.
Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/video/fbdev/auo_k190x.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/auo_k190x.c b/drivers/video/fbdev/auo_k190x.c
index 0d060383..b889401 100644
--- a/drivers/video/fbdev/auo_k190x.c
+++ b/drivers/video/fbdev/auo_k190x.c
@@ -1056,13 +1056,12 @@ int auok190x_common_probe(struct platform_device *pdev,
/* videomemory handling */
videomemorysize = roundup((panel->w * panel->h) * 2, PAGE_SIZE);
- videomemory = vmalloc(videomemorysize);
+ videomemory = vzalloc(videomemorysize);
if (!videomemory) {
ret = -ENOMEM;
goto err_irq;
}
- memset(videomemory, 0, videomemorysize);
info->screen_base = (char *)videomemory;
info->fix.smem_len = videomemorysize;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset
2017-12-31 12:37 ` Himanshu Jha
(?)
@ 2018-01-04 15:50 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-01-04 15:50 UTC (permalink / raw)
To: Himanshu Jha; +Cc: dri-devel, linux-fbdev, linux-kernel
On Sunday, December 31, 2017 05:55:57 PM Himanshu Jha wrote:
> Use vzalloc for allocating zeroed memory and remove unnecessary
> memset function.
>
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Use of "Generated-by:" triggers checkpatch.pl warning + error:
WARNING: Non-standard signature: Generated-by:
#8:
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
ERROR: Unrecognized email address: 'scripts/coccinelle/api/alloc/kzalloc-simple.cocci'
#8:
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
I've changed it to "Generate-by" to silence checkpatch.pl.
> 0-day tested with no failures.
>
> Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset
@ 2018-01-04 15:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-01-04 15:50 UTC (permalink / raw)
To: Himanshu Jha; +Cc: linux-fbdev, linux-kernel, dri-devel
On Sunday, December 31, 2017 05:55:57 PM Himanshu Jha wrote:
> Use vzalloc for allocating zeroed memory and remove unnecessary
> memset function.
>
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Use of "Generated-by:" triggers checkpatch.pl warning + error:
WARNING: Non-standard signature: Generated-by:
#8:
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
ERROR: Unrecognized email address: 'scripts/coccinelle/api/alloc/kzalloc-simple.cocci'
#8:
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
I've changed it to "Generate-by" to silence checkpatch.pl.
> 0-day tested with no failures.
>
> Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset
@ 2018-01-04 15:50 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2018-01-04 15:50 UTC (permalink / raw)
To: Himanshu Jha; +Cc: linux-fbdev, linux-kernel, dri-devel
On Sunday, December 31, 2017 05:55:57 PM Himanshu Jha wrote:
> Use vzalloc for allocating zeroed memory and remove unnecessary
> memset function.
>
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
Use of "Generated-by:" triggers checkpatch.pl warning + error:
WARNING: Non-standard signature: Generated-by:
#8:
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
ERROR: Unrecognized email address: 'scripts/coccinelle/api/alloc/kzalloc-simple.cocci'
#8:
Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
I've changed it to "Generate-by" to silence checkpatch.pl.
> 0-day tested with no failures.
>
> Suggested-by: Luis R. Rodriguez <mcgrof@kernel.org>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
Patch queued for 4.16, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-04 15:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20171231122615epcas1p467e0c038c7009363f9ee9444c82ab29d@epcas1p4.samsung.com>
2017-12-31 12:25 ` [PATCH] fbdev: auo_k190x: Use zeroing memory allocator than allocator/memset Himanshu Jha
2017-12-31 12:37 ` Himanshu Jha
2018-01-04 15:50 ` Bartlomiej Zolnierkiewicz
2018-01-04 15:50 ` Bartlomiej Zolnierkiewicz
2018-01-04 15:50 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.