All of lore.kernel.org
 help / color / mirror / Atom feed
* [SPDK] Running SPDK without app framework
@ 2020-02-03 12:16 Stojaczyk, Dariusz
  0 siblings, 0 replies; only message in thread
From: Stojaczyk, Dariusz @ 2020-02-03 12:16 UTC (permalink / raw)
  To: spdk

[-- Attachment #1: Type: text/plain, Size: 992 bytes --]

Tomek, I'm looking through your patch example/fio: add option to load json_config [1] and have some concerns to the overall design of applications utilizing SPDK without the app framework. First of all, we seem to use spdk_app_json_config_load() to load a JSON config in fio_plugin. The spdk_app_ prefix in that function suggests it's the app framework API, which we don't use in fio_plugin. I'm guessing it should be at least renamed? spdk_json_config_load() maybe?

spdk_app_json_config_load() is defined in spdk_internal/event.h. Why is this internal anyway? This practically forces external SPDK users to stick with either legacy json config files, or spdk_app_start(). The question is where should we move it? lib/event.h is currently specific to the app framework. Do you have any plans for SPDK app design without the app framework? I'm guessing we do want to support it (see fio_plugin), but currently it's messy.

D.

[1] https://review.gerrithub.io/c/spdk/spdk/+/463979/



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-02-03 12:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-03 12:16 [SPDK] Running SPDK without app framework Stojaczyk, Dariusz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.