* [PATCH] selinux: Fix error return code in sel_ib_pkey_sid_slow()
@ 2020-11-12 8:55 Chen Zhou
2020-11-12 13:23 ` chenzhou
0 siblings, 1 reply; 2+ messages in thread
From: Chen Zhou @ 2020-11-12 8:55 UTC (permalink / raw)
To: paul, stephen.smalley.work, eparis, danielj, dledford
Cc: selinux, linux-kernel, chenzhou10, Hulk Robot
Fix to return a negative error code from the error handling case
instead of 0 in function sel_ib_pkey_sid_slow(), as done elsewhere
in this function.
Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of PKey SIDs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
---
security/selinux/ibpkey.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/security/selinux/ibpkey.c b/security/selinux/ibpkey.c
index f68a7617cfb9..680b2dd1520f 100644
--- a/security/selinux/ibpkey.c
+++ b/security/selinux/ibpkey.c
@@ -151,8 +151,10 @@ static int sel_ib_pkey_sid_slow(u64 subnet_prefix, u16 pkey_num, u32 *sid)
* is valid, it just won't be added to the cache.
*/
new = kzalloc(sizeof(*new), GFP_ATOMIC);
- if (!new)
+ if (IS_ERR(new)) {
+ ret = PTR_ERR(new);
goto out;
+ }
new->psec.subnet_prefix = subnet_prefix;
new->psec.pkey = pkey_num;
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] selinux: Fix error return code in sel_ib_pkey_sid_slow()
2020-11-12 8:55 [PATCH] selinux: Fix error return code in sel_ib_pkey_sid_slow() Chen Zhou
@ 2020-11-12 13:23 ` chenzhou
0 siblings, 0 replies; 2+ messages in thread
From: chenzhou @ 2020-11-12 13:23 UTC (permalink / raw)
To: paul, stephen.smalley.work, eparis, danielj, dledford
Cc: selinux, linux-kernel, Hulk Robot
On 2020/11/12 16:55, Chen Zhou wrote:
> Fix to return a negative error code from the error handling case
> instead of 0 in function sel_ib_pkey_sid_slow(), as done elsewhere
> in this function.
>
> Fixes: 409dcf31538a ("selinux: Add a cache for quicker retreival of PKey SIDs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> ---
> security/selinux/ibpkey.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/security/selinux/ibpkey.c b/security/selinux/ibpkey.c
> index f68a7617cfb9..680b2dd1520f 100644
> --- a/security/selinux/ibpkey.c
> +++ b/security/selinux/ibpkey.c
> @@ -151,8 +151,10 @@ static int sel_ib_pkey_sid_slow(u64 subnet_prefix, u16 pkey_num, u32 *sid)
> * is valid, it just won't be added to the cache.
> */
> new = kzalloc(sizeof(*new), GFP_ATOMIC);
> - if (!new)
> + if (IS_ERR(new)) {
> + ret = PTR_ERR(new);
> goto out;
> + }
>
> new->psec.subnet_prefix = subnet_prefix;
> new->psec.pkey = pkey_num;
Ignore this, will send v2.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-12 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-12 8:55 [PATCH] selinux: Fix error return code in sel_ib_pkey_sid_slow() Chen Zhou
2020-11-12 13:23 ` chenzhou
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.