From: Sekhar Nori <nsekhar@ti.com> To: David Lechner <david@lechnology.com>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Kevin Hilman <khilman@kernel.org> Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "Axel Haslam" <ahaslam@baylibre.com>, "Alexandre Bailon" <abailon@baylibre.com>, "Bartosz Gołaszewski" <bgolaszewski@baylibre.com> Subject: Re: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf Date: Thu, 24 Nov 2016 11:24:47 +0530 [thread overview] Message-ID: <263cdd6d-ed04-647e-a4e9-4e3e094e54d9@ti.com> (raw) In-Reply-To: <06bc8517-8c33-85a1-9d5a-29042c7281db@lechnology.com> On Wednesday 23 November 2016 09:54 PM, David Lechner wrote: > On 11/23/2016 05:12 AM, Sekhar Nori wrote: >> On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: >>> This SoC has a separate pin controller for configuring pullup/pulldown >>> bias on groups of pins. >>> >>> Signed-off-by: David Lechner <david@lechnology.com> >>> --- >>> arch/arm/boot/dts/da850.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >>> index 8945815..1c0224c 100644 >>> --- a/arch/arm/boot/dts/da850.dtsi >>> +++ b/arch/arm/boot/dts/da850.dtsi >>> @@ -210,6 +210,11 @@ >>> }; >>> >>> }; >>> + pinconf: pin-controller@22c00c { >>> + compatible = "ti,da850-pupd"; >>> + reg = <0x22c00c 0x8>; >>> + status = "disabled"; >>> + }; >> >> Can you please place this below the i2c1 node. I am trying to keep the >> nodes sorted by unit address. I know thats broken in many places today, >> but lets add the new ones where they should eventually end up. > > I can do this, but it seems that the predominant sorting pattern here is > to keep subsystems together (e.g. all i2c are together, all uart are > together, etc.) Yeah, but that quickly gives away as there are many singleton devices and everyone tries to add theirs at the end of the list resulting in merge conflicts. > Would a separate patch to sort everything by unit address to get this > cleaned up be acceptable? Agree with Kevin that it would be churn. If done, it should be last thing that gets done in a merge window. I would not attempt it in relatively busy merge windows like this one. Thanks, Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: nsekhar@ti.com (Sekhar Nori) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf Date: Thu, 24 Nov 2016 11:24:47 +0530 [thread overview] Message-ID: <263cdd6d-ed04-647e-a4e9-4e3e094e54d9@ti.com> (raw) In-Reply-To: <06bc8517-8c33-85a1-9d5a-29042c7281db@lechnology.com> On Wednesday 23 November 2016 09:54 PM, David Lechner wrote: > On 11/23/2016 05:12 AM, Sekhar Nori wrote: >> On Wednesday 23 November 2016 08:59 AM, David Lechner wrote: >>> This SoC has a separate pin controller for configuring pullup/pulldown >>> bias on groups of pins. >>> >>> Signed-off-by: David Lechner <david@lechnology.com> >>> --- >>> arch/arm/boot/dts/da850.dtsi | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi >>> index 8945815..1c0224c 100644 >>> --- a/arch/arm/boot/dts/da850.dtsi >>> +++ b/arch/arm/boot/dts/da850.dtsi >>> @@ -210,6 +210,11 @@ >>> }; >>> >>> }; >>> + pinconf: pin-controller at 22c00c { >>> + compatible = "ti,da850-pupd"; >>> + reg = <0x22c00c 0x8>; >>> + status = "disabled"; >>> + }; >> >> Can you please place this below the i2c1 node. I am trying to keep the >> nodes sorted by unit address. I know thats broken in many places today, >> but lets add the new ones where they should eventually end up. > > I can do this, but it seems that the predominant sorting pattern here is > to keep subsystems together (e.g. all i2c are together, all uart are > together, etc.) Yeah, but that quickly gives away as there are many singleton devices and everyone tries to add theirs at the end of the list resulting in merge conflicts. > Would a separate patch to sort everything by unit address to get this > cleaned up be acceptable? Agree with Kevin that it would be churn. If done, it should be last thing that gets done in a merge window. I would not attempt it in relatively busy merge windows like this one. Thanks, Sekhar
next prev parent reply other threads:[~2016-11-24 5:56 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-11-23 3:29 [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf David Lechner 2016-11-23 3:29 ` David Lechner 2016-11-23 3:29 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd David Lechner 2016-11-23 3:29 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti, da850-pupd David Lechner 2016-11-23 11:01 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd Sekhar Nori 2016-11-23 11:01 ` Sekhar Nori 2016-11-24 14:04 ` Linus Walleij 2016-11-24 14:04 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti, da850-pupd Linus Walleij 2016-11-28 21:54 ` [PATCH 1/3] devicetree: bindings: pinctrl: Add binding for ti,da850-pupd Rob Herring 2016-11-28 21:54 ` Rob Herring 2016-11-23 3:29 ` [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf David Lechner 2016-11-23 3:29 ` David Lechner [not found] ` <1479871767-20160-3-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> 2016-11-23 11:04 ` Sekhar Nori 2016-11-23 11:04 ` Sekhar Nori 2016-11-23 11:04 ` Sekhar Nori [not found] ` <88b3d16b-6e5b-ea75-d770-35d9adc6c677-l0cyMroinI0@public.gmane.org> 2016-11-23 16:21 ` David Lechner 2016-11-23 16:21 ` David Lechner 2016-11-23 16:21 ` David Lechner 2016-11-24 14:05 ` Linus Walleij 2016-11-24 14:05 ` Linus Walleij 2016-11-24 14:05 ` Linus Walleij 2016-11-23 3:29 ` [PATCH 3/3] ARM: dts: da850: Add node for pullup/pulldown pinconf David Lechner 2016-11-23 3:29 ` David Lechner [not found] ` <1479871767-20160-4-git-send-email-david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> 2016-11-23 11:12 ` Sekhar Nori 2016-11-23 11:12 ` Sekhar Nori 2016-11-23 11:12 ` Sekhar Nori 2016-11-23 16:24 ` David Lechner 2016-11-23 16:24 ` David Lechner 2016-11-23 16:24 ` David Lechner 2016-11-23 22:33 ` Kevin Hilman 2016-11-23 22:33 ` Kevin Hilman 2016-11-24 5:54 ` Sekhar Nori [this message] 2016-11-24 5:54 ` Sekhar Nori 2016-11-23 11:17 ` [PATCH 0/3] TI DA850/OMAP-L138/AM18x pinconf Sekhar Nori 2016-11-23 11:17 ` Sekhar Nori
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=263cdd6d-ed04-647e-a4e9-4e3e094e54d9@ti.com \ --to=nsekhar@ti.com \ --cc=abailon@baylibre.com \ --cc=ahaslam@baylibre.com \ --cc=bgolaszewski@baylibre.com \ --cc=david@lechnology.com \ --cc=devicetree@vger.kernel.org \ --cc=khilman@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.