[Qemu-devel] Patch: allow Solaris to use OSS (OpenSound)

[Qemu-devel] Patch: allow Solaris to use OSS (OpenSound)

[Ben Taylor]

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]


As I seem to have hit a wall with the ES1370 driver in qemu not working 
on Solaris, I have modified configure to allow Solaris to use OpenSoundSystems
audio.

Is there any interest in having a default audio setting for SDL so that
you won't have to always put QEMU_SDL_AUDIO=oss before you start 
qemu?

Ben

[-- Attachment #2: qemu-solaris-oss.patch --]
[-- Type: text/x-patch, Size: 1377 bytes --]

diff -ruN qemu-ORIG/configure qemu/configure
--- qemu-ORIG/configure	2007-02-15 17:58:18.000000000 -0500
+++ qemu/configure	2007-02-25 20:26:11.270139000 -0500
@@ -221,6 +221,8 @@
   ;;
   --fmod-inc=*) fmod_inc="$optarg"
   ;;
+  --enable-oss) oss="yes"
+  ;;
   --enable-mingw32) mingw32="yes" ; cross_prefix="i386-mingw32-" ; linux_user="no"
   ;;
   --disable-slirp) slirp="no"
@@ -289,6 +291,7 @@
 echo "  --enable-coreaudio       enable Coreaudio audio driver"
 echo "  --enable-alsa            enable ALSA audio driver"
 echo "  --enable-fmod            enable FMOD audio driver"
+echo "  --enable-oss             enable OSS audio driver"
 echo "  --enabled-dsound         enable DirectSound audio driver"
 echo "  --enable-system          enable all system emulation targets"
 echo "  --disable-system         disable all system emulation targets"
@@ -619,6 +622,16 @@
     fmod_support=""
 fi
 echo "FMOD support      $fmod $fmod_support"
+if test "$oss" = "yes"; then
+    if test "$solaris" = "yes" && ! test -f /usr/include/sys/soundcard.h ; then
+        echo
+        echo "Error: /usr/include/sys/soundcard.h not found"
+        echo "Error: You must install OSS to use the oss module"
+        echo
+        exit 1
+    fi
+fi
+echo "OSS support       $oss"
 echo "kqemu support     $kqemu"
 echo "Documentation     $build_docs"
 [ ! -z "$uname_release" ] && \

Re: [Qemu-devel] Patch: allow Solaris to use OSS (OpenSound)

[malc]

On Sun, 25 Feb 2007, Ben Taylor wrote:

>
> As I seem to have hit a wall with the ES1370 driver in qemu not working
> on Solaris, I have modified configure to allow Solaris to use OpenSoundSystems
> audio.
>
> Is there any interest in having a default audio setting for SDL so that
> you won't have to always put QEMU_SDL_AUDIO=oss before you start
> qemu?

I don't quite get what does not work OSS or ES1370?

An aside. To the best of my knowledge OSS on Solaris, Net/OpenBSD
(FreeBSDs OSS is fine though) is not your usual OSS but some reduced
version which among other things only allows one open per device
(meaning that to do both DAC/ADC one has to use single file
descriptor)

>From where i stand SDL as the default is a bad idea.

-- 
vale

Re: [Qemu-devel] Patch: allow Solaris to use OSS (OpenSound)

[Ben Taylor]

---- malc <av1474@comtv.ru> wrote: 
> On Mon, 26 Feb 2007, Ben Taylor wrote:
> 
> [..snip..]
> 
> >> From where i stand SDL as the default is a bad idea.
> >
> > Solaris without OSS audio doesn't have any other options.
> > There is no ALSA, and AFAIK, there isn't an fmod either.
> >
> > However, I still think it is probably a good idea to have the
> > QEMU_SDL_AUDIO device default to the audio subsystem
> > that is defined (or defaulted to).  Thoughts?
> 
> I'm somewhat lost, there's no QEMU_SDL_AUDIO, furthermore there's
> no way to tell SDL what subsystem to use other than setting the
> environment variable.

Sorry.  I had a brain fart.  I meant QEMU_AUDIO_DRV.  And after
looking at the code, it appears to be smart enough to pick the
right audio subsystem.  I just remember having to fiddle with
QEMU_AUDIO_DRV when I was trying to figure out a previous
problem with audio occurred (like 18 months ago)

> And to reiterate the point: NetBSD, OpenBSD and Solaris do not
> have full fledged OSS, they provide a wrapper that implements
> some basic functionality. The native thing for them is SUN audio[1]
> (more or less). And there's no QEMU driver for that. Options for
> those system include: OSS wrapper provided with the system, 4Front
> drivers and SDL (if it can use /dev/audio at all).

Well, it appears to use SDL in that case where there is no OSS.

> Only 4Front's solution will allow DAC/ADC because it is basically
> full blown OSS implementation. Unless, ofcourse, native `/dev/audio'
> QEMU driver is written.
> 
> [1] http://docs.sun.com/app/docs/doc/816-0222/6m6nmlssf?q=audio&a=view

Thanks for the clarification.  Guess I'll just go ahead an use the OSS
stuff.

Regards,

Ben

Re: [Qemu-devel] Patch: allow Solaris to use OSS (OpenSound)

[malc]

On Mon, 26 Feb 2007, Ben Taylor wrote:

[..snip..]

>> From where i stand SDL as the default is a bad idea.
>
> Solaris without OSS audio doesn't have any other options.
> There is no ALSA, and AFAIK, there isn't an fmod either.
>
> However, I still think it is probably a good idea to have the
> QEMU_SDL_AUDIO device default to the audio subsystem
> that is defined (or defaulted to).  Thoughts?

I'm somewhat lost, there's no QEMU_SDL_AUDIO, furthermore there's
no way to tell SDL what subsystem to use other than setting the
environment variable.

And to reiterate the point: NetBSD, OpenBSD and Solaris do not
have full fledged OSS, they provide a wrapper that implements
some basic functionality. The native thing for them is SUN audio[1]
(more or less). And there's no QEMU driver for that. Options for
those system include: OSS wrapper provided with the system, 4Front
drivers and SDL (if it can use /dev/audio at all).

Only 4Front's solution will allow DAC/ADC because it is basically
full blown OSS implementation. Unless, ofcourse, native `/dev/audio'
QEMU driver is written.

[1] http://docs.sun.com/app/docs/doc/816-0222/6m6nmlssf?q=audio&a=view

-- 
vale

Re: [Qemu-devel] Patch: allow Solaris to use OSS (OpenSound)

[Ben Taylor]

Hi Malc,

---- malc <av1474@comtv.ru> wrote: 
> On Sun, 25 Feb 2007, Ben Taylor wrote:
> 
> >
> > As I seem to have hit a wall with the ES1370 driver in qemu not working
> > on Solaris, I have modified configure to allow Solaris to use OpenSoundSystems
> > audio.
> >
> > Is there any interest in having a default audio setting for SDL so that
> > you won't have to always put QEMU_SDL_AUDIO=oss before you start
> > qemu?
> 
> I don't quite get what does not work OSS or ES1370?

Using a precompiled version of qemu from opensolaris.org, that
binary didn't work with a Solaris Nevada guest with OSS audio
running on a Solaris Nevada host running native audio.

I think its a problem with the precompiled version of qemu I 
was using.

After I got the OSS version runnning on a different system with OSS, I
went back and recompiled the CVS code (enabling the debugging)
and the audio worked (though the debugging makes the timing of
the sound choppy).  Once recompiled without debugging, it worked
just fine.  I apologize for the false alarm.

> 
> An aside. To the best of my knowledge OSS on Solaris, Net/OpenBSD
> (FreeBSDs OSS is fine though) is not your usual OSS but some reduced
> version which among other things only allows one open per device
> (meaning that to do both DAC/ADC one has to use single file
> descriptor)

I have no idea.  I know it worked, but wouldn't know how to test for that
case you are talking about.


> From where i stand SDL as the default is a bad idea.

Solaris without OSS audio doesn't have any other options.
There is no ALSA, and AFAIK, there isn't an fmod either.

However, I still think it is probably a good idea to have the 
QEMU_SDL_AUDIO device default to the audio subsystem
that is defined (or defaulted to).  Thoughts?

Ben