From: Can Guo <cang@codeaurora.org> To: Stanley Chu <stanley.chu@mediatek.com> Cc: linux-scsi@vger.kernel.org, martin.petersen@oracle.com, avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com, beanhuo@micron.com, asutoshd@codeaurora.org, matthias.bgg@gmail.com, bvanassche@acm.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com, peter.wang@mediatek.com, chun-hung.wu@mediatek.com, andy.teng@mediatek.com, chaotian.jing@mediatek.com, cc.chou@mediatek.com, jiajie.hao@mediatek.com, alice.chao@mediatek.com Subject: Re: [PATCH v1] scsi: ufs: Fix race between shutdown and runtime resume flow Date: Thu, 19 Nov 2020 15:14:19 +0800 [thread overview] Message-ID: <26585f80038d25fc6ee9dddf07e66b93@codeaurora.org> (raw) In-Reply-To: <20201119062916.12931-1-stanley.chu@mediatek.com> On 2020-11-19 14:29, Stanley Chu wrote: > If UFS host device is in runtime-suspended state while > UFS shutdown callback is invoked, UFS device shall be > resumed for register accesses. Currently only UFS local > runtime resume function will be invoked to wake up the host. > This is not enough because if someone triggers runtime > resume from block layer, then race may happen between > shutdown and runtime resume flow, and finally lead to > unlocked register access. > > To fix this kind of issues, in ufshcd_shutdown(), use > pm_runtime_get_sync() instead of resuming UFS device by > ufshcd_runtime_resume() "internally" to let runtime PM > framework manage the whole resume flow. > > Fixes: 57d104c153d3 ("ufs: add UFS power management support") > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> Reviewed-by: Can Guo <cang@codeaurora.org> > --- > drivers/scsi/ufs/ufshcd.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 80cbce414678..bb16cc04f106 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -8941,11 +8941,7 @@ int ufshcd_shutdown(struct ufs_hba *hba) > if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba)) > goto out; > > - if (pm_runtime_suspended(hba->dev)) { > - ret = ufshcd_runtime_resume(hba); > - if (ret) > - goto out; > - } > + pm_runtime_get_sync(hba->dev); > > ret = ufshcd_suspend(hba, UFS_SHUTDOWN_PM); > out:
WARNING: multiple messages have this Message-ID (diff)
From: Can Guo <cang@codeaurora.org> To: Stanley Chu <stanley.chu@mediatek.com> Cc: jiajie.hao@mediatek.com, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, andy.teng@mediatek.com, jejb@linux.ibm.com, chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com, linux-kernel@vger.kernel.org, cc.chou@mediatek.com, avri.altman@wdc.com, alice.chao@mediatek.com, linux-mediatek@lists.infradead.org, peter.wang@mediatek.com, alim.akhtar@samsung.com, matthias.bgg@gmail.com, asutoshd@codeaurora.org, chaotian.jing@mediatek.com, bvanassche@acm.org, linux-arm-kernel@lists.infradead.org, beanhuo@micron.com Subject: Re: [PATCH v1] scsi: ufs: Fix race between shutdown and runtime resume flow Date: Thu, 19 Nov 2020 15:14:19 +0800 [thread overview] Message-ID: <26585f80038d25fc6ee9dddf07e66b93@codeaurora.org> (raw) In-Reply-To: <20201119062916.12931-1-stanley.chu@mediatek.com> On 2020-11-19 14:29, Stanley Chu wrote: > If UFS host device is in runtime-suspended state while > UFS shutdown callback is invoked, UFS device shall be > resumed for register accesses. Currently only UFS local > runtime resume function will be invoked to wake up the host. > This is not enough because if someone triggers runtime > resume from block layer, then race may happen between > shutdown and runtime resume flow, and finally lead to > unlocked register access. > > To fix this kind of issues, in ufshcd_shutdown(), use > pm_runtime_get_sync() instead of resuming UFS device by > ufshcd_runtime_resume() "internally" to let runtime PM > framework manage the whole resume flow. > > Fixes: 57d104c153d3 ("ufs: add UFS power management support") > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> Reviewed-by: Can Guo <cang@codeaurora.org> > --- > drivers/scsi/ufs/ufshcd.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c > index 80cbce414678..bb16cc04f106 100644 > --- a/drivers/scsi/ufs/ufshcd.c > +++ b/drivers/scsi/ufs/ufshcd.c > @@ -8941,11 +8941,7 @@ int ufshcd_shutdown(struct ufs_hba *hba) > if (ufshcd_is_ufs_dev_poweroff(hba) && ufshcd_is_link_off(hba)) > goto out; > > - if (pm_runtime_suspended(hba->dev)) { > - ret = ufshcd_runtime_resume(hba); > - if (ret) > - goto out; > - } > + pm_runtime_get_sync(hba->dev); > > ret = ufshcd_suspend(hba, UFS_SHUTDOWN_PM); > out: _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-11-19 7:14 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-19 6:29 [PATCH v1] scsi: ufs: Fix race between shutdown and runtime resume flow Stanley Chu 2020-11-19 6:29 ` Stanley Chu 2020-11-19 6:29 ` Stanley Chu 2020-11-19 7:14 ` Can Guo [this message] 2020-11-19 7:14 ` Can Guo 2020-11-20 3:30 ` Martin K. Petersen 2020-11-20 3:30 ` Martin K. Petersen 2020-11-20 3:30 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=26585f80038d25fc6ee9dddf07e66b93@codeaurora.org \ --to=cang@codeaurora.org \ --cc=alice.chao@mediatek.com \ --cc=alim.akhtar@samsung.com \ --cc=andy.teng@mediatek.com \ --cc=asutoshd@codeaurora.org \ --cc=avri.altman@wdc.com \ --cc=beanhuo@micron.com \ --cc=bvanassche@acm.org \ --cc=cc.chou@mediatek.com \ --cc=chaotian.jing@mediatek.com \ --cc=chun-hung.wu@mediatek.com \ --cc=jejb@linux.ibm.com \ --cc=jiajie.hao@mediatek.com \ --cc=kuohong.wang@mediatek.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=matthias.bgg@gmail.com \ --cc=peter.wang@mediatek.com \ --cc=stanley.chu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.