* 160 mhz crash
@ 2018-06-15 21:04 Ansuel Smith
2018-06-16 8:11 ` Sebastian Gottschall
0 siblings, 1 reply; 9+ messages in thread
From: Ansuel Smith @ 2018-06-15 21:04 UTC (permalink / raw)
To: ath10k
router r7800 when i set 160mhz channel 64 i get this
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.652048] ath10k_pci
0000:01:00.0: firmware crashed! (guid
f8c16b85-c5f1-49a0-9483-5be423b290df)
Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.652113] ath10k_pci
0000:01:00.0: qca9984/qca9994 hw1.0 target 0x01000000 chip_id
0x00000000 sub 168c:cafe
Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.659922] ath10k_pci
0000:01:00.0: kconfig debug 0 debugfs 1 tracing 0 dfs 1 testmode 1
Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.675217] ath10k_pci
0000:01:00.0: firmware ver 10.4-3.5.3-00053 api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps crc32
4c56a386
Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.679166] ath10k_pci
0000:01:00.0: board_file api 2 bmi_id 0:1 crc32 dd6d039c
Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.692226] ath10k_pci
0000:01:00.0: htt-ver 2.2 wmi-op 6 htt-op 4 cal pre-cal-file max-sta
512 raw 0 hwcrypto 1
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.701464] ath10k_pci
0000:01:00.0: firmware register dump:
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.709853] ath10k_pci
0000:01:00.0: [00]: 0x0000000A 0x000015B3 0x0A00D160 0x00975B31
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.715555] ath10k_pci
0000:01:00.0: [04]: 0x0A00D160 0x00060D30 0x0000001D 0x00472508
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.723272] ath10k_pci
0000:01:00.0: [08]: 0x0045E8E0 0x0045FD84 0x004316F8 0x00400000
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.731175] ath10k_pci
0000:01:00.0: [12]: 0x00000009 0xFFFFFFFF 0x00973D28 0x00973D33
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.738996] ath10k_pci
0000:01:00.0: [16]: 0x0A00D160 0x009C6C1D 0x00000000 0x00000000
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.746983] ath10k_pci
0000:01:00.0: [20]: 0x409C9920 0x004066FC 0x00975A00 0x00000000
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.754887] ath10k_pci
0000:01:00.0: [24]: 0x809A6D59 0x0040675C 0xFFFCFFFF 0xC09C9920
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.762791] ath10k_pci
0000:01:00.0: [28]: 0x809C75B7 0x004067CC 0x0045E8E0 0x00000000
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.770593] ath10k_pci
0000:01:00.0: [32]: 0x809A797B 0x0040681C 0x00417E6C 0x00009015
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.778566] ath10k_pci
0000:01:00.0: [36]: 0x809C7F01 0x004068BC 0x00000000 0x00009015
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.786470] ath10k_pci
0000:01:00.0: [40]: 0x809B72AF 0x004068EC 0x000EE6CC 0x0042C244
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.794374] ath10k_pci
0000:01:00.0: [44]: 0x809B39F2 0x0040692C 0x00000002 0x0042C244
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.802278] ath10k_pci
0000:01:00.0: [48]: 0x809B30CF 0x0040695C 0x00406980 0x0042443C
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.810088] ath10k_pci
0000:01:00.0: [52]: 0x8096EE0E 0x0040697C 0x000EE6C0 0x00000001
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.818085] ath10k_pci
0000:01:00.0: [56]: 0x8096F883 0x00406A2C 0x0042DE2C 0x00424A64
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.825989] ath10k_pci
0000:01:00.0: Copy Engine register dump:
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.833871] ath10k_pci
0000:01:00.0: [00]: 0x0004a000 14 14 3 3
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.839606] ath10k_pci
0000:01:00.0: [01]: 0x0004a400 2 2 40 41
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.846299] ath10k_pci
0000:01:00.0: [02]: 0x0004a800 19 19 18 19
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.852702] ath10k_pci
0000:01:00.0: [03]: 0x0004ac00 2 2 3 2
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.859049] ath10k_pci
0000:01:00.0: [04]: 0x0004b000 4 4 44 4
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.865574] ath10k_pci
0000:01:00.0: [05]: 0x0004b400 7 7 6 7
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.871978] ath10k_pci
0000:01:00.0: [06]: 0x0004b800 1 1 1 1
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.878318] ath10k_pci
0000:01:00.0: [07]: 0x0004bc00 1 1 1 1
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.884828] ath10k_pci
0000:01:00.0: [08]: 0x0004c000 0 0 127 0
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.891252] ath10k_pci
0000:01:00.0: [09]: 0x0004c400 0 0 0 0
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.897590] ath10k_pci
0000:01:00.0: [10]: 0x0004c800 0 0 0 0
Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.904099] ath10k_pci
0000:01:00.0: [11]: 0x0004cc00 0 0 0 0
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 261.911773] ath10k_pci
0000:01:00.0: failed to set 2g txpower 30: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 261.916859] ath10k_pci
0000:01:00.0: failed to setup tx power 30: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 261.923418] ath10k_pci
0000:01:00.0: failed to recalc tx power: -108
Fri Jun 15 23:00:20 2018 kern.info kernel: [ 262.014011] ieee80211
phy0: Hardware restart was requested
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.014174] ath10k_pci
0000:01:00.0: failed to set beacon interval for vdev 0: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.018414] ath10k_pci
0000:01:00.0: failed to set beacon mode for vdev 0: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.026108] ath10k_pci
0000:01:00.0: failed to set dtim period for vdev 0: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.033360] ath10k_pci
0000:01:00.0: failed to bring up vdev 0: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.040549] ath10k_pci
0000:01:00.0: failed to set 2g txpower 30: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.047277] ath10k_pci
0000:01:00.0: failed to setup tx power 30: -108
Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.053572] ath10k_pci
0000:01:00.0: failed to recalc tx power: -108
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.117935] ath10k_pci
0000:01:00.0: firmware crashed! (guid
ba8d431f-6427-4e0f-a32b-49b0af643086)
Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.118021] ath10k_pci
0000:01:00.0: qca9984/qca9994 hw1.0 target 0x01000000 chip_id
0x00000000 sub 168c:cafe
Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.125827] ath10k_pci
0000:01:00.0: kconfig debug 0 debugfs 1 tracing 0 dfs 1 testmode 1
Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.141071] ath10k_pci
0000:01:00.0: firmware ver 10.4-3.5.3-00053 api 5 features
no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps crc32
4c56a386
Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.145055] ath10k_pci
0000:01:00.0: board_file api 2 bmi_id 0:1 crc32 dd6d039c
Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.158032] ath10k_pci
0000:01:00.0: htt-ver 2.2 wmi-op 6 htt-op 4 cal pre-cal-file max-sta
512 raw 0 hwcrypto 1
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.167361] ath10k_pci
0000:01:00.0: firmware register dump:
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.175731] ath10k_pci
0000:01:00.0: [00]: 0x0000000A 0x000015B3 0x0A00D160 0x00975B31
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.181379] ath10k_pci
0000:01:00.0: [04]: 0x0A00D160 0x00060D30 0x0000001D 0x00472508
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.189128] ath10k_pci
0000:01:00.0: [08]: 0x0045E8E0 0x0045FD84 0x004316F8 0x00400000
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.197001] ath10k_pci
0000:01:00.0: [12]: 0x00000009 0xFFFFFFFF 0x00973D28 0x00973D33
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.204900] ath10k_pci
0000:01:00.0: [16]: 0x0A00D160 0x00965A95 0x00000000 0x00000000
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.212799] ath10k_pci
0000:01:00.0: [20]: 0x409C7D24 0x004066FC 0x00975A00 0x00000000
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.220698] ath10k_pci
0000:01:00.0: [24]: 0x809A6D59 0x0040675C 0xFFFCFFFF 0xC09C7D24
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.228598] ath10k_pci
0000:01:00.0: [28]: 0x809C801F 0x004067CC 0x0045E8E0 0x00000000
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.236513] ath10k_pci
0000:01:00.0: [32]: 0x809A797B 0x0040681C 0x00417E6C 0x00009015
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.244396] ath10k_pci
0000:01:00.0: [36]: 0x809CAB2D 0x004068BC 0x00000000 0x00009015
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.252295] ath10k_pci
0000:01:00.0: [40]: 0x809B72AF 0x004068EC 0x000EE6CC 0x0042C244
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.260194] ath10k_pci
0000:01:00.0: [44]: 0x809B39F2 0x0040692C 0x00000002 0x0042C244
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.268094] ath10k_pci
0000:01:00.0: [48]: 0x809B30CF 0x0040695C 0x00406980 0x0042443C
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.275994] ath10k_pci
0000:01:00.0: [52]: 0x8096EE0E 0x0040697C 0x000EE6C0 0x00000001
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.283898] ath10k_pci
0000:01:00.0: [56]: 0x8096F883 0x00406A2C 0x0042DE2C 0x00424A64
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.291791] ath10k_pci
0000:01:00.0: Copy Engine register dump:
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.299695] ath10k_pci
0000:01:00.0: [00]: 0x0004a000 14 14 3 3
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.305507] ath10k_pci
0000:01:00.0: [01]: 0x0004a400 28 28 34 35
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.312106] ath10k_pci
0000:01:00.0: [02]: 0x0004a800 3 3 2 3
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.318530] ath10k_pci
0000:01:00.0: [03]: 0x0004ac00 28 28 29 28
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.324951] ath10k_pci
0000:01:00.0: [04]: 0x0004b000 4 4 44 4
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.331375] ath10k_pci
0000:01:00.0: [05]: 0x0004b400 5 5 4 5
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.337799] ath10k_pci
0000:01:00.0: [06]: 0x0004b800 1 1 1 1
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.344225] ath10k_pci
0000:01:00.0: [07]: 0x0004bc00 1 1 1 1
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.350648] ath10k_pci
0000:01:00.0: [08]: 0x0004c000 0 0 127 0
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.357072] ath10k_pci
0000:01:00.0: [09]: 0x0004c400 0 0 0 0
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.363493] ath10k_pci
0000:01:00.0: [10]: 0x0004c800 0 0 0 0
Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.369917] ath10k_pci
0000:01:00.0: [11]: 0x0004cc00 0 0 0 0
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.377231] ath10k_pci
0000:01:00.0: failed to set wmm params: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.382956] ath10k_pci
0000:01:00.0: device is wedged, will not restart
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.388840] ath10k_pci
0000:01:00.0: failed to set wmm params: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.395615] ath10k_pci
0000:01:00.0: failed to set wmm params: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.401763] ath10k_pci
0000:01:00.0: failed to set wmm params: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.407924] ath10k_pci
0000:01:00.0: failed to set beacon interval for vdev 0: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.414278] ath10k_pci
0000:01:00.0: failed to set beacon mode for vdev 0: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.421920] ath10k_pci
0000:01:00.0: failed to set dtim period for vdev 0: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.429219] ath10k_pci
0000:01:00.0: failed to bring up vdev 0: -108
Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.436677] ath10k_pci
0000:01:00.0: failed to recalculate rts/cts prot for vdev 0: -108
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-06-15 21:04 160 mhz crash Ansuel Smith
@ 2018-06-16 8:11 ` Sebastian Gottschall
2018-06-28 6:46 ` Sven Eckelmann
0 siblings, 1 reply; 9+ messages in thread
From: Sebastian Gottschall @ 2018-06-16 8:11 UTC (permalink / raw)
To: Ansuel Smith, ath10k
this is normal. i already posted a patch on this mailinglist to resolve
this issue, but
but it hasnt found its way to the main source yes.
Sebastian
Am 15.06.2018 um 23:04 schrieb Ansuel Smith:
> router r7800 when i set 160mhz channel 64 i get this
>
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.652048] ath10k_pci
> 0000:01:00.0: firmware crashed! (guid
> f8c16b85-c5f1-49a0-9483-5be423b290df)
> Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.652113] ath10k_pci
> 0000:01:00.0: qca9984/qca9994 hw1.0 target 0x01000000 chip_id
> 0x00000000 sub 168c:cafe
> Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.659922] ath10k_pci
> 0000:01:00.0: kconfig debug 0 debugfs 1 tracing 0 dfs 1 testmode 1
> Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.675217] ath10k_pci
> 0000:01:00.0: firmware ver 10.4-3.5.3-00053 api 5 features
> no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps crc32
> 4c56a386
> Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.679166] ath10k_pci
> 0000:01:00.0: board_file api 2 bmi_id 0:1 crc32 dd6d039c
> Fri Jun 15 23:00:20 2018 kern.info kernel: [ 261.692226] ath10k_pci
> 0000:01:00.0: htt-ver 2.2 wmi-op 6 htt-op 4 cal pre-cal-file max-sta
> 512 raw 0 hwcrypto 1
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.701464] ath10k_pci
> 0000:01:00.0: firmware register dump:
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.709853] ath10k_pci
> 0000:01:00.0: [00]: 0x0000000A 0x000015B3 0x0A00D160 0x00975B31
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.715555] ath10k_pci
> 0000:01:00.0: [04]: 0x0A00D160 0x00060D30 0x0000001D 0x00472508
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.723272] ath10k_pci
> 0000:01:00.0: [08]: 0x0045E8E0 0x0045FD84 0x004316F8 0x00400000
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.731175] ath10k_pci
> 0000:01:00.0: [12]: 0x00000009 0xFFFFFFFF 0x00973D28 0x00973D33
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.738996] ath10k_pci
> 0000:01:00.0: [16]: 0x0A00D160 0x009C6C1D 0x00000000 0x00000000
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.746983] ath10k_pci
> 0000:01:00.0: [20]: 0x409C9920 0x004066FC 0x00975A00 0x00000000
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.754887] ath10k_pci
> 0000:01:00.0: [24]: 0x809A6D59 0x0040675C 0xFFFCFFFF 0xC09C9920
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.762791] ath10k_pci
> 0000:01:00.0: [28]: 0x809C75B7 0x004067CC 0x0045E8E0 0x00000000
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.770593] ath10k_pci
> 0000:01:00.0: [32]: 0x809A797B 0x0040681C 0x00417E6C 0x00009015
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.778566] ath10k_pci
> 0000:01:00.0: [36]: 0x809C7F01 0x004068BC 0x00000000 0x00009015
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.786470] ath10k_pci
> 0000:01:00.0: [40]: 0x809B72AF 0x004068EC 0x000EE6CC 0x0042C244
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.794374] ath10k_pci
> 0000:01:00.0: [44]: 0x809B39F2 0x0040692C 0x00000002 0x0042C244
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.802278] ath10k_pci
> 0000:01:00.0: [48]: 0x809B30CF 0x0040695C 0x00406980 0x0042443C
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.810088] ath10k_pci
> 0000:01:00.0: [52]: 0x8096EE0E 0x0040697C 0x000EE6C0 0x00000001
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.818085] ath10k_pci
> 0000:01:00.0: [56]: 0x8096F883 0x00406A2C 0x0042DE2C 0x00424A64
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.825989] ath10k_pci
> 0000:01:00.0: Copy Engine register dump:
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.833871] ath10k_pci
> 0000:01:00.0: [00]: 0x0004a000 14 14 3 3
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.839606] ath10k_pci
> 0000:01:00.0: [01]: 0x0004a400 2 2 40 41
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.846299] ath10k_pci
> 0000:01:00.0: [02]: 0x0004a800 19 19 18 19
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.852702] ath10k_pci
> 0000:01:00.0: [03]: 0x0004ac00 2 2 3 2
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.859049] ath10k_pci
> 0000:01:00.0: [04]: 0x0004b000 4 4 44 4
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.865574] ath10k_pci
> 0000:01:00.0: [05]: 0x0004b400 7 7 6 7
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.871978] ath10k_pci
> 0000:01:00.0: [06]: 0x0004b800 1 1 1 1
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.878318] ath10k_pci
> 0000:01:00.0: [07]: 0x0004bc00 1 1 1 1
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.884828] ath10k_pci
> 0000:01:00.0: [08]: 0x0004c000 0 0 127 0
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.891252] ath10k_pci
> 0000:01:00.0: [09]: 0x0004c400 0 0 0 0
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.897590] ath10k_pci
> 0000:01:00.0: [10]: 0x0004c800 0 0 0 0
> Fri Jun 15 23:00:20 2018 kern.err kernel: [ 261.904099] ath10k_pci
> 0000:01:00.0: [11]: 0x0004cc00 0 0 0 0
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 261.911773] ath10k_pci
> 0000:01:00.0: failed to set 2g txpower 30: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 261.916859] ath10k_pci
> 0000:01:00.0: failed to setup tx power 30: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 261.923418] ath10k_pci
> 0000:01:00.0: failed to recalc tx power: -108
> Fri Jun 15 23:00:20 2018 kern.info kernel: [ 262.014011] ieee80211
> phy0: Hardware restart was requested
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.014174] ath10k_pci
> 0000:01:00.0: failed to set beacon interval for vdev 0: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.018414] ath10k_pci
> 0000:01:00.0: failed to set beacon mode for vdev 0: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.026108] ath10k_pci
> 0000:01:00.0: failed to set dtim period for vdev 0: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.033360] ath10k_pci
> 0000:01:00.0: failed to bring up vdev 0: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.040549] ath10k_pci
> 0000:01:00.0: failed to set 2g txpower 30: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.047277] ath10k_pci
> 0000:01:00.0: failed to setup tx power 30: -108
> Fri Jun 15 23:00:20 2018 kern.warn kernel: [ 262.053572] ath10k_pci
> 0000:01:00.0: failed to recalc tx power: -108
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.117935] ath10k_pci
> 0000:01:00.0: firmware crashed! (guid
> ba8d431f-6427-4e0f-a32b-49b0af643086)
> Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.118021] ath10k_pci
> 0000:01:00.0: qca9984/qca9994 hw1.0 target 0x01000000 chip_id
> 0x00000000 sub 168c:cafe
> Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.125827] ath10k_pci
> 0000:01:00.0: kconfig debug 0 debugfs 1 tracing 0 dfs 1 testmode 1
> Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.141071] ath10k_pci
> 0000:01:00.0: firmware ver 10.4-3.5.3-00053 api 5 features
> no-p2p,mfp,peer-flow-ctrl,btcoex-param,allows-mesh-bcast,no-ps crc32
> 4c56a386
> Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.145055] ath10k_pci
> 0000:01:00.0: board_file api 2 bmi_id 0:1 crc32 dd6d039c
> Fri Jun 15 23:00:26 2018 kern.info kernel: [ 268.158032] ath10k_pci
> 0000:01:00.0: htt-ver 2.2 wmi-op 6 htt-op 4 cal pre-cal-file max-sta
> 512 raw 0 hwcrypto 1
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.167361] ath10k_pci
> 0000:01:00.0: firmware register dump:
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.175731] ath10k_pci
> 0000:01:00.0: [00]: 0x0000000A 0x000015B3 0x0A00D160 0x00975B31
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.181379] ath10k_pci
> 0000:01:00.0: [04]: 0x0A00D160 0x00060D30 0x0000001D 0x00472508
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.189128] ath10k_pci
> 0000:01:00.0: [08]: 0x0045E8E0 0x0045FD84 0x004316F8 0x00400000
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.197001] ath10k_pci
> 0000:01:00.0: [12]: 0x00000009 0xFFFFFFFF 0x00973D28 0x00973D33
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.204900] ath10k_pci
> 0000:01:00.0: [16]: 0x0A00D160 0x00965A95 0x00000000 0x00000000
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.212799] ath10k_pci
> 0000:01:00.0: [20]: 0x409C7D24 0x004066FC 0x00975A00 0x00000000
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.220698] ath10k_pci
> 0000:01:00.0: [24]: 0x809A6D59 0x0040675C 0xFFFCFFFF 0xC09C7D24
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.228598] ath10k_pci
> 0000:01:00.0: [28]: 0x809C801F 0x004067CC 0x0045E8E0 0x00000000
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.236513] ath10k_pci
> 0000:01:00.0: [32]: 0x809A797B 0x0040681C 0x00417E6C 0x00009015
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.244396] ath10k_pci
> 0000:01:00.0: [36]: 0x809CAB2D 0x004068BC 0x00000000 0x00009015
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.252295] ath10k_pci
> 0000:01:00.0: [40]: 0x809B72AF 0x004068EC 0x000EE6CC 0x0042C244
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.260194] ath10k_pci
> 0000:01:00.0: [44]: 0x809B39F2 0x0040692C 0x00000002 0x0042C244
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.268094] ath10k_pci
> 0000:01:00.0: [48]: 0x809B30CF 0x0040695C 0x00406980 0x0042443C
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.275994] ath10k_pci
> 0000:01:00.0: [52]: 0x8096EE0E 0x0040697C 0x000EE6C0 0x00000001
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.283898] ath10k_pci
> 0000:01:00.0: [56]: 0x8096F883 0x00406A2C 0x0042DE2C 0x00424A64
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.291791] ath10k_pci
> 0000:01:00.0: Copy Engine register dump:
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.299695] ath10k_pci
> 0000:01:00.0: [00]: 0x0004a000 14 14 3 3
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.305507] ath10k_pci
> 0000:01:00.0: [01]: 0x0004a400 28 28 34 35
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.312106] ath10k_pci
> 0000:01:00.0: [02]: 0x0004a800 3 3 2 3
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.318530] ath10k_pci
> 0000:01:00.0: [03]: 0x0004ac00 28 28 29 28
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.324951] ath10k_pci
> 0000:01:00.0: [04]: 0x0004b000 4 4 44 4
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.331375] ath10k_pci
> 0000:01:00.0: [05]: 0x0004b400 5 5 4 5
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.337799] ath10k_pci
> 0000:01:00.0: [06]: 0x0004b800 1 1 1 1
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.344225] ath10k_pci
> 0000:01:00.0: [07]: 0x0004bc00 1 1 1 1
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.350648] ath10k_pci
> 0000:01:00.0: [08]: 0x0004c000 0 0 127 0
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.357072] ath10k_pci
> 0000:01:00.0: [09]: 0x0004c400 0 0 0 0
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.363493] ath10k_pci
> 0000:01:00.0: [10]: 0x0004c800 0 0 0 0
> Fri Jun 15 23:00:26 2018 kern.err kernel: [ 268.369917] ath10k_pci
> 0000:01:00.0: [11]: 0x0004cc00 0 0 0 0
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.377231] ath10k_pci
> 0000:01:00.0: failed to set wmm params: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.382956] ath10k_pci
> 0000:01:00.0: device is wedged, will not restart
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.388840] ath10k_pci
> 0000:01:00.0: failed to set wmm params: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.395615] ath10k_pci
> 0000:01:00.0: failed to set wmm params: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.401763] ath10k_pci
> 0000:01:00.0: failed to set wmm params: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.407924] ath10k_pci
> 0000:01:00.0: failed to set beacon interval for vdev 0: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.414278] ath10k_pci
> 0000:01:00.0: failed to set beacon mode for vdev 0: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.421920] ath10k_pci
> 0000:01:00.0: failed to set dtim period for vdev 0: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.429219] ath10k_pci
> 0000:01:00.0: failed to bring up vdev 0: -108
> Fri Jun 15 23:00:26 2018 kern.warn kernel: [ 268.436677] ath10k_pci
> 0000:01:00.0: failed to recalculate rts/cts prot for vdev 0: -108
>
> _______________________________________________
> ath10k mailing list
> ath10k@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/ath10k
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-06-16 8:11 ` Sebastian Gottschall
@ 2018-06-28 6:46 ` Sven Eckelmann
2018-06-28 9:56 ` Sebastian Gottschall
2018-06-28 9:56 ` Sebastian Gottschall
0 siblings, 2 replies; 9+ messages in thread
From: Sven Eckelmann @ 2018-06-28 6:46 UTC (permalink / raw)
To: ath10k; +Cc: Ansuel Smith, Sebastian Gottschall
[-- Attachment #1.1: Type: text/plain, Size: 379 bytes --]
On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote:
>
> this is normal. i already posted a patch on this mailinglist to resolve
> this issue, but
>
> but it hasnt found its way to the main source yes.
Problem seems to be that the patch [1] has obvious style problems and open
questions.
Kind regards,
Sven
[1] https://patchwork.kernel.org/patch/10372949/
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-06-28 6:46 ` Sven Eckelmann
@ 2018-06-28 9:56 ` Sebastian Gottschall
2018-07-03 14:58 ` Kalle Valo
2018-06-28 9:56 ` Sebastian Gottschall
1 sibling, 1 reply; 9+ messages in thread
From: Sebastian Gottschall @ 2018-06-28 9:56 UTC (permalink / raw)
To: Sven Eckelmann, ath10k; +Cc: Ansuel Smith
Am 28.06.2018 um 08:46 schrieb Sven Eckelmann:
> On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote:
>> this is normal. i already posted a patch on this mailinglist to resolve
>> this issue, but
>>
>> but it hasnt found its way to the main source yes.
> Problem seems to be that the patch [1] has obvious style problems and open
> questions.
i understand that. but i dont see a problem with the code style since
the patch is small and not bad looking and on the second hand i was
tired to finish the discussion. it was frustrating me
anyone is welcome to enhance it. without it, the firmware will simply
crash. so its at least usefull to bring it in, in someway. it wont have
bad consequences.
consider also that the patch itself is basicly a port of the behaviour
of the propertiery qca driver. so think its correct and i'm running this
patch for months now
but another thing is that 2 patches are required for getting 160 mhz to
work. the first one which is required since firmware 3.4 was already
posted by me 2 years ago if i'm correct.
without the first patch 160 does not work at all. the second patch
posted 2 months ago is for 3.5 or newer but requires the first patch as well
Sebastian
>
> Kind regards,
> Sven
>
> [1] https://patchwork.kernel.org/patch/10372949/
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-06-28 6:46 ` Sven Eckelmann
2018-06-28 9:56 ` Sebastian Gottschall
@ 2018-06-28 9:56 ` Sebastian Gottschall
2018-06-28 12:24 ` Sven Eckelmann
1 sibling, 1 reply; 9+ messages in thread
From: Sebastian Gottschall @ 2018-06-28 9:56 UTC (permalink / raw)
To: Sven Eckelmann, ath10k; +Cc: Ansuel Smith
btw. openwrt imported my patches recently, but with some openwrt
specific modifications
Am 28.06.2018 um 08:46 schrieb Sven Eckelmann:
> On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote:
>> this is normal. i already posted a patch on this mailinglist to resolve
>> this issue, but
>>
>> but it hasnt found its way to the main source yes.
> Problem seems to be that the patch [1] has obvious style problems and open
> questions.
>
> Kind regards,
> Sven
>
> [1] https://patchwork.kernel.org/patch/10372949/
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-06-28 9:56 ` Sebastian Gottschall
@ 2018-06-28 12:24 ` Sven Eckelmann
2018-06-29 4:12 ` Sebastian Gottschall
0 siblings, 1 reply; 9+ messages in thread
From: Sven Eckelmann @ 2018-06-28 12:24 UTC (permalink / raw)
To: Sebastian Gottschall; +Cc: Ansuel Smith, ath10k
[-- Attachment #1.1: Type: text/plain, Size: 7541 bytes --]
On Donnerstag, 28. Juni 2018 11:56:39 CEST Sebastian Gottschall wrote:
> btw. openwrt imported my patches recently, but with some openwrt
> specific modifications
Thanks, just tested these [1]. It doesn't crash anymore and at least the basic
functionality seems to work.
On Donnerstag, 28. Juni 2018 11:56:02 CEST Sebastian Gottschall wrote:
> i understand that. but i dont see a problem with the code style
Your commit message contains things which don't belong there (the changelog of
the different version) and you don't follow the rules about line length in the
commit message or subject. Also checkpatch.pl panics when seeing your
changes [2,3]:
------------------------------------------------------------------------------------------
ath10k-160mhz/v1-ath10k-fix-band_center_freq-handling-for-VHT160-in-recent-firmwares.patch
------------------------------------------------------------------------------------------
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
starting with firmware 10.4.3.4.x series QCA changed the handling of the channel property band_center_freq1 and band_center_freq2 in vht160 operation mode
WARNING: 'compatiblity' may be misspelled - perhaps 'compatibility'?
#18:
likelly for backward compatiblity with vht80 only capable clients.
WARNING: line over 80 characters
#62: FILE: drivers/net/wireless/ath/ath10k/wmi.c:1681:
+ ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 - 40);
ERROR: trailing whitespace
#64: FILE: drivers/net/wireless/ath/ath10k/wmi.c:1683:
+^I^I^Ich->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 + 40);^I^I$
WARNING: line over 80 characters
#64: FILE: drivers/net/wireless/ath/ath10k/wmi.c:1683:
+ ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 + 40);
ERROR: Missing Signed-off-by: line(s)
total: 2 errors, 4 warnings, 0 checks, 34 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
NOTE: Whitespace errors detected.
You may wish to use scripts/cleanpatch or scripts/cleanfile
ath10k-160mhz/v1-ath10k-fix-band_center_freq-handling-for-VHT160-in-recent-firmwares.patch has style problems, please review.
----------------------------------------------------------------------------------------------------------------------------
ath10k-160mhz/v7-ath10k-fix-crash-in-recent-3.5.3-9984-firmware-due-wrong-handling-of-peer_bw_rxnss_override-parameter.patch
----------------------------------------------------------------------------------------------------------------------------
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#17:
current handling of peer_bw_rxnss_override parameter is based on guessing the VHT160/8080 capability by rx rate. this is wrong and may lead
WARNING: line over 80 characters
#73: FILE: drivers/net/wireless/ath/ath10k/mac.c:2534:
+ /* only 4x4 configuration do support 2x2 for VHT160, everything else must use 1x1 */
WARNING: line over 80 characters
#75: FILE: drivers/net/wireless/ath/ath10k/mac.c:2536:
+ nss160 = arg->peer_num_spatial_streams <= 2 ? arg->peer_num_spatial_streams : 2;
WARNING: line over 80 characters
#77: FILE: drivers/net/wireless/ath/ath10k/mac.c:2538:
+ /* in case if peer is connected with vht160 or vht80+80, we need to properly adjust rxnss parameters otherwise firmware will raise a assert */
ERROR: space required before the open parenthesis '('
#78: FILE: drivers/net/wireless/ath/ath10k/mac.c:2539:
+ switch(arg->peer_phymode) {
WARNING: line over 80 characters
#90: FILE: drivers/net/wireless/ath/ath10k/mac.c:2551:
+ sta->addr, arg->peer_max_mpdu, arg->peer_flags, arg->peer_bw_rxnss_override);
WARNING: line over 80 characters
#119: FILE: drivers/net/wireless/ath/ath10k/wmi.c:7214:
+ cmd->peer_bw_rxnss_override = __cpu_to_le32(arg->peer_bw_rxnss_override);
CHECK: Prefer using the BIT macro
#132: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6383:
+#define BW_NSS_FWCONF_MAP_ENABLE (1 << 31)
WARNING: line over 80 characters
#139: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6390:
+#define GET_BW_NSS_FWCONF_160(x) ((((x) & BW_NSS_FWCONF_MAP_160MHZ_M) >> BW_NSS_FWCONF_MAP_160MHZ_S) + 1)
WARNING: line over 80 characters
#140: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6391:
+#define GET_BW_NSS_FWCONF_80_80(x) ((((x) & BW_NSS_FWCONF_MAP_80_80MHZ_M) >> BW_NSS_FWCONF_MAP_80_80MHZ_S) + 1)
WARNING: line over 80 characters
#143: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6394:
+#define BW_NSS_FWCONF_160(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) & BW_NSS_FWCONF_MAP_160MHZ_M))
CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#143: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6394:
+#define BW_NSS_FWCONF_160(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) & BW_NSS_FWCONF_MAP_160MHZ_M))
WARNING: line over 80 characters
#144: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6395:
+#define BW_NSS_FWCONF_80_80(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) & BW_NSS_FWCONF_MAP_80_80MHZ_M))
CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#144: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6395:
+#define BW_NSS_FWCONF_80_80(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) & BW_NSS_FWCONF_MAP_80_80MHZ_M))
total: 1 errors, 10 warnings, 3 checks, 94 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
ath10k-160mhz/v7-ath10k-fix-crash-in-recent-3.5.3-9984-firmware-due-wrong-handling-of-peer_bw_rxnss_override-parameter.patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
There are also general coding style problems [4]. Look for example at the way
you format a switch:
+ /* in case if peer is connected with vht160 or vht80+80, we need to properly adjust rxnss parameters otherwise firmware will raise a assert */
+ switch(arg->peer_phymode) {
+ case MODE_11AC_VHT80_80:
+ arg->peer_bw_rxnss_override = BW_NSS_FWCONF_80_80(nss160);
+ /* fall through */
+ case MODE_11AC_VHT160:
+ arg->peer_bw_rxnss_override |= BW_NSS_FWCONF_160(nss160);
+ break;
+ default:
+ break;
}
Everything after (and including) the first break seems to be misaligned.
I hope it helps to improve the patches.
Kind regards,
Sven
[1] https://github.com/openwrt/openwrt/commit/134e832814f1986c7ee06ac00806ebb6e762fd15
[2] https://patchwork.kernel.org/patch/10365117/
[3] https://patchwork.kernel.org/patch/10372949/
[4] https://www.kernel.org/doc/html/v4.10/process/coding-style.html#indentation
[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 146 bytes --]
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-06-28 12:24 ` Sven Eckelmann
@ 2018-06-29 4:12 ` Sebastian Gottschall
0 siblings, 0 replies; 9+ messages in thread
From: Sebastian Gottschall @ 2018-06-29 4:12 UTC (permalink / raw)
To: Sven Eckelmann; +Cc: Ansuel Smith, ath10k
Am 28.06.2018 um 14:24 schrieb Sven Eckelmann:
> On Donnerstag, 28. Juni 2018 11:56:39 CEST Sebastian Gottschall wrote:
>> btw. openwrt imported my patches recently, but with some openwrt
>> specific modifications
> Thanks, just tested these [1]. It doesn't crash anymore and at least the basic
> functionality seems to work.
>
> On Donnerstag, 28. Juni 2018 11:56:02 CEST Sebastian Gottschall wrote:
>> i understand that. but i dont see a problem with the code style
> Your commit message contains things which don't belong there (the changelog of
> the different version) and you don't follow the rules about line length in the
> commit message or subject. Also checkpatch.pl panics when seeing your
> changes [2,3]:
never saw a warning posted. here on the mailing list about line length
etc. and about code line length
how to define this
(BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) & BW_NSS_FWCONF_MAP_160MHZ_M))
with a line break it turns unreadable and looking like shit. and this code is a definition taken from the original wmi headers from qca.
if its more than 85 characters. i'm fine with that. there is no way to change it
i need also manually to edit this old patch. i deleted already the trees which i used for writing it
> ------------------------------------------------------------------------------------------
> ath10k-160mhz/v1-ath10k-fix-band_center_freq-handling-for-VHT160-in-recent-firmwares.patch
> ------------------------------------------------------------------------------------------
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #17:
> starting with firmware 10.4.3.4.x series QCA changed the handling of the channel property band_center_freq1 and band_center_freq2 in vht160 operation mode
>
> WARNING: 'compatiblity' may be misspelled - perhaps 'compatibility'?
> #18:
> likelly for backward compatiblity with vht80 only capable clients.
>
> WARNING: line over 80 characters
> #62: FILE: drivers/net/wireless/ath/ath10k/wmi.c:1681:
> + ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 - 40);
>
> ERROR: trailing whitespace
> #64: FILE: drivers/net/wireless/ath/ath10k/wmi.c:1683:
> +^I^I^Ich->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 + 40);^I^I$
>
> WARNING: line over 80 characters
> #64: FILE: drivers/net/wireless/ath/ath10k/wmi.c:1683:
> + ch->band_center_freq1 = __cpu_to_le32(arg->band_center_freq1 + 40);
>
> ERROR: Missing Signed-off-by: line(s)
>
> total: 2 errors, 4 warnings, 0 checks, 34 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> NOTE: Whitespace errors detected.
> You may wish to use scripts/cleanpatch or scripts/cleanfile
>
> ath10k-160mhz/v1-ath10k-fix-band_center_freq-handling-for-VHT160-in-recent-firmwares.patch has style problems, please review.
> ----------------------------------------------------------------------------------------------------------------------------
> ath10k-160mhz/v7-ath10k-fix-crash-in-recent-3.5.3-9984-firmware-due-wrong-handling-of-peer_bw_rxnss_override-parameter.patch
> ----------------------------------------------------------------------------------------------------------------------------
> WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
> #17:
> current handling of peer_bw_rxnss_override parameter is based on guessing the VHT160/8080 capability by rx rate. this is wrong and may lead
>
> WARNING: line over 80 characters
> #73: FILE: drivers/net/wireless/ath/ath10k/mac.c:2534:
> + /* only 4x4 configuration do support 2x2 for VHT160, everything else must use 1x1 */
>
> WARNING: line over 80 characters
> #75: FILE: drivers/net/wireless/ath/ath10k/mac.c:2536:
> + nss160 = arg->peer_num_spatial_streams <= 2 ? arg->peer_num_spatial_streams : 2;
>
> WARNING: line over 80 characters
> #77: FILE: drivers/net/wireless/ath/ath10k/mac.c:2538:
> + /* in case if peer is connected with vht160 or vht80+80, we need to properly adjust rxnss parameters otherwise firmware will raise a assert */
>
> ERROR: space required before the open parenthesis '('
> #78: FILE: drivers/net/wireless/ath/ath10k/mac.c:2539:
> + switch(arg->peer_phymode) {
>
> WARNING: line over 80 characters
> #90: FILE: drivers/net/wireless/ath/ath10k/mac.c:2551:
> + sta->addr, arg->peer_max_mpdu, arg->peer_flags, arg->peer_bw_rxnss_override);
>
> WARNING: line over 80 characters
> #119: FILE: drivers/net/wireless/ath/ath10k/wmi.c:7214:
> + cmd->peer_bw_rxnss_override = __cpu_to_le32(arg->peer_bw_rxnss_override);
>
> CHECK: Prefer using the BIT macro
> #132: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6383:
> +#define BW_NSS_FWCONF_MAP_ENABLE (1 << 31)
>
> WARNING: line over 80 characters
> #139: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6390:
> +#define GET_BW_NSS_FWCONF_160(x) ((((x) & BW_NSS_FWCONF_MAP_160MHZ_M) >> BW_NSS_FWCONF_MAP_160MHZ_S) + 1)
>
> WARNING: line over 80 characters
> #140: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6391:
> +#define GET_BW_NSS_FWCONF_80_80(x) ((((x) & BW_NSS_FWCONF_MAP_80_80MHZ_M) >> BW_NSS_FWCONF_MAP_80_80MHZ_S) + 1)
>
> WARNING: line over 80 characters
> #143: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6394:
> +#define BW_NSS_FWCONF_160(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) & BW_NSS_FWCONF_MAP_160MHZ_M))
>
> CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues
> #143: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6394:
> +#define BW_NSS_FWCONF_160(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) & BW_NSS_FWCONF_MAP_160MHZ_M))
>
> WARNING: line over 80 characters
> #144: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6395:
> +#define BW_NSS_FWCONF_80_80(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) & BW_NSS_FWCONF_MAP_80_80MHZ_M))
>
> CHECK: Macro argument 'x' may be better as '(x)' to avoid precedence issues
> #144: FILE: drivers/net/wireless/ath/ath10k/wmi.h:6395:
> +#define BW_NSS_FWCONF_80_80(x) (BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_80_80MHZ_S) & BW_NSS_FWCONF_MAP_80_80MHZ_M))
>
> total: 1 errors, 10 warnings, 3 checks, 94 lines checked
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
> ath10k-160mhz/v7-ath10k-fix-crash-in-recent-3.5.3-9984-firmware-due-wrong-handling-of-peer_bw_rxnss_override-parameter.patch has style problems, please review.
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> There are also general coding style problems [4]. Look for example at the way
> you format a switch:
>
> + /* in case if peer is connected with vht160 or vht80+80, we need to properly adjust rxnss parameters otherwise firmware will raise a assert */
> + switch(arg->peer_phymode) {
> + case MODE_11AC_VHT80_80:
> + arg->peer_bw_rxnss_override = BW_NSS_FWCONF_80_80(nss160);
> + /* fall through */
> + case MODE_11AC_VHT160:
> + arg->peer_bw_rxnss_override |= BW_NSS_FWCONF_160(nss160);
> + break;
> + default:
> + break;
> }
>
> Everything after (and including) the first break seems to be misaligned.
>
>
> I hope it helps to improve the patches.
>
>
> Kind regards,
> Sven
>
> [1] https://github.com/openwrt/openwrt/commit/134e832814f1986c7ee06ac00806ebb6e762fd15
> [2] https://patchwork.kernel.org/patch/10365117/
> [3] https://patchwork.kernel.org/patch/10372949/
> [4] https://www.kernel.org/doc/html/v4.10/process/coding-style.html#indentation
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-06-28 9:56 ` Sebastian Gottschall
@ 2018-07-03 14:58 ` Kalle Valo
2018-07-04 6:05 ` Sebastian Gottschall
0 siblings, 1 reply; 9+ messages in thread
From: Kalle Valo @ 2018-07-03 14:58 UTC (permalink / raw)
To: Sebastian Gottschall; +Cc: Ansuel Smith, ath10k, Sven Eckelmann
Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
> Am 28.06.2018 um 08:46 schrieb Sven Eckelmann:
>> On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote:
>>> this is normal. i already posted a patch on this mailinglist to resolve
>>> this issue, but
>>>
>>> but it hasnt found its way to the main source yes.
>> Problem seems to be that the patch [1] has obvious style problems and open
>> questions.
>
> i understand that. but i dont see a problem with the code style since
> the patch is small and not bad looking and on the second hand i was
> tired to finish the discussion. it was frustrating me anyone is
> welcome to enhance it.
And this is why I don't even try to give review comments to your patches
anymore, as it would be waste of my time as shown above. If you want to
have your patches applied, you need to have productive attitude and
willing to receive review comments.
I have been hoping to clean up the patch myself, but I have not managed
to do it yet. If someone else can jump in and finish the patch, I would
be very grateful. I think the biggest work is to cleanup all the
checkpatch warnings and add a check for the WMI service flag.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: 160 mhz crash
2018-07-03 14:58 ` Kalle Valo
@ 2018-07-04 6:05 ` Sebastian Gottschall
0 siblings, 0 replies; 9+ messages in thread
From: Sebastian Gottschall @ 2018-07-04 6:05 UTC (permalink / raw)
To: Kalle Valo; +Cc: Ansuel Smith, ath10k, Sven Eckelmann
Am 03.07.2018 um 16:58 schrieb Kalle Valo:
> Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
>
>> Am 28.06.2018 um 08:46 schrieb Sven Eckelmann:
>>> On Samstag, 16. Juni 2018 10:11:27 CEST Sebastian Gottschall wrote:
>>>> this is normal. i already posted a patch on this mailinglist to resolve
>>>> this issue, but
>>>>
>>>> but it hasnt found its way to the main source yes.
>>> Problem seems to be that the patch [1] has obvious style problems and open
>>> questions.
>> i understand that. but i dont see a problem with the code style since
>> the patch is small and not bad looking and on the second hand i was
>> tired to finish the discussion. it was frustrating me anyone is
>> welcome to enhance it.
> And this is why I don't even try to give review comments to your patches
> anymore, as it would be waste of my time as shown above. If you want to
> have your patches applied, you need to have productive attitude and
> willing to receive review comments.
isnt that unproductive attitute on your side?
if you like the bugs in ath10k, you may keep them. on my side the
problems are fixed in my internal tree.
for sure i just wanted to be nice to give them back to the community,
but that efforts might be wrong placed here
if that get well ignored.
so "i dont want my patch applied" its not about pushing my ego here.
you should want the bugs beeing fixed, no matter if its done with my
patch or just with my solution for the problem.
> I have been hoping to clean up the patch myself, but I have not managed
> to do it yet. If someone else can jump in and finish the patch, I would
> be very grateful. I think the biggest work is to cleanup all the
> checkpatch warnings and add a check for the WMI service flag.
to be honest. its the first time i saw that checkpatch warning and
locally checkpatch isnt working for me
this tool itself is full of bugs and not working on my host system
and if i rewrite lines like
(BW_NSS_FWCONF_MAP_ENABLE | (((x - 1) << BW_NSS_FWCONF_MAP_160MHZ_S) &
BW_NSS_FWCONF_MAP_160MHZ_M))
to match the checkpatch rules, they turn unreadable as i said already.
so i believe also that checkpatch isnt a solution at all
since the rules are too restrictive for some code
for sure we can shorten down all words to be more unreadable. but that
doesnt make sense for me
i will fork the latest ath10k code from git today and try to recreate
the patch with all tabs and spaces correctly set.
>
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-07-04 6:05 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 21:04 160 mhz crash Ansuel Smith
2018-06-16 8:11 ` Sebastian Gottschall
2018-06-28 6:46 ` Sven Eckelmann
2018-06-28 9:56 ` Sebastian Gottschall
2018-07-03 14:58 ` Kalle Valo
2018-07-04 6:05 ` Sebastian Gottschall
2018-06-28 9:56 ` Sebastian Gottschall
2018-06-28 12:24 ` Sven Eckelmann
2018-06-29 4:12 ` Sebastian Gottschall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.