From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com
Subject: [PATCH v2 5/7] drm/i915/dsi: run backlight on/off sequences in panel enable/disable hooks
Date: Mon, 19 Sep 2016 15:02:28 +0300 [thread overview]
Message-ID: <267c4a2bde2076af18e9b8335c0bef2e26ea3112.1474286487.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1474286487.git.jani.nikula@intel.com>
In-Reply-To: <cover.1474286487.git.jani.nikula@intel.com>
Based on the documentation alone, it's anyone's guess when exactly we
should be running these sequences. Add them where it feels logical. The
drm panel hooks don't currently offer us more granularity anyway.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 2c5d14eb7851..24953f9f7e1d 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -477,12 +477,14 @@ static int vbt_panel_unprepare(struct drm_panel *panel)
static int vbt_panel_enable(struct drm_panel *panel)
{
generic_exec_sequence(panel, MIPI_SEQ_DISPLAY_ON);
+ generic_exec_sequence(panel, MIPI_SEQ_BACKLIGHT_ON);
return 0;
}
static int vbt_panel_disable(struct drm_panel *panel)
{
+ generic_exec_sequence(panel, MIPI_SEQ_BACKLIGHT_OFF);
generic_exec_sequence(panel, MIPI_SEQ_DISPLAY_OFF);
return 0;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-09-19 12:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
2016-09-19 12:02 ` [PATCH v2 1/7] drm/i915/dsi: don't debug log "missing" sequences Jani Nikula
2016-09-19 12:02 ` [PATCH v2 2/7] drm/i915/dsi: add debug logging to element execution Jani Nikula
2016-09-19 12:02 ` [PATCH v2 3/7] drm/i915/dsi: add skip functions for spi and pmic elements Jani Nikula
2016-09-19 12:02 ` [PATCH v2 4/7] drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks Jani Nikula
2016-09-19 12:02 ` Jani Nikula [this message]
2016-09-19 12:02 ` [PATCH v2 6/7] drm/i915/bios: log about presence of DSI sequences we do not run Jani Nikula
2016-09-19 12:02 ` [PATCH v2 7/7] drm/i915/dsi: double check element parsing against size if present Jani Nikula
2016-09-19 12:55 ` ✗ Fi.CI.BAT: warning for drm/i915: clean up dsi sequences Patchwork
2016-09-19 13:55 ` [PATCH v2 0/7] " Ville Syrjälä
2016-09-19 15:39 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267c4a2bde2076af18e9b8335c0bef2e26ea3112.1474286487.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.