* [PATCH v2 1/7] drm/i915/dsi: don't debug log "missing" sequences
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
@ 2016-09-19 12:02 ` Jani Nikula
2016-09-19 12:02 ` [PATCH v2 2/7] drm/i915/dsi: add debug logging to element execution Jani Nikula
` (7 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 12:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
This is not interesting. They are not "missing", they are just not part
of the VBT sequences for the panel.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index cd154ce6b6c1..a537c71cdcc6 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -385,11 +385,8 @@ static void generic_exec_sequence(struct drm_panel *panel, enum mipi_seq seq_id)
return;
data = dev_priv->vbt.dsi.sequence[seq_id];
- if (!data) {
- DRM_DEBUG_KMS("MIPI sequence %d - %s not available\n",
- seq_id, sequence_name(seq_id));
+ if (!data)
return;
- }
WARN_ON(*data != seq_id);
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 2/7] drm/i915/dsi: add debug logging to element execution
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
2016-09-19 12:02 ` [PATCH v2 1/7] drm/i915/dsi: don't debug log "missing" sequences Jani Nikula
@ 2016-09-19 12:02 ` Jani Nikula
2016-09-19 12:02 ` [PATCH v2 3/7] drm/i915/dsi: add skip functions for spi and pmic elements Jani Nikula
` (6 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 12:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Just simple breadcrumbs for now. While at it, rename the i2c skip
function.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index a537c71cdcc6..89f77a142521 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -126,6 +126,8 @@ static const u8 *mipi_exec_send_packet(struct intel_dsi *intel_dsi,
u16 len;
enum port port;
+ DRM_DEBUG_KMS("\n");
+
flags = *data++;
type = *data++;
@@ -199,6 +201,8 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
{
u32 delay = *((const u32 *) data);
+ DRM_DEBUG_KMS("\n");
+
usleep_range(delay, delay + 10);
data += 4;
@@ -307,6 +311,8 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
u8 gpio_source, gpio_index;
bool value;
+ DRM_DEBUG_KMS("\n");
+
if (dev_priv->vbt.dsi.seq_version >= 3)
data++;
@@ -331,8 +337,10 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
return data;
}
-static const u8 *mipi_exec_i2c_skip(struct intel_dsi *intel_dsi, const u8 *data)
+static const u8 *mipi_exec_i2c(struct intel_dsi *intel_dsi, const u8 *data)
{
+ DRM_DEBUG_KMS("Skipping I2C element execution\n");
+
return data + *(data + 6) + 7;
}
@@ -342,7 +350,7 @@ static const fn_mipi_elem_exec exec_elem[] = {
[MIPI_SEQ_ELEM_SEND_PKT] = mipi_exec_send_packet,
[MIPI_SEQ_ELEM_DELAY] = mipi_exec_delay,
[MIPI_SEQ_ELEM_GPIO] = mipi_exec_gpio,
- [MIPI_SEQ_ELEM_I2C] = mipi_exec_i2c_skip,
+ [MIPI_SEQ_ELEM_I2C] = mipi_exec_i2c,
};
/*
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 3/7] drm/i915/dsi: add skip functions for spi and pmic elements
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
2016-09-19 12:02 ` [PATCH v2 1/7] drm/i915/dsi: don't debug log "missing" sequences Jani Nikula
2016-09-19 12:02 ` [PATCH v2 2/7] drm/i915/dsi: add debug logging to element execution Jani Nikula
@ 2016-09-19 12:02 ` Jani Nikula
2016-09-19 12:02 ` [PATCH v2 4/7] drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks Jani Nikula
` (5 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 12:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
In sequence block v3 these are gracefully skipped anyway, but add the
functions so we can have some debug breadcrumbs.
v2: the pmic block is 15 bytes (Ville)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 89f77a142521..29156995a265 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -344,6 +344,20 @@ static const u8 *mipi_exec_i2c(struct intel_dsi *intel_dsi, const u8 *data)
return data + *(data + 6) + 7;
}
+static const u8 *mipi_exec_spi(struct intel_dsi *intel_dsi, const u8 *data)
+{
+ DRM_DEBUG_KMS("Skipping SPI element execution\n");
+
+ return data + *(data + 5) + 6;
+}
+
+static const u8 *mipi_exec_pmic(struct intel_dsi *intel_dsi, const u8 *data)
+{
+ DRM_DEBUG_KMS("Skipping PMIC element execution\n");
+
+ return data + 15;
+}
+
typedef const u8 * (*fn_mipi_elem_exec)(struct intel_dsi *intel_dsi,
const u8 *data);
static const fn_mipi_elem_exec exec_elem[] = {
@@ -351,6 +365,8 @@ static const fn_mipi_elem_exec exec_elem[] = {
[MIPI_SEQ_ELEM_DELAY] = mipi_exec_delay,
[MIPI_SEQ_ELEM_GPIO] = mipi_exec_gpio,
[MIPI_SEQ_ELEM_I2C] = mipi_exec_i2c,
+ [MIPI_SEQ_ELEM_SPI] = mipi_exec_spi,
+ [MIPI_SEQ_ELEM_PMIC] = mipi_exec_pmic,
};
/*
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 4/7] drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
` (2 preceding siblings ...)
2016-09-19 12:02 ` [PATCH v2 3/7] drm/i915/dsi: add skip functions for spi and pmic elements Jani Nikula
@ 2016-09-19 12:02 ` Jani Nikula
2016-09-19 12:02 ` [PATCH v2 5/7] drm/i915/dsi: run backlight on/off sequences in panel enable/disable hooks Jani Nikula
` (4 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 12:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Based on the documentation alone, it's anyone's guess when exactly we
should be running these sequences. Add power on/off sequences where they
feel logical and update assert/deassert reset. The drm panel hooks don't
currently offer us more granularity anyway.
v2: update assert/deassert reset as well (Ville)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 29156995a265..2c5d14eb7851 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -459,6 +459,8 @@ static void generic_exec_sequence(struct drm_panel *panel, enum mipi_seq seq_id)
static int vbt_panel_prepare(struct drm_panel *panel)
{
generic_exec_sequence(panel, MIPI_SEQ_ASSERT_RESET);
+ generic_exec_sequence(panel, MIPI_SEQ_POWER_ON);
+ generic_exec_sequence(panel, MIPI_SEQ_DEASSERT_RESET);
generic_exec_sequence(panel, MIPI_SEQ_INIT_OTP);
return 0;
@@ -466,7 +468,8 @@ static int vbt_panel_prepare(struct drm_panel *panel)
static int vbt_panel_unprepare(struct drm_panel *panel)
{
- generic_exec_sequence(panel, MIPI_SEQ_DEASSERT_RESET);
+ generic_exec_sequence(panel, MIPI_SEQ_ASSERT_RESET);
+ generic_exec_sequence(panel, MIPI_SEQ_POWER_OFF);
return 0;
}
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 5/7] drm/i915/dsi: run backlight on/off sequences in panel enable/disable hooks
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
` (3 preceding siblings ...)
2016-09-19 12:02 ` [PATCH v2 4/7] drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks Jani Nikula
@ 2016-09-19 12:02 ` Jani Nikula
2016-09-19 12:02 ` [PATCH v2 6/7] drm/i915/bios: log about presence of DSI sequences we do not run Jani Nikula
` (3 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 12:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Based on the documentation alone, it's anyone's guess when exactly we
should be running these sequences. Add them where it feels logical. The
drm panel hooks don't currently offer us more granularity anyway.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 2c5d14eb7851..24953f9f7e1d 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -477,12 +477,14 @@ static int vbt_panel_unprepare(struct drm_panel *panel)
static int vbt_panel_enable(struct drm_panel *panel)
{
generic_exec_sequence(panel, MIPI_SEQ_DISPLAY_ON);
+ generic_exec_sequence(panel, MIPI_SEQ_BACKLIGHT_ON);
return 0;
}
static int vbt_panel_disable(struct drm_panel *panel)
{
+ generic_exec_sequence(panel, MIPI_SEQ_BACKLIGHT_OFF);
generic_exec_sequence(panel, MIPI_SEQ_DISPLAY_OFF);
return 0;
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 6/7] drm/i915/bios: log about presence of DSI sequences we do not run
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
` (4 preceding siblings ...)
2016-09-19 12:02 ` [PATCH v2 5/7] drm/i915/dsi: run backlight on/off sequences in panel enable/disable hooks Jani Nikula
@ 2016-09-19 12:02 ` Jani Nikula
2016-09-19 12:02 ` [PATCH v2 7/7] drm/i915/dsi: double check element parsing against size if present Jani Nikula
` (2 subsequent siblings)
8 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 12:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Leave behind some debugging clues in case some panels don't work
properly.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_bios.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index c6e69e4cfa83..83667e8cdd6b 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -996,6 +996,10 @@ parse_mipi_sequence(struct drm_i915_private *dev_priv,
goto err;
}
+ /* Log about presence of sequences we won't run. */
+ if (seq_id == MIPI_SEQ_TEAR_ON || seq_id == MIPI_SEQ_TEAR_OFF)
+ DRM_DEBUG_KMS("Unsupported sequence %u\n", seq_id);
+
dev_priv->vbt.dsi.sequence[seq_id] = data + index;
if (sequence->version >= 3)
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 7/7] drm/i915/dsi: double check element parsing against size if present
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
` (5 preceding siblings ...)
2016-09-19 12:02 ` [PATCH v2 6/7] drm/i915/bios: log about presence of DSI sequences we do not run Jani Nikula
@ 2016-09-19 12:02 ` Jani Nikula
2016-09-19 12:55 ` ✗ Fi.CI.BAT: warning for drm/i915: clean up dsi sequences Patchwork
2016-09-19 13:55 ` [PATCH v2 0/7] " Ville Syrjälä
8 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 12:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Be a little paranoid in case the specs change or something.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
index 24953f9f7e1d..9f279a3d0f74 100644
--- a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
+++ b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c
@@ -441,7 +441,15 @@ static void generic_exec_sequence(struct drm_panel *panel, enum mipi_seq seq_id)
operation_size = *data++;
if (mipi_elem_exec) {
+ const u8 *next = data + operation_size;
+
data = mipi_elem_exec(intel_dsi, data);
+
+ /* Consistency check if we have size. */
+ if (operation_size && data != next) {
+ DRM_ERROR("Inconsistent operation size\n");
+ return;
+ }
} else if (operation_size) {
/* We have size, skip. */
DRM_DEBUG_KMS("Unsupported MIPI operation byte %u\n",
--
2.1.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread* ✗ Fi.CI.BAT: warning for drm/i915: clean up dsi sequences
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
` (6 preceding siblings ...)
2016-09-19 12:02 ` [PATCH v2 7/7] drm/i915/dsi: double check element parsing against size if present Jani Nikula
@ 2016-09-19 12:55 ` Patchwork
2016-09-19 13:55 ` [PATCH v2 0/7] " Ville Syrjälä
8 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2016-09-19 12:55 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: clean up dsi sequences
URL : https://patchwork.freedesktop.org/series/12640/
State : warning
== Summary ==
Series 12640v1 drm/i915: clean up dsi sequences
https://patchwork.freedesktop.org/api/1.0/series/12640/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-a:
dmesg-warn -> PASS (fi-skl-6700k)
Subgroup nonblocking-crc-pipe-b-frame-sequence:
pass -> SKIP (fi-hsw-4770r)
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42
fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35
fi-hsw-4770k total:244 pass:226 dwarn:0 dfail:0 fail:0 skip:18
fi-hsw-4770r total:244 pass:221 dwarn:0 dfail:0 fail:0 skip:23
fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25
fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:244 pass:221 dwarn:0 dfail:0 fail:1 skip:22
fi-skl-6700k total:244 pass:219 dwarn:1 dfail:0 fail:0 skip:24
fi-skl-6770hq total:244 pass:228 dwarn:1 dfail:0 fail:1 skip:14
fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36
fi-snb-2600 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2554/
0d6fa72a8c18ec6ab4dbabf5202b8d1cad840e04 drm-intel-nightly: 2016y-09m-19d-09h-28m-11s UTC integration manifest
13c9cdf drm/i915/dsi: double check element parsing against size if present
57a905b drm/i915/bios: log about presence of DSI sequences we do not run
c979437 drm/i915/dsi: run backlight on/off sequences in panel enable/disable hooks
248085c drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks
c34bc49 drm/i915/dsi: add skip functions for spi and pmic elements
c82ca7c2 drm/i915/dsi: add debug logging to element execution
b23a5c0 drm/i915/dsi: don't debug log "missing" sequences
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/7] drm/i915: clean up dsi sequences
2016-09-19 12:02 [PATCH v2 0/7] drm/i915: clean up dsi sequences Jani Nikula
` (7 preceding siblings ...)
2016-09-19 12:55 ` ✗ Fi.CI.BAT: warning for drm/i915: clean up dsi sequences Patchwork
@ 2016-09-19 13:55 ` Ville Syrjälä
2016-09-19 15:39 ` Jani Nikula
8 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2016-09-19 13:55 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Mon, Sep 19, 2016 at 03:02:23PM +0300, Jani Nikula wrote:
> v2 of an old series, addressing issues pointed out by Ville.
Entire series looks reasonable. Spec is vague, so hard to be 100% sure.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> BR,
> Jani.
>
> Jani Nikula (7):
> drm/i915/dsi: don't debug log "missing" sequences
> drm/i915/dsi: add debug logging to element execution
> drm/i915/dsi: add skip functions for spi and pmic elements
> drm/i915/dsi: update reset and power sequences in panel
> prepare/unprepare hooks
> drm/i915/dsi: run backlight on/off sequences in panel enable/disable
> hooks
> drm/i915/bios: log about presence of DSI sequences we do not run
> drm/i915/dsi: double check element parsing against size if present
>
> drivers/gpu/drm/i915/intel_bios.c | 4 +++
> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 48 +++++++++++++++++++++++++-----
> 2 files changed, 45 insertions(+), 7 deletions(-)
>
> --
> 2.1.4
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/7] drm/i915: clean up dsi sequences
2016-09-19 13:55 ` [PATCH v2 0/7] " Ville Syrjälä
@ 2016-09-19 15:39 ` Jani Nikula
0 siblings, 0 replies; 11+ messages in thread
From: Jani Nikula @ 2016-09-19 15:39 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Mon, 19 Sep 2016, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Sep 19, 2016 at 03:02:23PM +0300, Jani Nikula wrote:
>> v2 of an old series, addressing issues pointed out by Ville.
>
> Entire series looks reasonable. Spec is vague, so hard to be 100% sure.
We're about to find out, I pushed the lot. Thanks for the review.
BR,
Jani.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
>>
>> BR,
>> Jani.
>>
>> Jani Nikula (7):
>> drm/i915/dsi: don't debug log "missing" sequences
>> drm/i915/dsi: add debug logging to element execution
>> drm/i915/dsi: add skip functions for spi and pmic elements
>> drm/i915/dsi: update reset and power sequences in panel
>> prepare/unprepare hooks
>> drm/i915/dsi: run backlight on/off sequences in panel enable/disable
>> hooks
>> drm/i915/bios: log about presence of DSI sequences we do not run
>> drm/i915/dsi: double check element parsing against size if present
>>
>> drivers/gpu/drm/i915/intel_bios.c | 4 +++
>> drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 48 +++++++++++++++++++++++++-----
>> 2 files changed, 45 insertions(+), 7 deletions(-)
>>
>> --
>> 2.1.4
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread