* [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-06 9:47 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: mchehab, p.zabel
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, hkallweit1,
lee.jones, lgirdwood, broonie, davem, netdev, linux-kernel,
dri-devel, linux-arm-kernel, linux-fbdev, linux-media,
Anders Roxell
When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
loadable modules, we see the following warning:
warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.ko
Rework so media coda matches the config fragment. Leaving CODA_FS as is
since thats a well known module.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/media/platform/coda/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
index 54e9a73a92ab..588e6bf7c190 100644
--- a/drivers/media/platform/coda/Makefile
+++ b/drivers/media/platform/coda/Makefile
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
+video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
-obj-$(CONFIG_VIDEO_CODA) += coda.o
+obj-$(CONFIG_VIDEO_CODA) += video-coda.o
obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
--
2.20.1
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-06 9:47 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: mchehab, p.zabel
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, hkallweit1,
lee.jones, lgirdwood, broonie, davem, netdev, linux-kernel,
dri-devel, linux-arm-kernel, linux-fbdev, linux-media,
Anders Roxell
When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
loadable modules, we see the following warning:
warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.ko
Rework so media coda matches the config fragment. Leaving CODA_FS as is
since thats a well known module.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/media/platform/coda/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
index 54e9a73a92ab..588e6bf7c190 100644
--- a/drivers/media/platform/coda/Makefile
+++ b/drivers/media/platform/coda/Makefile
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
+video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
-obj-$(CONFIG_VIDEO_CODA) += coda.o
+obj-$(CONFIG_VIDEO_CODA) += video-coda.o
obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
--
2.20.1
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-06 9:47 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: mchehab, p.zabel
Cc: andrew, linux-fbdev, airlied, stefan, linux-kernel, a.hajda,
lee.jones, marex, f.fainelli, Anders Roxell, vivien.didelot,
linux-media, b.zolnierkie, s.hauer, broonie, dri-devel,
linux-arm-kernel, netdev, lgirdwood, daniel, shawnguo, davem,
hkallweit1
When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
loadable modules, we see the following warning:
warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.ko
Rework so media coda matches the config fragment. Leaving CODA_FS as is
since thats a well known module.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/media/platform/coda/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
index 54e9a73a92ab..588e6bf7c190 100644
--- a/drivers/media/platform/coda/Makefile
+++ b/drivers/media/platform/coda/Makefile
@@ -1,6 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
+video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
-obj-$(CONFIG_VIDEO_CODA) += coda.o
+obj-$(CONFIG_VIDEO_CODA) += video-coda.o
obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
--
2.20.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-06 9:47 ` Anders Roxell
(?)
@ 2019-06-06 10:13 ` Hans Verkuil
-1 siblings, 0 replies; 31+ messages in thread
From: Hans Verkuil @ 2019-06-06 10:13 UTC (permalink / raw)
To: Anders Roxell, mchehab, p.zabel
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, hkallweit1,
lee.jones, lgirdwood, broonie, davem, netdev, linux-kernel,
dri-devel, linux-arm-kernel, linux-fbdev, linux-media
On 6/6/19 11:47 AM, Anders Roxell wrote:
> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> loadable modules, we see the following warning:
>
> warning: same module names found:
> fs/coda/coda.ko
> drivers/media/platform/coda/coda.ko
>
> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> since thats a well known module.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/media/platform/coda/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> index 54e9a73a92ab..588e6bf7c190 100644
> --- a/drivers/media/platform/coda/Makefile
> +++ b/drivers/media/platform/coda/Makefile
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>
> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
How about imx-coda? video-coda suggests it is part of the video subsystem,
which it isn't.
Regards,
Hans
> obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-06 10:13 ` Hans Verkuil
0 siblings, 0 replies; 31+ messages in thread
From: Hans Verkuil @ 2019-06-06 10:13 UTC (permalink / raw)
To: Anders Roxell, mchehab, p.zabel
Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied,
daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, hkallweit1,
lee.jones, lgirdwood, broonie, davem, netdev, linux-kernel,
dri-devel, linux-arm-kernel, linux-fbdev, linux-media
On 6/6/19 11:47 AM, Anders Roxell wrote:
> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> loadable modules, we see the following warning:
>
> warning: same module names found:
> fs/coda/coda.ko
> drivers/media/platform/coda/coda.ko
>
> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> since thats a well known module.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/media/platform/coda/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> index 54e9a73a92ab..588e6bf7c190 100644
> --- a/drivers/media/platform/coda/Makefile
> +++ b/drivers/media/platform/coda/Makefile
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>
> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
How about imx-coda? video-coda suggests it is part of the video subsystem,
which it isn't.
Regards,
Hans
> obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-06 10:13 ` Hans Verkuil
0 siblings, 0 replies; 31+ messages in thread
From: Hans Verkuil @ 2019-06-06 10:13 UTC (permalink / raw)
To: Anders Roxell, mchehab, p.zabel
Cc: andrew, linux-fbdev, airlied, stefan, linux-kernel, a.hajda,
lee.jones, marex, f.fainelli, vivien.didelot, linux-media,
b.zolnierkie, s.hauer, broonie, dri-devel, linux-arm-kernel,
netdev, lgirdwood, daniel, shawnguo, davem, hkallweit1
On 6/6/19 11:47 AM, Anders Roxell wrote:
> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> loadable modules, we see the following warning:
>
> warning: same module names found:
> fs/coda/coda.ko
> drivers/media/platform/coda/coda.ko
>
> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> since thats a well known module.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
> drivers/media/platform/coda/Makefile | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> index 54e9a73a92ab..588e6bf7c190 100644
> --- a/drivers/media/platform/coda/Makefile
> +++ b/drivers/media/platform/coda/Makefile
> @@ -1,6 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
>
> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>
> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
How about imx-coda? video-coda suggests it is part of the video subsystem,
which it isn't.
Regards,
Hans
> obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-06 9:47 ` Anders Roxell
` (2 preceding siblings ...)
(?)
@ 2019-06-06 10:38 ` Marc Gonzalez
-1 siblings, 0 replies; 31+ messages in thread
From: Marc Gonzalez @ 2019-06-06 10:38 UTC (permalink / raw)
To: Anders Roxell; +Cc: linux-media, Mauro Carvalho Chehab, Hans Verkuil
On 06/06/2019 11:47, Anders Roxell wrote:
> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> loadable modules, we see the following warning:
>
> warning: same module names found:
> fs/coda/coda.ko
> drivers/media/platform/coda/coda.ko
>
> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> since thats a well known module.
s/thats/that's/
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-06 10:13 ` Hans Verkuil
(?)
@ 2019-06-10 13:03 ` Anders Roxell
-1 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-10 13:03 UTC (permalink / raw)
To: Hans Verkuil
Cc: Mauro Carvalho Chehab, p.zabel, andrew, vivien.didelot,
f.fainelli, marex, stefan, David Airlie, Daniel Vetter, shawnguo,
s.hauer, b.zolnierkie, a.hajda, hkallweit1, Lee Jones,
Liam Girdwood, Mark Brown, David Miller, Networking,
Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev,
linux-media
On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 6/6/19 11:47 AM, Anders Roxell wrote:
> > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > loadable modules, we see the following warning:
> >
> > warning: same module names found:
> > fs/coda/coda.ko
> > drivers/media/platform/coda/coda.ko
> >
> > Rework so media coda matches the config fragment. Leaving CODA_FS as is
> > since thats a well known module.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > drivers/media/platform/coda/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> > index 54e9a73a92ab..588e6bf7c190 100644
> > --- a/drivers/media/platform/coda/Makefile
> > +++ b/drivers/media/platform/coda/Makefile
> > @@ -1,6 +1,6 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> >
> > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >
> > -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>
> How about imx-coda? video-coda suggests it is part of the video subsystem,
> which it isn't.
I'll resend a v2 shortly with imx-coda instead.
Cheers,
Anders
>
> Regards,
>
> Hans
>
> > obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
> >
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-10 13:03 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-10 13:03 UTC (permalink / raw)
To: Hans Verkuil
Cc: Mauro Carvalho Chehab, p.zabel, andrew, vivien.didelot,
f.fainelli, marex, stefan, David Airlie, Daniel Vetter, shawnguo,
s.hauer, b.zolnierkie, a.hajda, hkallweit1, Lee Jones,
Liam Girdwood, Mark Brown, David Miller, Networking,
Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev,
linux-media
On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 6/6/19 11:47 AM, Anders Roxell wrote:
> > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > loadable modules, we see the following warning:
> >
> > warning: same module names found:
> > fs/coda/coda.ko
> > drivers/media/platform/coda/coda.ko
> >
> > Rework so media coda matches the config fragment. Leaving CODA_FS as is
> > since thats a well known module.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > drivers/media/platform/coda/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> > index 54e9a73a92ab..588e6bf7c190 100644
> > --- a/drivers/media/platform/coda/Makefile
> > +++ b/drivers/media/platform/coda/Makefile
> > @@ -1,6 +1,6 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> >
> > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >
> > -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>
> How about imx-coda? video-coda suggests it is part of the video subsystem,
> which it isn't.
I'll resend a v2 shortly with imx-coda instead.
Cheers,
Anders
>
> Regards,
>
> Hans
>
> > obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
> >
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-10 13:03 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-10 13:03 UTC (permalink / raw)
To: Hans Verkuil
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, p.zabel, b.zolnierkie, s.hauer,
Mark Brown, dri-devel, Mauro Carvalho Chehab, Linux ARM,
Networking, Liam Girdwood, Daniel Vetter, shawnguo, David Miller,
hkallweit1
On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 6/6/19 11:47 AM, Anders Roxell wrote:
> > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > loadable modules, we see the following warning:
> >
> > warning: same module names found:
> > fs/coda/coda.ko
> > drivers/media/platform/coda/coda.ko
> >
> > Rework so media coda matches the config fragment. Leaving CODA_FS as is
> > since thats a well known module.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > ---
> > drivers/media/platform/coda/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> > index 54e9a73a92ab..588e6bf7c190 100644
> > --- a/drivers/media/platform/coda/Makefile
> > +++ b/drivers/media/platform/coda/Makefile
> > @@ -1,6 +1,6 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> >
> > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >
> > -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>
> How about imx-coda? video-coda suggests it is part of the video subsystem,
> which it isn't.
I'll resend a v2 shortly with imx-coda instead.
Cheers,
Anders
>
> Regards,
>
> Hans
>
> > obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-10 13:03 ` Anders Roxell
(?)
(?)
@ 2019-06-10 13:14 ` Matt Redfearn
-1 siblings, 0 replies; 31+ messages in thread
From: Matt Redfearn @ 2019-06-10 13:14 UTC (permalink / raw)
To: Anders Roxell, Hans Verkuil
Cc: Mauro Carvalho Chehab, p.zabel, andrew, vivien.didelot,
f.fainelli, marex, stefan, David Airlie, Daniel Vetter, shawnguo,
s.hauer, b.zolnierkie, a.hajda, hkallweit1, Lee Jones,
Liam Girdwood, Mark Brown, David Miller, Networking,
Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev,
linux-media
On 10/06/2019 14:03, Anders Roxell wrote:
> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>
>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>>> loadable modules, we see the following warning:
>>>
>>> warning: same module names found:
>>> fs/coda/coda.ko
>>> drivers/media/platform/coda/coda.ko
>>>
>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>>> since thats a well known module.
>>>
>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>> ---
>>> drivers/media/platform/coda/Makefile | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>>> index 54e9a73a92ab..588e6bf7c190 100644
>>> --- a/drivers/media/platform/coda/Makefile
>>> +++ b/drivers/media/platform/coda/Makefile
>>> @@ -1,6 +1,6 @@
>>> # SPDX-License-Identifier: GPL-2.0-only
>>>
>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>
>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>>
>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>> which it isn't.
>
> I'll resend a v2 shortly with imx-coda instead.
What about other vendor SoCs implementing the Coda IP block which are
not an imx? I'd prefer a more generic name - maybe media-coda.
Thanks,
Matt
>
>
> Cheers,
> Anders
>
>>
>> Regards,
>>
>> Hans
>>
>>> obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
>>>
>>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-10 13:14 ` Matt Redfearn
0 siblings, 0 replies; 31+ messages in thread
From: Matt Redfearn @ 2019-06-10 13:14 UTC (permalink / raw)
To: Anders Roxell, Hans Verkuil
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, p.zabel, b.zolnierkie, s.hauer,
Mark Brown, dri-devel, Mauro Carvalho Chehab, Linux ARM,
Networking, Liam Girdwood
DQoNCk9uIDEwLzA2LzIwMTkgMTQ6MDMsIEFuZGVycyBSb3hlbGwgd3JvdGU6DQo+IE9uIFRodSwg
NiBKdW4gMjAxOSBhdCAxMjoxMywgSGFucyBWZXJrdWlsIDxodmVya3VpbEB4czRhbGwubmw+IHdy
b3RlOg0KPj4NCj4+IE9uIDYvNi8xOSAxMTo0NyBBTSwgQW5kZXJzIFJveGVsbCB3cm90ZToNCj4+
PiBXaGVuIGJ1aWxkaW5nIHdpdGggQ09ORklHX1ZJREVPX0NPREEgYW5kIENPTkZJR19DT0RBX0ZT
IGVuYWJsZWQgYXMNCj4+PiBsb2FkYWJsZSBtb2R1bGVzLCB3ZSBzZWUgdGhlIGZvbGxvd2luZyB3
YXJuaW5nOg0KPj4+DQo+Pj4gd2FybmluZzogc2FtZSBtb2R1bGUgbmFtZXMgZm91bmQ6DQo+Pj4g
ICAgZnMvY29kYS9jb2RhLmtvDQo+Pj4gICAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9jb2RhL2Nv
ZGEua28NCj4+Pg0KPj4+IFJld29yayBzbyBtZWRpYSBjb2RhIG1hdGNoZXMgdGhlIGNvbmZpZyBm
cmFnbWVudC4gTGVhdmluZyBDT0RBX0ZTIGFzIGlzDQo+Pj4gc2luY2UgdGhhdHMgYSB3ZWxsIGtu
b3duIG1vZHVsZS4NCj4+Pg0KPj4+IFNpZ25lZC1vZmYtYnk6IEFuZGVycyBSb3hlbGwgPGFuZGVy
cy5yb3hlbGxAbGluYXJvLm9yZz4NCj4+PiAtLS0NCj4+PiAgIGRyaXZlcnMvbWVkaWEvcGxhdGZv
cm0vY29kYS9NYWtlZmlsZSB8IDQgKystLQ0KPj4+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0
aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4+Pg0KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21l
ZGlhL3BsYXRmb3JtL2NvZGEvTWFrZWZpbGUgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL2NvZGEv
TWFrZWZpbGUNCj4+PiBpbmRleCA1NGU5YTczYTkyYWIuLjU4OGU2YmY3YzE5MCAxMDA2NDQNCj4+
PiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL2NvZGEvTWFrZWZpbGUNCj4+PiArKysgYi9k
cml2ZXJzL21lZGlhL3BsYXRmb3JtL2NvZGEvTWFrZWZpbGUNCj4+PiBAQCAtMSw2ICsxLDYgQEAN
Cj4+PiAgICMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seQ0KPj4+DQo+Pj4g
LWNvZGEtb2JqcyA6PSBjb2RhLWNvbW1vbi5vIGNvZGEtYml0Lm8gY29kYS1nZGkubyBjb2RhLWgy
NjQubyBjb2RhLW1wZWcyLm8gY29kYS1tcGVnNC5vIGNvZGEtanBlZy5vDQo+Pj4gK3ZpZGVvLWNv
ZGEtb2JqcyA6PSBjb2RhLWNvbW1vbi5vIGNvZGEtYml0Lm8gY29kYS1nZGkubyBjb2RhLWgyNjQu
byBjb2RhLW1wZWcyLm8gY29kYS1tcGVnNC5vIGNvZGEtanBlZy5vDQo+Pj4NCj4+PiAtb2JqLSQo
Q09ORklHX1ZJREVPX0NPREEpICs9IGNvZGEubw0KPj4+ICtvYmotJChDT05GSUdfVklERU9fQ09E
QSkgKz0gdmlkZW8tY29kYS5vDQo+Pg0KPj4gSG93IGFib3V0IGlteC1jb2RhPyB2aWRlby1jb2Rh
IHN1Z2dlc3RzIGl0IGlzIHBhcnQgb2YgdGhlIHZpZGVvIHN1YnN5c3RlbSwNCj4+IHdoaWNoIGl0
IGlzbid0Lg0KPiANCj4gSSdsbCByZXNlbmQgYSB2MiBzaG9ydGx5IHdpdGggaW14LWNvZGEgaW5z
dGVhZC4NCg0KV2hhdCBhYm91dCBvdGhlciB2ZW5kb3IgU29DcyBpbXBsZW1lbnRpbmcgdGhlIENv
ZGEgSVAgYmxvY2sgd2hpY2ggYXJlIA0Kbm90IGFuIGlteD8gSSdkIHByZWZlciBhIG1vcmUgZ2Vu
ZXJpYyBuYW1lIC0gbWF5YmUgbWVkaWEtY29kYS4NCg0KVGhhbmtzLA0KTWF0dA0KDQo+IA0KPiAN
Cj4gQ2hlZXJzLA0KPiBBbmRlcnMNCj4gDQo+Pg0KPj4gUmVnYXJkcywNCj4+DQo+PiAgICAgICAg
ICBIYW5zDQo+Pg0KPj4+ICAgb2JqLSQoQ09ORklHX1ZJREVPX0lNWF9WRE9BKSArPSBpbXgtdmRv
YS5vDQo+Pj4NCj4+DQo
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-10 13:14 ` Matt Redfearn
0 siblings, 0 replies; 31+ messages in thread
From: Matt Redfearn @ 2019-06-10 13:14 UTC (permalink / raw)
To: Anders Roxell, Hans Verkuil
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, p.zabel, b.zolnierkie, s.hauer,
Mark Brown, dri-devel, Mauro Carvalho Chehab, Linux ARM,
Networking, Liam Girdwood, Daniel Vetter, shawnguo, David Miller,
hkallweit1
On 10/06/2019 14:03, Anders Roxell wrote:
> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>
>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>>> loadable modules, we see the following warning:
>>>
>>> warning: same module names found:
>>> fs/coda/coda.ko
>>> drivers/media/platform/coda/coda.ko
>>>
>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>>> since thats a well known module.
>>>
>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>> ---
>>> drivers/media/platform/coda/Makefile | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>>> index 54e9a73a92ab..588e6bf7c190 100644
>>> --- a/drivers/media/platform/coda/Makefile
>>> +++ b/drivers/media/platform/coda/Makefile
>>> @@ -1,6 +1,6 @@
>>> # SPDX-License-Identifier: GPL-2.0-only
>>>
>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>
>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>>
>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>> which it isn't.
>
> I'll resend a v2 shortly with imx-coda instead.
What about other vendor SoCs implementing the Coda IP block which are
not an imx? I'd prefer a more generic name - maybe media-coda.
Thanks,
Matt
>
>
> Cheers,
> Anders
>
>>
>> Regards,
>>
>> Hans
>>
>>> obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
>>>
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-10 13:14 ` Matt Redfearn
0 siblings, 0 replies; 31+ messages in thread
From: Matt Redfearn @ 2019-06-10 13:14 UTC (permalink / raw)
To: Anders Roxell, Hans Verkuil
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, p.zabel, b.zolnierkie, s.hauer,
Mark Brown, dri-devel, Mauro Carvalho Chehab, Linux ARM,
Networking, Liam Girdwood
On 10/06/2019 14:03, Anders Roxell wrote:
> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>
>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>>> loadable modules, we see the following warning:
>>>
>>> warning: same module names found:
>>> fs/coda/coda.ko
>>> drivers/media/platform/coda/coda.ko
>>>
>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>>> since thats a well known module.
>>>
>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>> ---
>>> drivers/media/platform/coda/Makefile | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>>> index 54e9a73a92ab..588e6bf7c190 100644
>>> --- a/drivers/media/platform/coda/Makefile
>>> +++ b/drivers/media/platform/coda/Makefile
>>> @@ -1,6 +1,6 @@
>>> # SPDX-License-Identifier: GPL-2.0-only
>>>
>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>
>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>>
>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>> which it isn't.
>
> I'll resend a v2 shortly with imx-coda instead.
What about other vendor SoCs implementing the Coda IP block which are
not an imx? I'd prefer a more generic name - maybe media-coda.
Thanks,
Matt
>
>
> Cheers,
> Anders
>
>>
>> Regards,
>>
>> Hans
>>
>>> obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
>>>
>>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-10 13:14 ` Matt Redfearn
(?)
(?)
@ 2019-06-11 8:15 ` Philipp Zabel
-1 siblings, 0 replies; 31+ messages in thread
From: Philipp Zabel @ 2019-06-11 8:15 UTC (permalink / raw)
To: Matt Redfearn, Anders Roxell, Hans Verkuil
Cc: Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark Brown, David Miller, Networking, Linux Kernel Mailing List,
dri-devel, Linux ARM, linux-fbdev, linux-media
Hi,
On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>
> On 10/06/2019 14:03, Anders Roxell wrote:
> > On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > >
> > > On 6/6/19 11:47 AM, Anders Roxell wrote:
> > > > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > > > loadable modules, we see the following warning:
> > > >
> > > > warning: same module names found:
> > > > fs/coda/coda.ko
> > > > drivers/media/platform/coda/coda.ko
> > > >
> > > > Rework so media coda matches the config fragment. Leaving CODA_FS as is
> > > > since thats a well known module.
> > > >
> > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > > > ---
> > > > drivers/media/platform/coda/Makefile | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> > > > index 54e9a73a92ab..588e6bf7c190 100644
> > > > --- a/drivers/media/platform/coda/Makefile
> > > > +++ b/drivers/media/platform/coda/Makefile
> > > > @@ -1,6 +1,6 @@
> > > > # SPDX-License-Identifier: GPL-2.0-only
> > > >
> > > > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > >
> > > > -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > > > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> > >
> > > How about imx-coda? video-coda suggests it is part of the video subsystem,
> > > which it isn't.
> >
> > I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
> What about other vendor SoCs implementing the Coda IP block which are
> not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
[1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
regards
Philipp
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 8:15 ` Philipp Zabel
0 siblings, 0 replies; 31+ messages in thread
From: Philipp Zabel @ 2019-06-11 8:15 UTC (permalink / raw)
To: Matt Redfearn, Anders Roxell, Hans Verkuil
Cc: Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark Brown, David Miller, Networking, Linux
Hi,
On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>
> On 10/06/2019 14:03, Anders Roxell wrote:
> > On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > >
> > > On 6/6/19 11:47 AM, Anders Roxell wrote:
> > > > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > > > loadable modules, we see the following warning:
> > > >
> > > > warning: same module names found:
> > > > fs/coda/coda.ko
> > > > drivers/media/platform/coda/coda.ko
> > > >
> > > > Rework so media coda matches the config fragment. Leaving CODA_FS as is
> > > > since thats a well known module.
> > > >
> > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > > > ---
> > > > drivers/media/platform/coda/Makefile | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> > > > index 54e9a73a92ab..588e6bf7c190 100644
> > > > --- a/drivers/media/platform/coda/Makefile
> > > > +++ b/drivers/media/platform/coda/Makefile
> > > > @@ -1,6 +1,6 @@
> > > > # SPDX-License-Identifier: GPL-2.0-only
> > > >
> > > > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > >
> > > > -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > > > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> > >
> > > How about imx-coda? video-coda suggests it is part of the video subsystem,
> > > which it isn't.
> >
> > I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
> What about other vendor SoCs implementing the Coda IP block which are
> not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
[1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
regards
Philipp
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 8:15 ` Philipp Zabel
0 siblings, 0 replies; 31+ messages in thread
From: Philipp Zabel @ 2019-06-11 8:15 UTC (permalink / raw)
To: Matt Redfearn, Anders Roxell, Hans Verkuil
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, b.zolnierkie, s.hauer, Mark Brown,
dri-devel, Mauro Carvalho Chehab, Linux ARM, Networking,
Liam Girdwood, Daniel Vetter, shawnguo, David Miller, hkallweit1
Hi,
On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>
> On 10/06/2019 14:03, Anders Roxell wrote:
> > On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > >
> > > On 6/6/19 11:47 AM, Anders Roxell wrote:
> > > > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > > > loadable modules, we see the following warning:
> > > >
> > > > warning: same module names found:
> > > > fs/coda/coda.ko
> > > > drivers/media/platform/coda/coda.ko
> > > >
> > > > Rework so media coda matches the config fragment. Leaving CODA_FS as is
> > > > since thats a well known module.
> > > >
> > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > > > ---
> > > > drivers/media/platform/coda/Makefile | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> > > > index 54e9a73a92ab..588e6bf7c190 100644
> > > > --- a/drivers/media/platform/coda/Makefile
> > > > +++ b/drivers/media/platform/coda/Makefile
> > > > @@ -1,6 +1,6 @@
> > > > # SPDX-License-Identifier: GPL-2.0-only
> > > >
> > > > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > >
> > > > -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > > > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> > >
> > > How about imx-coda? video-coda suggests it is part of the video subsystem,
> > > which it isn't.
> >
> > I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
> What about other vendor SoCs implementing the Coda IP block which are
> not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
[1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 8:15 ` Philipp Zabel
0 siblings, 0 replies; 31+ messages in thread
From: Philipp Zabel @ 2019-06-11 8:15 UTC (permalink / raw)
To: Matt Redfearn, Anders Roxell, Hans Verkuil
Cc: Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark Brown, David Miller, Networking, Linux
Hi,
On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>
> On 10/06/2019 14:03, Anders Roxell wrote:
> > On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > >
> > > On 6/6/19 11:47 AM, Anders Roxell wrote:
> > > > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > > > loadable modules, we see the following warning:
> > > >
> > > > warning: same module names found:
> > > > fs/coda/coda.ko
> > > > drivers/media/platform/coda/coda.ko
> > > >
> > > > Rework so media coda matches the config fragment. Leaving CODA_FS as is
> > > > since thats a well known module.
> > > >
> > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > > > ---
> > > > drivers/media/platform/coda/Makefile | 4 ++--
> > > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> > > > index 54e9a73a92ab..588e6bf7c190 100644
> > > > --- a/drivers/media/platform/coda/Makefile
> > > > +++ b/drivers/media/platform/coda/Makefile
> > > > @@ -1,6 +1,6 @@
> > > > # SPDX-License-Identifier: GPL-2.0-only
> > > >
> > > > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > > >
> > > > -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > > > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> > >
> > > How about imx-coda? video-coda suggests it is part of the video subsystem,
> > > which it isn't.
> >
> > I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
> What about other vendor SoCs implementing the Coda IP block which are
> not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
[1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
regards
Philipp
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-11 8:15 ` Philipp Zabel
(?)
(?)
@ 2019-06-11 8:21 ` Hans Verkuil
-1 siblings, 0 replies; 31+ messages in thread
From: Hans Verkuil @ 2019-06-11 8:21 UTC (permalink / raw)
To: Philipp Zabel, Matt Redfearn, Anders Roxell
Cc: Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark Brown, David Miller, Networking, Linux Kernel Mailing List,
dri-devel, Linux ARM, linux-fbdev, linux-media
On 6/11/19 10:15 AM, Philipp Zabel wrote:
> Hi,
>
> On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>>
>> On 10/06/2019 14:03, Anders Roxell wrote:
>>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>>>
>>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>>>>> loadable modules, we see the following warning:
>>>>>
>>>>> warning: same module names found:
>>>>> fs/coda/coda.ko
>>>>> drivers/media/platform/coda/coda.ko
>>>>>
>>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>>>>> since thats a well known module.
>>>>>
>>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>>>> ---
>>>>> drivers/media/platform/coda/Makefile | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>>>>> index 54e9a73a92ab..588e6bf7c190 100644
>>>>> --- a/drivers/media/platform/coda/Makefile
>>>>> +++ b/drivers/media/platform/coda/Makefile
>>>>> @@ -1,6 +1,6 @@
>>>>> # SPDX-License-Identifier: GPL-2.0-only
>>>>>
>>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>>
>>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>>>>
>>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>>>> which it isn't.
>>>
>>> I'll resend a v2 shortly with imx-coda instead.
>
> I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
>
>> What about other vendor SoCs implementing the Coda IP block which are
>> not an imx? I'd prefer a more generic name - maybe media-coda.
>
> Right, this driver can be used on other SoCs [1].
Good point.
Regards,
Hans
>
> [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>
> regards
> Philipp
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 8:21 ` Hans Verkuil
0 siblings, 0 replies; 31+ messages in thread
From: Hans Verkuil @ 2019-06-11 8:21 UTC (permalink / raw)
To: Philipp Zabel, Matt Redfearn, Anders Roxell
Cc: Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark Brown, David Miller, Networking, Linux
On 6/11/19 10:15 AM, Philipp Zabel wrote:
> Hi,
>
> On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>>
>> On 10/06/2019 14:03, Anders Roxell wrote:
>>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>>>
>>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>>>>> loadable modules, we see the following warning:
>>>>>
>>>>> warning: same module names found:
>>>>> fs/coda/coda.ko
>>>>> drivers/media/platform/coda/coda.ko
>>>>>
>>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>>>>> since thats a well known module.
>>>>>
>>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>>>> ---
>>>>> drivers/media/platform/coda/Makefile | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>>>>> index 54e9a73a92ab..588e6bf7c190 100644
>>>>> --- a/drivers/media/platform/coda/Makefile
>>>>> +++ b/drivers/media/platform/coda/Makefile
>>>>> @@ -1,6 +1,6 @@
>>>>> # SPDX-License-Identifier: GPL-2.0-only
>>>>>
>>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>>
>>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>>>>
>>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>>>> which it isn't.
>>>
>>> I'll resend a v2 shortly with imx-coda instead.
>
> I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
>
>> What about other vendor SoCs implementing the Coda IP block which are
>> not an imx? I'd prefer a more generic name - maybe media-coda.
>
> Right, this driver can be used on other SoCs [1].
Good point.
Regards,
Hans
>
> [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>
> regards
> Philipp
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 8:21 ` Hans Verkuil
0 siblings, 0 replies; 31+ messages in thread
From: Hans Verkuil @ 2019-06-11 8:21 UTC (permalink / raw)
To: Philipp Zabel, Matt Redfearn, Anders Roxell
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, b.zolnierkie, s.hauer, Mark Brown,
dri-devel, Mauro Carvalho Chehab, Linux ARM, Networking,
Liam Girdwood, Daniel Vetter, shawnguo, David Miller, hkallweit1
On 6/11/19 10:15 AM, Philipp Zabel wrote:
> Hi,
>
> On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>>
>> On 10/06/2019 14:03, Anders Roxell wrote:
>>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>>>
>>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>>>>> loadable modules, we see the following warning:
>>>>>
>>>>> warning: same module names found:
>>>>> fs/coda/coda.ko
>>>>> drivers/media/platform/coda/coda.ko
>>>>>
>>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>>>>> since thats a well known module.
>>>>>
>>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>>>> ---
>>>>> drivers/media/platform/coda/Makefile | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>>>>> index 54e9a73a92ab..588e6bf7c190 100644
>>>>> --- a/drivers/media/platform/coda/Makefile
>>>>> +++ b/drivers/media/platform/coda/Makefile
>>>>> @@ -1,6 +1,6 @@
>>>>> # SPDX-License-Identifier: GPL-2.0-only
>>>>>
>>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>>
>>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>>>>
>>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>>>> which it isn't.
>>>
>>> I'll resend a v2 shortly with imx-coda instead.
>
> I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
>
>> What about other vendor SoCs implementing the Coda IP block which are
>> not an imx? I'd prefer a more generic name - maybe media-coda.
>
> Right, this driver can be used on other SoCs [1].
Good point.
Regards,
Hans
>
> [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>
> regards
> Philipp
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 8:21 ` Hans Verkuil
0 siblings, 0 replies; 31+ messages in thread
From: Hans Verkuil @ 2019-06-11 8:21 UTC (permalink / raw)
To: Philipp Zabel, Matt Redfearn, Anders Roxell
Cc: Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark Brown, David Miller, Networking, Linux
On 6/11/19 10:15 AM, Philipp Zabel wrote:
> Hi,
>
> On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>>
>> On 10/06/2019 14:03, Anders Roxell wrote:
>>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>>>>
>>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>>>>> loadable modules, we see the following warning:
>>>>>
>>>>> warning: same module names found:
>>>>> fs/coda/coda.ko
>>>>> drivers/media/platform/coda/coda.ko
>>>>>
>>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>>>>> since thats a well known module.
>>>>>
>>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>>>>> ---
>>>>> drivers/media/platform/coda/Makefile | 4 ++--
>>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>>>>> index 54e9a73a92ab..588e6bf7c190 100644
>>>>> --- a/drivers/media/platform/coda/Makefile
>>>>> +++ b/drivers/media/platform/coda/Makefile
>>>>> @@ -1,6 +1,6 @@
>>>>> # SPDX-License-Identifier: GPL-2.0-only
>>>>>
>>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>>>>>
>>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>>>>
>>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>>>> which it isn't.
>>>
>>> I'll resend a v2 shortly with imx-coda instead.
>
> I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
>
>> What about other vendor SoCs implementing the Coda IP block which are
>> not an imx? I'd prefer a more generic name - maybe media-coda.
>
> Right, this driver can be used on other SoCs [1].
Good point.
Regards,
Hans
>
> [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>
> regards
> Philipp
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-11 8:21 ` Hans Verkuil
(?)
(?)
@ 2019-06-11 16:01 ` Anders Roxell
-1 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:01 UTC (permalink / raw)
To: Hans Verkuil
Cc: Philipp Zabel, Matt Redfearn, Mauro Carvalho Chehab, andrew,
vivien.didelot, f.fainelli, marex, stefan, David Airlie,
Daniel Vetter, shawnguo, s.hauer, b.zolnierkie, a.hajda,
hkallweit1, Lee Jones, Liam Girdwood, Mark Brown, David Miller,
Networking, Linux Kernel Mailing List, dri-devel, Linux ARM,
linux-fbdev, linux-media
On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 6/11/19 10:15 AM, Philipp Zabel wrote:
> > Hi,
> >
> > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
> >>
> >> On 10/06/2019 14:03, Anders Roxell wrote:
> >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >>>>
> >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
> >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> >>>>> loadable modules, we see the following warning:
> >>>>>
> >>>>> warning: same module names found:
> >>>>> fs/coda/coda.ko
> >>>>> drivers/media/platform/coda/coda.ko
> >>>>>
> >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> >>>>> since thats a well known module.
> >>>>>
> >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >>>>> ---
> >>>>> drivers/media/platform/coda/Makefile | 4 ++--
> >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> >>>>> index 54e9a73a92ab..588e6bf7c190 100644
> >>>>> --- a/drivers/media/platform/coda/Makefile
> >>>>> +++ b/drivers/media/platform/coda/Makefile
> >>>>> @@ -1,6 +1,6 @@
> >>>>> # SPDX-License-Identifier: GPL-2.0-only
> >>>>>
> >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>>
> >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> >>>>
> >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
> >>>> which it isn't.
> >>>
> >>> I'll resend a v2 shortly with imx-coda instead.
> >
> > I'd be in favor of calling it "coda-vpu" instead.
>
> Fine by me!
>
> >
> >> What about other vendor SoCs implementing the Coda IP block which are
> >> not an imx? I'd prefer a more generic name - maybe media-coda.
> >
> > Right, this driver can be used on other SoCs [1].
>
> Good point.
OK, so I'll change it to 'media-coda'.
Cheers,
Anders
>
> Regards,
>
> Hans
>
> >
> > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
> >
> > regards
> > Philipp
> >
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 16:01 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:01 UTC (permalink / raw)
To: Hans Verkuil
Cc: Philipp Zabel, Matt Redfearn, Mauro Carvalho Chehab, andrew,
vivien.didelot, f.fainelli, marex, stefan, David Airlie,
Daniel Vetter, shawnguo, s.hauer, b.zolnierkie, a.hajda,
hkallweit1, Lee Jones, Liam Girdwood, Mark Brown
On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 6/11/19 10:15 AM, Philipp Zabel wrote:
> > Hi,
> >
> > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
> >>
> >> On 10/06/2019 14:03, Anders Roxell wrote:
> >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >>>>
> >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
> >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> >>>>> loadable modules, we see the following warning:
> >>>>>
> >>>>> warning: same module names found:
> >>>>> fs/coda/coda.ko
> >>>>> drivers/media/platform/coda/coda.ko
> >>>>>
> >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> >>>>> since thats a well known module.
> >>>>>
> >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >>>>> ---
> >>>>> drivers/media/platform/coda/Makefile | 4 ++--
> >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> >>>>> index 54e9a73a92ab..588e6bf7c190 100644
> >>>>> --- a/drivers/media/platform/coda/Makefile
> >>>>> +++ b/drivers/media/platform/coda/Makefile
> >>>>> @@ -1,6 +1,6 @@
> >>>>> # SPDX-License-Identifier: GPL-2.0-only
> >>>>>
> >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>>
> >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> >>>>
> >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
> >>>> which it isn't.
> >>>
> >>> I'll resend a v2 shortly with imx-coda instead.
> >
> > I'd be in favor of calling it "coda-vpu" instead.
>
> Fine by me!
>
> >
> >> What about other vendor SoCs implementing the Coda IP block which are
> >> not an imx? I'd prefer a more generic name - maybe media-coda.
> >
> > Right, this driver can be used on other SoCs [1].
>
> Good point.
OK, so I'll change it to 'media-coda'.
Cheers,
Anders
>
> Regards,
>
> Hans
>
> >
> > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
> >
> > regards
> > Philipp
> >
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 16:01 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:01 UTC (permalink / raw)
To: Hans Verkuil
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, a.hajda, Lee Jones, marex, f.fainelli,
vivien.didelot, linux-media, Philipp Zabel, b.zolnierkie,
s.hauer, Mark Brown, dri-devel, Mauro Carvalho Chehab, Linux ARM,
Networking, Liam Girdwood, Matt Redfearn, Daniel Vetter,
shawnguo, David Miller, hkallweit1
On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 6/11/19 10:15 AM, Philipp Zabel wrote:
> > Hi,
> >
> > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
> >>
> >> On 10/06/2019 14:03, Anders Roxell wrote:
> >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >>>>
> >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
> >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> >>>>> loadable modules, we see the following warning:
> >>>>>
> >>>>> warning: same module names found:
> >>>>> fs/coda/coda.ko
> >>>>> drivers/media/platform/coda/coda.ko
> >>>>>
> >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> >>>>> since thats a well known module.
> >>>>>
> >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >>>>> ---
> >>>>> drivers/media/platform/coda/Makefile | 4 ++--
> >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> >>>>> index 54e9a73a92ab..588e6bf7c190 100644
> >>>>> --- a/drivers/media/platform/coda/Makefile
> >>>>> +++ b/drivers/media/platform/coda/Makefile
> >>>>> @@ -1,6 +1,6 @@
> >>>>> # SPDX-License-Identifier: GPL-2.0-only
> >>>>>
> >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>>
> >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> >>>>
> >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
> >>>> which it isn't.
> >>>
> >>> I'll resend a v2 shortly with imx-coda instead.
> >
> > I'd be in favor of calling it "coda-vpu" instead.
>
> Fine by me!
>
> >
> >> What about other vendor SoCs implementing the Coda IP block which are
> >> not an imx? I'd prefer a more generic name - maybe media-coda.
> >
> > Right, this driver can be used on other SoCs [1].
>
> Good point.
OK, so I'll change it to 'media-coda'.
Cheers,
Anders
>
> Regards,
>
> Hans
>
> >
> > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
> >
> > regards
> > Philipp
> >
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 16:01 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:01 UTC (permalink / raw)
To: Hans Verkuil
Cc: Philipp Zabel, Matt Redfearn, Mauro Carvalho Chehab, andrew,
vivien.didelot, f.fainelli, marex, stefan, David Airlie,
Daniel Vetter, shawnguo, s.hauer, b.zolnierkie, a.hajda,
hkallweit1, Lee Jones, Liam Girdwood, Mark Brown
On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>
> On 6/11/19 10:15 AM, Philipp Zabel wrote:
> > Hi,
> >
> > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
> >>
> >> On 10/06/2019 14:03, Anders Roxell wrote:
> >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >>>>
> >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
> >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> >>>>> loadable modules, we see the following warning:
> >>>>>
> >>>>> warning: same module names found:
> >>>>> fs/coda/coda.ko
> >>>>> drivers/media/platform/coda/coda.ko
> >>>>>
> >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
> >>>>> since thats a well known module.
> >>>>>
> >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >>>>> ---
> >>>>> drivers/media/platform/coda/Makefile | 4 ++--
> >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
> >>>>> index 54e9a73a92ab..588e6bf7c190 100644
> >>>>> --- a/drivers/media/platform/coda/Makefile
> >>>>> +++ b/drivers/media/platform/coda/Makefile
> >>>>> @@ -1,6 +1,6 @@
> >>>>> # SPDX-License-Identifier: GPL-2.0-only
> >>>>>
> >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> >>>>>
> >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> >>>>
> >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
> >>>> which it isn't.
> >>>
> >>> I'll resend a v2 shortly with imx-coda instead.
> >
> > I'd be in favor of calling it "coda-vpu" instead.
>
> Fine by me!
>
> >
> >> What about other vendor SoCs implementing the Coda IP block which are
> >> not an imx? I'd prefer a more generic name - maybe media-coda.
> >
> > Right, this driver can be used on other SoCs [1].
>
> Good point.
OK, so I'll change it to 'media-coda'.
Cheers,
Anders
>
> Regards,
>
> Hans
>
> >
> > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
> >
> > regards
> > Philipp
> >
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-11 16:01 ` Anders Roxell
` (2 preceding siblings ...)
(?)
@ 2019-06-11 16:18 ` Ezequiel Garcia
2019-06-11 16:28 ` Anders Roxell
-1 siblings, 1 reply; 31+ messages in thread
From: Ezequiel Garcia @ 2019-06-11 16:18 UTC (permalink / raw)
To: Anders Roxell
Cc: andrew, linux-fbdev, David Airlie, Linux Kernel Mailing List,
Hans Verkuil, Lee Jones, marex, f.fainelli, vivien.didelot,
linux-media, b.zolnierkie, Mark Brown, dri-devel,
Mauro Carvalho Chehab, Linux ARM, Networking, Liam Girdwood,
Matt Redfearn, shawnguo, David Miller, hka
[-- Attachment #1.1: Type: text/plain, Size: 2618 bytes --]
On Tue, Jun 11, 2019, 1:01 PM Anders Roxell <anders.roxell@linaro.org>
wrote:
> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >
> > On 6/11/19 10:15 AM, Philipp Zabel wrote:
> > > Hi,
> > >
> > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
> > >>
> > >> On 10/06/2019 14:03, Anders Roxell wrote:
> > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl>
> wrote:
> > >>>>
> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
> > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > >>>>> loadable modules, we see the following warning:
> > >>>>>
> > >>>>> warning: same module names found:
> > >>>>> fs/coda/coda.ko
> > >>>>> drivers/media/platform/coda/coda.ko
> > >>>>>
> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS
> as is
> > >>>>> since thats a well known module.
> > >>>>>
> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > >>>>> ---
> > >>>>> drivers/media/platform/coda/Makefile | 4 ++--
> > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
> > >>>>>
> > >>>>> diff --git a/drivers/media/platform/coda/Makefile
> b/drivers/media/platform/coda/Makefile
> > >>>>> index 54e9a73a92ab..588e6bf7c190 100644
> > >>>>> --- a/drivers/media/platform/coda/Makefile
> > >>>>> +++ b/drivers/media/platform/coda/Makefile
> > >>>>> @@ -1,6 +1,6 @@
> > >>>>> # SPDX-License-Identifier: GPL-2.0-only
> > >>>>>
> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o
> coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o
> coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > >>>>>
> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> > >>>>
> > >>>> How about imx-coda? video-coda suggests it is part of the video
> subsystem,
> > >>>> which it isn't.
> > >>>
> > >>> I'll resend a v2 shortly with imx-coda instead.
> > >
> > > I'd be in favor of calling it "coda-vpu" instead.
> >
> > Fine by me!
> >
> > >
> > >> What about other vendor SoCs implementing the Coda IP block which are
> > >> not an imx? I'd prefer a more generic name - maybe media-coda.
> > >
> > > Right, this driver can be used on other SoCs [1].
> >
> > Good point.
>
> OK, so I'll change it to 'media-coda'.
>
>
>
>
As suggested by Philipp, coda-vpu seems the most accurate name.
Thanks,
Ezequiel
Cheers,
> Anders
>
> >
> > Regards,
> >
> > Hans
> >
> > >
> > > [1]
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
> > >
> > > regards
> > > Philipp
> > >
> >
>
[-- Attachment #1.2: Type: text/html, Size: 4725 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
2019-06-11 16:18 ` Ezequiel Garcia
2019-06-11 16:28 ` Anders Roxell
(?)
@ 2019-06-11 16:28 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:28 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Hans Verkuil, Philipp Zabel, Matt Redfearn,
Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark Brown, David Miller, Networking, Linux Kernel Mailing List,
dri-devel, Linux ARM, linux-fbdev, linux-media
On Tue, 11 Jun 2019 at 18:18, Ezequiel Garcia
<ezequiel@vanguardiasur.com.ar> wrote:
>
>
>
> On Tue, Jun 11, 2019, 1:01 PM Anders Roxell <anders.roxell@linaro.org> wrote:
>>
>> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> >
>> > On 6/11/19 10:15 AM, Philipp Zabel wrote:
>> > > Hi,
>> > >
>> > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>> > >>
>> > >> On 10/06/2019 14:03, Anders Roxell wrote:
>> > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> > >>>>
>> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>> > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>> > >>>>> loadable modules, we see the following warning:
>> > >>>>>
>> > >>>>> warning: same module names found:
>> > >>>>> fs/coda/coda.ko
>> > >>>>> drivers/media/platform/coda/coda.ko
>> > >>>>>
>> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>> > >>>>> since thats a well known module.
>> > >>>>>
>> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> > >>>>> ---
>> > >>>>> drivers/media/platform/coda/Makefile | 4 ++--
>> > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> > >>>>>
>> > >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>> > >>>>> index 54e9a73a92ab..588e6bf7c190 100644
>> > >>>>> --- a/drivers/media/platform/coda/Makefile
>> > >>>>> +++ b/drivers/media/platform/coda/Makefile
>> > >>>>> @@ -1,6 +1,6 @@
>> > >>>>> # SPDX-License-Identifier: GPL-2.0-only
>> > >>>>>
>> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>>
>> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>> > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>> > >>>>
>> > >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>> > >>>> which it isn't.
>> > >>>
>> > >>> I'll resend a v2 shortly with imx-coda instead.
>> > >
>> > > I'd be in favor of calling it "coda-vpu" instead.
>> >
>> > Fine by me!
>> >
>> > >
>> > >> What about other vendor SoCs implementing the Coda IP block which are
>> > >> not an imx? I'd prefer a more generic name - maybe media-coda.
>> > >
>> > > Right, this driver can be used on other SoCs [1].
>> >
>> > Good point.
>>
>> OK, so I'll change it to 'media-coda'.
>>
>>
>>
>
> As suggested by Philipp, coda-vpu seems the most accurate name.
urgh, that correct.
Thanks,
Anders
>
> Thanks,
> Ezequiel
>
>
>
>> Cheers,
>> Anders
>>
>> >
>> > Regards,
>> >
>> > Hans
>> >
>> > >
>> > > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>> > >
>> > > regards
>> > > Philipp
>> > >
>> >
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 16:28 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:28 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Hans Verkuil, Philipp Zabel, Matt Redfearn,
Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark
On Tue, 11 Jun 2019 at 18:18, Ezequiel Garcia
<ezequiel@vanguardiasur.com.ar> wrote:
>
>
>
> On Tue, Jun 11, 2019, 1:01 PM Anders Roxell <anders.roxell@linaro.org> wrote:
>>
>> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> >
>> > On 6/11/19 10:15 AM, Philipp Zabel wrote:
>> > > Hi,
>> > >
>> > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>> > >>
>> > >> On 10/06/2019 14:03, Anders Roxell wrote:
>> > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> > >>>>
>> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>> > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>> > >>>>> loadable modules, we see the following warning:
>> > >>>>>
>> > >>>>> warning: same module names found:
>> > >>>>> fs/coda/coda.ko
>> > >>>>> drivers/media/platform/coda/coda.ko
>> > >>>>>
>> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>> > >>>>> since thats a well known module.
>> > >>>>>
>> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> > >>>>> ---
>> > >>>>> drivers/media/platform/coda/Makefile | 4 ++--
>> > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> > >>>>>
>> > >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>> > >>>>> index 54e9a73a92ab..588e6bf7c190 100644
>> > >>>>> --- a/drivers/media/platform/coda/Makefile
>> > >>>>> +++ b/drivers/media/platform/coda/Makefile
>> > >>>>> @@ -1,6 +1,6 @@
>> > >>>>> # SPDX-License-Identifier: GPL-2.0-only
>> > >>>>>
>> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>>
>> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>> > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>> > >>>>
>> > >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>> > >>>> which it isn't.
>> > >>>
>> > >>> I'll resend a v2 shortly with imx-coda instead.
>> > >
>> > > I'd be in favor of calling it "coda-vpu" instead.
>> >
>> > Fine by me!
>> >
>> > >
>> > >> What about other vendor SoCs implementing the Coda IP block which are
>> > >> not an imx? I'd prefer a more generic name - maybe media-coda.
>> > >
>> > > Right, this driver can be used on other SoCs [1].
>> >
>> > Good point.
>>
>> OK, so I'll change it to 'media-coda'.
>>
>>
>>
>
> As suggested by Philipp, coda-vpu seems the most accurate name.
urgh, that correct.
Thanks,
Anders
>
> Thanks,
> Ezequiel
>
>
>
>> Cheers,
>> Anders
>>
>> >
>> > Regards,
>> >
>> > Hans
>> >
>> > >
>> > > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>> > >
>> > > regards
>> > > Philipp
>> > >
>> >
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 16:28 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:28 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: andrew, linux-fbdev, David Airlie, stefan,
Linux Kernel Mailing List, Hans Verkuil, a.hajda, Lee Jones,
marex, f.fainelli, vivien.didelot, linux-media, Philipp Zabel,
b.zolnierkie, s.hauer, Mark Brown, dri-devel,
Mauro Carvalho Chehab, Linux ARM, Networking, Liam Girdwood,
Matt Redfearn, Daniel Vetter, shawnguo, David Miller, hkallweit1
On Tue, 11 Jun 2019 at 18:18, Ezequiel Garcia
<ezequiel@vanguardiasur.com.ar> wrote:
>
>
>
> On Tue, Jun 11, 2019, 1:01 PM Anders Roxell <anders.roxell@linaro.org> wrote:
>>
>> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> >
>> > On 6/11/19 10:15 AM, Philipp Zabel wrote:
>> > > Hi,
>> > >
>> > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>> > >>
>> > >> On 10/06/2019 14:03, Anders Roxell wrote:
>> > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> > >>>>
>> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>> > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>> > >>>>> loadable modules, we see the following warning:
>> > >>>>>
>> > >>>>> warning: same module names found:
>> > >>>>> fs/coda/coda.ko
>> > >>>>> drivers/media/platform/coda/coda.ko
>> > >>>>>
>> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>> > >>>>> since thats a well known module.
>> > >>>>>
>> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> > >>>>> ---
>> > >>>>> drivers/media/platform/coda/Makefile | 4 ++--
>> > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> > >>>>>
>> > >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>> > >>>>> index 54e9a73a92ab..588e6bf7c190 100644
>> > >>>>> --- a/drivers/media/platform/coda/Makefile
>> > >>>>> +++ b/drivers/media/platform/coda/Makefile
>> > >>>>> @@ -1,6 +1,6 @@
>> > >>>>> # SPDX-License-Identifier: GPL-2.0-only
>> > >>>>>
>> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>>
>> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>> > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>> > >>>>
>> > >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>> > >>>> which it isn't.
>> > >>>
>> > >>> I'll resend a v2 shortly with imx-coda instead.
>> > >
>> > > I'd be in favor of calling it "coda-vpu" instead.
>> >
>> > Fine by me!
>> >
>> > >
>> > >> What about other vendor SoCs implementing the Coda IP block which are
>> > >> not an imx? I'd prefer a more generic name - maybe media-coda.
>> > >
>> > > Right, this driver can be used on other SoCs [1].
>> >
>> > Good point.
>>
>> OK, so I'll change it to 'media-coda'.
>>
>>
>>
>
> As suggested by Philipp, coda-vpu seems the most accurate name.
urgh, that correct.
Thanks,
Anders
>
> Thanks,
> Ezequiel
>
>
>
>> Cheers,
>> Anders
>>
>> >
>> > Regards,
>> >
>> > Hans
>> >
>> > >
>> > > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>> > >
>> > > regards
>> > > Philipp
>> > >
>> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
@ 2019-06-11 16:28 ` Anders Roxell
0 siblings, 0 replies; 31+ messages in thread
From: Anders Roxell @ 2019-06-11 16:28 UTC (permalink / raw)
To: Ezequiel Garcia
Cc: Hans Verkuil, Philipp Zabel, Matt Redfearn,
Mauro Carvalho Chehab, andrew, vivien.didelot, f.fainelli, marex,
stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer,
b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood,
Mark
On Tue, 11 Jun 2019 at 18:18, Ezequiel Garcia
<ezequiel@vanguardiasur.com.ar> wrote:
>
>
>
> On Tue, Jun 11, 2019, 1:01 PM Anders Roxell <anders.roxell@linaro.org> wrote:
>>
>> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> >
>> > On 6/11/19 10:15 AM, Philipp Zabel wrote:
>> > > Hi,
>> > >
>> > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
>> > >>
>> > >> On 10/06/2019 14:03, Anders Roxell wrote:
>> > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote:
>> > >>>>
>> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
>> > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
>> > >>>>> loadable modules, we see the following warning:
>> > >>>>>
>> > >>>>> warning: same module names found:
>> > >>>>> fs/coda/coda.ko
>> > >>>>> drivers/media/platform/coda/coda.ko
>> > >>>>>
>> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is
>> > >>>>> since thats a well known module.
>> > >>>>>
>> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>> > >>>>> ---
>> > >>>>> drivers/media/platform/coda/Makefile | 4 ++--
>> > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> > >>>>>
>> > >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile
>> > >>>>> index 54e9a73a92ab..588e6bf7c190 100644
>> > >>>>> --- a/drivers/media/platform/coda/Makefile
>> > >>>>> +++ b/drivers/media/platform/coda/Makefile
>> > >>>>> @@ -1,6 +1,6 @@
>> > >>>>> # SPDX-License-Identifier: GPL-2.0-only
>> > >>>>>
>> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
>> > >>>>>
>> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
>> > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
>> > >>>>
>> > >>>> How about imx-coda? video-coda suggests it is part of the video subsystem,
>> > >>>> which it isn't.
>> > >>>
>> > >>> I'll resend a v2 shortly with imx-coda instead.
>> > >
>> > > I'd be in favor of calling it "coda-vpu" instead.
>> >
>> > Fine by me!
>> >
>> > >
>> > >> What about other vendor SoCs implementing the Coda IP block which are
>> > >> not an imx? I'd prefer a more generic name - maybe media-coda.
>> > >
>> > > Right, this driver can be used on other SoCs [1].
>> >
>> > Good point.
>>
>> OK, so I'll change it to 'media-coda'.
>>
>>
>>
>
> As suggested by Philipp, coda-vpu seems the most accurate name.
urgh, that correct.
Thanks,
Anders
>
> Thanks,
> Ezequiel
>
>
>
>> Cheers,
>> Anders
>>
>> >
>> > Regards,
>> >
>> > Hans
>> >
>> > >
>> > > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
>> > >
>> > > regards
>> > > Philipp
>> > >
>> >
^ permalink raw reply [flat|nested] 31+ messages in thread
end of thread, other threads:[~2019-06-11 16:29 UTC | newest]
Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 9:47 [PATCH 5/8] drivers: media: coda: fix warning same module names Anders Roxell
2019-06-06 9:47 ` Anders Roxell
2019-06-06 9:47 ` Anders Roxell
2019-06-06 10:13 ` Hans Verkuil
2019-06-06 10:13 ` Hans Verkuil
2019-06-06 10:13 ` Hans Verkuil
2019-06-10 13:03 ` Anders Roxell
2019-06-10 13:03 ` Anders Roxell
2019-06-10 13:03 ` Anders Roxell
2019-06-10 13:14 ` Matt Redfearn
2019-06-10 13:14 ` Matt Redfearn
2019-06-10 13:14 ` Matt Redfearn
2019-06-10 13:14 ` Matt Redfearn
2019-06-11 8:15 ` Philipp Zabel
2019-06-11 8:15 ` Philipp Zabel
2019-06-11 8:15 ` Philipp Zabel
2019-06-11 8:15 ` Philipp Zabel
2019-06-11 8:21 ` Hans Verkuil
2019-06-11 8:21 ` Hans Verkuil
2019-06-11 8:21 ` Hans Verkuil
2019-06-11 8:21 ` Hans Verkuil
2019-06-11 16:01 ` Anders Roxell
2019-06-11 16:01 ` Anders Roxell
2019-06-11 16:01 ` Anders Roxell
2019-06-11 16:01 ` Anders Roxell
2019-06-11 16:18 ` Ezequiel Garcia
2019-06-11 16:28 ` Anders Roxell
2019-06-11 16:28 ` Anders Roxell
2019-06-11 16:28 ` Anders Roxell
2019-06-11 16:28 ` Anders Roxell
2019-06-06 10:38 ` Marc Gonzalez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.