* [patch] i40e: remove a stray unlock
@ 2016-08-03 19:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-08-03 19:01 UTC (permalink / raw)
To: Jeff Kirsher, Catherine Sullivan; +Cc: intel-wired-lan, netdev, kernel-janitors
We shifted the locking around a bit but forgot to delete this unlock so
now it can unlock twice.
Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index e1370c5..1a9682f 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -990,7 +990,6 @@ int i40e_unregister_client(struct i40e_client *client)
if (!i40e_client_is_registered(client)) {
pr_info("i40e: Client %s has not been registered\n",
client->name);
- mutex_unlock(&i40e_client_mutex);
ret = -ENODEV;
goto out;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] i40e: remove a stray unlock
@ 2016-08-03 19:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-08-03 19:01 UTC (permalink / raw)
To: Jeff Kirsher, Catherine Sullivan; +Cc: intel-wired-lan, netdev, kernel-janitors
We shifted the locking around a bit but forgot to delete this unlock so
now it can unlock twice.
Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index e1370c5..1a9682f 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -990,7 +990,6 @@ int i40e_unregister_client(struct i40e_client *client)
if (!i40e_client_is_registered(client)) {
pr_info("i40e: Client %s has not been registered\n",
client->name);
- mutex_unlock(&i40e_client_mutex);
ret = -ENODEV;
goto out;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [patch] i40e: remove a stray unlock
@ 2016-08-03 19:01 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-08-03 19:01 UTC (permalink / raw)
To: intel-wired-lan
We shifted the locking around a bit but forgot to delete this unlock so
now it can unlock twice.
Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c
index e1370c5..1a9682f 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_client.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c
@@ -990,7 +990,6 @@ int i40e_unregister_client(struct i40e_client *client)
if (!i40e_client_is_registered(client)) {
pr_info("i40e: Client %s has not been registered\n",
client->name);
- mutex_unlock(&i40e_client_mutex);
ret = -ENODEV;
goto out;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [patch] i40e: remove a stray unlock
2016-08-03 19:01 ` Dan Carpenter
(?)
(?)
@ 2016-08-11 18:59 ` Bowers, AndrewX
-1 siblings, 0 replies; 4+ messages in thread
From: Bowers, AndrewX @ 2016-08-11 18:59 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Dan Carpenter
> Sent: Wednesday, August 03, 2016 12:01 PM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Catherine Sullivan
> <catherine.sullivan@intel.com>
> Cc: netdev at vger.kernel.org; kernel-janitors at vger.kernel.org; intel-wired-
> lan at lists.osuosl.org
> Subject: [Intel-wired-lan] [patch] i40e: remove a stray unlock
>
> We shifted the locking around a bit but forgot to delete this unlock so now it
> can unlock twice.
>
> Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-08-11 18:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 19:01 [patch] i40e: remove a stray unlock Dan Carpenter
2016-08-03 19:01 ` [Intel-wired-lan] " Dan Carpenter
2016-08-03 19:01 ` Dan Carpenter
2016-08-11 18:59 ` [Intel-wired-lan] " Bowers, AndrewX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.