* [Intel-wired-lan] [PATCH] ixgbe: Avoid to write the RETA table when unnecessary.
@ 2018-01-28 11:53 Tonghao Zhang
2018-02-02 22:28 ` Bowers, AndrewX
0 siblings, 1 reply; 2+ messages in thread
From: Tonghao Zhang @ 2018-01-28 11:53 UTC (permalink / raw)
To: intel-wired-lan
If indir == 0 in the ixgbe_set_rxfh(), it is unnecessary
to write the HW. Because redirection table is not changed.
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index 3173510..8c652c6 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -3059,6 +3059,8 @@ static int ixgbe_set_rxfh(struct net_device *netdev, const u32 *indir,
for (i = 0; i < reta_entries; i++)
adapter->rss_indir_tbl[i] = indir[i];
+
+ ixgbe_store_reta(adapter);
}
/* Fill out the rss hash key */
@@ -3067,8 +3069,6 @@ static int ixgbe_set_rxfh(struct net_device *netdev, const u32 *indir,
ixgbe_store_key(adapter);
}
- ixgbe_store_reta(adapter);
-
return 0;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Intel-wired-lan] [PATCH] ixgbe: Avoid to write the RETA table when unnecessary.
2018-01-28 11:53 [Intel-wired-lan] [PATCH] ixgbe: Avoid to write the RETA table when unnecessary Tonghao Zhang
@ 2018-02-02 22:28 ` Bowers, AndrewX
0 siblings, 0 replies; 2+ messages in thread
From: Bowers, AndrewX @ 2018-02-02 22:28 UTC (permalink / raw)
To: intel-wired-lan
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On
> Behalf Of Tonghao Zhang
> Sent: Sunday, January 28, 2018 3:54 AM
> To: intel-wired-lan at osuosl.org
> Subject: [Intel-wired-lan] [PATCH] ixgbe: Avoid to write the RETA table when
> unnecessary.
>
> If indir == 0 in the ixgbe_set_rxfh(), it is unnecessary to write the HW.
> Because redirection table is not changed.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-02 22:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-28 11:53 [Intel-wired-lan] [PATCH] ixgbe: Avoid to write the RETA table when unnecessary Tonghao Zhang
2018-02-02 22:28 ` Bowers, AndrewX
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.