* [PATCH] tools: xenalyze: kill spurious sched_switch output in non dump mode.
@ 2016-08-04 8:59 Dario Faggioli
2016-08-08 9:33 ` George Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Dario Faggioli @ 2016-08-04 8:59 UTC (permalink / raw)
To: xen-devel; +Cc: George Dunlap, Wei Liu, Ian Jackson
In fact, 52cf096df7 ("xenalyze: handle scheduling event"),
when dealing with TRC_SCHED_SWITCH, forgot to check whether
we actually are in dump mode, causing the printf() in
dump_sched_switch() to always produce its output, which
is not what we want.
Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
tools/xentrace/xenalyze.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c
index d223de6..3d06e45 100644
--- a/tools/xentrace/xenalyze.c
+++ b/tools/xentrace/xenalyze.c
@@ -7629,7 +7629,8 @@ void sched_process(struct pcpu_info *p)
}
break;
case TRC_SCHED_SWITCH:
- dump_sched_switch(ri);
+ if(opt.dump_all)
+ dump_sched_switch(ri);
break;
case TRC_SCHED_SWITCH_INFPREV:
if(opt.dump_all) {
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tools: xenalyze: kill spurious sched_switch output in non dump mode.
2016-08-04 8:59 [PATCH] tools: xenalyze: kill spurious sched_switch output in non dump mode Dario Faggioli
@ 2016-08-08 9:33 ` George Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: George Dunlap @ 2016-08-08 9:33 UTC (permalink / raw)
To: Dario Faggioli, xen-devel; +Cc: George Dunlap, Wei Liu, Ian Jackson
On 04/08/16 09:59, Dario Faggioli wrote:
> In fact, 52cf096df7 ("xenalyze: handle scheduling event"),
> when dealing with TRC_SCHED_SWITCH, forgot to check whether
> we actually are in dump mode, causing the printf() in
> dump_sched_switch() to always produce its output, which
> is not what we want.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
And queued.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-08 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-04 8:59 [PATCH] tools: xenalyze: kill spurious sched_switch output in non dump mode Dario Faggioli
2016-08-08 9:33 ` George Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.