From: Quentin Schulz <quentin.schulz@free-electrons.com> To: Jonathan Cameron <jic23@kernel.org>, jdelvare@suse.com, linux@roeck-us.net, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, maxime.ripard@free-electrons.com, wens@csie.org, lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@free-electrons.com, antoine.tenart@free-electrons.com Subject: Re: [PATCH v2 2/4] iio: adc: add support for Allwinner SoCs ADC Date: Thu, 21 Jul 2016 14:15:38 +0200 [thread overview] Message-ID: <26aa8f33-8525-6d82-ca17-b782c55c2c82@free-electrons.com> (raw) In-Reply-To: <e763fba8-391f-f353-9ffe-354c08305dc5@kernel.org> On 20/07/2016 16:57, Jonathan Cameron wrote: > On 19/07/16 09:33, Quentin Schulz wrote: >> On 18/07/2016 15:18, Jonathan Cameron wrote: >>> On 15/07/16 10:59, Quentin Schulz wrote: [...] >>>> + enable_irq(info->temp_data_irq); >>> Is this hardware spitting out extra irqs? If not, much better to just >>> leave it enabled all the time and control whether it can occur or not >>> by controlling the device state.. >> >> The temp_data_irq occurs every SUNXI_GPADC_TEMP_PERIOD(x) periods (in >> the current state of the driver: 2s). What do you mean by controlling >> the device state? Enabling or disabling the hardware part of the IP >> responsible of getting the temperature >> (SUNXI_GPADC_TP_TPR_TEMP_ENABLE(x) here)? > Yes, or something along those lines if it wakes up fast enough. The ADC wakes up fast enough but resets its internal time clock (I don't know if it's the right term to use). Note that the temperature interrupt occurs by period of X seconds in this IP. This means that each time we disable the ADC on the hardware side, no temperature interrupt will occur within the first X seconds. I don't think this is what we want. [...] Quentin
WARNING: multiple messages have this Message-ID (diff)
From: quentin.schulz@free-electrons.com (Quentin Schulz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/4] iio: adc: add support for Allwinner SoCs ADC Date: Thu, 21 Jul 2016 14:15:38 +0200 [thread overview] Message-ID: <26aa8f33-8525-6d82-ca17-b782c55c2c82@free-electrons.com> (raw) In-Reply-To: <e763fba8-391f-f353-9ffe-354c08305dc5@kernel.org> On 20/07/2016 16:57, Jonathan Cameron wrote: > On 19/07/16 09:33, Quentin Schulz wrote: >> On 18/07/2016 15:18, Jonathan Cameron wrote: >>> On 15/07/16 10:59, Quentin Schulz wrote: [...] >>>> + enable_irq(info->temp_data_irq); >>> Is this hardware spitting out extra irqs? If not, much better to just >>> leave it enabled all the time and control whether it can occur or not >>> by controlling the device state.. >> >> The temp_data_irq occurs every SUNXI_GPADC_TEMP_PERIOD(x) periods (in >> the current state of the driver: 2s). What do you mean by controlling >> the device state? Enabling or disabling the hardware part of the IP >> responsible of getting the temperature >> (SUNXI_GPADC_TP_TPR_TEMP_ENABLE(x) here)? > Yes, or something along those lines if it wakes up fast enough. The ADC wakes up fast enough but resets its internal time clock (I don't know if it's the right term to use). Note that the temperature interrupt occurs by period of X seconds in this IP. This means that each time we disable the ADC on the hardware side, no temperature interrupt will occur within the first X seconds. I don't think this is what we want. [...] Quentin
next prev parent reply other threads:[~2016-07-21 12:15 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-15 9:59 [PATCH v2 0/4] add support for Allwinner SoCs ADC Quentin Schulz 2016-07-15 9:59 ` Quentin Schulz 2016-07-15 9:59 ` [PATCH v2 1/4] hwmon: iio_hwmon: defer probe when no channel is found Quentin Schulz 2016-07-15 9:59 ` Quentin Schulz 2016-07-16 17:00 ` [v2,1/4] " Guenter Roeck 2016-07-16 17:00 ` Guenter Roeck 2016-07-18 10:02 ` Maxime Ripard 2016-07-18 10:02 ` Maxime Ripard 2016-07-18 13:29 ` Guenter Roeck 2016-07-18 13:29 ` Guenter Roeck 2016-07-15 9:59 ` [PATCH v2 2/4] iio: adc: add support for Allwinner SoCs ADC Quentin Schulz 2016-07-15 9:59 ` Quentin Schulz 2016-07-18 12:57 ` Maxime Ripard 2016-07-18 12:57 ` Maxime Ripard 2016-07-19 9:04 ` Quentin Schulz 2016-07-19 9:04 ` Quentin Schulz 2016-07-19 12:40 ` Maxime Ripard 2016-07-19 12:40 ` Maxime Ripard 2016-07-18 13:18 ` Jonathan Cameron 2016-07-18 13:18 ` Jonathan Cameron 2016-07-19 8:33 ` Quentin Schulz 2016-07-19 8:33 ` Quentin Schulz 2016-07-20 14:57 ` Jonathan Cameron 2016-07-20 14:57 ` Jonathan Cameron 2016-07-21 12:15 ` Quentin Schulz [this message] 2016-07-21 12:15 ` Quentin Schulz 2016-07-23 6:37 ` Jonathan Cameron 2016-07-23 6:37 ` Jonathan Cameron 2016-07-20 12:37 ` Quentin Schulz 2016-07-20 12:37 ` Quentin Schulz 2016-07-20 14:15 ` Crt Mori 2016-07-20 14:15 ` Crt Mori 2016-07-20 14:59 ` Jonathan Cameron 2016-07-20 14:59 ` Jonathan Cameron 2016-07-15 9:59 ` [PATCH v2 3/4] mfd: " Quentin Schulz 2016-07-15 9:59 ` Quentin Schulz 2016-07-18 13:02 ` Maxime Ripard 2016-07-18 13:02 ` Maxime Ripard 2016-07-19 12:04 ` Quentin Schulz 2016-07-19 12:04 ` Quentin Schulz 2016-07-18 13:25 ` Jonathan Cameron 2016-07-18 13:25 ` Jonathan Cameron 2016-07-19 7:31 ` Lee Jones 2016-07-19 7:31 ` Lee Jones 2016-07-20 15:01 ` Jonathan Cameron 2016-07-20 15:01 ` Jonathan Cameron 2016-07-21 12:12 ` Lee Jones 2016-07-21 12:12 ` Lee Jones 2016-07-21 20:08 ` Maxime Ripard 2016-07-21 20:08 ` Maxime Ripard 2016-07-22 13:55 ` Lee Jones 2016-07-22 13:55 ` Lee Jones 2016-07-23 6:42 ` Jonathan Cameron 2016-07-23 6:42 ` Jonathan Cameron 2016-07-25 9:55 ` Maxime Ripard 2016-07-25 9:55 ` Maxime Ripard 2016-07-19 8:35 ` Quentin Schulz 2016-07-19 8:35 ` Quentin Schulz 2016-07-15 9:59 ` [PATCH v2 4/4] hwmon: iio: add label for channels read by iio_hwmon Quentin Schulz 2016-07-15 9:59 ` Quentin Schulz 2016-07-15 14:03 ` Guenter Roeck 2016-07-15 14:03 ` Guenter Roeck 2016-07-15 14:36 ` Quentin Schulz 2016-07-15 14:36 ` Quentin Schulz 2016-07-16 2:53 ` Guenter Roeck 2016-07-16 2:53 ` Guenter Roeck 2016-07-18 12:24 ` Jonathan Cameron 2016-07-18 12:24 ` Jonathan Cameron 2016-07-19 6:55 ` Quentin Schulz 2016-07-19 6:55 ` Quentin Schulz 2016-07-20 14:49 ` Jonathan Cameron 2016-07-20 14:49 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=26aa8f33-8525-6d82-ca17-b782c55c2c82@free-electrons.com \ --to=quentin.schulz@free-electrons.com \ --cc=antoine.tenart@free-electrons.com \ --cc=jdelvare@suse.com \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@roeck-us.net \ --cc=maxime.ripard@free-electrons.com \ --cc=pmeerw@pmeerw.net \ --cc=thomas.petazzoni@free-electrons.com \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.