* [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80
@ 2016-08-18 9:51 Christian König
[not found] ` <1471513874-1685-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Christian König @ 2016-08-18 9:51 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alexander.Deucher-5C7GfCeVMHo
From: Christian König <christian.koenig@amd.com>
Looks like some RV6xx have problems with that.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
index a97abc8..1dcf390 100644
--- a/drivers/gpu/drm/radeon/atombios_crtc.c
+++ b/drivers/gpu/drm/radeon/atombios_crtc.c
@@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
if (radeon_crtc->ss.refdiv) {
radeon_crtc->pll_flags |= RADEON_PLL_USE_REF_DIV;
radeon_crtc->pll_reference_div = radeon_crtc->ss.refdiv;
- if (rdev->family >= CHIP_RV770)
+ if (ASIC_IS_AVIVO(rdev) &&
+ rdev->family != CHIP_RS780 &&
+ rdev->family != CHIP_RS880)
radeon_crtc->pll_flags |= RADEON_PLL_USE_FRAC_FB_DIV;
}
}
--
2.5.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80
[not found] ` <1471513874-1685-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
@ 2016-08-18 9:53 ` Christian König
2016-08-18 13:40 ` Deucher, Alexander
1 sibling, 0 replies; 6+ messages in thread
From: Christian König @ 2016-08-18 9:53 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alexander.Deucher-5C7GfCeVMHo
Am 18.08.2016 um 11:51 schrieb Christian König:
> From: Christian König <christian.koenig@amd.com>
>
> Looks like some RV6xx have problems with that.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Ups, here should be a CC:stable as well.
Christian.
> ---
> drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c b/drivers/gpu/drm/radeon/atombios_crtc.c
> index a97abc8..1dcf390 100644
> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> @@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
> if (radeon_crtc->ss.refdiv) {
> radeon_crtc->pll_flags |= RADEON_PLL_USE_REF_DIV;
> radeon_crtc->pll_reference_div = radeon_crtc->ss.refdiv;
> - if (rdev->family >= CHIP_RV770)
> + if (ASIC_IS_AVIVO(rdev) &&
> + rdev->family != CHIP_RS780 &&
> + rdev->family != CHIP_RS880)
> radeon_crtc->pll_flags |= RADEON_PLL_USE_FRAC_FB_DIV;
> }
> }
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80
[not found] ` <1471513874-1685-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-08-18 9:53 ` Christian König
@ 2016-08-18 13:40 ` Deucher, Alexander
[not found] ` <MWHPR12MB1694E3519417D4AF776C5A52F7150-Gy0DoCVfaSW4WA4dJ5YXGAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
1 sibling, 1 reply; 6+ messages in thread
From: Deucher, Alexander @ 2016-08-18 13:40 UTC (permalink / raw)
To: 'Christian König', amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
> -----Original Message-----
> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Thursday, August 18, 2016 5:51 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH] drm/radeon: only apply the SS fractional workaround to
> RS[78]80
>
> From: Christian König <christian.koenig@amd.com>
>
> Looks like some RV6xx have problems with that.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Please mention the bugzilla in the patch. With that included:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
> b/drivers/gpu/drm/radeon/atombios_crtc.c
> index a97abc8..1dcf390 100644
> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> @@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
> if (radeon_crtc->ss.refdiv) {
> radeon_crtc->pll_flags |=
> RADEON_PLL_USE_REF_DIV;
> radeon_crtc->pll_reference_div =
> radeon_crtc->ss.refdiv;
> - if (rdev->family >= CHIP_RV770)
> + if (ASIC_IS_AVIVO(rdev) &&
> + rdev->family != CHIP_RS780 &&
> + rdev->family != CHIP_RS880)
> radeon_crtc->pll_flags |=
> RADEON_PLL_USE_FRAC_FB_DIV;
> }
> }
> --
> 2.5.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80
[not found] ` <MWHPR12MB1694E3519417D4AF776C5A52F7150-Gy0DoCVfaSW4WA4dJ5YXGAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
@ 2016-08-18 15:18 ` Alex Deucher
[not found] ` <CADnq5_OT4QFmXo29XG=FXG27UmzgpkUbngb_522rba-Jej1cYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Alex Deucher @ 2016-08-18 15:18 UTC (permalink / raw)
To: Deucher, Alexander
Cc: Christian König, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Thu, Aug 18, 2016 at 9:40 AM, Deucher, Alexander
<Alexander.Deucher@amd.com> wrote:
>> -----Original Message-----
>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
>> Of Christian König
>> Sent: Thursday, August 18, 2016 5:51 AM
>> To: amd-gfx@lists.freedesktop.org
>> Cc: Deucher, Alexander
>> Subject: [PATCH] drm/radeon: only apply the SS fractional workaround to
>> RS[78]80
>>
>> From: Christian König <christian.koenig@amd.com>
>>
>> Looks like some RV6xx have problems with that.
>>
>> Signed-off-by: Christian König <christian.koenig@amd.com>
>
> Please mention the bugzilla in the patch. With that included:
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Fixed up and applied.
Alex
>
>> ---
>> drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
>> b/drivers/gpu/drm/radeon/atombios_crtc.c
>> index a97abc8..1dcf390 100644
>> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
>> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
>> @@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
>> if (radeon_crtc->ss.refdiv) {
>> radeon_crtc->pll_flags |=
>> RADEON_PLL_USE_REF_DIV;
>> radeon_crtc->pll_reference_div =
>> radeon_crtc->ss.refdiv;
>> - if (rdev->family >= CHIP_RV770)
>> + if (ASIC_IS_AVIVO(rdev) &&
>> + rdev->family != CHIP_RS780 &&
>> + rdev->family != CHIP_RS880)
>> radeon_crtc->pll_flags |=
>> RADEON_PLL_USE_FRAC_FB_DIV;
>> }
>> }
>> --
>> 2.5.0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80
[not found] ` <CADnq5_OT4QFmXo29XG=FXG27UmzgpkUbngb_522rba-Jej1cYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2016-08-18 15:19 ` Christian König
[not found] ` <eef71136-6cd2-5878-4a63-5c92f75eb5b5-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
0 siblings, 1 reply; 6+ messages in thread
From: Christian König @ 2016-08-18 15:19 UTC (permalink / raw)
To: Alex Deucher, Deucher, Alexander; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Am 18.08.2016 um 17:18 schrieb Alex Deucher:
> On Thu, Aug 18, 2016 at 9:40 AM, Deucher, Alexander
> <Alexander.Deucher@amd.com> wrote:
>>> -----Original Message-----
>>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf
>>> Of Christian König
>>> Sent: Thursday, August 18, 2016 5:51 AM
>>> To: amd-gfx@lists.freedesktop.org
>>> Cc: Deucher, Alexander
>>> Subject: [PATCH] drm/radeon: only apply the SS fractional workaround to
>>> RS[78]80
>>>
>>> From: Christian König <christian.koenig@amd.com>
>>>
>>> Looks like some RV6xx have problems with that.
>>>
>>> Signed-off-by: Christian König <christian.koenig@amd.com>
>> Please mention the bugzilla in the patch. With that included:
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Fixed up and applied.
Have you seen my follow up mail? E.g. did you added CC:stable as well?
Christian.
>
> Alex
>
>>> ---
>>> drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
>>> b/drivers/gpu/drm/radeon/atombios_crtc.c
>>> index a97abc8..1dcf390 100644
>>> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
>>> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
>>> @@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc *crtc,
>>> if (radeon_crtc->ss.refdiv) {
>>> radeon_crtc->pll_flags |=
>>> RADEON_PLL_USE_REF_DIV;
>>> radeon_crtc->pll_reference_div =
>>> radeon_crtc->ss.refdiv;
>>> - if (rdev->family >= CHIP_RV770)
>>> + if (ASIC_IS_AVIVO(rdev) &&
>>> + rdev->family != CHIP_RS780 &&
>>> + rdev->family != CHIP_RS880)
>>> radeon_crtc->pll_flags |=
>>> RADEON_PLL_USE_FRAC_FB_DIV;
>>> }
>>> }
>>> --
>>> 2.5.0
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80
[not found] ` <eef71136-6cd2-5878-4a63-5c92f75eb5b5-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
@ 2016-08-18 15:19 ` Deucher, Alexander
0 siblings, 0 replies; 6+ messages in thread
From: Deucher, Alexander @ 2016-08-18 15:19 UTC (permalink / raw)
To: 'Christian König', Alex Deucher
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
> -----Original Message-----
> From: Christian König [mailto:deathsimple@vodafone.de]
> Sent: Thursday, August 18, 2016 11:19 AM
> To: Alex Deucher; Deucher, Alexander
> Cc: amd-gfx@lists.freedesktop.org
> Subject: Re: [PATCH] drm/radeon: only apply the SS fractional workaround to
> RS[78]80
>
> Am 18.08.2016 um 17:18 schrieb Alex Deucher:
> > On Thu, Aug 18, 2016 at 9:40 AM, Deucher, Alexander
> > <Alexander.Deucher@amd.com> wrote:
> >>> -----Original Message-----
> >>> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On
> Behalf
> >>> Of Christian König
> >>> Sent: Thursday, August 18, 2016 5:51 AM
> >>> To: amd-gfx@lists.freedesktop.org
> >>> Cc: Deucher, Alexander
> >>> Subject: [PATCH] drm/radeon: only apply the SS fractional workaround
> to
> >>> RS[78]80
> >>>
> >>> From: Christian König <christian.koenig@amd.com>
> >>>
> >>> Looks like some RV6xx have problems with that.
> >>>
> >>> Signed-off-by: Christian König <christian.koenig@amd.com>
> >> Please mention the bugzilla in the patch. With that included:
> >> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> > Fixed up and applied.
>
> Have you seen my follow up mail? E.g. did you added CC:stable as well?
Yes.
Alex
>
> Christian.
>
> >
> > Alex
> >
> >>> ---
> >>> drivers/gpu/drm/radeon/atombios_crtc.c | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/radeon/atombios_crtc.c
> >>> b/drivers/gpu/drm/radeon/atombios_crtc.c
> >>> index a97abc8..1dcf390 100644
> >>> --- a/drivers/gpu/drm/radeon/atombios_crtc.c
> >>> +++ b/drivers/gpu/drm/radeon/atombios_crtc.c
> >>> @@ -627,7 +627,9 @@ static u32 atombios_adjust_pll(struct drm_crtc
> *crtc,
> >>> if (radeon_crtc->ss.refdiv) {
> >>> radeon_crtc->pll_flags |=
> >>> RADEON_PLL_USE_REF_DIV;
> >>> radeon_crtc->pll_reference_div =
> >>> radeon_crtc->ss.refdiv;
> >>> - if (rdev->family >= CHIP_RV770)
> >>> + if (ASIC_IS_AVIVO(rdev) &&
> >>> + rdev->family != CHIP_RS780 &&
> >>> + rdev->family != CHIP_RS880)
> >>> radeon_crtc->pll_flags |=
> >>> RADEON_PLL_USE_FRAC_FB_DIV;
> >>> }
> >>> }
> >>> --
> >>> 2.5.0
> >>>
> >>> _______________________________________________
> >>> amd-gfx mailing list
> >>> amd-gfx@lists.freedesktop.org
> >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> >> _______________________________________________
> >> amd-gfx mailing list
> >> amd-gfx@lists.freedesktop.org
> >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-18 15:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 9:51 [PATCH] drm/radeon: only apply the SS fractional workaround to RS[78]80 Christian König
[not found] ` <1471513874-1685-1-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-08-18 9:53 ` Christian König
2016-08-18 13:40 ` Deucher, Alexander
[not found] ` <MWHPR12MB1694E3519417D4AF776C5A52F7150-Gy0DoCVfaSW4WA4dJ5YXGAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-08-18 15:18 ` Alex Deucher
[not found] ` <CADnq5_OT4QFmXo29XG=FXG27UmzgpkUbngb_522rba-Jej1cYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-18 15:19 ` Christian König
[not found] ` <eef71136-6cd2-5878-4a63-5c92f75eb5b5-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org>
2016-08-18 15:19 ` Deucher, Alexander
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.