[PATCH RESEND] openssl: pass PERL=perl environment variable to configurator

[PATCH RESEND] openssl: pass PERL=perl environment variable to configurator

[Ruslan Bilovol]

In our build environment we use wrapper script
for perl in non-standard configuration with
extra variables set (provided by custom
buildtools-tarball).

In this case openssl fails to build because
by default it's Configure script detects and uses
perl executable directly (with absolute path)
obviously missing extra settings from wrapper
script.

Pass PERL=perl environment variable to Configure,
so it won't try to use perl executable directly
but will use what is provided from environment.

Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com>
---
 meta/recipes-connectivity/openssl/openssl_1.1.1d.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb b/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
index c2ba005f47..d4871fe973 100644
--- a/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
+++ b/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
@@ -123,7 +123,7 @@ do_configure () {
 	fi
 	# WARNING: do not set compiler/linker flags (-I/-D etc.) in EXTRA_OECONF, as they will fully replace the
 	# environment variables set by bitbake. Adjust the environment variables instead.
-	PERL5LIB="${S}/external/perl/Text-Template-1.46/lib/" \
+	PERL=perl PERL5LIB="${S}/external/perl/Text-Template-1.46/lib/" \
 	perl ${S}/Configure ${EXTRA_OECONF} ${PACKAGECONFIG_CONFARGS} --prefix=$useprefix --openssldir=${libdir}/ssl-1.1 --libdir=${libdir} $target
 	perl ${B}/configdata.pm --dump
 }
-- 
2.17.1

Re: [PATCH RESEND] openssl: pass PERL=perl environment variable to configurator

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2375 bytes --]

This breaks c_rehash calls from dash (works fine with bash)

dash doesn't like
#!perl
shebang, would
PERL="/usr/bin/env perl"
work for you?

But unfortunately just passing PERL like this doesn't pass do_configure:
Creating Makefile
sh: 1: /usr/bin/env perl: not found
WARNING: exit code 1 from a shell command.

But passing it as:
HASHBANGPERL="/usr/bin/env perl" PERL=perl
seems to work.

On Thu, Mar 5, 2020 at 12:55 PM Ruslan Bilovol via Openembedded-core <
openembedded-core@lists.openembedded.org> wrote:

> In our build environment we use wrapper script
> for perl in non-standard configuration with
> extra variables set (provided by custom
> buildtools-tarball).
>
> In this case openssl fails to build because
> by default it's Configure script detects and uses
> perl executable directly (with absolute path)
> obviously missing extra settings from wrapper
> script.
>
> Pass PERL=perl environment variable to Configure,
> so it won't try to use perl executable directly
> but will use what is provided from environment.
>
> Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com>
> ---
>  meta/recipes-connectivity/openssl/openssl_1.1.1d.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
> b/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
> index c2ba005f47..d4871fe973 100644
> --- a/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
> @@ -123,7 +123,7 @@ do_configure () {
>         fi
>         # WARNING: do not set compiler/linker flags (-I/-D etc.) in
> EXTRA_OECONF, as they will fully replace the
>         # environment variables set by bitbake. Adjust the environment
> variables instead.
> -       PERL5LIB="${S}/external/perl/Text-Template-1.46/lib/" \
> +       PERL=perl PERL5LIB="${S}/external/perl/Text-Template-1.46/lib/" \
>         perl ${S}/Configure ${EXTRA_OECONF} ${PACKAGECONFIG_CONFARGS}
> --prefix=$useprefix --openssldir=${libdir}/ssl-1.1 --libdir=${libdir}
> $target
>         perl ${B}/configdata.pm --dump
>  }
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3657 bytes --]

Re: [PATCH RESEND] openssl: pass PERL=perl environment variable to configurator

[Ruslan Bilovol]

On 3/7/20 12:19 AM, Martin Jansa wrote:
> This breaks c_rehash calls from dash (works fine with bash)

Yes, we use bach during our builds

> 
> dash doesn't like
> #!perl
> shebang, would
> PERL="/usr/bin/env perl"
> work for you?
> 
> But unfortunately just passing PERL like this doesn't pass do_configure:
> Creating Makefile
> sh: 1: /usr/bin/env perl: not found
> WARNING: exit code 1 from a shell command.
> 
> But passing it as:
> HASHBANGPERL="/usr/bin/env perl" PERL=perl
> seems to work.

Will check this suggestion

Thanks,
Ruslan

> 
> On Thu, Mar 5, 2020 at 12:55 PM Ruslan Bilovol via Openembedded-core 
> <openembedded-core@lists.openembedded.org 
> <mailto:openembedded-core@lists.openembedded.org>> wrote:
> 
>     In our build environment we use wrapper script
>     for perl in non-standard configuration with
>     extra variables set (provided by custom
>     buildtools-tarball).
> 
>     In this case openssl fails to build because
>     by default it's Configure script detects and uses
>     perl executable directly (with absolute path)
>     obviously missing extra settings from wrapper
>     script.
> 
>     Pass PERL=perl environment variable to Configure,
>     so it won't try to use perl executable directly
>     but will use what is provided from environment.
> 
>     Signed-off-by: Ruslan Bilovol <rbilovol@cisco.com
>     <mailto:rbilovol@cisco.com>>
>     ---
>       meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
>     <http://openssl_1.1.1d.bb> | 2 +-
>       1 file changed, 1 insertion(+), 1 deletion(-)
> 
>     diff --git a/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
>     <http://openssl_1.1.1d.bb>
>     b/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
>     <http://openssl_1.1.1d.bb>
>     index c2ba005f47..d4871fe973 100644
>     --- a/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
>     <http://openssl_1.1.1d.bb>
>     +++ b/meta/recipes-connectivity/openssl/openssl_1.1.1d.bb
>     <http://openssl_1.1.1d.bb>
>     @@ -123,7 +123,7 @@ do_configure () {
>              fi
>              # WARNING: do not set compiler/linker flags (-I/-D etc.) in
>     EXTRA_OECONF, as they will fully replace the
>              # environment variables set by bitbake. Adjust the
>     environment variables instead.
>     -       PERL5LIB="${S}/external/perl/Text-Template-1.46/lib/" \
>     +       PERL=perl
>     PERL5LIB="${S}/external/perl/Text-Template-1.46/lib/" \
>              perl ${S}/Configure ${EXTRA_OECONF}
>     ${PACKAGECONFIG_CONFARGS} --prefix=$useprefix
>     --openssldir=${libdir}/ssl-1.1 --libdir=${libdir} $target
>              perl ${B}/configdata.pm <http://configdata.pm> --dump
>       }
>     -- 
>     2.17.1
> 
>     -- 
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>