From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Greg KH <gregkh@linuxfoundation.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root
Date: Sat, 19 Sep 2020 17:03:50 +0530 [thread overview]
Message-ID: <26d881e5-f68a-b3b7-4cb0-04a3c6c384ac@gmail.com> (raw)
In-Reply-To: <20200919165558.GH3421308@ZenIV.linux.org.uk>
On 19-09-2020 22:25, Al Viro wrote:
> On Sat, Sep 19, 2020 at 05:17:27PM +0100, Al Viro wrote:
>
>> Lovely... That would get an empty path and non-directory for a starting
>> point, but it should end up with LAST_ROOT in nd->last_type. Which should
>> not be able to reach the readers of those fields... Which kernel had
>> that been on?
> Yecchhh... I see what's going on; I suspect that this ought to be enough.
> Folks, could somebody test it on the original reproducer setup?
Sure. I can do that.
Thanks,
Anant
WARNING: multiple messages have this Message-ID (diff)
From: Anant Thazhemadam <anant.thazhemadam@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>, Greg KH <gregkh@linuxfoundation.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
linux-fsdevel@vger.kernel.org,
syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees] [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root
Date: Sat, 19 Sep 2020 17:03:50 +0530 [thread overview]
Message-ID: <26d881e5-f68a-b3b7-4cb0-04a3c6c384ac@gmail.com> (raw)
In-Reply-To: <20200919165558.GH3421308@ZenIV.linux.org.uk>
On 19-09-2020 22:25, Al Viro wrote:
> On Sat, Sep 19, 2020 at 05:17:27PM +0100, Al Viro wrote:
>
>> Lovely... That would get an empty path and non-directory for a starting
>> point, but it should end up with LAST_ROOT in nd->last_type. Which should
>> not be able to reach the readers of those fields... Which kernel had
>> that been on?
> Yecchhh... I see what's going on; I suspect that this ought to be enough.
> Folks, could somebody test it on the original reproducer setup?
Sure. I can do that.
Thanks,
Anant
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-09-19 17:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 5:26 [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root Anant Thazhemadam
2020-09-16 5:26 ` [Linux-kernel-mentees] " Anant Thazhemadam
2020-09-16 5:41 ` Eric Biggers
2020-09-16 5:41 ` [Linux-kernel-mentees] " Eric Biggers
2020-09-17 0:22 ` Al Viro
2020-09-17 0:22 ` [Linux-kernel-mentees] " Al Viro
2020-09-19 14:44 ` Greg KH
2020-09-19 14:44 ` Greg KH
2020-09-19 16:17 ` Al Viro
2020-09-19 16:17 ` Al Viro
2020-09-19 16:55 ` Al Viro
2020-09-19 16:55 ` Al Viro
2020-09-19 11:33 ` Anant Thazhemadam [this message]
2020-09-19 11:33 ` Anant Thazhemadam
2020-09-19 20:17 ` Anant Thazhemadam
2020-09-19 20:17 ` Anant Thazhemadam
2020-10-04 15:25 ` Anant Thazhemadam
2020-10-04 15:25 ` Anant Thazhemadam
2020-09-16 6:16 ` Greg KH
2020-09-16 6:16 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d881e5-f68a-b3b7-4cb0-04a3c6c384ac@gmail.com \
--to=anant.thazhemadam@gmail.com \
--cc=ebiggers@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.