From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Julian Braha <julianbraha@gmail.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
Vijendar.Mukunda@amd.com, AjitKumar.Pandey@amd.com,
kai.vehmanen@linux.intel.com, tanureal@opensource.cirrus.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
fazilyildiran@gmail.com
Subject: Re: [PATCH] ASoC: amd: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
Date: Tue, 18 Jan 2022 11:21:50 -0600 [thread overview]
Message-ID: <26ec72a7-effa-7553-fc0f-4e016b651c09@linux.intel.com> (raw)
In-Reply-To: <Yeb0n9AVXeVzBHrT@sirena.org.uk>
On 1/18/22 11:10 AM, Mark Brown wrote:
> On Sun, Jan 16, 2022 at 11:15:28PM -0500, Julian Braha wrote:
>> When SND_SOC_AMD_YC_MACH is selected,
>> and GPIOLIB is not selected,
>> Kbuild gives the following warning:
>>
>> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
>> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
>> Selected by [y]:
>> - SND_SOC_AMD_YC_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_ACP6x [=y]
>
> Why is this a good fix and not removing the dependency on gpiolib from
> DMIC? While a DMIC *can* use a GPIO it's not something that's an
> intrinsic requirement and it's entirely optional in the code.
We also have similar 'depends on GPIOLIB' for Intel boards that are not
really useful. see e.g. 4262ddc2ad63 ('ASoC: Intel: boards: add explicit
dependency on GPIOLIB when DMIC is used'). IIRC we had this discussion
before about doing a larger cleanup.
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Julian Braha <julianbraha@gmail.com>
Cc: alsa-devel@alsa-project.org, AjitKumar.Pandey@amd.com,
kai.vehmanen@linux.intel.com, linux-kernel@vger.kernel.org,
fazilyildiran@gmail.com, tiwai@suse.com, lgirdwood@gmail.com,
Vijendar.Mukunda@amd.com, tanureal@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: amd: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
Date: Tue, 18 Jan 2022 11:21:50 -0600 [thread overview]
Message-ID: <26ec72a7-effa-7553-fc0f-4e016b651c09@linux.intel.com> (raw)
In-Reply-To: <Yeb0n9AVXeVzBHrT@sirena.org.uk>
On 1/18/22 11:10 AM, Mark Brown wrote:
> On Sun, Jan 16, 2022 at 11:15:28PM -0500, Julian Braha wrote:
>> When SND_SOC_AMD_YC_MACH is selected,
>> and GPIOLIB is not selected,
>> Kbuild gives the following warning:
>>
>> WARNING: unmet direct dependencies detected for SND_SOC_DMIC
>> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
>> Selected by [y]:
>> - SND_SOC_AMD_YC_MACH [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && SND_SOC_AMD_ACP6x [=y]
>
> Why is this a good fix and not removing the dependency on gpiolib from
> DMIC? While a DMIC *can* use a GPIO it's not something that's an
> intrinsic requirement and it's entirely optional in the code.
We also have similar 'depends on GPIOLIB' for Intel boards that are not
really useful. see e.g. 4262ddc2ad63 ('ASoC: Intel: boards: add explicit
dependency on GPIOLIB when DMIC is used'). IIRC we had this discussion
before about doing a larger cleanup.
next prev parent reply other threads:[~2022-01-18 17:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 4:15 [PATCH] ASoC: amd: fix unmet dependency on GPIOLIB for SND_SOC_DMIC Julian Braha
2022-01-17 4:15 ` Julian Braha
2022-01-18 17:10 ` Mark Brown
2022-01-18 17:10 ` Mark Brown
2022-01-18 17:21 ` Pierre-Louis Bossart [this message]
2022-01-18 17:21 ` Pierre-Louis Bossart
2022-01-18 17:35 ` Mark Brown
2022-01-18 17:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26ec72a7-effa-7553-fc0f-4e016b651c09@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=AjitKumar.Pandey@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fazilyildiran@gmail.com \
--cc=julianbraha@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.