* [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23
@ 2020-12-30 21:41 Alejandro Colomar
2020-12-30 22:40 ` Michael Kerrisk (man-pages)
0 siblings, 1 reply; 6+ messages in thread
From: Alejandro Colomar @ 2020-12-30 21:41 UTC (permalink / raw)
To: mtk.manpages; +Cc: Alejandro Colomar, linux-man, Jakub Wilk
See glibc's commit: 0ce657c576bf1b24
https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24
Reported-by: Jakub Wilk <jwilk@jwilk.net>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
man3/get_phys_pages.3 | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3
index 35f83fedb..a8a1ce3f4 100644
--- a/man3/get_phys_pages.3
+++ b/man3/get_phys_pages.3
@@ -55,15 +55,20 @@ The system could not provide the required information
(possibly because the
.I /proc
filesystem was not mounted).
-.SH CONFORMING TO
-These functions are GNU extensions.
-.SH NOTES
-These functions obtain the required information by scanning the
+.SH VERSIONS
+Before glibc 2.23,
+these functions obtained the required information by scanning the
.I MemTotal
and
.I MemFree
fields of
.IR /proc/meminfo .
+.SH CONFORMING TO
+These functions are GNU extensions.
+.SH NOTES
+Since glibc 2.23,
+these functions obtain the required information by calling
+.BR sysinfo (2).
.PP
The following
.BR sysconf (3)
--
2.29.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23
2020-12-30 21:41 [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23 Alejandro Colomar
@ 2020-12-30 22:40 ` Michael Kerrisk (man-pages)
2020-12-30 23:22 ` Alejandro Colomar (man-pages)
0 siblings, 1 reply; 6+ messages in thread
From: Michael Kerrisk (man-pages) @ 2020-12-30 22:40 UTC (permalink / raw)
To: Alejandro Colomar; +Cc: mtk.manpages, linux-man, Jakub Wilk
Hi Alewx,
On 12/30/20 10:41 PM, Alejandro Colomar wrote:
> See glibc's commit: 0ce657c576bf1b24
> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24
>
> Reported-by: Jakub Wilk <jwilk@jwilk.net>
> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
> ---
> man3/get_phys_pages.3 | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3
> index 35f83fedb..a8a1ce3f4 100644
> --- a/man3/get_phys_pages.3
> +++ b/man3/get_phys_pages.3
> @@ -55,15 +55,20 @@ The system could not provide the required information
> (possibly because the
> .I /proc
> filesystem was not mounted).
> -.SH CONFORMING TO
> -These functions are GNU extensions.
> -.SH NOTES
> -These functions obtain the required information by scanning the
> +.SH VERSIONS
> +Before glibc 2.23,
> +these functions obtained the required information by scanning the
> .I MemTotal
> and
> .I MemFree
> fields of
> .IR /proc/meminfo .
Thanks for the patch. But I think it would be better to put
all the info into NOTES, rather than splitting some out into
VERSIONS.
> +.SH CONFORMING TO
> +These functions are GNU extensions.
And it's good to add this, but let's make it a separate patch.
> +.SH NOTES
> +Since glibc 2.23,
> +these functions obtain the required information by calling
> +.BR sysinfo (2).
> .PP
> The following
> .BR sysconf (3)
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23
2020-12-30 22:40 ` Michael Kerrisk (man-pages)
@ 2020-12-30 23:22 ` Alejandro Colomar (man-pages)
2020-12-31 8:21 ` Michael Kerrisk (man-pages)
0 siblings, 1 reply; 6+ messages in thread
From: Alejandro Colomar (man-pages) @ 2020-12-30 23:22 UTC (permalink / raw)
To: Michael Kerrisk (man-pages); +Cc: linux-man, Jakub Wilk
On 12/30/20 11:40 PM, Michael Kerrisk (man-pages) wrote:
> Hi Alewx,
>
> On 12/30/20 10:41 PM, Alejandro Colomar wrote:
>> See glibc's commit: 0ce657c576bf1b24
>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24
>>
>> Reported-by: Jakub Wilk <jwilk@jwilk.net>
>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>> ---
>> man3/get_phys_pages.3 | 13 +++++++++----
>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3
>> index 35f83fedb..a8a1ce3f4 100644
>> --- a/man3/get_phys_pages.3
>> +++ b/man3/get_phys_pages.3
>> @@ -55,15 +55,20 @@ The system could not provide the required information
>> (possibly because the
>> .I /proc
>> filesystem was not mounted).
>> -.SH CONFORMING TO
>> -These functions are GNU extensions.
>> -.SH NOTES
>> -These functions obtain the required information by scanning the
>> +.SH VERSIONS
>> +Before glibc 2.23,
>> +these functions obtained the required information by scanning the
>> .I MemTotal
>> and
>> .I MemFree
>> fields of
>> .IR /proc/meminfo .
>
> Thanks for the patch. But I think it would be better to put
> all the info into NOTES, rather than splitting some out into
> VERSIONS.
>
>> +.SH CONFORMING TO
>> +These functions are GNU extensions.
>
> And it's good to add this, but let's make it a separate patch.
Hi Michael,
I didn't add that.
This is one of those times when git provides unreadable diffs.
Please have a closer look at the diff,
and also at the rendered output.
Thanks,
Alex
>
>> +.SH NOTES
>> +Since glibc 2.23,
>> +these functions obtain the required information by calling
>> +.BR sysinfo (2).
>> .PP
>> The following
>> .BR sysconf (3)
>
>
> Thanks,
>
> Michael
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23
2020-12-30 23:22 ` Alejandro Colomar (man-pages)
@ 2020-12-31 8:21 ` Michael Kerrisk (man-pages)
2020-12-31 11:48 ` Alejandro Colomar (man-pages)
0 siblings, 1 reply; 6+ messages in thread
From: Michael Kerrisk (man-pages) @ 2020-12-31 8:21 UTC (permalink / raw)
To: Alejandro Colomar (man-pages); +Cc: mtk.manpages, linux-man, Jakub Wilk
On 12/31/20 12:22 AM, Alejandro Colomar (man-pages) wrote:
>
>
> On 12/30/20 11:40 PM, Michael Kerrisk (man-pages) wrote:
>> Hi Alewx,
>>
>> On 12/30/20 10:41 PM, Alejandro Colomar wrote:
>>> See glibc's commit: 0ce657c576bf1b24
>>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24
>>>
>>> Reported-by: Jakub Wilk <jwilk@jwilk.net>
>>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>>> ---
>>> man3/get_phys_pages.3 | 13 +++++++++----
>>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3
>>> index 35f83fedb..a8a1ce3f4 100644
>>> --- a/man3/get_phys_pages.3
>>> +++ b/man3/get_phys_pages.3
>>> @@ -55,15 +55,20 @@ The system could not provide the required information
>>> (possibly because the
>>> .I /proc
>>> filesystem was not mounted).
>>> -.SH CONFORMING TO
>>> -These functions are GNU extensions.
>>> -.SH NOTES
>>> -These functions obtain the required information by scanning the
>>> +.SH VERSIONS
>>> +Before glibc 2.23,
>>> +these functions obtained the required information by scanning the
>>> .I MemTotal
>>> and
>>> .I MemFree
>>> fields of
>>> .IR /proc/meminfo .
>>
>> Thanks for the patch. But I think it would be better to put
>> all the info into NOTES, rather than splitting some out into
>> VERSIONS.
>>
>>> +.SH CONFORMING TO
>>> +These functions are GNU extensions.
>>
>> And it's good to add this, but let's make it a separate patch.
>
> Hi Michael,
>
> I didn't add that.
> This is one of those times when git provides unreadable diffs.
> Please have a closer look at the diff,
> and also at the rendered output.
Yes, I see now.
Still, it would be best to put this piece into NOTES:
[[
Before glibc 2.23,
these functions obtained the required information by scanning the
.I MemTotal
Before glibc 2.23,
these functions obtained the required information by scanning the
.I MemTotal
]]
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23
2020-12-31 8:21 ` Michael Kerrisk (man-pages)
@ 2020-12-31 11:48 ` Alejandro Colomar (man-pages)
2021-01-01 22:39 ` Michael Kerrisk (man-pages)
0 siblings, 1 reply; 6+ messages in thread
From: Alejandro Colomar (man-pages) @ 2020-12-31 11:48 UTC (permalink / raw)
To: Michael Kerrisk (man-pages); +Cc: linux-man, Jakub Wilk
On 12/31/20 9:21 AM, Michael Kerrisk (man-pages) wrote:
> On 12/31/20 12:22 AM, Alejandro Colomar (man-pages) wrote:
>>
>>
>> On 12/30/20 11:40 PM, Michael Kerrisk (man-pages) wrote:
>>> Hi Alewx,
>>>
>>> On 12/30/20 10:41 PM, Alejandro Colomar wrote:
>>>> See glibc's commit: 0ce657c576bf1b24
>>>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24
>>>>
>>>> Reported-by: Jakub Wilk <jwilk@jwilk.net>
>>>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>>>> ---
>>>> man3/get_phys_pages.3 | 13 +++++++++----
>>>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3
>>>> index 35f83fedb..a8a1ce3f4 100644
>>>> --- a/man3/get_phys_pages.3
>>>> +++ b/man3/get_phys_pages.3
>>>> @@ -55,15 +55,20 @@ The system could not provide the required information
>>>> (possibly because the
>>>> .I /proc
>>>> filesystem was not mounted).
>>>> -.SH CONFORMING TO
>>>> -These functions are GNU extensions.
>>>> -.SH NOTES
>>>> -These functions obtain the required information by scanning the
>>>> +.SH VERSIONS
>>>> +Before glibc 2.23,
>>>> +these functions obtained the required information by scanning the
>>>> .I MemTotal
>>>> and
>>>> .I MemFree
>>>> fields of
>>>> .IR /proc/meminfo .
>>>
>>> Thanks for the patch. But I think it would be better to put
>>> all the info into NOTES, rather than splitting some out into
>>> VERSIONS.
>>>
>>>> +.SH CONFORMING TO
>>>> +These functions are GNU extensions.
>>>
>>> And it's good to add this, but let's make it a separate patch.
>>
>> Hi Michael,
>>
>> I didn't add that.
>> This is one of those times when git provides unreadable diffs.
>> Please have a closer look at the diff,
>> and also at the rendered output.
>
> Yes, I see now.
>
> Still, it would be best to put this piece into NOTES:
>
> [[
> Before glibc 2.23,
> these functions obtained the required information by scanning the
> .I MemTotal
> Before glibc 2.23,
> these functions obtained the required information by scanning the
> .I MemTotal
> ]]
Hi Michael,
I've seen you've applied the patch already; maybe by accident?
I don't know exactly how you prefer it, so maybe now you can move around
the text to NOTES in a new commit.
Thanks,
Alex
>
> Thanks,
>
> Michael
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23
2020-12-31 11:48 ` Alejandro Colomar (man-pages)
@ 2021-01-01 22:39 ` Michael Kerrisk (man-pages)
0 siblings, 0 replies; 6+ messages in thread
From: Michael Kerrisk (man-pages) @ 2021-01-01 22:39 UTC (permalink / raw)
To: Alejandro Colomar (man-pages); +Cc: mtk.manpages, linux-man, Jakub Wilk
On 12/31/20 12:48 PM, Alejandro Colomar (man-pages) wrote:
>
>
> On 12/31/20 9:21 AM, Michael Kerrisk (man-pages) wrote:
>> On 12/31/20 12:22 AM, Alejandro Colomar (man-pages) wrote:
>>>
>>>
>>> On 12/30/20 11:40 PM, Michael Kerrisk (man-pages) wrote:
>>>> Hi Alewx,
>>>>
>>>> On 12/30/20 10:41 PM, Alejandro Colomar wrote:
>>>>> See glibc's commit: 0ce657c576bf1b24
>>>>> https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0ce657c576bf1b24
>>>>>
>>>>> Reported-by: Jakub Wilk <jwilk@jwilk.net>
>>>>> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
>>>>> ---
>>>>> man3/get_phys_pages.3 | 13 +++++++++----
>>>>> 1 file changed, 9 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/man3/get_phys_pages.3 b/man3/get_phys_pages.3
>>>>> index 35f83fedb..a8a1ce3f4 100644
>>>>> --- a/man3/get_phys_pages.3
>>>>> +++ b/man3/get_phys_pages.3
>>>>> @@ -55,15 +55,20 @@ The system could not provide the required information
>>>>> (possibly because the
>>>>> .I /proc
>>>>> filesystem was not mounted).
>>>>> -.SH CONFORMING TO
>>>>> -These functions are GNU extensions.
>>>>> -.SH NOTES
>>>>> -These functions obtain the required information by scanning the
>>>>> +.SH VERSIONS
>>>>> +Before glibc 2.23,
>>>>> +these functions obtained the required information by scanning the
>>>>> .I MemTotal
>>>>> and
>>>>> .I MemFree
>>>>> fields of
>>>>> .IR /proc/meminfo .
>>>>
>>>> Thanks for the patch. But I think it would be better to put
>>>> all the info into NOTES, rather than splitting some out into
>>>> VERSIONS.
>>>>
>>>>> +.SH CONFORMING TO
>>>>> +These functions are GNU extensions.
>>>>
>>>> And it's good to add this, but let's make it a separate patch.
>>>
>>> Hi Michael,
>>>
>>> I didn't add that.
>>> This is one of those times when git provides unreadable diffs.
>>> Please have a closer look at the diff,
>>> and also at the rendered output.
>>
>> Yes, I see now.
>>
>> Still, it would be best to put this piece into NOTES:
>>
>> [[
>> Before glibc 2.23,
>> these functions obtained the required information by scanning the
>> .I MemTotal
>> Before glibc 2.23,
>> these functions obtained the required information by scanning the
>> .I MemTotal
>> ]]
>
> Hi Michael,
>
> I've seen you've applied the patch already; maybe by accident?
D'oh! Yes, it was an accident.
> I don't know exactly how you prefer it, so maybe now you can move around
> the text to NOTES in a new commit.
Done.
Thanks,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-01 22:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-30 21:41 [PATCH] get_phys_pages.3: glibc gets the info from sysinfo(2) since 2.23 Alejandro Colomar
2020-12-30 22:40 ` Michael Kerrisk (man-pages)
2020-12-30 23:22 ` Alejandro Colomar (man-pages)
2020-12-31 8:21 ` Michael Kerrisk (man-pages)
2020-12-31 11:48 ` Alejandro Colomar (man-pages)
2021-01-01 22:39 ` Michael Kerrisk (man-pages)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.