All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Julien Grall <julien.grall@arm.com>,
	Shanker Donthineni <shankerd@codeaurora.org>,
	xen-devel <xen-devel@lists.xensource.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Cc: Philip Elcan <pelcan@codeaurora.org>,
	Vikram Sethi <vikrams@codeaurora.org>
Subject: Re: [PATCH V2 05/10] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region
Date: Mon, 27 Jun 2016 13:43:54 +0100	[thread overview]
Message-ID: <270a9df8-ebc2-44a9-6e02-fee799329532@citrix.com> (raw)
In-Reply-To: <57711E54.1030508@arm.com>


>> to a compile time macro MAX_RDIST_COUNT which is 4. On some systems,
>
> s/a compile time macro/a define/
> s/On some/Some/
>
>> especially latest server chips might have more than 4 redistributors.
>
> I would add a comma after 'chips'.

In English, rules for dual commas forming a subclause like this are that
the sentence still makes grammatical sense if the subclause is omitted.

Therefore

"On some systems, especially latest server chips, might have more than 4
redistributors."

is expected be equivalent to

"On some systems might have more than 4 redistributors."


The latter however doesn't make sense.

May I recommend instead:

"Some systems, especially latest server chips, may have more than 4
redistributors."

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

  reply	other threads:[~2016-06-27 12:43 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-26 17:48 [PATCH V2 00/10] Add support for parsing per CPU Redistributor entry Shanker Donthineni
2016-06-26 17:48 ` [PATCH V2 01/10] arm/gic-v3: Fix bug in function cmp_rdist() Shanker Donthineni
2016-06-27 11:03   ` Julien Grall
2016-06-27 13:41     ` Shanker Donthineni
2016-06-26 17:48 ` [PATCH V2 02/10] arm/gic-v3: Do early GICD ioremap and clean up Shanker Donthineni
2016-06-27 11:08   ` Julien Grall
2016-06-26 17:48 ` [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function Shanker Donthineni
2016-06-27 11:26   ` Julien Grall
2016-06-27 13:50     ` Shanker Donthineni
2016-06-27 15:40     ` Shanker Donthineni
2016-06-27 15:41       ` Julien Grall
2016-06-27 16:07         ` Shanker Donthineni
2016-06-27 16:09           ` Julien Grall
2016-06-27 16:17             ` Shanker Donthineni
2016-06-27 16:20               ` Julien Grall
2016-06-26 17:48 ` [PATCH V2 04/10] arm/gic-v3: Parse per-cpu redistributor entry in GICC subtable Shanker Donthineni
2016-06-27 11:47   ` Julien Grall
2016-06-27 14:17     ` Shanker Donthineni
2016-06-27 15:13       ` Julien Grall
2016-06-26 17:48 ` [PATCH V2 05/10] xen/arm: vgic: Use dynamic memory allocation for vgic_rdist_region Shanker Donthineni
2016-06-27 12:38   ` Julien Grall
2016-06-27 12:43     ` Andrew Cooper [this message]
2016-06-27 14:28     ` Shanker Donthineni
2016-06-26 17:48 ` [PATCH V2 06/10] arm/gic-v3: Remove an unused macro MAX_RDIST_COUNT Shanker Donthineni
2016-06-27 13:52   ` Julien Grall
2016-06-26 17:48 ` [PATCH V2 07/10] arm: vgic: Split vgic_domain_init() functionality into two functions Shanker Donthineni
2016-06-27 12:45   ` Julien Grall
2016-06-26 17:48 ` [PATCH V2 08/10] arm/io: Use separate memory allocation for mmio handlers Shanker Donthineni
2016-06-27 13:55   ` Julien Grall
2016-06-26 17:48 ` [PATCH V2 09/10] xen/arm: io: Use binary search for mmio handler lookup Shanker Donthineni
2016-06-27 13:31   ` Julien Grall
2016-06-27 14:50     ` Shanker Donthineni
2016-06-27 15:27       ` Julien Grall
2016-06-26 17:48 ` [PATCH V2 10/10] arm/vgic: Change fixed number of mmio handlers to variable number Shanker Donthineni
2016-06-27 13:35   ` Julien Grall
2016-06-27 15:02     ` Shanker Donthineni
2016-06-28 10:51       ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=270a9df8-ebc2-44a9-6e02-fee799329532@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=julien.grall@arm.com \
    --cc=pelcan@codeaurora.org \
    --cc=shankerd@codeaurora.org \
    --cc=sstabellini@kernel.org \
    --cc=vikrams@codeaurora.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.