Re: [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function

From: Julien Grall <julien.grall@arm.com>
To: shankerd@codeaurora.org,
	xen-devel <xen-devel@lists.xensource.com>,
	Stefano Stabellini <sstabellini@kernel.org>
Cc: Philip Elcan <pelcan@codeaurora.org>,
	Vikram Sethi <vikrams@codeaurora.org>
Subject: Re: [PATCH V2 03/10] arm/gic-v3: Fold GICR subtable parsing into a new function
Date: Mon, 27 Jun 2016 17:09:01 +0100	[thread overview]
Message-ID: <57714F9D.2050307@arm.com> (raw)
In-Reply-To: <57714F55.9080606@codeaurora.org>

On 27/06/16 17:07, Shanker Donthineni wrote:
> On 06/27/2016 10:41 AM, Julien Grall wrote:
>>
>>
>> On 27/06/16 16:40, Shanker Donthineni wrote:
>>>>> +    gicv3.rdist_regions = rdist_regs;
>>>>> +
>>>>> +    /* Parse always-on power domain Re-distributor entries */
>>>>> +    count = acpi_parse_entries(ACPI_SIG_MADT,
>>>>> +                               sizeof(struct acpi_table_madt),
>>>>> + gic_acpi_parse_madt_redistributor,
>>>> table,
>>>>> + ACPI_MADT_TYPE_GENERIC_REDISTRIBUTOR,
>>>> count);
>>>>
>>>> Please use acpi_table_parse_madt here.
>>>>
>>>
>>> How do we pass MADT table pointer that we are using to a function
>>> acpi_table_parse_madt()?  We have already obtained  the MADT table
>>> address by calling  acpi_get_table() at the beginning of the function
>>> gicv3_acpi_init().
>>
>> You don't need to pass it. The function will take care to get the MADT
>> table for you.
>>
>
> Are you expecting me to modify current driver to replace
> acpi_parse_entries() calls with acpi_table_parse_madt() before my changes?

No, I was just suggesting to modify the caller you changed/added within 
the different patch.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel