[PATCH 1/1] libata: Initialize nbytes for internal sg commands

[PATCH 1/1] libata: Initialize nbytes for internal sg commands

[Brian King]

Some LLDDs, like ipr, use nbytes and pad_len to determine
the total data transfer length of a command. Make sure
nbytes gets initialized for internally generated commands.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---

Jeff,

This bug is already fixed in #upstream, with Tejun's patch,
which does away with nsect, but it is still broken in 2.6.20.
This is a resend of my original, 1 line patch. If this doesn't
make 2.6.20, it might be a candidate for -stable, since without
it, libata is not able to find SATA devices attached with ipr.

Thanks,

Brian

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
---

 linux-2.6-bjking1/drivers/ata/libata-core.c |    1 +
 1 files changed, 1 insertion(+)

diff -puN drivers/ata/libata-core.c~libata_fix_nbytes drivers/ata/libata-core.c
--- linux-2.6/drivers/ata/libata-core.c~libata_fix_nbytes	2007-01-30 11:24:20.000000000 -0600
+++ linux-2.6-bjking1/drivers/ata/libata-core.c	2007-01-30 11:24:20.000000000 -0600
@@ -1250,6 +1250,7 @@ unsigned ata_exec_internal_sg(struct ata
 
 		ata_sg_init(qc, sg, n_elem);
 		qc->nsect = buflen / ATA_SECT_SIZE;
+		qc->nbytes = buflen;
 	}
 
 	qc->private_data = &wait;
_

Re: [PATCH 1/1] libata: Initialize nbytes for internal sg commands

[Jeff Garzik]

Brian King wrote:
> Some LLDDs, like ipr, use nbytes and pad_len to determine
> the total data transfer length of a command. Make sure
> nbytes gets initialized for internally generated commands.
> 
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
> ---
> 
> Jeff,
> 
> This bug is already fixed in #upstream, with Tejun's patch,
> which does away with nsect, but it is still broken in 2.6.20.
> This is a resend of my original, 1 line patch. If this doesn't
> make 2.6.20, it might be a candidate for -stable, since without
> it, libata is not able to find SATA devices attached with ipr.
> 
> Thanks,
> 
> Brian
> 
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>

applied

Re: [PATCH 1/1] libata: Initialize nbytes for internal sg commands

[Tejun Heo]

Brian King wrote:
> Some LLDDs, like ipr, use nbytes and pad_len to determine
> the total data transfer length of a command. Make sure
> nbytes gets initialized for internally generated commands.
> 
> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>

Acked-by: Tejun Heo <htejun@gmail.com>

-- 
tejun