* [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-05-16 16:44 ` Alexandru Ardelean
0 siblings, 0 replies; 12+ messages in thread
From: Alexandru Ardelean @ 2023-05-16 16:44 UTC (permalink / raw)
To: dri-devel, linux-kernel
Cc: airlied, daniel, Bogdan Togorean, Alexandru Ardelean
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
---
drivers/gpu/drm/i2c/adv7511.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
index 61aa824d45d2..e016105a8fbe 100644
--- a/drivers/gpu/drm/i2c/adv7511.c
+++ b/drivers/gpu/drm/i2c/adv7511.c
@@ -729,8 +729,13 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.40.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-05-16 16:44 ` Alexandru Ardelean
0 siblings, 0 replies; 12+ messages in thread
From: Alexandru Ardelean @ 2023-05-16 16:44 UTC (permalink / raw)
To: dri-devel, linux-kernel; +Cc: Bogdan Togorean, Alexandru Ardelean
From: Bogdan Togorean <bogdan.togorean@analog.com>
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
---
drivers/gpu/drm/i2c/adv7511.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
index 61aa824d45d2..e016105a8fbe 100644
--- a/drivers/gpu/drm/i2c/adv7511.c
+++ b/drivers/gpu/drm/i2c/adv7511.c
@@ -729,8 +729,13 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.40.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-05-16 16:44 ` Alexandru Ardelean
@ 2023-07-13 20:08 ` Alexandru Ardelean
-1 siblings, 0 replies; 12+ messages in thread
From: Alexandru Ardelean @ 2023-07-13 20:08 UTC (permalink / raw)
To: dri-devel, linux-kernel; +Cc: airlied, daniel, Bogdan Togorean
On Tue, May 16, 2023 at 7:44 PM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
Ping on this patch :)
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
> drivers/gpu/drm/i2c/adv7511.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
> index 61aa824d45d2..e016105a8fbe 100644
> --- a/drivers/gpu/drm/i2c/adv7511.c
> +++ b/drivers/gpu/drm/i2c/adv7511.c
> @@ -729,8 +729,13 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-13 20:08 ` Alexandru Ardelean
0 siblings, 0 replies; 12+ messages in thread
From: Alexandru Ardelean @ 2023-07-13 20:08 UTC (permalink / raw)
To: dri-devel, linux-kernel; +Cc: Bogdan Togorean
On Tue, May 16, 2023 at 7:44 PM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
Ping on this patch :)
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> ---
> drivers/gpu/drm/i2c/adv7511.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c
> index 61aa824d45d2..e016105a8fbe 100644
> --- a/drivers/gpu/drm/i2c/adv7511.c
> +++ b/drivers/gpu/drm/i2c/adv7511.c
> @@ -729,8 +729,13 @@ static void adv7511_encoder_mode_set(struct drm_encoder *encoder,
> else
> low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
>
> - regmap_update_bits(adv7511->regmap, 0xfb,
> - 0x6, low_refresh_rate << 1);
> + if (adv7511->type == ADV7511)
> + regmap_update_bits(adv7511->regmap, 0xfb,
> + 0x6, low_refresh_rate << 1);
> + else
> + regmap_update_bits(adv7511->regmap, 0x4a,
> + 0xc, low_refresh_rate << 2);
> +
> regmap_update_bits(adv7511->regmap, 0x17,
> 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
>
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-05-16 16:44 ` Alexandru Ardelean
@ 2023-07-13 20:19 ` Fabio Estevam
-1 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2023-07-13 20:19 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: dri-devel, linux-kernel, Bogdan Togorean
On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Should this contain a Fixes tag so that it could be backported to
stable kernels?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-13 20:19 ` Fabio Estevam
0 siblings, 0 replies; 12+ messages in thread
From: Fabio Estevam @ 2023-07-13 20:19 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-kernel, dri-devel, Bogdan Togorean
On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
>
> From: Bogdan Togorean <bogdan.togorean@analog.com>
>
> For ADV7533 and ADV7535 low refresh rate is selected using
> bits [3:2] of 0x4a main register.
> So depending on ADV model write 0xfb or 0x4a register.
>
> Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Should this contain a Fixes tag so that it could be backported to
stable kernels?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-13 20:19 ` Fabio Estevam
@ 2023-07-14 7:51 ` Nuno Sá
-1 siblings, 0 replies; 12+ messages in thread
From: Nuno Sá @ 2023-07-14 7:51 UTC (permalink / raw)
To: Fabio Estevam, Alexandru Ardelean
Cc: dri-devel, linux-kernel, Bogdan Togorean
Hey Alex,
On Thu, 2023-07-13 at 17:19 -0300, Fabio Estevam wrote:
> On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
> >
> > From: Bogdan Togorean <bogdan.togorean@analog.com>
> >
> > For ADV7533 and ADV7535 low refresh rate is selected using
> > bits [3:2] of 0x4a main register.
> > So depending on ADV model write 0xfb or 0x4a register.
> >
> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
>
> Should this contain a Fixes tag so that it could be backported to
> stable kernels?
Yeah, most likely yes... With that:
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-14 7:51 ` Nuno Sá
0 siblings, 0 replies; 12+ messages in thread
From: Nuno Sá @ 2023-07-14 7:51 UTC (permalink / raw)
To: Fabio Estevam, Alexandru Ardelean
Cc: linux-kernel, dri-devel, Bogdan Togorean
Hey Alex,
On Thu, 2023-07-13 at 17:19 -0300, Fabio Estevam wrote:
> On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
> >
> > From: Bogdan Togorean <bogdan.togorean@analog.com>
> >
> > For ADV7533 and ADV7535 low refresh rate is selected using
> > bits [3:2] of 0x4a main register.
> > So depending on ADV model write 0xfb or 0x4a register.
> >
> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
>
> Should this contain a Fixes tag so that it could be backported to
> stable kernels?
Yeah, most likely yes... With that:
Reviewed-by: Nuno Sa <nuno.sa@analog.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
2023-07-14 7:51 ` Nuno Sá
@ 2023-07-18 6:17 ` Alexandru Ardelean
-1 siblings, 0 replies; 12+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 6:17 UTC (permalink / raw)
To: Nuno Sá; +Cc: linux-kernel, dri-devel, Bogdan Togorean
On Fri, Jul 14, 2023 at 10:48 AM Nuno Sá <noname.nuno@gmail.com> wrote:
>
> Hey Alex,
Hey Nuno :)
>
> On Thu, 2023-07-13 at 17:19 -0300, Fabio Estevam wrote:
> > On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
> > >
> > > From: Bogdan Togorean <bogdan.togorean@analog.com>
> > >
> > > For ADV7533 and ADV7535 low refresh rate is selected using
> > > bits [3:2] of 0x4a main register.
> > > So depending on ADV model write 0xfb or 0x4a register.
> > >
> > > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> >
> > Should this contain a Fixes tag so that it could be backported to
> > stable kernels?
>
> Yeah, most likely yes... With that:
I'll add one.
I seem to forget some upstreaming routines, since I started doing less
upstreaming.
Thanks
Alex
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2023-07-18 6:17 ` Alexandru Ardelean
0 siblings, 0 replies; 12+ messages in thread
From: Alexandru Ardelean @ 2023-07-18 6:17 UTC (permalink / raw)
To: Nuno Sá; +Cc: Fabio Estevam, dri-devel, linux-kernel, Bogdan Togorean
On Fri, Jul 14, 2023 at 10:48 AM Nuno Sá <noname.nuno@gmail.com> wrote:
>
> Hey Alex,
Hey Nuno :)
>
> On Thu, 2023-07-13 at 17:19 -0300, Fabio Estevam wrote:
> > On Wed, May 17, 2023 at 4:08 AM Alexandru Ardelean <alex@shruggie.ro> wrote:
> > >
> > > From: Bogdan Togorean <bogdan.togorean@analog.com>
> > >
> > > For ADV7533 and ADV7535 low refresh rate is selected using
> > > bits [3:2] of 0x4a main register.
> > > So depending on ADV model write 0xfb or 0x4a register.
> > >
> > > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > > Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
> >
> > Should this contain a Fixes tag so that it could be backported to
> > stable kernels?
>
> Yeah, most likely yes... With that:
I'll add one.
I seem to forget some upstreaming routines, since I started doing less
upstreaming.
Thanks
Alex
>
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
>
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2019-07-16 13:10 ` Bogdan Togorean
0 siblings, 0 replies; 12+ messages in thread
From: Bogdan Togorean @ 2019-07-16 13:10 UTC (permalink / raw)
To: a.hajda
Cc: Laurent.pinchart, airlied, daniel, sam, swinslow,
benjamin.gaignard, bogdan.togorean, tglx, matt.redfearn,
dri-devel, linux-kernel
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 9c8af882bf12: ("drm: Add adv7511 encoder driver")
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f6d2681f6927..4508a304d23f 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -756,8 +756,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.22.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5
@ 2019-07-16 13:10 ` Bogdan Togorean
0 siblings, 0 replies; 12+ messages in thread
From: Bogdan Togorean @ 2019-07-16 13:10 UTC (permalink / raw)
To: a.hajda
Cc: Laurent.pinchart, airlied, daniel, sam, swinslow,
benjamin.gaignard, bogdan.togorean, tglx, matt.redfearn,
dri-devel, linux-kernel
For ADV7533 and ADV7535 low refresh rate is selected using
bits [3:2] of 0x4a main register.
So depending on ADV model write 0xfb or 0x4a register.
Fixes: 9c8af882bf12: ("drm: Add adv7511 encoder driver")
Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f6d2681f6927..4508a304d23f 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -756,8 +756,13 @@ static void adv7511_mode_set(struct adv7511 *adv7511,
else
low_refresh_rate = ADV7511_LOW_REFRESH_RATE_NONE;
- regmap_update_bits(adv7511->regmap, 0xfb,
- 0x6, low_refresh_rate << 1);
+ if (adv7511->type == ADV7511)
+ regmap_update_bits(adv7511->regmap, 0xfb,
+ 0x6, low_refresh_rate << 1);
+ else
+ regmap_update_bits(adv7511->regmap, 0x4a,
+ 0xc, low_refresh_rate << 2);
+
regmap_update_bits(adv7511->regmap, 0x17,
0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
--
2.22.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-07-18 6:19 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-16 16:44 [PATCH] drm: adv7511: Fix low refresh rate register for ADV7533/5 Alexandru Ardelean
2023-05-16 16:44 ` Alexandru Ardelean
2023-07-13 20:08 ` Alexandru Ardelean
2023-07-13 20:08 ` Alexandru Ardelean
2023-07-13 20:19 ` Fabio Estevam
2023-07-13 20:19 ` Fabio Estevam
2023-07-14 7:51 ` Nuno Sá
2023-07-14 7:51 ` Nuno Sá
2023-07-18 6:17 ` Alexandru Ardelean
2023-07-18 6:17 ` Alexandru Ardelean
-- strict thread matches above, loose matches on Subject: below --
2019-07-16 13:10 Bogdan Togorean
2019-07-16 13:10 ` Bogdan Togorean
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.