All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
	"Loftus, Ciara" <ciara.loftus@intel.com>,
	"Liu, Yuanhan" <yuanhan.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] net/vhost: Add function to retreive the 'vid'	for a given port id.
Date: Thu, 29 Sep 2016 11:30:43 +0200	[thread overview]
Message-ID: <2712023.9XEuyBWnhG@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE20262576B@IRSMSX103.ger.corp.intel.com>

2016-09-29 09:21, Mcnamara, John:
> > In some cases when using the vHost PMD, certain vHost library functions
> > may still need to be accessed. One such example is the
> > rte_vhost_get_queue_num function which returns the number of virtqueues
> > reported by the guest - information which is not exposed by the PMD.
> > 
> > This commit introduces a new rte_eth_vhost function that returns the 'vid'
> > associated with a given port id. This allows the PMD user to call vHost
> > library functions which require the 'vid' value.
> > 
> > Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

A conclusion to this long thread:
This patch can be helpful in many situations where we need vhost lib when
using vhost PMD. And driver-specific API is acceptable. And this specific
function is not a candidate to be promoted in ethdev.
So it should go in release 16.11.

When overlooking the OVS issue related, this solution seems to be a
workaround. For next release, would it be possible to find a real fix
for vhost PMD and/or ethdev API instead of relying on vhost lib?

  reply	other threads:[~2016-09-29  9:30 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13 13:47 [PATCH] net/vhost: Add function to retreive the 'vid' for a given port id Ciara Loftus
2016-09-13 15:10 ` Thomas Monjalon
2016-09-14  4:43   ` Yuanhan Liu
2016-09-14  7:10     ` Thomas Monjalon
2016-09-14  7:21       ` Yuanhan Liu
2016-09-14  8:35         ` Thomas Monjalon
2016-09-18  8:27           ` Yuanhan Liu
2016-09-21 13:07             ` Thomas Monjalon
2016-09-22  2:36               ` Yuanhan Liu
2016-09-22 16:43                 ` Thomas Monjalon
2016-09-23  4:26                   ` Yuanhan Liu
2016-09-23  8:43                     ` Thomas Monjalon
2016-09-23  9:16                       ` Yuanhan Liu
2016-09-23  9:26                         ` Loftus, Ciara
2016-09-23 21:23                     ` Wiles, Keith
2016-09-26  3:19                       ` Yuanhan Liu
2016-09-26 13:12                       ` Thomas Monjalon
2016-09-26 13:18                         ` Bruce Richardson
2016-09-26 14:26                           ` Thomas Monjalon
2016-09-26 14:34                             ` Bruce Richardson
2016-09-26 16:24                               ` Iremonger, Bernard
2016-09-26 16:55                                 ` Thomas Monjalon
2016-09-26 17:05                                 ` Wiles, Keith
2016-09-28 16:59   ` Mcnamara, John
2016-09-29  9:21 ` Mcnamara, John
2016-09-29  9:30   ` Thomas Monjalon [this message]
2016-09-29 12:08   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2712023.9XEuyBWnhG@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=yuanhan.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.