* [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity
@ 2020-06-12 7:29 ` Ludovic Barre
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Barre @ 2020-06-12 7:29 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier, Rob Herring
Cc: Maxime Coquelin, Alexandre Torgue, linux-kernel,
linux-arm-kernel, devicetree, Ludovic Barre
exti hardware point of view, there is no specific action on set_affinity.
So the affinity must be forwarded to parent if there is a
descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.
Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
---
drivers/irqchip/irq-stm32-exti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index faa8482c8246..1a0a60ee7140 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
if (d->parent_data->chip)
return irq_chip_set_affinity_parent(d, dest, force);
- return -EINVAL;
+ return IRQ_SET_MASK_OK_DONE;
}
static int __maybe_unused stm32_exti_h_suspend(void)
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity
@ 2020-06-12 7:29 ` Ludovic Barre
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Barre @ 2020-06-12 7:29 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier, Rob Herring
Cc: devicetree, Alexandre Torgue, linux-kernel, Ludovic Barre,
Maxime Coquelin, linux-arm-kernel
exti hardware point of view, there is no specific action on set_affinity.
So the affinity must be forwarded to parent if there is a
descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.
Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
---
drivers/irqchip/irq-stm32-exti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
index faa8482c8246..1a0a60ee7140 100644
--- a/drivers/irqchip/irq-stm32-exti.c
+++ b/drivers/irqchip/irq-stm32-exti.c
@@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
if (d->parent_data->chip)
return irq_chip_set_affinity_parent(d, dest, force);
- return -EINVAL;
+ return IRQ_SET_MASK_OK_DONE;
}
static int __maybe_unused stm32_exti_h_suspend(void)
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity
2020-06-12 7:29 ` Ludovic Barre
@ 2020-09-21 9:26 ` Ludovic BARRE
-1 siblings, 0 replies; 4+ messages in thread
From: Ludovic BARRE @ 2020-09-21 9:26 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier, Rob Herring
Cc: Maxime Coquelin, Alexandre Torgue, linux-kernel,
linux-arm-kernel, devicetree
Hi Marc
Just a gentleman ping about this patch.
I verified, you could always apply this patch on linux master branch.
Regards
Ludo
Le 6/12/20 à 9:29 AM, Ludovic Barre a écrit :
> exti hardware point of view, there is no specific action on set_affinity.
> So the affinity must be forwarded to parent if there is a
> descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
> drivers/irqchip/irq-stm32-exti.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index faa8482c8246..1a0a60ee7140 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
> if (d->parent_data->chip)
> return irq_chip_set_affinity_parent(d, dest, force);
>
> - return -EINVAL;
> + return IRQ_SET_MASK_OK_DONE;
> }
>
> static int __maybe_unused stm32_exti_h_suspend(void)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity
@ 2020-09-21 9:26 ` Ludovic BARRE
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic BARRE @ 2020-09-21 9:26 UTC (permalink / raw)
To: Thomas Gleixner, Jason Cooper, Marc Zyngier, Rob Herring
Cc: linux-arm-kernel, devicetree, Alexandre Torgue, Maxime Coquelin,
linux-kernel
Hi Marc
Just a gentleman ping about this patch.
I verified, you could always apply this patch on linux master branch.
Regards
Ludo
Le 6/12/20 à 9:29 AM, Ludovic Barre a écrit :
> exti hardware point of view, there is no specific action on set_affinity.
> So the affinity must be forwarded to parent if there is a
> descendent irqchips, otherwise just return IRQ_SET_MASK_OK_DONE.
>
> Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
> ---
> drivers/irqchip/irq-stm32-exti.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c
> index faa8482c8246..1a0a60ee7140 100644
> --- a/drivers/irqchip/irq-stm32-exti.c
> +++ b/drivers/irqchip/irq-stm32-exti.c
> @@ -555,7 +555,7 @@ static int stm32_exti_h_set_affinity(struct irq_data *d,
> if (d->parent_data->chip)
> return irq_chip_set_affinity_parent(d, dest, force);
>
> - return -EINVAL;
> + return IRQ_SET_MASK_OK_DONE;
> }
>
> static int __maybe_unused stm32_exti_h_suspend(void)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-09-21 9:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-12 7:29 [PATCH] irqchip/stm32: fix return value of stm32_exti_h_set_affinity Ludovic Barre
2020-06-12 7:29 ` Ludovic Barre
2020-09-21 9:26 ` Ludovic BARRE
2020-09-21 9:26 ` Ludovic BARRE
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.