Re: [PATCH v9 07/21] virt: geniezone: Add vm capability check - Yi-De Wu (吳一德)

From: "Yi-De Wu (吳一德)" <Yi-De.Wu@mediatek.com>
To: "corbet@lwn.net" <corbet@lwn.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	"Yingshiuan Pan (潘穎軒)" <Yingshiuan.Pan@mediatek.com>,
	"krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>,
	"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
	"Ze-yu Wang (王澤宇)" <Ze-yu.Wang@mediatek.com>,
	"angelogioacchino.delregno@collabora.com"
	<angelogioacchino.delregno@collabora.com>,
	"will@kernel.org" <will@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>,
	"quic_tsoni@quicinc.com" <quic_tsoni@quicinc.com>,
	"MY Chuang (莊明躍)" <MY.Chuang@mediatek.com>,
	"Kevenny Hsieh (謝宜芸)" <Kevenny.Hsieh@mediatek.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"PeiLun Suei (隋培倫)" <PeiLun.Suei@mediatek.com>,
	"Liju-clr Chen (陳麗如)" <Liju-clr.Chen@mediatek.com>,
	"dbrazdil@google.com" <dbrazdil@google.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Shawn Hsiao (蕭志祥)" <shawn.hsiao@mediatek.com>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"Chi-shen Yeh (葉奇軒)" <Chi-shen.Yeh@mediatek.com>
Subject: Re: [PATCH v9 07/21] virt: geniezone: Add vm capability check
Date: Wed, 3 Apr 2024 08:50:00 +0000	[thread overview]
Message-ID: <27258baa96e7ff3701ee56e86dd649756da2c70c.camel@mediatek.com> (raw)
In-Reply-To: <c027bf67-e9b2-4eb2-9dee-a47a9c3bdd8a@collabora.com>

On Thu, 2024-02-01 at 10:44 +0100, AngeloGioacchino Del Regno wrote:
> Il 29/01/24 09:32, Yi-De Wu ha scritto:
> > From: "Yingshiuan Pan" <yingshiuan.pan@mediatek.com>
> > 
> > Inquire the `capability support` on GenieZone hypervisor.
> > Example:
> > `GZVM_CAP_PROTECTED_VM` or `GZVM_CAP_VM_GPA_SIZE`.
> > 
> > Signed-off-by: Yingshiuan Pan <yingshiuan.pan@mediatek.com>
> > Signed-off-by: Jerry Wang <ze-yu.wang@mediatek.com>
> > Signed-off-by: kevenny hsieh <kevenny.hsieh@mediatek.com>
> > Signed-off-by: Liju Chen <liju-clr.chen@mediatek.com>
> > Signed-off-by: Yi-De Wu <yi-de.wu@mediatek.com>
> > ---
> >   arch/arm64/geniezone/gzvm_arch_common.h |   2 +
> >   arch/arm64/geniezone/vm.c               | 122
> > ++++++++++++++++++++++++
> >   drivers/virt/geniezone/gzvm_main.c      |  27 ++++++
> >   drivers/virt/geniezone/gzvm_vm.c        |  21 ++++
> >   include/linux/gzvm_drv.h                |   5 +
> >   include/uapi/linux/gzvm.h               |  31 ++++++
> >   6 files changed, 208 insertions(+)
> > 
> > diff --git a/arch/arm64/geniezone/gzvm_arch_common.h
> > b/arch/arm64/geniezone/gzvm_arch_common.h
> > index 2f66e496dfae..383af0829f11 100644
> > --- a/arch/arm64/geniezone/gzvm_arch_common.h
> > +++ b/arch/arm64/geniezone/gzvm_arch_common.h
> > @@ -13,6 +13,7 @@ enum {
> >   	GZVM_FUNC_DESTROY_VM = 1,
> >   	GZVM_FUNC_SET_MEMREGION = 4,
> >   	GZVM_FUNC_PROBE = 12,
> > +	GZVM_FUNC_ENABLE_CAP = 13,
> 
> GZVM_FUNC_PROBE  = 12,
> GZVM_FUNC_ENABLE_CAP,
> 

Given that this is an API from the kernel to the hypervisor, it may be
utilized with various toolchains. Our intention is to explicitly assign
values to prevent any unexpected compiler behavior. For further
details, we'd like to refer to the discussion below.

https://lore.kernel.org/all/20200318125003.GA2727094@kroah.com/

> >   	NR_GZVM_FUNC,
> >   };
> >   
> 
> Regards,
> Angelo
> 