From: Christian Schoenebeck via Qemu-devel <qemu-devel@nongnu.org>
To: qemu-devel@nongnu.org
Cc: berrange@redhat.com, stefanha@gmail.com,
Christian Schoenebeck <qemu_oss@crudebyte.com>,
Greg Kurz <groug@kaod.org>,
dgilbert@redhat.com, antonios.motakis@huawei.com
Subject: Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions
Date: Tue, 03 Sep 2019 00:29:43 +0200 [thread overview]
Message-ID: <2734436.Mu773bgsdE@silver> (raw)
In-Reply-To: <20190902173432.20f2637b@bahia.lan>
On Montag, 2. September 2019 17:34:32 CEST Greg Kurz wrote:
> On Sun, 01 Sep 2019 21:28:45 +0200
>
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > On Donnerstag, 29. August 2019 19:02:34 CEST Greg Kurz wrote:
> > > On Thu, 22 Aug 2019 15:18:54 -0700 (PDT)
> > >
> > > no-reply@patchew.org wrote:
> > > > Patchew URL:
> > > > https://patchew.org/QEMU/cover.1566503584.git.qemu_oss@crudebyte.com/
> > > >
> > > >
> > > >
> > > > Hi,
> > > >
> > > > This series seems to have some coding style problems. See output below
> > > > for
> >
> > > > more information:
> > [snip]
> >
> > > > === OUTPUT BEGIN ===
> > > > 1/4 Checking commit bb69de63f788 (9p: Treat multiple devices on one
> > > > export
> > > > as an error) ERROR: Author email address is mangled by the mailing
> > > > list
> > > > #2:
> > > > Author: Christian Schoenebeck via Qemu-devel <qemu-devel@nongnu.org>
> > >
> > > This is problematic since it ends up in the Author: field in git. Please
> > > find a way to fix that.
> >
> > Like in which way do you imagine that? And where is the actual practical
> > problem? I mean every patch still has my signed-off-by tag with the
> > correct
> > email address ending up in git history.
>
> Yes, this only breaks Author: if the patch is applied from the list.
>
> > The cause for this issue is that the domain is configured to require DKIM
> > signatures for all outgoing emails. That's why mailman replaces my address
> > by "Christian Schoenebeck via Qemu-devel <qemu-devel@nongnu.org>"
> > placeholder since it could not provide a valid signature.
> >
> > There were good reasons for enabling DKIM and it is a good thing for all
> > domains in general, since that ensures that (i.e. foreign) email addresses
> > cannot be used as sender address if the actual sender is not authorized
> > for
> > sending emails with that address.
>
> Don't know much about DKIM but google seems to confirm what you say.
When you view the source of my emails you'll always see a "DKIM-Signature:"
field in the email header, which is a signature of the email's body and the
specific email header fields listed in the "DKIM-Signature:" block, so the
original server can choose by itself which header fields to include ("h=...")
for signing, but the standard requires the From: field must always be
included.
A receiving server then obtains the public key from the domain's DNS records
and checks if the DKIM signature of the email was correct:
https://en.wikipedia.org/wiki/DomainKeys_Identified_Mail
Additionally the receiving server obtains the so called "DMARC" entry from the
domain's DNS records. The "DMARC" DNS entry contains the domain's general
policies how receiving email servers shall handle verification of emails of
this domain. For instance the DMARC entry may list SMTP servers (e.g. IPs, DNS
names) eligble to send emails on behalf of the domain at all, and it defines
what receiving email servers shall do with emails which were identified of not
being from an eligible source (e.g. sender IP not listed in DMARC entry or
missing or wrong DKIM signature in email header). For instance if the policy
is "quarantine" in the DMARC entry then receiving servers are advised to
simply drop invalid emails: https://en.wikipedia.org/wiki/DMARC
> So, this means that patchew will complain each time you post if we can't
> find a proper way to address that... :-\
Well, mailman is handling this correctly. It replaces the "From:" field with a
placeholder and instead adds my actual email address as "Reply-To:" field.
That's the common way to handle this on mailing lists, as also mentioned here:
https://en.wikipedia.org/wiki/DMARC#From:_rewriting
So IMO patchew should automatically use the value of "Reply-To:" in that case
as author of patches instead.
Reducing security cannot be the solution.
> > What I changed in the meantime though is that you should get all my
> > patches
> > directly to your personal address, not only from the list. Or did you
> > receive v6 again just from the list?
>
> I've received the patches in my mailbox but I prefer to use the patchwork's
> pwclient CLI to apply patches... and patchwork captures the patches from
> the list, so I end up having to patch the authorship manually anyway.
>
> How are you sending patches ? With git send-email ? If so, maybe you can
> pass something like --from='"Christian Schoenebeck"
> <qemu_oss@crudebyte.com>'. Since this is a different string, git will
> assume you're sending someone else's patch : it will automatically add an
> extra From: made out of the commit Author as recorded in the git tree.
I use "git format-patch ..." to dump the invidiual emails as raw email sources
and then I'll send those raw emails from the command line. So I have even more
control of what is exactly sent out and could of course also add custom email
header fields if required, if that would solve the situation somehow, i.e.
manually as first test and later in automated way. That's not the issue here.
The problem however is that there is probably not any header field I could add
that would solve the problem. Because I guess patchew is really just taking
the first "From:" field as author, period.
I think the source files are available, so I could check that.
> > > Other warnings/errors should also be fixed but they look trivial.
> >
> > Yeah, they are trivial. *But* there is one thing ...
> >
> > > > Author: Christian Schoenebeck via Qemu-devel <qemu-devel@nongnu.org>
> > > >
> > > > ERROR: space prohibited after that open parenthesis '('
> > > > #92: FILE: hw/9pfs/9p.c:586:
> > > > + return ((uint64_t)mirror8bit( value & 0xff) << 56) |
> > > >
> > > > ERROR: space prohibited before that close parenthesis ')'
> > > > #98: FILE: hw/9pfs/9p.c:592:
> > > > + ((uint64_t)mirror8bit((value >> 48) & 0xff) << 8 ) |
> > > >
> > > > ERROR: space prohibited before that close parenthesis ')'
> > > > #99: FILE: hw/9pfs/9p.c:593:
> > > > + ((uint64_t)mirror8bit((value >> 56) & 0xff) ) ;
> >
> > ... I would like to ignore this specific bot whining, because that
> > particular function looks much more readable the way it is (in that
> > patch) right now.
> Prettier certainly but...
>
> /* Same as mirror8bit() just for a 64 bit data type instead for a byte. */
> static inline uint64_t mirror64bit(uint64_t value)
> {
> return ((uint64_t)mirror8bit(value & 0xff) << 56) |
> ((uint64_t)mirror8bit((value >> 8) & 0xff) << 48) |
> ((uint64_t)mirror8bit((value >> 16) & 0xff) << 40) |
> ((uint64_t)mirror8bit((value >> 24) & 0xff) << 32) |
> ((uint64_t)mirror8bit((value >> 32) & 0xff) << 24) |
> ((uint64_t)mirror8bit((value >> 40) & 0xff) << 16) |
> ((uint64_t)mirror8bit((value >> 48) & 0xff) << 8) |
> ((uint64_t)mirror8bit((value >> 56) & 0xff));
> }
>
> ... is readable enough IMHO and makes checkpatch happy :)
Well, okay :)
next prev parent reply other threads:[~2019-09-02 22:31 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 19:53 [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions Christian Schoenebeck via Qemu-devel
2019-08-22 19:28 ` [Qemu-devel] [PATCH v6 1/4] 9p: Treat multiple devices on one export as an error Christian Schoenebeck via Qemu-devel
2019-08-29 16:27 ` Greg Kurz
2019-09-01 17:38 ` Christian Schoenebeck via Qemu-devel
2019-08-22 19:33 ` [Qemu-devel] [PATCH v6 2/4] 9p: Added virtfs option 'multidevs=remap|forbid|warn' Christian Schoenebeck via Qemu-devel
2019-08-29 16:55 ` Greg Kurz
2019-09-01 18:40 ` Christian Schoenebeck via Qemu-devel
2019-09-02 10:16 ` Greg Kurz
2019-09-02 21:07 ` Christian Schoenebeck via Qemu-devel
2019-08-30 12:22 ` Greg Kurz
2019-09-01 18:56 ` Christian Schoenebeck via Qemu-devel
2019-09-02 11:49 ` Greg Kurz
2019-09-02 21:25 ` Christian Schoenebeck via Qemu-devel
2019-08-22 19:44 ` [Qemu-devel] [PATCH v6 3/4] 9p: stat_to_qid: implement slow path Christian Schoenebeck via Qemu-devel
2019-08-22 19:49 ` [Qemu-devel] [PATCH v6 4/4] 9p: Use variable length suffixes for inode remapping Christian Schoenebeck via Qemu-devel
2019-08-22 22:18 ` [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions no-reply
2019-08-29 17:02 ` Greg Kurz
2019-09-01 19:28 ` Christian Schoenebeck via Qemu-devel
2019-09-02 15:34 ` Greg Kurz
2019-09-02 22:29 ` Christian Schoenebeck via Qemu-devel [this message]
2019-09-03 19:11 ` [Qemu-devel] DMARC/DKIM and qemu-devel list settings Ian Kelling
2019-09-04 8:13 ` Daniel P. Berrangé
2019-09-04 14:19 ` Ian Kelling
2019-09-04 14:30 ` Peter Maydell
2019-09-09 11:47 ` Markus Armbruster
2019-09-10 7:23 ` Stefan Hajnoczi
2019-09-03 19:38 ` [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions Eric Blake
2019-09-04 13:02 ` Christian Schoenebeck via Qemu-devel
2019-09-05 12:25 ` Christian Schoenebeck via Qemu-devel
2019-09-05 12:59 ` Greg Kurz
2019-09-23 11:27 ` Christian Schoenebeck via
2019-09-09 14:05 ` Eric Blake
2019-09-09 14:05 ` Eric Blake
2019-09-09 14:25 ` Jeff King
2019-09-09 14:25 ` Jeff King
2019-09-23 11:19 ` Christian Schoenebeck
2019-09-23 11:19 ` Christian Schoenebeck via
2019-09-23 22:24 ` Jeff King
2019-09-23 22:24 ` Jeff King
2019-09-24 9:03 ` git format.from (was: 9p: Fix file ID collisions) Christian Schoenebeck
2019-09-24 9:03 ` Christian Schoenebeck via
2019-09-24 21:36 ` Jeff King
2019-09-24 21:36 ` Jeff King
2019-09-09 18:41 ` [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions Junio C Hamano
2019-09-09 18:41 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2734436.Mu773bgsdE@silver \
--to=qemu-devel@nongnu.org \
--cc=antonios.motakis@huawei.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=qemu_oss@crudebyte.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.