All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Paul Cercueil <paul@crapouillou.net>,
	rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Maarten ter Huurne <maarten@treewalker.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@linux-mips.org
Subject: Re: [PATCH v2 2/7] Documentation: dt: Add binding info for jz4740-rtc driver
Date: Mon, 31 Oct 2016 12:48:36 +0300	[thread overview]
Message-ID: <27537b7b-2485-d51c-b2e1-cfd6ba29e5bf@cogentembedded.com> (raw)
In-Reply-To: <20161030230247.20538-3-paul@crapouillou.net>

Hello.

On 10/31/2016 2:02 AM, Paul Cercueil wrote:

> This commit adds documentation for the device-tree bindings of the
> jz4740-rtc driver, which supports the RTC unit present in the JZ4740 and
> JZ4780 SoCs from Ingenic.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Acked-by: Maarten ter Huurne <maarten@treewalker.org>
> ---
>  .../devicetree/bindings/rtc/ingenic,jz4740-rtc.txt | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
>
> v2:
> - Remove 'interrupt-parent' of the list of required properties
> - Add the -msec suffix for the DT entries that represent time
>
> diff --git a/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
> new file mode 100644
> index 0000000..df97594
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
> @@ -0,0 +1,37 @@
[...]
> +Example:
> +
> +rtc@10003000 {
> +	compatible = "ingenic,jz4740-rtc";
> +	reg = <0x10003000 0x3F>;

    Are you sure it's not 0x40? It's a size, not a limit...

[...]

MBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Paul Cercueil <paul@crapouillou.net>,
	rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Maarten ter Huurne <maarten@treewalker.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mips@linux-mips.org
Subject: [rtc-linux] Re: [PATCH v2 2/7] Documentation: dt: Add binding info for jz4740-rtc driver
Date: Mon, 31 Oct 2016 12:48:36 +0300	[thread overview]
Message-ID: <27537b7b-2485-d51c-b2e1-cfd6ba29e5bf@cogentembedded.com> (raw)
In-Reply-To: <20161030230247.20538-3-paul@crapouillou.net>

Hello.

On 10/31/2016 2:02 AM, Paul Cercueil wrote:

> This commit adds documentation for the device-tree bindings of the
> jz4740-rtc driver, which supports the RTC unit present in the JZ4740 and
> JZ4780 SoCs from Ingenic.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Acked-by: Maarten ter Huurne <maarten@treewalker.org>
> ---
>  .../devicetree/bindings/rtc/ingenic,jz4740-rtc.txt | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
>
> v2:
> - Remove 'interrupt-parent' of the list of required properties
> - Add the -msec suffix for the DT entries that represent time
>
> diff --git a/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
> new file mode 100644
> index 0000000..df97594
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
> @@ -0,0 +1,37 @@
[...]
> +Example:
> +
> +rtc@10003000 {
> +	compatible = "ingenic,jz4740-rtc";
> +	reg = <0x10003000 0x3F>;

    Are you sure it's not 0x40? It's a size, not a limit...

[...]

MBR, Sergei

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Paul Cercueil <paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org>,
	rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Alessandro Zummo
	<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
	Alexandre Belloni
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Ralf Baechle <ralf-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
	Maarten ter Huurne
	<maarten-Ph2Y2OKCxY1M656bX5wj8A@public.gmane.org>,
	Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org
Subject: Re: [PATCH v2 2/7] Documentation: dt: Add binding info for jz4740-rtc driver
Date: Mon, 31 Oct 2016 12:48:36 +0300	[thread overview]
Message-ID: <27537b7b-2485-d51c-b2e1-cfd6ba29e5bf@cogentembedded.com> (raw)
In-Reply-To: <20161030230247.20538-3-paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org>

Hello.

On 10/31/2016 2:02 AM, Paul Cercueil wrote:

> This commit adds documentation for the device-tree bindings of the
> jz4740-rtc driver, which supports the RTC unit present in the JZ4740 and
> JZ4780 SoCs from Ingenic.
>
> Signed-off-by: Paul Cercueil <paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org>
> Acked-by: Maarten ter Huurne <maarten-Ph2Y2OKCxY1M656bX5wj8A@public.gmane.org>
> ---
>  .../devicetree/bindings/rtc/ingenic,jz4740-rtc.txt | 37 ++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
>
> v2:
> - Remove 'interrupt-parent' of the list of required properties
> - Add the -msec suffix for the DT entries that represent time
>
> diff --git a/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
> new file mode 100644
> index 0000000..df97594
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/ingenic,jz4740-rtc.txt
> @@ -0,0 +1,37 @@
[...]
> +Example:
> +
> +rtc@10003000 {
> +	compatible = "ingenic,jz4740-rtc";
> +	reg = <0x10003000 0x3F>;

    Are you sure it's not 0x40? It's a size, not a limit...

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-10-31  9:48 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-30 23:02 [PATCH v2 0/7] DT bindings for the jz4740-rtc driver Paul Cercueil
2016-10-30 23:02 ` Paul Cercueil
2016-10-30 23:02 ` [rtc-linux] " Paul Cercueil
2016-10-30 23:02 ` [PATCH v2 1/7] rtc: rtc-jz4740: Add support for the RTC in the jz4780 SoC Paul Cercueil
2016-10-30 23:02   ` Paul Cercueil
2016-10-30 23:02   ` [rtc-linux] " Paul Cercueil
2016-10-30 23:02 ` [PATCH v2 2/7] Documentation: dt: Add binding info for jz4740-rtc driver Paul Cercueil
2016-10-30 23:02   ` Paul Cercueil
2016-10-30 23:02   ` [rtc-linux] " Paul Cercueil
2016-10-31  6:39   ` Rob Herring
2016-10-31  6:39     ` Rob Herring
2016-10-31  6:39     ` [rtc-linux] " Rob Herring
2016-10-31  9:48   ` Sergei Shtylyov [this message]
2016-10-31  9:48     ` Sergei Shtylyov
2016-10-31  9:48     ` [rtc-linux] " Sergei Shtylyov
2016-10-30 23:02 ` [PATCH v2 3/7] rtc: rtc-jz4740: Add support for devicetree Paul Cercueil
2016-10-30 23:02   ` Paul Cercueil
2016-10-30 23:02   ` [rtc-linux] " Paul Cercueil
2016-10-30 23:02 ` [PATCH v2 4/7] rtc: jz4740_rtc: Add support for acting as the system power controller Paul Cercueil
2016-10-30 23:02   ` Paul Cercueil
2016-10-30 23:02   ` [rtc-linux] " Paul Cercueil
2016-10-30 23:02 ` [PATCH v2 5/7] MIPS: jz4740: DTS: Probe the jz4740-rtc driver from devicetree Paul Cercueil
2016-10-30 23:02   ` Paul Cercueil
2016-10-30 23:02   ` [rtc-linux] " Paul Cercueil
2016-10-31  9:50   ` Sergei Shtylyov
2016-10-31  9:50     ` Sergei Shtylyov
2016-10-31  9:50     ` [rtc-linux] " Sergei Shtylyov
2016-10-30 23:02 ` [PATCH v2 6/7] MIPS: qi_lb60: Probe RTC driver from DT and use it as power controller Paul Cercueil
2016-10-30 23:02   ` Paul Cercueil
2016-10-30 23:02   ` [rtc-linux] " Paul Cercueil
2016-10-30 23:02 ` [PATCH v2 7/7] MIPS: jz4740: Remove obsolete code Paul Cercueil
2016-10-30 23:02   ` Paul Cercueil
2016-10-30 23:02   ` [rtc-linux] " Paul Cercueil
2016-10-31 20:39 ` [PATCH v3 1/7] rtc: rtc-jz4740: Add support for the RTC in the jz4780 SoC Paul Cercueil
2016-10-31 20:39   ` [rtc-linux] " Paul Cercueil
2016-10-31 20:39   ` [PATCH v3 2/7] Documentation: dt: Add binding info for jz4740-rtc driver Paul Cercueil
2016-10-31 20:39     ` Paul Cercueil
2016-10-31 20:39     ` [rtc-linux] " Paul Cercueil
2016-10-31 21:16     ` Rob Herring
2016-10-31 21:16       ` Rob Herring
2016-10-31 21:16       ` [rtc-linux] " Rob Herring
2016-10-31 20:39   ` [PATCH v3 3/7] rtc: rtc-jz4740: Add support for devicetree Paul Cercueil
2016-10-31 20:39     ` Paul Cercueil
2016-10-31 20:39     ` [rtc-linux] " Paul Cercueil
2016-10-31 20:39   ` [PATCH v3 4/7] rtc: jz4740_rtc: Add support for acting as the system power controller Paul Cercueil
2016-10-31 20:39     ` [rtc-linux] " Paul Cercueil
2016-10-31 20:39   ` [PATCH v3 5/7] MIPS: jz4740: DTS: Probe the jz4740-rtc driver from devicetree Paul Cercueil
2016-10-31 20:39     ` Paul Cercueil
2016-10-31 20:39     ` [rtc-linux] " Paul Cercueil
2016-10-31 20:39   ` [PATCH v3 6/7] MIPS: qi_lb60: Probe RTC driver from DT and use it as power controller Paul Cercueil
2016-10-31 20:39     ` Paul Cercueil
2016-10-31 20:39     ` [rtc-linux] " Paul Cercueil
2016-10-31 20:39   ` [PATCH v3 7/7] MIPS: jz4740: Remove obsolete code Paul Cercueil
2016-10-31 20:39     ` Paul Cercueil
2016-10-31 20:39     ` [rtc-linux] " Paul Cercueil
2016-11-04 23:08   ` [PATCH v3 1/7] rtc: rtc-jz4740: Add support for the RTC in the jz4780 SoC Alexandre Belloni
2016-11-04 23:08     ` Alexandre Belloni
2016-11-04 23:08     ` [rtc-linux] " Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27537b7b-2485-d51c-b2e1-cfd6ba29e5bf@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=maarten@treewalker.org \
    --cc=mark.rutland@arm.com \
    --cc=paul@crapouillou.net \
    --cc=ralf@linux-mips.org \
    --cc=robh+dt@kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.