[PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[Rashika Kheria]

Marks the function acpi_table_checksum() as static in osl.c
because it is not used outside this file.

This eliminates the following warning in osl.c:
drivers/acpi/osl.c:547:11: warning: no previous prototype for ‘acpi_table_checksum’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/osl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 54a20ff..1f4c104 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
 static int all_tables_size;
 
 /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
-u8 __init acpi_table_checksum(u8 *buffer, u32 length)
+static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
 {
 	u8 sum = 0;
 	u8 *end = buffer + length;
-- 
1.7.9.5

[PATCH 02/11] drivers: acpi: Include appropriate header file in nvs.c

[Rashika Kheria]

Include header file internal.h in nvs.c because functions
suspend_nvs_free(), suspend_nvs_alloc(), suspend_nvs_save() and
suspend_nvs_restore() have their prototype declaration in internal.h.

This eliminates the following warnings in nvs.c:
drivers/acpi/nvs.c:128:6: warning: no previous prototype for ‘suspend_nvs_free’ [-Wmissing-prototypes]
drivers/acpi/nvs.c:152:5: warning: no previous prototype for ‘suspend_nvs_alloc’ [-Wmissing-prototypes]
drivers/acpi/nvs.c:169:5: warning: no previous prototype for ‘suspend_nvs_save’ [-Wmissing-prototypes]
drivers/acpi/nvs.c:201:6: warning: no previous prototype for ‘suspend_nvs_restore’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/nvs.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/nvs.c b/drivers/acpi/nvs.c
index 386a9fe..5841914 100644
--- a/drivers/acpi/nvs.c
+++ b/drivers/acpi/nvs.c
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/acpi.h>
 #include <linux/acpi_io.h>
+#include "internal.h"
 
 /* ACPI NVS regions, APEI may use it */
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 02/11] drivers: acpi: Include appropriate header file in nvs.c

[Rashika Kheria]

Include header file internal.h in nvs.c because functions
suspend_nvs_free(), suspend_nvs_alloc(), suspend_nvs_save() and
suspend_nvs_restore() have their prototype declaration in internal.h.

This eliminates the following warnings in nvs.c:
drivers/acpi/nvs.c:128:6: warning: no previous prototype for ‘suspend_nvs_free’ [-Wmissing-prototypes]
drivers/acpi/nvs.c:152:5: warning: no previous prototype for ‘suspend_nvs_alloc’ [-Wmissing-prototypes]
drivers/acpi/nvs.c:169:5: warning: no previous prototype for ‘suspend_nvs_save’ [-Wmissing-prototypes]
drivers/acpi/nvs.c:201:6: warning: no previous prototype for ‘suspend_nvs_restore’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/nvs.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/nvs.c b/drivers/acpi/nvs.c
index 386a9fe..5841914 100644
--- a/drivers/acpi/nvs.c
+++ b/drivers/acpi/nvs.c
@@ -13,6 +13,7 @@
 #include <linux/slab.h>
 #include <linux/acpi.h>
 #include <linux/acpi_io.h>
+#include "internal.h"
 
 /* ACPI NVS regions, APEI may use it */
 
-- 
1.7.9.5

[PATCH 03/11] drivers: acpi: Mark the function acpi_ec_add_debugfs() as static in ec_sys.c

Mark the function acpi_ec_add_debugfs() as static in
ec_sys.c because it is not used outside this file.

This eliminates the following warning in ec_sys.c:
drivers/acpi/ec_sys.c:108:5: warning: no previous prototype for ‘acpi_ec_add_debugfs’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/ec_sys.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
index 4e7b798..b4c216b 100644
--- a/drivers/acpi/ec_sys.c
+++ b/drivers/acpi/ec_sys.c
@@ -105,7 +105,7 @@ static const struct file_operations acpi_ec_io_ops = {
 	.llseek = default_llseek,
 };
 
-int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
+static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
 {
 	struct dentry *dev_dir;
 	char name[64];
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 03/11] drivers: acpi: Mark the function acpi_ec_add_debugfs() as static in ec_sys.c

[Rashika Kheria]

Mark the function acpi_ec_add_debugfs() as static in
ec_sys.c because it is not used outside this file.

This eliminates the following warning in ec_sys.c:
drivers/acpi/ec_sys.c:108:5: warning: no previous prototype for ‘acpi_ec_add_debugfs’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/ec_sys.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c
index 4e7b798..b4c216b 100644
--- a/drivers/acpi/ec_sys.c
+++ b/drivers/acpi/ec_sys.c
@@ -105,7 +105,7 @@ static const struct file_operations acpi_ec_io_ops = {
 	.llseek = default_llseek,
 };
 
-int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
+static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count)
 {
 	struct dentry *dev_dir;
 	char name[64];
-- 
1.7.9.5

[PATCH 04/11] drivers: acpi: Include appropriate header file in pci_slot.c

[Rashika Kheria]

Includes appropriate header file linux/pci-acpi.h in pci_slot.c
because functions acpi_pci_slot_enumerate(), acpi_pci_slot_remove()
and acpi_pci_slot_init() have their prototype declaratons in
linux/pci-acpi.h.

This eliminates the following warnings in pci_slot.c:
drivers/acpi/pci_slot.c:162:6: warning: no previous prototype for ‘acpi_pci_slot_enumerate’ [-Wmissing-prototypes]
drivers/acpi/pci_slot.c:174:6: warning: no previous prototype for ‘acpi_pci_slot_remove’ [-Wmissing-prototypes]
drivers/acpi/pci_slot.c:215:13: warning: no previous prototype for ‘acpi_pci_slot_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/pci_slot.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/pci_slot.c b/drivers/acpi/pci_slot.c
index d678a18..139d9e4 100644
--- a/drivers/acpi/pci_slot.c
+++ b/drivers/acpi/pci_slot.c
@@ -35,6 +35,7 @@
 #include <linux/pci.h>
 #include <linux/acpi.h>
 #include <linux/dmi.h>
+#include <linux/pci-acpi.h>
 
 static bool debug;
 static int check_sta_before_sun;
-- 
1.7.9.5

[PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Rashika Kheria]

Include appropriate header file acutils.h in acpica/utstate.c because
function acpi_ut_create_pkg_state_and_push() has its prototype declaration
in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
condition of ACPI_FUTURE_USAGE.

This eliminates the following warning in utstate.c:
drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/acpica/utstate.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
index 03c4c2f..0920d23 100644
--- a/drivers/acpi/acpica/utstate.c
+++ b/drivers/acpi/acpica/utstate.c
@@ -43,6 +43,7 @@
 
 #include <acpi/acpi.h>
 #include "accommon.h"
+#include "acutils.h"
 
 #define _COMPONENT          ACPI_UTILITIES
 ACPI_MODULE_NAME("utstate")
@@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
  * DESCRIPTION: Create a new state and push it
  *
  ******************************************************************************/
+#ifdef  ACPI_FUTURE_USAGE
 acpi_status
 acpi_ut_create_pkg_state_and_push(void *internal_object,
 				  void *external_object,
@@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
 	acpi_ut_push_generic_state(state_list, state);
 	return (AE_OK);
 }
+#endif
 
 /*******************************************************************************
  *
-- 
1.7.9.5

[PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c

[Rashika Kheria]

Enclose functions acpi_ex_dump_namespace_node() and
acpi_ex_dump_object_descriptor() in appropriate ifdef condition of
ACPI_FUTURE_USAGE in file acpica/exdump.c.

This eliminates the following warnings in exdump.c:
drivers/acpi/acpica/exdump.c:809:6: warning: no previous prototype for ‘acpi_ex_dump_namespace_node’ [-Wmissing-prototypes]
drivers/acpi/acpica/exdump.c:995:1: warning: no previous prototype for ‘acpi_ex_dump_object_descriptor’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/acpica/exdump.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
index 4d046fa..3cd2817 100644
--- a/drivers/acpi/acpica/exdump.c
+++ b/drivers/acpi/acpica/exdump.c
@@ -54,6 +54,7 @@ ACPI_MODULE_NAME("exdump")
  * The following routines are used for debug output only
  */
 #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
+#ifdef  ACPI_FUTURE_USAGE
 /* Local prototypes */
 static void acpi_ex_out_string(char *title, char *value);
 
@@ -68,6 +69,7 @@ static void acpi_ex_dump_reference_obj(union acpi_operand_object *obj_desc);
 static void
 acpi_ex_dump_package_obj(union acpi_operand_object *obj_desc,
 			 u32 level, u32 index);
+#endif
 
 /*******************************************************************************
  *
@@ -210,6 +212,7 @@ static struct acpi_exdump_info acpi_ex_dump_bank_field[5] = {
 	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(bank_field.bank_obj), "Bank Object"}
 };
 
+#ifdef  ACPI_FUTURE_USAGE
 static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
 	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_bank_field), NULL},
 	{ACPI_EXD_FIELD, 0, NULL},
@@ -218,6 +221,7 @@ static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
 	 "Index Object"},
 	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(index_field.data_obj), "Data Object"}
 };
+#endif
 
 static struct acpi_exdump_info acpi_ex_dump_reference[8] = {
 	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_reference), NULL},
@@ -287,6 +291,7 @@ static struct acpi_exdump_info acpi_ex_dump_node[5] = {
 
 /* Dispatch table, indexed by object type */
 
+#ifdef  ACPI_FUTURE_USAGE
 static struct acpi_exdump_info *acpi_ex_dump_info[] = {
 	NULL,
 	acpi_ex_dump_integer,
@@ -444,6 +449,7 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
 		count--;
 	}
 }
+#endif
 
 /*******************************************************************************
  *
@@ -785,6 +791,7 @@ acpi_ex_dump_operands(union acpi_operand_object **operands,
  *
  ******************************************************************************/
 
+#ifdef  ACPI_FUTURE_USAGE
 static void acpi_ex_out_string(char *title, char *value)
 {
 	acpi_os_printf("%20s : %s\n", title, value);
@@ -1042,5 +1049,6 @@ acpi_ex_dump_object_descriptor(union acpi_operand_object *obj_desc, u32 flags)
 	acpi_ex_dump_object(obj_desc, acpi_ex_dump_info[obj_desc->common.type]);
 	return_VOID;
 }
+#endif
 
 #endif
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c

[Rashika Kheria]

Enclose functions acpi_ex_dump_namespace_node() and
acpi_ex_dump_object_descriptor() in appropriate ifdef condition of
ACPI_FUTURE_USAGE in file acpica/exdump.c.

This eliminates the following warnings in exdump.c:
drivers/acpi/acpica/exdump.c:809:6: warning: no previous prototype for ‘acpi_ex_dump_namespace_node’ [-Wmissing-prototypes]
drivers/acpi/acpica/exdump.c:995:1: warning: no previous prototype for ‘acpi_ex_dump_object_descriptor’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/acpica/exdump.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
index 4d046fa..3cd2817 100644
--- a/drivers/acpi/acpica/exdump.c
+++ b/drivers/acpi/acpica/exdump.c
@@ -54,6 +54,7 @@ ACPI_MODULE_NAME("exdump")
  * The following routines are used for debug output only
  */
 #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
+#ifdef  ACPI_FUTURE_USAGE
 /* Local prototypes */
 static void acpi_ex_out_string(char *title, char *value);
 
@@ -68,6 +69,7 @@ static void acpi_ex_dump_reference_obj(union acpi_operand_object *obj_desc);
 static void
 acpi_ex_dump_package_obj(union acpi_operand_object *obj_desc,
 			 u32 level, u32 index);
+#endif
 
 /*******************************************************************************
  *
@@ -210,6 +212,7 @@ static struct acpi_exdump_info acpi_ex_dump_bank_field[5] = {
 	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(bank_field.bank_obj), "Bank Object"}
 };
 
+#ifdef  ACPI_FUTURE_USAGE
 static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
 	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_bank_field), NULL},
 	{ACPI_EXD_FIELD, 0, NULL},
@@ -218,6 +221,7 @@ static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
 	 "Index Object"},
 	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(index_field.data_obj), "Data Object"}
 };
+#endif
 
 static struct acpi_exdump_info acpi_ex_dump_reference[8] = {
 	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_reference), NULL},
@@ -287,6 +291,7 @@ static struct acpi_exdump_info acpi_ex_dump_node[5] = {
 
 /* Dispatch table, indexed by object type */
 
+#ifdef  ACPI_FUTURE_USAGE
 static struct acpi_exdump_info *acpi_ex_dump_info[] = {
 	NULL,
 	acpi_ex_dump_integer,
@@ -444,6 +449,7 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
 		count--;
 	}
 }
+#endif
 
 /*******************************************************************************
  *
@@ -785,6 +791,7 @@ acpi_ex_dump_operands(union acpi_operand_object **operands,
  *
  ******************************************************************************/
 
+#ifdef  ACPI_FUTURE_USAGE
 static void acpi_ex_out_string(char *title, char *value)
 {
 	acpi_os_printf("%20s : %s\n", title, value);
@@ -1042,5 +1049,6 @@ acpi_ex_dump_object_descriptor(union acpi_operand_object *obj_desc, u32 flags)
 	acpi_ex_dump_object(obj_desc, acpi_ex_dump_info[obj_desc->common.type]);
 	return_VOID;
 }
+#endif
 
 #endif
-- 
1.7.9.5

[PATCH 07/11] drivers: acpi: Include appropriate header file in pci_link.c

[Rashika Kheria]

Includes appropriate header file internal.h in pci_link.c
because function acpi_pci_link_init() has its prototype declaration in
internal.h.

This eliminates the following warning in pci_link.c:
drivers/acpi/pci_link.c:874:13: warning: no previous prototype for ‘acpi_pci_link_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/pci_link.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/pci_link.c b/drivers/acpi/pci_link.c
index 2652a61..447c329 100644
--- a/drivers/acpi/pci_link.c
+++ b/drivers/acpi/pci_link.c
@@ -42,6 +42,7 @@
 
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
+#include "internal.h"
 
 #define PREFIX "ACPI: "
 
-- 
1.7.9.5

[PATCH 08/11] drivers: acpi: Include appropriate header file in dock.c

[Rashika Kheria]

Includes appropriate header file internal.h in dock.c because
function acpi_dock_init() has its prototype declaration in
internal.h.

This eliminates the following warning in dock.c:
drivers/acpi/dock.c:899:13: warning: no previous prototype for ‘acpi_dock_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/dock.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index dcd73cc..f229862 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -34,6 +34,7 @@
 #include <linux/acpi.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
+#include "internal.h"
 
 #define PREFIX "ACPI: "
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 08/11] drivers: acpi: Include appropriate header file in dock.c

[Rashika Kheria]

Includes appropriate header file internal.h in dock.c because
function acpi_dock_init() has its prototype declaration in
internal.h.

This eliminates the following warning in dock.c:
drivers/acpi/dock.c:899:13: warning: no previous prototype for ‘acpi_dock_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/dock.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index dcd73cc..f229862 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -34,6 +34,7 @@
 #include <linux/acpi.h>
 #include <acpi/acpi_bus.h>
 #include <acpi/acpi_drivers.h>
+#include "internal.h"
 
 #define PREFIX "ACPI: "
 
-- 
1.7.9.5

[PATCH 09/11] drivers: acpi: Remove unused function in ec.c and add prototype declaration in header file internal.h

[Rashika Kheria]

Adds the prototype declarations of functions acpi_ec_add_query_handler()
and acpi_ec_remove_query_handler() in header file internal.h and removes
unused functions ec_burst_enable() and ec_burst_disable() in ec.c.

This eliminates the following warnings in ec.c:
drivers/acpi/ec.c:393:5: warning: no previous prototype for ‘ec_burst_enable’ [-Wmissing-prototypes]
drivers/acpi/ec.c:402:5: warning: no previous prototype for ‘ec_burst_disable’ [-Wmissing-prototypes]
drivers/acpi/ec.c:531:5: warning: no previous prototype for ‘acpi_ec_add_query_handler’ [-Wmissing-prototypes]
drivers/acpi/ec.c:552:6: warning: no previous prototype for ‘acpi_ec_remove_query_handler’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/ec.c       |   25 -------------------------
 drivers/acpi/internal.h |    9 +++++++++
 2 files changed, 9 insertions(+), 25 deletions(-)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index ba5b56d..5391e02 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -91,10 +91,6 @@ static unsigned int ec_storm_threshold  __read_mostly = 8;
 module_param(ec_storm_threshold, uint, 0644);
 MODULE_PARM_DESC(ec_storm_threshold, "Maxim false GPE numbers not considered as GPE storm");
 
-/* If we find an EC via the ECDT, we need to keep a ptr to its context */
-/* External interfaces use first EC only, so remember */
-typedef int (*acpi_ec_query_func) (void *data);
-
 struct acpi_ec_query_handler {
 	struct list_head node;
 	acpi_ec_query_func func;
@@ -387,27 +383,6 @@ static int acpi_ec_write(struct acpi_ec *ec, u8 address, u8 data)
 	return acpi_ec_transaction(ec, &t);
 }
 
-/*
- * Externally callable EC access functions. For now, assume 1 EC only
- */
-int ec_burst_enable(void)
-{
-	if (!first_ec)
-		return -ENODEV;
-	return acpi_ec_burst_enable(first_ec);
-}
-
-EXPORT_SYMBOL(ec_burst_enable);
-
-int ec_burst_disable(void)
-{
-	if (!first_ec)
-		return -ENODEV;
-	return acpi_ec_burst_disable(first_ec);
-}
-
-EXPORT_SYMBOL(ec_burst_disable);
-
 int ec_read(u8 addr, u8 *val)
 {
 	int err;
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index a29739c..8ef9787 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -127,12 +127,21 @@ struct acpi_ec {
 
 extern struct acpi_ec *first_ec;
 
+/* If we find an EC via the ECDT, we need to keep a ptr to its context */
+/* External interfaces use first EC only, so remember */
+typedef int (*acpi_ec_query_func) (void *data);
+
 int acpi_ec_init(void);
 int acpi_ec_ecdt_probe(void);
 int acpi_boot_ec_enable(void);
 void acpi_ec_block_transactions(void);
 void acpi_ec_unblock_transactions(void);
 void acpi_ec_unblock_transactions_early(void);
+int acpi_ec_add_query_handler(struct acpi_ec *ec, u8 query_bit,
+			      acpi_handle handle, acpi_ec_query_func func,
+			      void *data);
+void acpi_ec_remove_query_handler(struct acpi_ec *ec, u8 query_bit);
+
 
 /*--------------------------------------------------------------------------
                                   Suspend/Resume
-- 
1.7.9.5

[PATCH 10/11] drivers: acpi: Include appropriate header file in proc.c

[Rashika Kheria]

Include appropriate header file internal.h in proc.c because function
acpi_sleep_proc_init() has its prototype declaration in internal.h.

This eliminates the following warning in proc.c:
drivers/acpi/proc.c:148:12: warning: no previous prototype for ‘acpi_sleep_proc_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/proc.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
index 6a5b152..e8f7d36 100644
--- a/drivers/acpi/proc.c
+++ b/drivers/acpi/proc.c
@@ -9,6 +9,7 @@
 #include <acpi/acpi_drivers.h>
 
 #include "sleep.h"
+#include "internal.h"
 
 #define _COMPONENT		ACPI_SYSTEM_COMPONENT
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 10/11] drivers: acpi: Include appropriate header file in proc.c

[Rashika Kheria]

Include appropriate header file internal.h in proc.c because function
acpi_sleep_proc_init() has its prototype declaration in internal.h.

This eliminates the following warning in proc.c:
drivers/acpi/proc.c:148:12: warning: no previous prototype for ‘acpi_sleep_proc_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/proc.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/proc.c b/drivers/acpi/proc.c
index 6a5b152..e8f7d36 100644
--- a/drivers/acpi/proc.c
+++ b/drivers/acpi/proc.c
@@ -9,6 +9,7 @@
 #include <acpi/acpi_drivers.h>
 
 #include "sleep.h"
+#include "internal.h"
 
 #define _COMPONENT		ACPI_SYSTEM_COMPONENT
 
-- 
1.7.9.5

[PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Rashika Kheria]

Include header file internal.h in debugfs.c and change the return
value's type in header file internal.h.

This eliminates the following warning in debugfs.c:
drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/debugfs.c  |    3 +++
 drivers/acpi/internal.h |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
index b55d6a2..96bcaf7 100644
--- a/drivers/acpi/debugfs.c
+++ b/drivers/acpi/debugfs.c
@@ -6,6 +6,7 @@
 #include <linux/init.h>
 #include <linux/debugfs.h>
 #include <acpi/acpi_drivers.h>
+#include "internal.h"
 
 #define _COMPONENT		ACPI_SYSTEM_COMPONENT
 ACPI_MODULE_NAME("debugfs");
@@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
 struct dentry *acpi_debugfs_dir;
 EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
 
+#ifdef  CONFIG_DEBUG_FS
 void __init acpi_debugfs_init(void)
 {
 	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
 }
+#endif
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 8ef9787..c2e35bd 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -63,7 +63,7 @@ void acpi_scan_hotplug_enabled(struct acpi_hotplug_profile *hotplug, bool val);
 
 #ifdef CONFIG_DEBUG_FS
 extern struct dentry *acpi_debugfs_dir;
-int acpi_debugfs_init(void);
+void acpi_debugfs_init(void);
 #else
 static inline void acpi_debugfs_init(void) { return; }
 #endif
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Rashika Kheria]

Include header file internal.h in debugfs.c and change the return
value's type in header file internal.h.

This eliminates the following warning in debugfs.c:
drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
---
 drivers/acpi/debugfs.c  |    3 +++
 drivers/acpi/internal.h |    2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
index b55d6a2..96bcaf7 100644
--- a/drivers/acpi/debugfs.c
+++ b/drivers/acpi/debugfs.c
@@ -6,6 +6,7 @@
 #include <linux/init.h>
 #include <linux/debugfs.h>
 #include <acpi/acpi_drivers.h>
+#include "internal.h"
 
 #define _COMPONENT		ACPI_SYSTEM_COMPONENT
 ACPI_MODULE_NAME("debugfs");
@@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
 struct dentry *acpi_debugfs_dir;
 EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
 
+#ifdef  CONFIG_DEBUG_FS
 void __init acpi_debugfs_init(void)
 {
 	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
 }
+#endif
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
index 8ef9787..c2e35bd 100644
--- a/drivers/acpi/internal.h
+++ b/drivers/acpi/internal.h
@@ -63,7 +63,7 @@ void acpi_scan_hotplug_enabled(struct acpi_hotplug_profile *hotplug, bool val);
 
 #ifdef CONFIG_DEBUG_FS
 extern struct dentry *acpi_debugfs_dir;
-int acpi_debugfs_init(void);
+void acpi_debugfs_init(void);
 #else
 static inline void acpi_debugfs_init(void) { return; }
 #endif
-- 
1.7.9.5

RE: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Moore, Robert]

I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".

> -----Original Message-----
> From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> Sent: Tuesday, December 17, 2013 1:22 AM
> To: linux-kernel@vger.kernel.org
> Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> utstate.c
> 
> Include appropriate header file acutils.h in acpica/utstate.c because
> function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> condition of ACPI_FUTURE_USAGE.
> 
> This eliminates the following warning in utstate.c:
> drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/acpi/acpica/utstate.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> index 03c4c2f..0920d23 100644
> --- a/drivers/acpi/acpica/utstate.c
> +++ b/drivers/acpi/acpica/utstate.c
> @@ -43,6 +43,7 @@
> 
>  #include <acpi/acpi.h>
>  #include "accommon.h"
> +#include "acutils.h"
> 
>  #define _COMPONENT          ACPI_UTILITIES
>  ACPI_MODULE_NAME("utstate")
> @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
>   * DESCRIPTION: Create a new state and push it
>   *
> 
> **************************************************************************
> ****/
> +#ifdef  ACPI_FUTURE_USAGE
>  acpi_status
>  acpi_ut_create_pkg_state_and_push(void *internal_object,
>  				  void *external_object,
> @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
>  	acpi_ut_push_generic_state(state_list, state);
>  	return (AE_OK);
>  }
> +#endif
> 
> 
> /*************************************************************************
> ******
>   *
> --
> 1.7.9.5

RE: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Moore, Robert]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2307 bytes --]

I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".

> -----Original Message-----
> From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> Sent: Tuesday, December 17, 2013 1:22 AM
> To: linux-kernel@vger.kernel.org
> Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> utstate.c
> 
> Include appropriate header file acutils.h in acpica/utstate.c because
> function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> condition of ACPI_FUTURE_USAGE.
> 
> This eliminates the following warning in utstate.c:
> drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/acpi/acpica/utstate.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> index 03c4c2f..0920d23 100644
> --- a/drivers/acpi/acpica/utstate.c
> +++ b/drivers/acpi/acpica/utstate.c
> @@ -43,6 +43,7 @@
> 
>  #include <acpi/acpi.h>
>  #include "accommon.h"
> +#include "acutils.h"
> 
>  #define _COMPONENT          ACPI_UTILITIES
>  ACPI_MODULE_NAME("utstate")
> @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
>   * DESCRIPTION: Create a new state and push it
>   *
> 
> **************************************************************************
> ****/
> +#ifdef  ACPI_FUTURE_USAGE
>  acpi_status
>  acpi_ut_create_pkg_state_and_push(void *internal_object,
>  				  void *external_object,
> @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
>  	acpi_ut_push_generic_state(state_list, state);
>  	return (AE_OK);
>  }
> +#endif
> 
> 
> /*************************************************************************
> ******
>   *
> --
> 1.7.9.5

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [Devel] [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Moore, Robert]

[-- Attachment #1: Type: text/plain, Size: 2222 bytes --]

I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".

> -----Original Message-----
> From: Rashika Kheria [mailto:rashika.kheria(a)gmail.com]
> Sent: Tuesday, December 17, 2013 1:22 AM
> To: linux-kernel(a)vger.kernel.org
> Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> acpi(a)vger.kernel.org; josh(a)joshtriplett.org; devel(a)acpica.org
> Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> utstate.c
> 
> Include appropriate header file acutils.h in acpica/utstate.c because
> function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> condition of ACPI_FUTURE_USAGE.
> 
> This eliminates the following warning in utstate.c:
> drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria(a)gmail.com>
> Reviewed-by: Josh Triplett <josh(a)joshtriplett.org>
> ---
>  drivers/acpi/acpica/utstate.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> index 03c4c2f..0920d23 100644
> --- a/drivers/acpi/acpica/utstate.c
> +++ b/drivers/acpi/acpica/utstate.c
> @@ -43,6 +43,7 @@
> 
>  #include <acpi/acpi.h>
>  #include "accommon.h"
> +#include "acutils.h"
> 
>  #define _COMPONENT          ACPI_UTILITIES
>  ACPI_MODULE_NAME("utstate")
> @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
>   * DESCRIPTION: Create a new state and push it
>   *
> 
> **************************************************************************
> ****/
> +#ifdef  ACPI_FUTURE_USAGE
>  acpi_status
>  acpi_ut_create_pkg_state_and_push(void *internal_object,
>  				  void *external_object,
> @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
>  	acpi_ut_push_generic_state(state_list, state);
>  	return (AE_OK);
>  }
> +#endif
> 
> 
> /*************************************************************************
> ******
>   *
> --
> 1.7.9.5

Re: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Josh Triplett]

On Tue, Dec 17, 2013 at 05:35:46PM +0000, Moore, Robert wrote:
> I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".

This is the version in the latest git tree for the Linux kernel.

- Josh Triplett

> > -----Original Message-----
> > From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> > Sent: Tuesday, December 17, 2013 1:22 AM
> > To: linux-kernel@vger.kernel.org
> > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > utstate.c
> > 
> > Include appropriate header file acutils.h in acpica/utstate.c because
> > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > condition of ACPI_FUTURE_USAGE.
> > 
> > This eliminates the following warning in utstate.c:
> > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> >  drivers/acpi/acpica/utstate.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > index 03c4c2f..0920d23 100644
> > --- a/drivers/acpi/acpica/utstate.c
> > +++ b/drivers/acpi/acpica/utstate.c
> > @@ -43,6 +43,7 @@
> > 
> >  #include <acpi/acpi.h>
> >  #include "accommon.h"
> > +#include "acutils.h"
> > 
> >  #define _COMPONENT          ACPI_UTILITIES
> >  ACPI_MODULE_NAME("utstate")
> > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> >   * DESCRIPTION: Create a new state and push it
> >   *
> > 
> > **************************************************************************
> > ****/
> > +#ifdef  ACPI_FUTURE_USAGE
> >  acpi_status
> >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  				  void *external_object,
> > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  	acpi_ut_push_generic_state(state_list, state);
> >  	return (AE_OK);
> >  }
> > +#endif
> > 
> > 
> > /*************************************************************************
> > ******
> >   *
> > --
> > 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Josh Triplett]

On Tue, Dec 17, 2013 at 05:35:46PM +0000, Moore, Robert wrote:
> I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".

This is the version in the latest git tree for the Linux kernel.

- Josh Triplett

> > -----Original Message-----
> > From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> > Sent: Tuesday, December 17, 2013 1:22 AM
> > To: linux-kernel@vger.kernel.org
> > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > utstate.c
> > 
> > Include appropriate header file acutils.h in acpica/utstate.c because
> > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > condition of ACPI_FUTURE_USAGE.
> > 
> > This eliminates the following warning in utstate.c:
> > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> >  drivers/acpi/acpica/utstate.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > index 03c4c2f..0920d23 100644
> > --- a/drivers/acpi/acpica/utstate.c
> > +++ b/drivers/acpi/acpica/utstate.c
> > @@ -43,6 +43,7 @@
> > 
> >  #include <acpi/acpi.h>
> >  #include "accommon.h"
> > +#include "acutils.h"
> > 
> >  #define _COMPONENT          ACPI_UTILITIES
> >  ACPI_MODULE_NAME("utstate")
> > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> >   * DESCRIPTION: Create a new state and push it
> >   *
> > 
> > **************************************************************************
> > ****/
> > +#ifdef  ACPI_FUTURE_USAGE
> >  acpi_status
> >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  				  void *external_object,
> > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  	acpi_ut_push_generic_state(state_list, state);
> >  	return (AE_OK);
> >  }
> > +#endif
> > 
> > 
> > /*************************************************************************
> > ******
> >   *
> > --
> > 1.7.9.5
> 

Re: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 12:25:18 PM Josh Triplett wrote:
> On Tue, Dec 17, 2013 at 05:35:46PM +0000, Moore, Robert wrote:
> > I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".
> 
> This is the version in the latest git tree for the Linux kernel.

Well, I guess that's something for Lv to look at, then.

Lv, we seem to have a divergence here, can you please see if we can fix it
shortly?

Rafael


> > > -----Original Message-----
> > > From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> > > Sent: Tuesday, December 17, 2013 1:22 AM
> > > To: linux-kernel@vger.kernel.org
> > > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> > > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > > utstate.c
> > > 
> > > Include appropriate header file acutils.h in acpica/utstate.c because
> > > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > > condition of ACPI_FUTURE_USAGE.
> > > 
> > > This eliminates the following warning in utstate.c:
> > > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> > > 
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > ---
> > >  drivers/acpi/acpica/utstate.c |    3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > > index 03c4c2f..0920d23 100644
> > > --- a/drivers/acpi/acpica/utstate.c
> > > +++ b/drivers/acpi/acpica/utstate.c
> > > @@ -43,6 +43,7 @@
> > > 
> > >  #include <acpi/acpi.h>
> > >  #include "accommon.h"
> > > +#include "acutils.h"
> > > 
> > >  #define _COMPONENT          ACPI_UTILITIES
> > >  ACPI_MODULE_NAME("utstate")
> > > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> > >   * DESCRIPTION: Create a new state and push it
> > >   *
> > > 
> > > **************************************************************************
> > > ****/
> > > +#ifdef  ACPI_FUTURE_USAGE
> > >  acpi_status
> > >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> > >  				  void *external_object,
> > > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> > >  	acpi_ut_push_generic_state(state_list, state);
> > >  	return (AE_OK);
> > >  }
> > > +#endif
> > > 
> > > 
> > > /*************************************************************************
> > > ******
> > >   *
> > > --
> > > 1.7.9.5
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 12:25:18 PM Josh Triplett wrote:
> On Tue, Dec 17, 2013 at 05:35:46PM +0000, Moore, Robert wrote:
> > I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".
> 
> This is the version in the latest git tree for the Linux kernel.

Well, I guess that's something for Lv to look at, then.

Lv, we seem to have a divergence here, can you please see if we can fix it
shortly?

Rafael


> > > -----Original Message-----
> > > From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> > > Sent: Tuesday, December 17, 2013 1:22 AM
> > > To: linux-kernel@vger.kernel.org
> > > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> > > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > > utstate.c
> > > 
> > > Include appropriate header file acutils.h in acpica/utstate.c because
> > > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > > condition of ACPI_FUTURE_USAGE.
> > > 
> > > This eliminates the following warning in utstate.c:
> > > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> > > 
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > ---
> > >  drivers/acpi/acpica/utstate.c |    3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > > index 03c4c2f..0920d23 100644
> > > --- a/drivers/acpi/acpica/utstate.c
> > > +++ b/drivers/acpi/acpica/utstate.c
> > > @@ -43,6 +43,7 @@
> > > 
> > >  #include <acpi/acpi.h>
> > >  #include "accommon.h"
> > > +#include "acutils.h"
> > > 
> > >  #define _COMPONENT          ACPI_UTILITIES
> > >  ACPI_MODULE_NAME("utstate")
> > > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> > >   * DESCRIPTION: Create a new state and push it
> > >   *
> > > 
> > > **************************************************************************
> > > ****/
> > > +#ifdef  ACPI_FUTURE_USAGE
> > >  acpi_status
> > >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> > >  				  void *external_object,
> > > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> > >  	acpi_ut_push_generic_state(state_list, state);
> > >  	return (AE_OK);
> > >  }
> > > +#endif
> > > 
> > > 
> > > /*************************************************************************
> > > ******
> > >   *
> > > --
> > > 1.7.9.5
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

RE: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Zheng, Lv]

Hi,

Currently we didn't do much on automatically optimized out ACPI_FUTURE_USAGE functions as long as they do not affect the generation of vmlinux binary.

> From: Moore, Robert
> Sent: Wednesday, December 18, 2013 1:36 AM
> 
> I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".
> 
> > -----Original Message-----
> > From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> > Sent: Tuesday, December 17, 2013 1:22 AM
> > To: linux-kernel@vger.kernel.org
> > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > utstate.c
> >
> > Include appropriate header file acutils.h in acpica/utstate.c because
> > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > condition of ACPI_FUTURE_USAGE.
> >
> > This eliminates the following warning in utstate.c:
> > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> >  drivers/acpi/acpica/utstate.c |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > index 03c4c2f..0920d23 100644
> > --- a/drivers/acpi/acpica/utstate.c
> > +++ b/drivers/acpi/acpica/utstate.c
> > @@ -43,6 +43,7 @@
> >
> >  #include <acpi/acpi.h>
> >  #include "accommon.h"
> > +#include "acutils.h"

IMO, this line is useless.

> >
> >  #define _COMPONENT          ACPI_UTILITIES
> >  ACPI_MODULE_NAME("utstate")
> > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> >   * DESCRIPTION: Create a new state and push it
> >   *
> >
> > **************************************************************************
> > ****/
> > +#ifdef  ACPI_FUTURE_USAGE
> >  acpi_status
> >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  				  void *external_object,
> > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  	acpi_ut_push_generic_state(state_list, state);
> >  	return (AE_OK);
> >  }
> > +#endif

IMO, these lines are useful.
I have a plan to do a cleanup on all ACPICA build warnings so that such inconsistencies can be sorted out.
Maybe it is time to do it right now.

Thanks
-Lv

> >
> >
> > /*************************************************************************
> > ******
> >   *
> > --
> > 1.7.9.5

RE: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Zheng, Lv]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2861 bytes --]

Hi,

Currently we didn't do much on automatically optimized out ACPI_FUTURE_USAGE functions as long as they do not affect the generation of vmlinux binary.

> From: Moore, Robert
> Sent: Wednesday, December 18, 2013 1:36 AM
> 
> I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".
> 
> > -----Original Message-----
> > From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> > Sent: Tuesday, December 17, 2013 1:22 AM
> > To: linux-kernel@vger.kernel.org
> > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > acpi@vger.kernel.org; josh@joshtriplett.org; devel@acpica.org
> > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > utstate.c
> >
> > Include appropriate header file acutils.h in acpica/utstate.c because
> > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > condition of ACPI_FUTURE_USAGE.
> >
> > This eliminates the following warning in utstate.c:
> > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> >  drivers/acpi/acpica/utstate.c |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > index 03c4c2f..0920d23 100644
> > --- a/drivers/acpi/acpica/utstate.c
> > +++ b/drivers/acpi/acpica/utstate.c
> > @@ -43,6 +43,7 @@
> >
> >  #include <acpi/acpi.h>
> >  #include "accommon.h"
> > +#include "acutils.h"

IMO, this line is useless.

> >
> >  #define _COMPONENT          ACPI_UTILITIES
> >  ACPI_MODULE_NAME("utstate")
> > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> >   * DESCRIPTION: Create a new state and push it
> >   *
> >
> > **************************************************************************
> > ****/
> > +#ifdef  ACPI_FUTURE_USAGE
> >  acpi_status
> >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  				  void *external_object,
> > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  	acpi_ut_push_generic_state(state_list, state);
> >  	return (AE_OK);
> >  }
> > +#endif

IMO, these lines are useful.
I have a plan to do a cleanup on all ACPICA build warnings so that such inconsistencies can be sorted out.
Maybe it is time to do it right now.

Thanks
-Lv

> >
> >
> > /*************************************************************************
> > ******
> >   *
> > --
> > 1.7.9.5

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [Devel] [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Zheng, Lv]

[-- Attachment #1: Type: text/plain, Size: 2794 bytes --]

Hi,

Currently we didn't do much on automatically optimized out ACPI_FUTURE_USAGE functions as long as they do not affect the generation of vmlinux binary.

> From: Moore, Robert
> Sent: Wednesday, December 18, 2013 1:36 AM
> 
> I'm not sure what version of ACPICA you are looking at, but in the master git tree for ACPICA, the file accommon.h includes "acutils.h".
> 
> > -----Original Message-----
> > From: Rashika Kheria [mailto:rashika.kheria(a)gmail.com]
> > Sent: Tuesday, December 17, 2013 1:22 AM
> > To: linux-kernel(a)vger.kernel.org
> > Cc: Moore, Robert; Zheng, Lv; Wysocki, Rafael J; Len Brown; linux-
> > acpi(a)vger.kernel.org; josh(a)joshtriplett.org; devel(a)acpica.org
> > Subject: [PATCH 05/11] drivers: acpi: Include appropriate header file in
> > utstate.c
> >
> > Include appropriate header file acutils.h in acpica/utstate.c because
> > function acpi_ut_create_pkg_state_and_push() has its prototype declaration
> > in acutils.h. Also, encloses the function in acpica/utstate.c in ifdef
> > condition of ACPI_FUTURE_USAGE.
> >
> > This eliminates the following warning in utstate.c:
> > drivers/acpi/acpica/utstate.c:64:1: warning: no previous prototype for
> > ‘acpi_ut_create_pkg_state_and_push’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <rashika.kheria(a)gmail.com>
> > Reviewed-by: Josh Triplett <josh(a)joshtriplett.org>
> > ---
> >  drivers/acpi/acpica/utstate.c |    3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/acpi/acpica/utstate.c b/drivers/acpi/acpica/utstate.c
> > index 03c4c2f..0920d23 100644
> > --- a/drivers/acpi/acpica/utstate.c
> > +++ b/drivers/acpi/acpica/utstate.c
> > @@ -43,6 +43,7 @@
> >
> >  #include <acpi/acpi.h>
> >  #include "accommon.h"
> > +#include "acutils.h"

IMO, this line is useless.

> >
> >  #define _COMPONENT          ACPI_UTILITIES
> >  ACPI_MODULE_NAME("utstate")
> > @@ -60,6 +61,7 @@ ACPI_MODULE_NAME("utstate")
> >   * DESCRIPTION: Create a new state and push it
> >   *
> >
> > **************************************************************************
> > ****/
> > +#ifdef  ACPI_FUTURE_USAGE
> >  acpi_status
> >  acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  				  void *external_object,
> > @@ -79,6 +81,7 @@ acpi_ut_create_pkg_state_and_push(void *internal_object,
> >  	acpi_ut_push_generic_state(state_list, state);
> >  	return (AE_OK);
> >  }
> > +#endif

IMO, these lines are useful.
I have a plan to do a cleanup on all ACPICA build warnings so that such inconsistencies can be sorted out.
Maybe it is time to do it right now.

Thanks
-Lv

> >
> >
> > /*************************************************************************
> > ******
> >   *
> > --
> > 1.7.9.5

RE: [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c

[Zheng, Lv]

Hi,

I think this patch is useless.
It is possible to include dump code into Linux kernel for debugging purposes.
Thus we should do cleanup in different way for them.

Thanks
-Lv

> From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> Sent: Tuesday, December 17, 2013 5:24 PM
> 
> Enclose functions acpi_ex_dump_namespace_node() and
> acpi_ex_dump_object_descriptor() in appropriate ifdef condition of
> ACPI_FUTURE_USAGE in file acpica/exdump.c.
> 
> This eliminates the following warnings in exdump.c:
> drivers/acpi/acpica/exdump.c:809:6: warning: no previous prototype for ‘acpi_ex_dump_namespace_node’ [-Wmissing-prototypes]
> drivers/acpi/acpica/exdump.c:995:1: warning: no previous prototype for ‘acpi_ex_dump_object_descriptor’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/acpi/acpica/exdump.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
> index 4d046fa..3cd2817 100644
> --- a/drivers/acpi/acpica/exdump.c
> +++ b/drivers/acpi/acpica/exdump.c
> @@ -54,6 +54,7 @@ ACPI_MODULE_NAME("exdump")
>   * The following routines are used for debug output only
>   */
>  #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
> +#ifdef  ACPI_FUTURE_USAGE
>  /* Local prototypes */
>  static void acpi_ex_out_string(char *title, char *value);
> 
> @@ -68,6 +69,7 @@ static void acpi_ex_dump_reference_obj(union acpi_operand_object *obj_desc);
>  static void
>  acpi_ex_dump_package_obj(union acpi_operand_object *obj_desc,
>  			 u32 level, u32 index);
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -210,6 +212,7 @@ static struct acpi_exdump_info acpi_ex_dump_bank_field[5] = {
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(bank_field.bank_obj), "Bank Object"}
>  };
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_bank_field), NULL},
>  	{ACPI_EXD_FIELD, 0, NULL},
> @@ -218,6 +221,7 @@ static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	 "Index Object"},
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(index_field.data_obj), "Data Object"}
>  };
> +#endif
> 
>  static struct acpi_exdump_info acpi_ex_dump_reference[8] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_reference), NULL},
> @@ -287,6 +291,7 @@ static struct acpi_exdump_info acpi_ex_dump_node[5] = {
> 
>  /* Dispatch table, indexed by object type */
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info *acpi_ex_dump_info[] = {
>  	NULL,
>  	acpi_ex_dump_integer,
> @@ -444,6 +449,7 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
>  		count--;
>  	}
>  }
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -785,6 +791,7 @@ acpi_ex_dump_operands(union acpi_operand_object **operands,
>   *
>   ******************************************************************************/
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static void acpi_ex_out_string(char *title, char *value)
>  {
>  	acpi_os_printf("%20s : %s\n", title, value);
> @@ -1042,5 +1049,6 @@ acpi_ex_dump_object_descriptor(union acpi_operand_object *obj_desc, u32 flags)
>  	acpi_ex_dump_object(obj_desc, acpi_ex_dump_info[obj_desc->common.type]);
>  	return_VOID;
>  }
> +#endif
> 
>  #endif
> --
> 1.7.9.5

RE: [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c

[Zheng, Lv]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 3651 bytes --]

Hi,

I think this patch is useless.
It is possible to include dump code into Linux kernel for debugging purposes.
Thus we should do cleanup in different way for them.

Thanks
-Lv

> From: Rashika Kheria [mailto:rashika.kheria@gmail.com]
> Sent: Tuesday, December 17, 2013 5:24 PM
> 
> Enclose functions acpi_ex_dump_namespace_node() and
> acpi_ex_dump_object_descriptor() in appropriate ifdef condition of
> ACPI_FUTURE_USAGE in file acpica/exdump.c.
> 
> This eliminates the following warnings in exdump.c:
> drivers/acpi/acpica/exdump.c:809:6: warning: no previous prototype for ‘acpi_ex_dump_namespace_node’ [-Wmissing-prototypes]
> drivers/acpi/acpica/exdump.c:995:1: warning: no previous prototype for ‘acpi_ex_dump_object_descriptor’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/acpi/acpica/exdump.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
> index 4d046fa..3cd2817 100644
> --- a/drivers/acpi/acpica/exdump.c
> +++ b/drivers/acpi/acpica/exdump.c
> @@ -54,6 +54,7 @@ ACPI_MODULE_NAME("exdump")
>   * The following routines are used for debug output only
>   */
>  #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
> +#ifdef  ACPI_FUTURE_USAGE
>  /* Local prototypes */
>  static void acpi_ex_out_string(char *title, char *value);
> 
> @@ -68,6 +69,7 @@ static void acpi_ex_dump_reference_obj(union acpi_operand_object *obj_desc);
>  static void
>  acpi_ex_dump_package_obj(union acpi_operand_object *obj_desc,
>  			 u32 level, u32 index);
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -210,6 +212,7 @@ static struct acpi_exdump_info acpi_ex_dump_bank_field[5] = {
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(bank_field.bank_obj), "Bank Object"}
>  };
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_bank_field), NULL},
>  	{ACPI_EXD_FIELD, 0, NULL},
> @@ -218,6 +221,7 @@ static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	 "Index Object"},
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(index_field.data_obj), "Data Object"}
>  };
> +#endif
> 
>  static struct acpi_exdump_info acpi_ex_dump_reference[8] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_reference), NULL},
> @@ -287,6 +291,7 @@ static struct acpi_exdump_info acpi_ex_dump_node[5] = {
> 
>  /* Dispatch table, indexed by object type */
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info *acpi_ex_dump_info[] = {
>  	NULL,
>  	acpi_ex_dump_integer,
> @@ -444,6 +449,7 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
>  		count--;
>  	}
>  }
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -785,6 +791,7 @@ acpi_ex_dump_operands(union acpi_operand_object **operands,
>   *
>   ******************************************************************************/
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static void acpi_ex_out_string(char *title, char *value)
>  {
>  	acpi_os_printf("%20s : %s\n", title, value);
> @@ -1042,5 +1049,6 @@ acpi_ex_dump_object_descriptor(union acpi_operand_object *obj_desc, u32 flags)
>  	acpi_ex_dump_object(obj_desc, acpi_ex_dump_info[obj_desc->common.type]);
>  	return_VOID;
>  }
> +#endif
> 
>  #endif
> --
> 1.7.9.5

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [Devel] [PATCH 06/11] drivers: acpi: Add appropriate ifdef conditions in exdump.c

[Zheng, Lv]

[-- Attachment #1: Type: text/plain, Size: 3593 bytes --]

Hi,

I think this patch is useless.
It is possible to include dump code into Linux kernel for debugging purposes.
Thus we should do cleanup in different way for them.

Thanks
-Lv

> From: Rashika Kheria [mailto:rashika.kheria(a)gmail.com]
> Sent: Tuesday, December 17, 2013 5:24 PM
> 
> Enclose functions acpi_ex_dump_namespace_node() and
> acpi_ex_dump_object_descriptor() in appropriate ifdef condition of
> ACPI_FUTURE_USAGE in file acpica/exdump.c.
> 
> This eliminates the following warnings in exdump.c:
> drivers/acpi/acpica/exdump.c:809:6: warning: no previous prototype for ‘acpi_ex_dump_namespace_node’ [-Wmissing-prototypes]
> drivers/acpi/acpica/exdump.c:995:1: warning: no previous prototype for ‘acpi_ex_dump_object_descriptor’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria(a)gmail.com>
> Reviewed-by: Josh Triplett <josh(a)joshtriplett.org>
> ---
>  drivers/acpi/acpica/exdump.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/acpi/acpica/exdump.c b/drivers/acpi/acpica/exdump.c
> index 4d046fa..3cd2817 100644
> --- a/drivers/acpi/acpica/exdump.c
> +++ b/drivers/acpi/acpica/exdump.c
> @@ -54,6 +54,7 @@ ACPI_MODULE_NAME("exdump")
>   * The following routines are used for debug output only
>   */
>  #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
> +#ifdef  ACPI_FUTURE_USAGE
>  /* Local prototypes */
>  static void acpi_ex_out_string(char *title, char *value);
> 
> @@ -68,6 +69,7 @@ static void acpi_ex_dump_reference_obj(union acpi_operand_object *obj_desc);
>  static void
>  acpi_ex_dump_package_obj(union acpi_operand_object *obj_desc,
>  			 u32 level, u32 index);
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -210,6 +212,7 @@ static struct acpi_exdump_info acpi_ex_dump_bank_field[5] = {
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(bank_field.bank_obj), "Bank Object"}
>  };
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_bank_field), NULL},
>  	{ACPI_EXD_FIELD, 0, NULL},
> @@ -218,6 +221,7 @@ static struct acpi_exdump_info acpi_ex_dump_index_field[5] = {
>  	 "Index Object"},
>  	{ACPI_EXD_POINTER, ACPI_EXD_OFFSET(index_field.data_obj), "Data Object"}
>  };
> +#endif
> 
>  static struct acpi_exdump_info acpi_ex_dump_reference[8] = {
>  	{ACPI_EXD_INIT, ACPI_EXD_TABLE_SIZE(acpi_ex_dump_reference), NULL},
> @@ -287,6 +291,7 @@ static struct acpi_exdump_info acpi_ex_dump_node[5] = {
> 
>  /* Dispatch table, indexed by object type */
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static struct acpi_exdump_info *acpi_ex_dump_info[] = {
>  	NULL,
>  	acpi_ex_dump_integer,
> @@ -444,6 +449,7 @@ acpi_ex_dump_object(union acpi_operand_object *obj_desc,
>  		count--;
>  	}
>  }
> +#endif
> 
>  /*******************************************************************************
>   *
> @@ -785,6 +791,7 @@ acpi_ex_dump_operands(union acpi_operand_object **operands,
>   *
>   ******************************************************************************/
> 
> +#ifdef  ACPI_FUTURE_USAGE
>  static void acpi_ex_out_string(char *title, char *value)
>  {
>  	acpi_os_printf("%20s : %s\n", title, value);
> @@ -1042,5 +1049,6 @@ acpi_ex_dump_object_descriptor(union acpi_operand_object *obj_desc, u32 flags)
>  	acpi_ex_dump_object(obj_desc, acpi_ex_dump_info[obj_desc->common.type]);
>  	return_VOID;
>  }
> +#endif
> 
>  #endif
> --
> 1.7.9.5

Re: [PATCH 05/11] drivers: acpi: Include appropriate header file in utstate.c

[Josh Triplett]

On Wed, Dec 18, 2013 at 06:17:33AM +0000, Zheng, Lv wrote:
> Currently we didn't do much on automatically optimized out ACPI_FUTURE_USAGE functions as long as they do not affect the generation of vmlinux binary.

They do affect the size of vmlinux, though, if they're left compiled in
but not actually called.

> I have a plan to do a cleanup on all ACPICA build warnings so that such inconsistencies can be sorted out.
> Maybe it is time to do it right now.

That would be most appreciated, especially if you plan to eliminate the
warnings from -Wmissing-prototypes in the process.

Thanks,
Josh Triplett

Re: [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 02:43:05 PM Rashika Kheria wrote:
> Marks the function acpi_table_checksum() as static in osl.c
> because it is not used outside this file.
> 
> This eliminates the following warning in osl.c:
> drivers/acpi/osl.c:547:11: warning: no previous prototype for
> ‘acpi_table_checksum’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

I've queued up patches [1-4/11] and [7-10/11] for 3.14.

I've skipped patches [5-6/11], because the general rule for ACPICA material is
that it should go through ACPICA upstream, so please submit those patches to
Bob/Lv.

I'll send a reply to patch [11/11] in a while.

Thanks!

> ---
>  drivers/acpi/osl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 54a20ff..1f4c104 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
>  static int all_tables_size;
>  
>  /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
> -u8 __init acpi_table_checksum(u8 *buffer, u32 length)
> +static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
>  {
>  	u8 sum = 0;
>  	u8 *end = buffer + length;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/11] drivers: acpi: Mark the function acpi_table_checksum() as static in osl.c

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 02:43:05 PM Rashika Kheria wrote:
> Marks the function acpi_table_checksum() as static in osl.c
> because it is not used outside this file.
> 
> This eliminates the following warning in osl.c:
> drivers/acpi/osl.c:547:11: warning: no previous prototype for
> ‘acpi_table_checksum’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

I've queued up patches [1-4/11] and [7-10/11] for 3.14.

I've skipped patches [5-6/11], because the general rule for ACPICA material is
that it should go through ACPICA upstream, so please submit those patches to
Bob/Lv.

I'll send a reply to patch [11/11] in a while.

Thanks!

> ---
>  drivers/acpi/osl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 54a20ff..1f4c104 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -544,7 +544,7 @@ static u64 acpi_tables_addr;
>  static int all_tables_size;
>  
>  /* Copied from acpica/tbutils.c:acpi_tb_checksum() */
> -u8 __init acpi_table_checksum(u8 *buffer, u32 length)
> +static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
>  {
>  	u8 sum = 0;
>  	u8 *end = buffer + length;
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> Include header file internal.h in debugfs.c and change the return
> value's type in header file internal.h.
> 
> This eliminates the following warning in debugfs.c:
> drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/acpi/debugfs.c  |    3 +++
>  drivers/acpi/internal.h |    2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> index b55d6a2..96bcaf7 100644
> --- a/drivers/acpi/debugfs.c
> +++ b/drivers/acpi/debugfs.c
> @@ -6,6 +6,7 @@
>  #include <linux/init.h>
>  #include <linux/debugfs.h>
>  #include <acpi/acpi_drivers.h>
> +#include "internal.h"
>  
>  #define _COMPONENT		ACPI_SYSTEM_COMPONENT
>  ACPI_MODULE_NAME("debugfs");
> @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
>  struct dentry *acpi_debugfs_dir;
>  EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
>  
> +#ifdef  CONFIG_DEBUG_FS
>  void __init acpi_debugfs_init(void)
>  {
>  	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
>  }
> +#endif

What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?

That surely would make sense? 

> diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
> index 8ef9787..c2e35bd 100644
> --- a/drivers/acpi/internal.h
> +++ b/drivers/acpi/internal.h
> @@ -63,7 +63,7 @@ void acpi_scan_hotplug_enabled(struct acpi_hotplug_profile *hotplug, bool val);
>  
>  #ifdef CONFIG_DEBUG_FS
>  extern struct dentry *acpi_debugfs_dir;
> -int acpi_debugfs_init(void);
> +void acpi_debugfs_init(void);
>  #else
>  static inline void acpi_debugfs_init(void) { return; }
>  #endif
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Rafael J. Wysocki]

On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> Include header file internal.h in debugfs.c and change the return
> value's type in header file internal.h.
> 
> This eliminates the following warning in debugfs.c:
> drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---
>  drivers/acpi/debugfs.c  |    3 +++
>  drivers/acpi/internal.h |    2 +-
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> index b55d6a2..96bcaf7 100644
> --- a/drivers/acpi/debugfs.c
> +++ b/drivers/acpi/debugfs.c
> @@ -6,6 +6,7 @@
>  #include <linux/init.h>
>  #include <linux/debugfs.h>
>  #include <acpi/acpi_drivers.h>
> +#include "internal.h"
>  
>  #define _COMPONENT		ACPI_SYSTEM_COMPONENT
>  ACPI_MODULE_NAME("debugfs");
> @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
>  struct dentry *acpi_debugfs_dir;
>  EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
>  
> +#ifdef  CONFIG_DEBUG_FS
>  void __init acpi_debugfs_init(void)
>  {
>  	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
>  }
> +#endif

What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?

That surely would make sense? 

> diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h
> index 8ef9787..c2e35bd 100644
> --- a/drivers/acpi/internal.h
> +++ b/drivers/acpi/internal.h
> @@ -63,7 +63,7 @@ void acpi_scan_hotplug_enabled(struct acpi_hotplug_profile *hotplug, bool val);
>  
>  #ifdef CONFIG_DEBUG_FS
>  extern struct dentry *acpi_debugfs_dir;
> -int acpi_debugfs_init(void);
> +void acpi_debugfs_init(void);
>  #else
>  static inline void acpi_debugfs_init(void) { return; }
>  #endif
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Josh Triplett]

On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote:
> On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> > Include header file internal.h in debugfs.c and change the return
> > value's type in header file internal.h.
> > 
> > This eliminates the following warning in debugfs.c:
> > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> >  drivers/acpi/debugfs.c  |    3 +++
> >  drivers/acpi/internal.h |    2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> > index b55d6a2..96bcaf7 100644
> > --- a/drivers/acpi/debugfs.c
> > +++ b/drivers/acpi/debugfs.c
> > @@ -6,6 +6,7 @@
> >  #include <linux/init.h>
> >  #include <linux/debugfs.h>
> >  #include <acpi/acpi_drivers.h>
> > +#include "internal.h"
> >  
> >  #define _COMPONENT		ACPI_SYSTEM_COMPONENT
> >  ACPI_MODULE_NAME("debugfs");
> > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
> >  struct dentry *acpi_debugfs_dir;
> >  EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
> >  
> > +#ifdef  CONFIG_DEBUG_FS
> >  void __init acpi_debugfs_init(void)
> >  {
> >  	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
> >  }
> > +#endif
> 
> What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?
> 
> That surely would make sense? 

It exports the symbol acpi_debugfs_dir, which is used unconditionally.

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Josh Triplett]

On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote:
> On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> > Include header file internal.h in debugfs.c and change the return
> > value's type in header file internal.h.
> > 
> > This eliminates the following warning in debugfs.c:
> > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > ---
> >  drivers/acpi/debugfs.c  |    3 +++
> >  drivers/acpi/internal.h |    2 +-
> >  2 files changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> > index b55d6a2..96bcaf7 100644
> > --- a/drivers/acpi/debugfs.c
> > +++ b/drivers/acpi/debugfs.c
> > @@ -6,6 +6,7 @@
> >  #include <linux/init.h>
> >  #include <linux/debugfs.h>
> >  #include <acpi/acpi_drivers.h>
> > +#include "internal.h"
> >  
> >  #define _COMPONENT		ACPI_SYSTEM_COMPONENT
> >  ACPI_MODULE_NAME("debugfs");
> > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
> >  struct dentry *acpi_debugfs_dir;
> >  EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
> >  
> > +#ifdef  CONFIG_DEBUG_FS
> >  void __init acpi_debugfs_init(void)
> >  {
> >  	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
> >  }
> > +#endif
> 
> What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?
> 
> That surely would make sense? 

It exports the symbol acpi_debugfs_dir, which is used unconditionally.

- Josh Triplett

Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Rafael J. Wysocki]

On Sunday, January 05, 2014 07:28:49 PM Josh Triplett wrote:
> On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote:
> > On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> > > Include header file internal.h in debugfs.c and change the return
> > > value's type in header file internal.h.
> > > 
> > > This eliminates the following warning in debugfs.c:
> > > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> > > 
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > ---
> > >  drivers/acpi/debugfs.c  |    3 +++
> > >  drivers/acpi/internal.h |    2 +-
> > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> > > index b55d6a2..96bcaf7 100644
> > > --- a/drivers/acpi/debugfs.c
> > > +++ b/drivers/acpi/debugfs.c
> > > @@ -6,6 +6,7 @@
> > >  #include <linux/init.h>
> > >  #include <linux/debugfs.h>
> > >  #include <acpi/acpi_drivers.h>
> > > +#include "internal.h"
> > >  
> > >  #define _COMPONENT		ACPI_SYSTEM_COMPONENT
> > >  ACPI_MODULE_NAME("debugfs");
> > > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
> > >  struct dentry *acpi_debugfs_dir;
> > >  EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
> > >  
> > > +#ifdef  CONFIG_DEBUG_FS
> > >  void __init acpi_debugfs_init(void)
> > >  {
> > >  	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
> > >  }
> > > +#endif
> > 
> > What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?
> > 
> > That surely would make sense? 
> 
> It exports the symbol acpi_debugfs_dir, which is used unconditionally.

It's only used by drivers/acpi/custom_method.c which also should only be
compiled for CONFIG_DEBUG_FS set.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 11/11] drivers: acpi: Include header file in debugfs.c and rectify prototype declaration in internal.h

[Rafael J. Wysocki]

On Sunday, January 05, 2014 07:28:49 PM Josh Triplett wrote:
> On Mon, Jan 06, 2014 at 12:33:57AM +0100, Rafael J. Wysocki wrote:
> > On Tuesday, December 17, 2013 03:06:54 PM Rashika Kheria wrote:
> > > Include header file internal.h in debugfs.c and change the return
> > > value's type in header file internal.h.
> > > 
> > > This eliminates the following warning in debugfs.c:
> > > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> > > 
> > > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> > > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> > > ---
> > >  drivers/acpi/debugfs.c  |    3 +++
> > >  drivers/acpi/internal.h |    2 +-
> > >  2 files changed, 4 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
> > > index b55d6a2..96bcaf7 100644
> > > --- a/drivers/acpi/debugfs.c
> > > +++ b/drivers/acpi/debugfs.c
> > > @@ -6,6 +6,7 @@
> > >  #include <linux/init.h>
> > >  #include <linux/debugfs.h>
> > >  #include <acpi/acpi_drivers.h>
> > > +#include "internal.h"
> > >  
> > >  #define _COMPONENT		ACPI_SYSTEM_COMPONENT
> > >  ACPI_MODULE_NAME("debugfs");
> > > @@ -13,7 +14,9 @@ ACPI_MODULE_NAME("debugfs");
> > >  struct dentry *acpi_debugfs_dir;
> > >  EXPORT_SYMBOL_GPL(acpi_debugfs_dir);
> > >  
> > > +#ifdef  CONFIG_DEBUG_FS
> > >  void __init acpi_debugfs_init(void)
> > >  {
> > >  	acpi_debugfs_dir = debugfs_create_dir("acpi", NULL);
> > >  }
> > > +#endif
> > 
> > What about avoiding to build the entire debugfs.c for CONFIG_DEBUG_FS unset?
> > 
> > That surely would make sense? 
> 
> It exports the symbol acpi_debugfs_dir, which is used unconditionally.

It's only used by drivers/acpi/custom_method.c which also should only be
compiled for CONFIG_DEBUG_FS set.

Thanks,
Rafael