All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
	Dave Airlie <airlied@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines.
Date: Fri, 11 Mar 2016 14:45:23 +0100	[thread overview]
Message-ID: <2759763.dR5D0KopkA@vostro.rjw.lan> (raw)
In-Reply-To: <20160311105815.GS1796@lahna.fi.intel.com>

On Friday, March 11, 2016 12:58:15 PM Mika Westerberg wrote:
> On Thu, Mar 10, 2016 at 09:57:09PM +0100, Rafael J. Wysocki wrote:
> > > It doesn't seem to do any runtime PM,
> > > I do wonder if pcieport should be doing it's own runtime PM handling,
> > > but that is a
> > > larger task than I'm thinking to tackle here.
> > 
> > PCIe ports don't do PM - yet.  Mika has posted a series of patches to implement
> > that, however, that are waiting for comments now:
> > 
> > https://patchwork.kernel.org/patch/8453311/
> > https://patchwork.kernel.org/patch/8453381/
> > https://patchwork.kernel.org/patch/8453391/
> > https://patchwork.kernel.org/patch/8453411/
> > https://patchwork.kernel.org/patch/8453371/
> > https://patchwork.kernel.org/patch/8453351/
> > 
> > > Maybe I should be doing
> > > 
> > > pci_set_power_state(pdev->bus->self, PCI_D3cold) ? I'm not really sure.
> > 
> > Using pci_set_power_state() would be more appropriate IMO, but you can get
> > to the bridge via dev->parent too, can't you?
> > 
> > In any case, it looks like you and Mika need to talk. :-)
> 
> When the vga_switcheroo device gets runtime suspended (with the above
> runtime PM patchs for PCIe root ports) the root port should also be
> runtime suspended by the PM core.

Right, after your patches have been applied, the additional handling
won't be needed.

So Dave, maybe you can check if the Mika's patches help?

Thanks,
Rafael

  reply	other threads:[~2016-03-11 13:45 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09  6:14 [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines Dave Airlie
2016-03-09  6:14 ` [PATCH 2/2] nouveau: use new vga_switcheroo power domain Dave Airlie
2016-03-09 13:20   ` Rafael J. Wysocki
2016-03-09 14:40   ` Lukas Wunner
2016-03-09 22:04     ` Dave Airlie
2016-03-15 20:47       ` Lukas Wunner
2016-03-09 13:19 ` [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines Rafael J. Wysocki
2016-03-09 21:56   ` Dave Airlie
2016-03-10 20:57     ` Rafael J. Wysocki
2016-03-11 10:58       ` Mika Westerberg
2016-03-11 13:45         ` Rafael J. Wysocki [this message]
2016-03-14  2:19           ` Dave Airlie
2016-03-14  2:19             ` Dave Airlie
2016-03-14  9:43             ` Mika Westerberg
2016-03-14  9:47               ` Dave Airlie
2016-03-14 10:02                 ` Daniel Vetter
2016-03-14 10:02                   ` Daniel Vetter
2016-03-14 10:23                 ` Mika Westerberg
2016-03-14 12:50                   ` Rafael J. Wysocki
2016-03-14 14:30                     ` Mika Westerberg
2016-03-15 13:39               ` Lukas Wunner
2016-03-15 13:39                 ` Lukas Wunner
2016-03-15 13:57                 ` Mika Westerberg
2016-03-14 14:30             ` Alex Deucher
2016-03-14 14:30               ` Alex Deucher
2016-03-09 14:33 ` Lukas Wunner
2016-03-09 14:33   ` Lukas Wunner
2016-03-09 16:52   ` Alex Deucher
2016-03-09 16:52     ` Alex Deucher
2016-03-09 20:17     ` Lukas Wunner
2016-03-09 20:17       ` Lukas Wunner
2016-03-09 20:22       ` Alex Deucher
2016-03-09 20:22         ` Alex Deucher
2016-03-09 22:02       ` Dave Airlie
2016-03-09 22:02         ` Dave Airlie
2016-03-09 22:00   ` Dave Airlie
2016-03-09 22:00     ` Dave Airlie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2759763.dR5D0KopkA@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=airlied@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.