From: Dave Airlie <airlied@gmail.com> To: Lukas Wunner <lukas@wunner.de> Cc: Linux ACPI <linux-acpi@vger.kernel.org>, Linux PCI <linux-pci@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>, Linux PM list <linux-pm@vger.kernel.org> Subject: Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Date: Thu, 10 Mar 2016 08:00:35 +1000 [thread overview] Message-ID: <CAPM=9twnnxvohz+Ao7rSDC0nm+DLOPrOq+hvoTVyb8+w27BFnA@mail.gmail.com> (raw) In-Reply-To: <20160309143336.GA26158@wunner.de> On 10 March 2016 at 00:33, Lukas Wunner <lukas@wunner.de> wrote: > Hi Dave, > > On Wed, Mar 09, 2016 at 04:14:04PM +1000, Dave Airlie wrote: >> From: Dave Airlie <airlied@redhat.com> >> >> Windows 10 seems to have standardised power control for the >> optimus/powerxpress laptops using PR3 power resource hooks. > > What happened to the Optimus DSM, does this still work? If not, > echoing OFF to the vgaswitcheroo sysfs file won't power down the > GPU now, right? (If runtime pm is disabled in nouveau.) No it doesn't work, hence why I had to go dig through this method. When you report Windows 2013 ACPI support to the BIOS it disables the PS3 method, and relies on hitting the PR3 method. Unlike ATPX I couldn't find any indicator bit in the optimus DSM to say which method to use. So we get to try both methods. I've confirmed on my older machine that if there are no PR3 methods, then it has no effect. > How about implementing an additional vga_switcheroo handler somewhere > in drivers/acpi/, which looks for the PR3 hooks and registers with > vga_switcheroo if found. The ->power_state callback of that handler > would then invoke acpi_device_set_power(). I've nothing to trigger off when to register in that case. I'm not sure if the PR3 hooks alone are enough to tell you whether you should be using this method. The ATPX guys have a bit we need to read to know if we should be using this method. > > In any case this patch should be amended with kerneldoc for > vga_switcheroo_init_parent_pr3_ops(), I've spent considerable time > last year to document everything and kindly ask that this water not > be muddied again. ;-) > > One small nit, the headers are sorted alphabetically yet acpi.h is > added at the end. I'll add those in v2. Dave. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Dave Airlie <airlied@gmail.com> To: Lukas Wunner <lukas@wunner.de> Cc: dri-devel <dri-devel@lists.freedesktop.org>, Linux PM list <linux-pm@vger.kernel.org>, Linux ACPI <linux-acpi@vger.kernel.org>, Linux PCI <linux-pci@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines. Date: Thu, 10 Mar 2016 08:00:35 +1000 [thread overview] Message-ID: <CAPM=9twnnxvohz+Ao7rSDC0nm+DLOPrOq+hvoTVyb8+w27BFnA@mail.gmail.com> (raw) In-Reply-To: <20160309143336.GA26158@wunner.de> On 10 March 2016 at 00:33, Lukas Wunner <lukas@wunner.de> wrote: > Hi Dave, > > On Wed, Mar 09, 2016 at 04:14:04PM +1000, Dave Airlie wrote: >> From: Dave Airlie <airlied@redhat.com> >> >> Windows 10 seems to have standardised power control for the >> optimus/powerxpress laptops using PR3 power resource hooks. > > What happened to the Optimus DSM, does this still work? If not, > echoing OFF to the vgaswitcheroo sysfs file won't power down the > GPU now, right? (If runtime pm is disabled in nouveau.) No it doesn't work, hence why I had to go dig through this method. When you report Windows 2013 ACPI support to the BIOS it disables the PS3 method, and relies on hitting the PR3 method. Unlike ATPX I couldn't find any indicator bit in the optimus DSM to say which method to use. So we get to try both methods. I've confirmed on my older machine that if there are no PR3 methods, then it has no effect. > How about implementing an additional vga_switcheroo handler somewhere > in drivers/acpi/, which looks for the PR3 hooks and registers with > vga_switcheroo if found. The ->power_state callback of that handler > would then invoke acpi_device_set_power(). I've nothing to trigger off when to register in that case. I'm not sure if the PR3 hooks alone are enough to tell you whether you should be using this method. The ATPX guys have a bit we need to read to know if we should be using this method. > > In any case this patch should be amended with kerneldoc for > vga_switcheroo_init_parent_pr3_ops(), I've spent considerable time > last year to document everything and kindly ask that this water not > be muddied again. ;-) > > One small nit, the headers are sorted alphabetically yet acpi.h is > added at the end. I'll add those in v2. Dave.
next prev parent reply other threads:[~2016-03-09 22:00 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-03-09 6:14 [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines Dave Airlie 2016-03-09 6:14 ` [PATCH 2/2] nouveau: use new vga_switcheroo power domain Dave Airlie 2016-03-09 13:20 ` Rafael J. Wysocki 2016-03-09 14:40 ` Lukas Wunner 2016-03-09 22:04 ` Dave Airlie 2016-03-15 20:47 ` Lukas Wunner 2016-03-09 13:19 ` [PATCH 1/2] vga_switcheroo: add power support for windows 10 machines Rafael J. Wysocki 2016-03-09 21:56 ` Dave Airlie 2016-03-10 20:57 ` Rafael J. Wysocki 2016-03-11 10:58 ` Mika Westerberg 2016-03-11 13:45 ` Rafael J. Wysocki 2016-03-14 2:19 ` Dave Airlie 2016-03-14 2:19 ` Dave Airlie 2016-03-14 9:43 ` Mika Westerberg 2016-03-14 9:47 ` Dave Airlie 2016-03-14 10:02 ` Daniel Vetter 2016-03-14 10:02 ` Daniel Vetter 2016-03-14 10:23 ` Mika Westerberg 2016-03-14 12:50 ` Rafael J. Wysocki 2016-03-14 14:30 ` Mika Westerberg 2016-03-15 13:39 ` Lukas Wunner 2016-03-15 13:39 ` Lukas Wunner 2016-03-15 13:57 ` Mika Westerberg 2016-03-14 14:30 ` Alex Deucher 2016-03-14 14:30 ` Alex Deucher 2016-03-09 14:33 ` Lukas Wunner 2016-03-09 14:33 ` Lukas Wunner 2016-03-09 16:52 ` Alex Deucher 2016-03-09 16:52 ` Alex Deucher 2016-03-09 20:17 ` Lukas Wunner 2016-03-09 20:17 ` Lukas Wunner 2016-03-09 20:22 ` Alex Deucher 2016-03-09 20:22 ` Alex Deucher 2016-03-09 22:02 ` Dave Airlie 2016-03-09 22:02 ` Dave Airlie 2016-03-09 22:00 ` Dave Airlie [this message] 2016-03-09 22:00 ` Dave Airlie
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPM=9twnnxvohz+Ao7rSDC0nm+DLOPrOq+hvoTVyb8+w27BFnA@mail.gmail.com' \ --to=airlied@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lukas@wunner.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.