Re: [PATCH urcu] Fix: SONAME bump to 6.1.0

Re: [PATCH urcu] Fix: SONAME bump to 6.1.0

[Mathieu Desnoyers]

Merged into master and stable-0.11. Will release a 0.11.1 version with this
fix right away.

Thanks!

Mathieu

----- On Jun 3, 2019, at 4:36 PM, Michael Jeanson mjeanson@efficios.com wrote:

> In commit d6c78161aed9b2d550ce201b0a8cd5b3ee515ac8 we bumped the 'age'
> part of the library version with the intention of keeping the same major
> SONAME because we only introduced new symbols. However by bumping the
> 'age' and not the 'current' we substracted 1 to the major SONAME which
> we did not intend. Seems like we missed this in testing.
> 
> Fix it by bumping the 'current' to end up with an SONAME of 6.1.0 which
> is what we originally intended.
> 
> From the libtool manual for reference :
> 
>  Programs using the previous version may use the new version as drop-in
>  replacement, but programs using the new version may use APIs not present
>  in the previous one. In other words, a program linking against the new
>  version may fail with “unresolved symbols” if linking against the old
>  version at runtime: set revision to 0, bump current and age.
> 
> Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index ed60885..1d13ea3 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -3,7 +3,7 @@ AC_INIT([userspace-rcu],[0.11.0],[mathieu dot desnoyers at
> efficios dot com], []
> 
> # Following the numbering scheme proposed by libtool for the library version
> #
> http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> -AC_SUBST([URCU_LIBRARY_VERSION], [6:0:1])
> +AC_SUBST([URCU_LIBRARY_VERSION], [7:0:1])
> 
> AC_CONFIG_HEADERS([include/config.h include/urcu/config.h])
> AC_CONFIG_AUX_DIR([config])
> --
> 2.17.1

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[PATCH urcu] Fix: SONAME bump to 6.1.0

[Michael Jeanson]

In commit d6c78161aed9b2d550ce201b0a8cd5b3ee515ac8 we bumped the 'age'
part of the library version with the intention of keeping the same major
SONAME because we only introduced new symbols. However by bumping the
'age' and not the 'current' we substracted 1 to the major SONAME which
we did not intend. Seems like we missed this in testing.

Fix it by bumping the 'current' to end up with an SONAME of 6.1.0 which
is what we originally intended.

From the libtool manual for reference :

  Programs using the previous version may use the new version as drop-in
  replacement, but programs using the new version may use APIs not present
  in the previous one. In other words, a program linking against the new
  version may fail with “unresolved symbols” if linking against the old
  version at runtime: set revision to 0, bump current and age.

Signed-off-by: Michael Jeanson <mjeanson@efficios.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index ed60885..1d13ea3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3,7 +3,7 @@ AC_INIT([userspace-rcu],[0.11.0],[mathieu dot desnoyers at efficios dot com], []
 
 # Following the numbering scheme proposed by libtool for the library version
 # http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
-AC_SUBST([URCU_LIBRARY_VERSION], [6:0:1])
+AC_SUBST([URCU_LIBRARY_VERSION], [7:0:1])
 
 AC_CONFIG_HEADERS([include/config.h include/urcu/config.h])
 AC_CONFIG_AUX_DIR([config])
-- 
2.17.1

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev