From: Roger Quadros <rogerq@ti.com>
To: Mohan Kumar <mohankumar718@gmail.com>
Cc: <tony@atomide.com>, <linux-omap@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: memory: This patch fix the following checkpatch warning.
Date: Tue, 16 Apr 2019 11:49:53 +0300 [thread overview]
Message-ID: <27678553-2f8b-cd8a-c3ed-dc897922dc42@ti.com> (raw)
In-Reply-To: <1555404372-3582-1-git-send-email-mohankumar718@gmail.com>
Hi Mohan,
On 16/04/2019 11:46, Mohan Kumar wrote:
> Switch hardcoded function name with a reference to __func__ making the
> code more maintainable
>
> WARNING: Prefer using '"%s...", __func__' to using function's name, in a
> string
>
> Use pr_warn instead of printk
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
> then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
> ---
> drivers/memory/omap-gpmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index f629759..685f422 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -795,7 +795,7 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t,
> #endif
>
> gpmc_cs_bool_timings(cs, &t->bool_timings);
> - gpmc_cs_show_timings(cs, "after gpmc_cs_set_timings");
> + gpmc_cs_show_timings(cs, "%s", __func__);
This will not build. gpmc_cs_show_timings only takes 2 arguments.
>
> return 0;
> }
> @@ -1033,7 +1033,7 @@ void gpmc_cs_free(int cs)
>
> spin_lock(&gpmc_mem_lock);
> if (cs >= gpmc_cs_num || cs < 0 || !gpmc_cs_reserved(cs)) {
> - printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs);
> + pr_err("Trying to free non-reserved GPMC CS%d\n", cs);
> BUG();
> spin_unlock(&gpmc_mem_lock);
> return;
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Mohan Kumar <mohankumar718@gmail.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: memory: This patch fix the following checkpatch warning.
Date: Tue, 16 Apr 2019 11:49:53 +0300 [thread overview]
Message-ID: <27678553-2f8b-cd8a-c3ed-dc897922dc42@ti.com> (raw)
In-Reply-To: <1555404372-3582-1-git-send-email-mohankumar718@gmail.com>
Hi Mohan,
On 16/04/2019 11:46, Mohan Kumar wrote:
> Switch hardcoded function name with a reference to __func__ making the
> code more maintainable
>
> WARNING: Prefer using '"%s...", __func__' to using function's name, in a
> string
>
> Use pr_warn instead of printk
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ...
> then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
>
> Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
> ---
> drivers/memory/omap-gpmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index f629759..685f422 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -795,7 +795,7 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t,
> #endif
>
> gpmc_cs_bool_timings(cs, &t->bool_timings);
> - gpmc_cs_show_timings(cs, "after gpmc_cs_set_timings");
> + gpmc_cs_show_timings(cs, "%s", __func__);
This will not build. gpmc_cs_show_timings only takes 2 arguments.
>
> return 0;
> }
> @@ -1033,7 +1033,7 @@ void gpmc_cs_free(int cs)
>
> spin_lock(&gpmc_mem_lock);
> if (cs >= gpmc_cs_num || cs < 0 || !gpmc_cs_reserved(cs)) {
> - printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs);
> + pr_err("Trying to free non-reserved GPMC CS%d\n", cs);
> BUG();
> spin_unlock(&gpmc_mem_lock);
> return;
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-04-16 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 8:46 [PATCH] drivers: memory: This patch fix the following checkpatch warning Mohan Kumar
2019-04-16 8:49 ` Roger Quadros [this message]
2019-04-16 8:49 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27678553-2f8b-cd8a-c3ed-dc897922dc42@ti.com \
--to=rogerq@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mohankumar718@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.