All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Thomas Pedersen <twp@qca.qualcomm.com>,
	linux-wireless <linux-wireless@vger.kernel.org>
Cc: Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8
Date: Tue, 6 Sep 2016 12:07:18 -0700	[thread overview]
Message-ID: <2769a14e-964d-4ec2-9f04-ddd332434b78@candelatech.com> (raw)
In-Reply-To: <1473188417-13987-1-git-send-email-twp@qca.qualcomm.com>

On 09/06/2016 12:00 PM, Thomas Pedersen wrote:
> Some drivers (ath10k) report MCS 9 @ 20MHz, which
> technically isn't allowed. To get more meaningful value
> than 0 out of this however, just cap the bitrate for 20MHz
> to MCS 8.

If it is actually reporting MCS9, why lie about it?  Report it up
the stack as a proper value instead of hiding the issue?

Thanks,
Ben


>
> Signed-off-by: Thomas Pedersen <twp@qca.qualcomm.com>
> ---
>  net/wireless/util.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/wireless/util.c b/net/wireless/util.c
> index 0675f51..5fb0249 100644
> --- a/net/wireless/util.c
> +++ b/net/wireless/util.c
> @@ -1157,7 +1157,9 @@ static u32 cfg80211_calculate_bitrate_vht(struct rate_info *rate)
>  		   58500000,
>  		   65000000,
>  		   78000000,
> -		   0,
> +		   /* some drivers report MCS 9 for 20MHz anyway. Clip to MCS 8
> +		    * bitrate as it's closer than 0 */
> +		   78000000,
>  		},
>  		{  13500000,
>  		   27000000,
>


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

  reply	other threads:[~2016-09-06 19:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-06 19:00 [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8 Thomas Pedersen
2016-09-06 19:07 ` Ben Greear [this message]
2016-09-07 18:20   ` Pedersen, Thomas
2016-09-12  6:43     ` Johannes Berg
2016-09-12 16:36       ` Ben Greear
2016-09-13 17:57       ` Pedersen, Thomas
2016-09-13 18:02         ` Johannes Berg
2016-09-16 18:31           ` Pedersen, Thomas
2016-09-19  9:00             ` Johannes Berg
2016-09-19  9:31               ` Arend Van Spriel
2016-09-19 16:19               ` Ben Greear
2016-10-04  9:32                 ` Johannes Berg
2016-10-04 16:31                   ` Ben Greear
2016-10-13 12:52                     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2769a14e-964d-4ec2-9f04-ddd332434b78@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=twp@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.