From: Ben Greear <greearb@candelatech.com>
To: Johannes Berg <johannes@sipsolutions.net>,
"Pedersen, Thomas" <twp@qca.qualcomm.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8
Date: Mon, 19 Sep 2016 09:19:50 -0700 [thread overview]
Message-ID: <57E01026.9030604@candelatech.com> (raw)
In-Reply-To: <1474275637.4469.15.camel@sipsolutions.net>
On 09/19/2016 02:00 AM, Johannes Berg wrote:
>
>> Actually, can you apply the v2 (cfg80211: add bitrate for 20MHz MCS
>> 9) of this? Systems guys confirmed they use MCS 9 @ 20MHz when LDPC
>> is enabled. Also confirmed bitrate should be ok.
>
> I don't really understand that. How can the bitrate be "OK" when the
> spec explicitly says it cannot be used?
>
> johannes
>
I think it is a moot point as far as this change goes: Regardless of whether
the NIC should or not, it _does_. So, mis-reporting it up the stack only hides
the issue and does not even give the user a clue that on-the-air encoding may be
slightly off-spec.
If the on-air encoding is an issue, then we need to hack the firmware to
disable this 'feature', but that is a completely separate issue.
Once this patch goes in, someone might consider properly reporting CCK
rx rates for 5Ghz band too: ath10k can do this 'feature' as well, at least
in some firmware. Probably can reproduce by sending off-channel mgt frames on
5Ghz when associated on 2.4, or something similar to this. I was using ath9k as
sniffer when I found this long ago, so at least ath9k needs the change....
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2016-09-19 16:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 19:00 [PATCH] cfg80211: cap 20MHz VHT bitrate at MCS 8 Thomas Pedersen
2016-09-06 19:07 ` Ben Greear
2016-09-07 18:20 ` Pedersen, Thomas
2016-09-12 6:43 ` Johannes Berg
2016-09-12 16:36 ` Ben Greear
2016-09-13 17:57 ` Pedersen, Thomas
2016-09-13 18:02 ` Johannes Berg
2016-09-16 18:31 ` Pedersen, Thomas
2016-09-19 9:00 ` Johannes Berg
2016-09-19 9:31 ` Arend Van Spriel
2016-09-19 16:19 ` Ben Greear [this message]
2016-10-04 9:32 ` Johannes Berg
2016-10-04 16:31 ` Ben Greear
2016-10-13 12:52 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57E01026.9030604@candelatech.com \
--to=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=twp@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.