* [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()
@ 2022-11-06 14:16 wangkailong
2022-11-07 8:52 ` Helge Deller
0 siblings, 1 reply; 3+ messages in thread
From: wangkailong @ 2022-11-06 14:16 UTC (permalink / raw)
To: deller, arnd, b.zolnierkie, robert.jarzmik, ulf.hansson, wangqing
Cc: linux-fbdev, dri-devel, linux-kernel
Eliminate the follow coccicheck warning:
./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
platform_get_irq() already prints an error
Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
drivers/video/fbdev/pxafb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
index 696ac5431180..c46ed78298ae 100644
--- a/drivers/video/fbdev/pxafb.c
+++ b/drivers/video/fbdev/pxafb.c
@@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)
irq = platform_get_irq(dev, 0);
if (irq < 0) {
- dev_err(&dev->dev, "no IRQ defined\n");
ret = -ENODEV;
goto failed_free_mem;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()
2022-11-06 14:16 [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err() wangkailong
@ 2022-11-07 8:52 ` Helge Deller
0 siblings, 0 replies; 3+ messages in thread
From: Helge Deller @ 2022-11-07 8:52 UTC (permalink / raw)
To: arnd, b.zolnierkie, robert.jarzmik, ulf.hansson, wangqing
Cc: linux-fbdev, dri-devel, linux-kernel
On 11/6/22 15:16, wangkailong@jari.cn wrote:
> Eliminate the follow coccicheck warning:
>
> ./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/pxafb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 696ac5431180..c46ed78298ae 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)
>
> irq = platform_get_irq(dev, 0);
> if (irq < 0) {
> - dev_err(&dev->dev, "no IRQ defined\n");
> ret = -ENODEV;
> goto failed_free_mem;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err()
@ 2022-11-07 8:52 ` Helge Deller
0 siblings, 0 replies; 3+ messages in thread
From: Helge Deller @ 2022-11-07 8:52 UTC (permalink / raw)
To: arnd, b.zolnierkie, robert.jarzmik, ulf.hansson, wangqing
Cc: linux-fbdev, linux-kernel, dri-devel
On 11/6/22 15:16, wangkailong@jari.cn wrote:
> Eliminate the follow coccicheck warning:
>
> ./drivers/video/fbdev/pxafb.c:2330:2-9: line 2330 is redundant because
> platform_get_irq() already prints an error
>
> Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
applied.
Thanks!
Helge
> ---
> drivers/video/fbdev/pxafb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c
> index 696ac5431180..c46ed78298ae 100644
> --- a/drivers/video/fbdev/pxafb.c
> +++ b/drivers/video/fbdev/pxafb.c
> @@ -2327,7 +2327,6 @@ static int pxafb_probe(struct platform_device *dev)
>
> irq = platform_get_irq(dev, 0);
> if (irq < 0) {
> - dev_err(&dev->dev, "no IRQ defined\n");
> ret = -ENODEV;
> goto failed_free_mem;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-07 8:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-06 14:16 [PATCH] video: fbdev: pxafb: Remove unnecessary print function dev_err() wangkailong
2022-11-07 8:52 ` Helge Deller
2022-11-07 8:52 ` Helge Deller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.