All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: omap: fix Kconfig warning
Date: Mon, 08 Sep 2014 20:16:42 +0200	[thread overview]
Message-ID: <2797284.2mFcuQ0Ias@wuerfel> (raw)
In-Reply-To: <20140908153400.GC3238@atomide.com>

On Monday 08 September 2014 08:34:00 Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [140908 08:01]:
> > A small mistake during the recent Kconfig cleanup has led
> > to a harmless warning for OMAP1:
> > 
> > warning: (ARCH_OMAP1) selects ARCH_OMAP which has unmet direct dependencies (ARCH_MULTI_V6 || ARCH_MULTI_V7)
> > 
> > We can easily avoid that by moving the ARCH_OMAP symbol outside of the
> > OMAP2 submenu.
> 
> OK I made a similar patch, but I moved it into plat-omap/Kconfig
> as it's also used by omap1. The regression was probably caused by
> commit 21278aeafbfa (ARM: use menuconfig for sub-arch menus).
> 
> If that works for you, I'll verify the regression causing commit
> and post it with a description.

Yes, sounds good. Your version is better than mind.

	Arnd

> 
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -1,9 +1,6 @@
>  menu "TI OMAP/AM/DM/DRA Family"
>  	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7
>  
> -config ARCH_OMAP
> -	bool
> -
>  config ARCH_OMAP2
>  	bool "TI OMAP2"
>  	depends on ARCH_MULTI_V6
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -1,3 +1,6 @@
> +config ARCH_OMAP
> +	bool
> +
>  if ARCH_OMAP
>  
>  menu "TI OMAP Common Features"


WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: omap: fix Kconfig warning
Date: Mon, 08 Sep 2014 20:16:42 +0200	[thread overview]
Message-ID: <2797284.2mFcuQ0Ias@wuerfel> (raw)
In-Reply-To: <20140908153400.GC3238@atomide.com>

On Monday 08 September 2014 08:34:00 Tony Lindgren wrote:
> * Arnd Bergmann <arnd@arndb.de> [140908 08:01]:
> > A small mistake during the recent Kconfig cleanup has led
> > to a harmless warning for OMAP1:
> > 
> > warning: (ARCH_OMAP1) selects ARCH_OMAP which has unmet direct dependencies (ARCH_MULTI_V6 || ARCH_MULTI_V7)
> > 
> > We can easily avoid that by moving the ARCH_OMAP symbol outside of the
> > OMAP2 submenu.
> 
> OK I made a similar patch, but I moved it into plat-omap/Kconfig
> as it's also used by omap1. The regression was probably caused by
> commit 21278aeafbfa (ARM: use menuconfig for sub-arch menus).
> 
> If that works for you, I'll verify the regression causing commit
> and post it with a description.

Yes, sounds good. Your version is better than mind.

	Arnd

> 
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -1,9 +1,6 @@
>  menu "TI OMAP/AM/DM/DRA Family"
>  	depends on ARCH_MULTI_V6 || ARCH_MULTI_V7
>  
> -config ARCH_OMAP
> -	bool
> -
>  config ARCH_OMAP2
>  	bool "TI OMAP2"
>  	depends on ARCH_MULTI_V6
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -1,3 +1,6 @@
> +config ARCH_OMAP
> +	bool
> +
>  if ARCH_OMAP
>  
>  menu "TI OMAP Common Features"

  reply	other threads:[~2014-09-08 18:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 15:00 [PATCH] ARM: omap: fix Kconfig warning Arnd Bergmann
2014-09-08 15:00 ` Arnd Bergmann
2014-09-08 15:34 ` Tony Lindgren
2014-09-08 15:34   ` Tony Lindgren
2014-09-08 18:16   ` Arnd Bergmann [this message]
2014-09-08 18:16     ` Arnd Bergmann
2014-09-08 21:29     ` Tony Lindgren
2014-09-08 21:29       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2797284.2mFcuQ0Ias@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.