* [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name
@ 2022-09-25 21:02 Luca Weiss
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
` (5 more replies)
0 siblings, 6 replies; 19+ messages in thread
From: Luca Weiss @ 2022-09-25 21:02 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
Adjust the node name to match bindings and fix the validation warning.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
index 9b7d9d04ded6..be8c8032a3b1 100644
--- a/arch/arm/boot/dts/qcom-pm8226.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
@@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
#address-cells = <1>;
#size-cells = <0>;
- pm8226_spmi_regulators: pm8226-regulators {
+ pm8226_spmi_regulators: regulators {
compatible = "qcom,pm8226-regulators";
};
--
2.37.3
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
@ 2022-09-25 21:02 ` Luca Weiss
2022-09-26 8:56 ` Neil Armstrong
` (2 more replies)
2022-09-25 21:02 ` [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name " Luca Weiss
` (4 subsequent siblings)
5 siblings, 3 replies; 19+ messages in thread
From: Luca Weiss @ 2022-09-25 21:02 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
index 33517cccee01..01f14d5f314d 100644
--- a/arch/arm/boot/dts/qcom-pm8941.dtsi
+++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
@@ -27,7 +27,7 @@ pwrkey@800 {
bias-pull-up;
};
- usb_id: misc@900 {
+ usb_id: extcon@900 {
compatible = "qcom,pm8941-misc";
reg = <0x900>;
interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
@@ -138,7 +138,7 @@ pm8941_iadc: adc@3600 {
qcom,external-resistor-micro-ohms = <10000>;
};
- pm8941_coincell: coincell@2800 {
+ pm8941_coincell: charger@2800 {
compatible = "qcom,pm8941-coincell";
reg = <0x2800>;
status = "disabled";
--
2.37.3
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name to bindings
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
@ 2022-09-25 21:02 ` Luca Weiss
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
2022-09-26 8:53 ` [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Neil Armstrong
` (3 subsequent siblings)
5 siblings, 2 replies; 19+ messages in thread
From: Luca Weiss @ 2022-09-25 21:02 UTC (permalink / raw)
To: linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Luca Weiss, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
The pm8941-coincell node is supposed to be called 'charger'.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
index d09f2954b6f9..52c1b34e7d79 100644
--- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
@@ -63,7 +63,7 @@ pm8998_temp: temp-alarm@2400 {
#thermal-sensor-cells = <0>;
};
- pm8998_coincell: coincell@2800 {
+ pm8998_coincell: charger@2800 {
compatible = "qcom,pm8941-coincell";
reg = <0x2800>;
--
2.37.3
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
2022-09-25 21:02 ` [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name " Luca Weiss
@ 2022-09-26 8:53 ` Neil Armstrong
2022-09-26 8:56 ` Neil Armstrong
` (2 subsequent siblings)
5 siblings, 0 replies; 19+ messages in thread
From: Neil Armstrong @ 2022-09-26 8:53 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index 9b7d9d04ded6..be8c8032a3b1 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pm8226_spmi_regulators: pm8226-regulators {
> + pm8226_spmi_regulators: regulators {
> compatible = "qcom,pm8226-regulators";
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
@ 2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
2 siblings, 0 replies; 19+ messages in thread
From: Neil Armstrong @ 2022-09-26 8:56 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
Hi,
On 25/09/2022 23:02, Luca Weiss wrote:
> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 33517cccee01..01f14d5f314d 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -27,7 +27,7 @@ pwrkey@800 {
> bias-pull-up;
> };
>
> - usb_id: misc@900 {
> + usb_id: extcon@900 {
> compatible = "qcom,pm8941-misc";
> reg = <0x900>;
> interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> @@ -138,7 +138,7 @@ pm8941_iadc: adc@3600 {
> qcom,external-resistor-micro-ohms = <10000>;
> };
>
> - pm8941_coincell: coincell@2800 {
> + pm8941_coincell: charger@2800 {
> compatible = "qcom,pm8941-coincell";
> reg = <0x2800>;
> status = "disabled";
I think those changes are unrelated and should be split into 2 patches.
Neil
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
` (2 preceding siblings ...)
2022-09-26 8:53 ` [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Neil Armstrong
@ 2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:05 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
5 siblings, 0 replies; 19+ messages in thread
From: Neil Armstrong @ 2022-09-26 8:56 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index 9b7d9d04ded6..be8c8032a3b1 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pm8226_spmi_regulators: pm8226-regulators {
> + pm8226_spmi_regulators: regulators {
> compatible = "qcom,pm8226-regulators";
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
` (3 preceding siblings ...)
2022-09-26 8:56 ` Neil Armstrong
@ 2022-09-26 9:05 ` Krzysztof Kozlowski
2022-09-26 9:12 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
5 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 9:05 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
Thanks, I missed it in my last cleanups.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name
2022-09-26 9:05 ` Krzysztof Kozlowski
@ 2022-09-26 9:12 ` Krzysztof Kozlowski
2022-09-26 9:19 ` Krzysztof Kozlowski
0 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 9:12 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 26/09/2022 11:05, Krzysztof Kozlowski wrote:
> On 25/09/2022 23:02, Luca Weiss wrote:
>> Adjust the node name to match bindings and fix the validation warning.
>>
>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>> ---
>> arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
>
> Thanks, I missed it in my last cleanups.
No, this should be rather squashed with my cleanups:
https://lore.kernel.org/all/20220901093401.134473-3-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name
2022-09-26 9:12 ` Krzysztof Kozlowski
@ 2022-09-26 9:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 9:19 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 26/09/2022 11:12, Krzysztof Kozlowski wrote:
> On 26/09/2022 11:05, Krzysztof Kozlowski wrote:
>> On 25/09/2022 23:02, Luca Weiss wrote:
>>> Adjust the node name to match bindings and fix the validation warning.
>>>
>>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>>> ---
>>> arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
>>
>> Thanks, I missed it in my last cleanups.
>
> No, this should be rather squashed with my cleanups:
> https://lore.kernel.org/all/20220901093401.134473-3-krzysztof.kozlowski@linaro.org/
No, to a no, my patch was changing RPM regulators... Argh, damn that
naming...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
2022-09-26 8:56 ` Neil Armstrong
@ 2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-26 10:04 ` Neil Armstrong
2022-09-27 13:07 ` Konrad Dybcio
2 siblings, 1 reply; 19+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 9:22 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 23:02, Luca Weiss wrote:
> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 33517cccee01..01f14d5f314d 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -27,7 +27,7 @@ pwrkey@800 {
> bias-pull-up;
> };
>
> - usb_id: misc@900 {
> + usb_id: extcon@900 {
Why? extcon is Linux specific name and should not be added to DTS.
Anything requires it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name to bindings
2022-09-25 21:02 ` [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name " Luca Weiss
@ 2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 9:22 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 25/09/2022 23:02, Luca Weiss wrote:
> The pm8941-coincell node is supposed to be called 'charger'.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-26 9:22 ` Krzysztof Kozlowski
@ 2022-09-26 10:04 ` Neil Armstrong
2022-09-26 10:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 19+ messages in thread
From: Neil Armstrong @ 2022-09-26 10:04 UTC (permalink / raw)
To: Krzysztof Kozlowski, Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
> On 25/09/2022 23:02, Luca Weiss wrote:
>> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
>>
>> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
>> ---
>> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
>> index 33517cccee01..01f14d5f314d 100644
>> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
>> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
>> @@ -27,7 +27,7 @@ pwrkey@800 {
>> bias-pull-up;
>> };
>>
>> - usb_id: misc@900 {
>> + usb_id: extcon@900 {
>
> Why? extcon is Linux specific name and should not be added to DTS.
> Anything requires it?
It matches the current dt bindings:
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml:
<snip>
"extcon@[0-9a-f]+$":
type: object
$ref: /schemas/extcon/qcom,pm8941-misc.yaml#
<snip>
Neil
>
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-26 10:04 ` Neil Armstrong
@ 2022-09-26 10:29 ` Krzysztof Kozlowski
2022-09-26 15:07 ` Luca Weiss
2022-09-26 15:17 ` Neil Armstrong
0 siblings, 2 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-26 10:29 UTC (permalink / raw)
To: neil.armstrong, Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 26/09/2022 12:04, Neil Armstrong wrote:
> On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
>>> };
>>>
>>> - usb_id: misc@900 {
>>> + usb_id: extcon@900 {
>>
>> Why? extcon is Linux specific name and should not be added to DTS.
>> Anything requires it?
>
> It matches the current dt bindings:
Then instead maybe let's fix it in the bindings and DTS?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-26 10:29 ` Krzysztof Kozlowski
@ 2022-09-26 15:07 ` Luca Weiss
2022-09-28 7:24 ` Krzysztof Kozlowski
2022-09-26 15:17 ` Neil Armstrong
1 sibling, 1 reply; 19+ messages in thread
From: Luca Weiss @ 2022-09-26 15:07 UTC (permalink / raw)
To: neil.armstrong, linux-arm-msm, Krzysztof Kozlowski
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
Hi Krzysztof,
On Montag, 26. September 2022 12:29:11 CEST Krzysztof Kozlowski wrote:
> On 26/09/2022 12:04, Neil Armstrong wrote:
> > On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
> >>> };
> >>>
> >>> - usb_id: misc@900 {
> >>> + usb_id: extcon@900 {
> >>
> >> Why? extcon is Linux specific name and should not be added to DTS.
> >> Anything requires it?
> >
> > It matches the current dt bindings:
> Then instead maybe let's fix it in the bindings and DTS?
What node name do you propose? I doubt "misc" is a better name as it really
doesn't describe anything so I don't really have a suggestion here..
Regards
Luca
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-26 10:29 ` Krzysztof Kozlowski
2022-09-26 15:07 ` Luca Weiss
@ 2022-09-26 15:17 ` Neil Armstrong
1 sibling, 0 replies; 19+ messages in thread
From: Neil Armstrong @ 2022-09-26 15:17 UTC (permalink / raw)
To: Krzysztof Kozlowski, Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 26/09/2022 12:29, Krzysztof Kozlowski wrote:
> On 26/09/2022 12:04, Neil Armstrong wrote:
>> On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
>>>> };
>>>>
>>>> - usb_id: misc@900 {
>>>> + usb_id: extcon@900 {
>>>
>>> Why? extcon is Linux specific name and should not be added to DTS.
>>> Anything requires it?
>>
>> It matches the current dt bindings:
>
> Then instead maybe let's fix it in the bindings and DTS?
Yes it would be preferable
>
> Best regards,
> Krzysztof
>
Neil
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
` (4 preceding siblings ...)
2022-09-26 9:05 ` Krzysztof Kozlowski
@ 2022-09-27 13:07 ` Konrad Dybcio
5 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:07 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 25.09.2022 23:02, Luca Weiss wrote:
> Adjust the node name to match bindings and fix the validation warning.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-pm8226.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8226.dtsi b/arch/arm/boot/dts/qcom-pm8226.dtsi
> index 9b7d9d04ded6..be8c8032a3b1 100644
> --- a/arch/arm/boot/dts/qcom-pm8226.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8226.dtsi
> @@ -98,7 +98,7 @@ pm8226_1: pm8226@1 {
> #address-cells = <1>;
> #size-cells = <0>;
>
> - pm8226_spmi_regulators: pm8226-regulators {
> + pm8226_spmi_regulators: regulators {
> compatible = "qcom,pm8226-regulators";
> };
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:22 ` Krzysztof Kozlowski
@ 2022-09-27 13:07 ` Konrad Dybcio
2 siblings, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:07 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 25.09.2022 23:02, Luca Weiss wrote:
> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 33517cccee01..01f14d5f314d 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -27,7 +27,7 @@ pwrkey@800 {
> bias-pull-up;
> };
>
> - usb_id: misc@900 {
> + usb_id: extcon@900 {
> compatible = "qcom,pm8941-misc";
> reg = <0x900>;
> interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> @@ -138,7 +138,7 @@ pm8941_iadc: adc@3600 {
> qcom,external-resistor-micro-ohms = <10000>;
> };
>
> - pm8941_coincell: coincell@2800 {
> + pm8941_coincell: charger@2800 {
> compatible = "qcom,pm8941-coincell";
> reg = <0x2800>;
> status = "disabled";
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name to bindings
2022-09-25 21:02 ` [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name " Luca Weiss
2022-09-26 9:22 ` Krzysztof Kozlowski
@ 2022-09-27 13:07 ` Konrad Dybcio
1 sibling, 0 replies; 19+ messages in thread
From: Konrad Dybcio @ 2022-09-27 13:07 UTC (permalink / raw)
To: Luca Weiss, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski, devicetree,
linux-kernel
On 25.09.2022 23:02, Luca Weiss wrote:
> The pm8941-coincell node is supposed to be called 'charger'.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> index d09f2954b6f9..52c1b34e7d79 100644
> --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi
> @@ -63,7 +63,7 @@ pm8998_temp: temp-alarm@2400 {
> #thermal-sensor-cells = <0>;
> };
>
> - pm8998_coincell: coincell@2800 {
> + pm8998_coincell: charger@2800 {
> compatible = "qcom,pm8941-coincell";
> reg = <0x2800>;
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
2022-09-26 15:07 ` Luca Weiss
@ 2022-09-28 7:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 19+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-28 7:24 UTC (permalink / raw)
To: Luca Weiss, neil.armstrong, linux-arm-msm
Cc: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
devicetree, linux-kernel
On 26/09/2022 17:07, Luca Weiss wrote:
> Hi Krzysztof,
>
> On Montag, 26. September 2022 12:29:11 CEST Krzysztof Kozlowski wrote:
>> On 26/09/2022 12:04, Neil Armstrong wrote:
>>> On 26/09/2022 11:22, Krzysztof Kozlowski wrote:
>>>>> };
>>>>>
>>>>> - usb_id: misc@900 {
>>>>> + usb_id: extcon@900 {
>>>>
>>>> Why? extcon is Linux specific name and should not be added to DTS.
>>>> Anything requires it?
>>>
>>> It matches the current dt bindings:
>> Then instead maybe let's fix it in the bindings and DTS?
>
> What node name do you propose? I doubt "misc" is a better name as it really
> doesn't describe anything so I don't really have a suggestion here..
>
Some manufacturers call it a muic (Micro-USB IC), but maybe just
usb-detect? The role of this device is accessory and cable detection.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2022-09-28 7:28 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-25 21:02 [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Luca Weiss
2022-09-25 21:02 ` [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings Luca Weiss
2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-26 10:04 ` Neil Armstrong
2022-09-26 10:29 ` Krzysztof Kozlowski
2022-09-26 15:07 ` Luca Weiss
2022-09-28 7:24 ` Krzysztof Kozlowski
2022-09-26 15:17 ` Neil Armstrong
2022-09-27 13:07 ` Konrad Dybcio
2022-09-25 21:02 ` [PATCH 3/3] arm64: dts: qcom: pm8998: adjust coincell node name " Luca Weiss
2022-09-26 9:22 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
2022-09-26 8:53 ` [PATCH 1/3] ARM: dts: qcom: pm8226: fix regulators node name Neil Armstrong
2022-09-26 8:56 ` Neil Armstrong
2022-09-26 9:05 ` Krzysztof Kozlowski
2022-09-26 9:12 ` Krzysztof Kozlowski
2022-09-26 9:19 ` Krzysztof Kozlowski
2022-09-27 13:07 ` Konrad Dybcio
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.