From: Tianyu Lan <ltykernel@gmail.com> To: Christoph Hellwig <hch@lst.de> Cc: kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, arnd@arndb.de, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, rppt@kernel.org, hannes@cmpxchg.org, cai@lca.pw, krish.sadhukhan@oracle.com, saravanand@fb.com, Tianyu.Lan@microsoft.com, konrad.wilk@oracle.com, m.szyprowski@samsung.com, robin.murphy@arm.com, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, joro@8bytes.org, will@kernel.org, xen-devel@lists.xenproject.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com, iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com, thomas.lendacky@amd.com, brijesh.singh@amd.com, sunilmut@microsoft.com Subject: Re: [RFC PATCH V3 10/11] HV/Netvsc: Add Isolation VM support for netvsc driver Date: Mon, 7 Jun 2021 23:21:20 +0800 [thread overview] Message-ID: <279cb4bf-c5b6-6db9-0f1e-9238e902c8f2@gmail.com> (raw) In-Reply-To: <20210607065007.GE24478@lst.de> On 6/7/2021 2:50 PM, Christoph Hellwig wrote: > On Sun, May 30, 2021 at 11:06:27AM -0400, Tianyu Lan wrote: >> + if (hv_isolation_type_snp()) { >> + pfns = kcalloc(buf_size / HV_HYP_PAGE_SIZE, sizeof(unsigned long), >> + GFP_KERNEL); >> + for (i = 0; i < buf_size / HV_HYP_PAGE_SIZE; i++) >> + pfns[i] = virt_to_hvpfn(net_device->recv_buf + i * HV_HYP_PAGE_SIZE) + >> + (ms_hyperv.shared_gpa_boundary >> HV_HYP_PAGE_SHIFT); >> + >> + vaddr = vmap_pfn(pfns, buf_size / HV_HYP_PAGE_SIZE, PAGE_KERNEL_IO); >> + kfree(pfns); >> + if (!vaddr) >> + goto cleanup; >> + net_device->recv_original_buf = net_device->recv_buf; >> + net_device->recv_buf = vaddr; >> + } > > This probably wnats a helper to make the thing more readable. But who > came up with this fucked up communication protocol where the host needs > to map random pfns into a contigous range? Sometime I really have to > wonder what crack the hyper-v people take when comparing this to the > relatively sane approach others take. Agree. Will add a helper function. > >> + for (i = 0; i < page_count; i++) >> + dma_unmap_single(&hv_dev->device, packet->dma_range[i].dma, >> + packet->dma_range[i].mapping_size, >> + DMA_TO_DEVICE); >> + >> + kfree(packet->dma_range); > > Any reason this isn't simply using a struct scatterlist? I will have a look. Thanks to reminder scatterlist. > >> + for (i = 0; i < page_count; i++) { >> + char *src = phys_to_virt((pb[i].pfn << HV_HYP_PAGE_SHIFT) >> + + pb[i].offset); >> + u32 len = pb[i].len; >> + >> + dma = dma_map_single(&hv_dev->device, src, len, >> + DMA_TO_DEVICE); > > dma_map_single can only be used on page baked memory, and if this is > using page backed memory you wouldn't need to do thee phys_to_virt > tricks. Can someone explain the mess here in more detail? Sorry. Could you elaborate the issue? These pages in the pb array are not allocated by DMA API and using dma_map_single() here is to map these pages' address to bounce buffer physical address. > >> struct rndis_device *dev = nvdev->extension; >> struct rndis_request *request = NULL; >> + struct hv_device *hv_dev = ((struct net_device_context *) >> + netdev_priv(ndev))->device_ctx; > > Why not use a net_device_context local variable instead of this cast > galore? > OK. I will update. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Tianyu Lan <ltykernel@gmail.com> To: Christoph Hellwig <hch@lst.de> Cc: linux-hyperv@vger.kernel.org, brijesh.singh@amd.com, peterz@infradead.org, dave.hansen@linux.intel.com, hpa@zytor.com, kys@microsoft.com, will@kernel.org, boris.ostrovsky@oracle.com, linux-arch@vger.kernel.org, wei.liu@kernel.org, sstabellini@kernel.org, sthemmin@microsoft.com, linux-scsi@vger.kernel.org, x86@kernel.org, decui@microsoft.com, mingo@redhat.com, xen-devel@lists.xenproject.org, jejb@linux.ibm.com, thomas.lendacky@amd.com, Tianyu.Lan@microsoft.com, arnd@arndb.de, konrad.wilk@oracle.com, haiyangz@microsoft.com, kuba@kernel.org, bp@alien8.de, luto@kernel.org, krish.sadhukhan@oracle.com, tglx@linutronix.de, vkuznets@redhat.com, jgross@suse.com, martin.petersen@oracle.com, saravanand@fb.com, netdev@vger.kernel.org, sunilmut@microsoft.com, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, kirill.shutemov@linux.intel.com, hannes@cmpxchg.org, cai@lca.pw, akpm@linux-foundation.org, robin.murphy@arm.com, davem@davemloft.net, rppt@kernel.org Subject: Re: [RFC PATCH V3 10/11] HV/Netvsc: Add Isolation VM support for netvsc driver Date: Mon, 7 Jun 2021 23:21:20 +0800 [thread overview] Message-ID: <279cb4bf-c5b6-6db9-0f1e-9238e902c8f2@gmail.com> (raw) In-Reply-To: <20210607065007.GE24478@lst.de> On 6/7/2021 2:50 PM, Christoph Hellwig wrote: > On Sun, May 30, 2021 at 11:06:27AM -0400, Tianyu Lan wrote: >> + if (hv_isolation_type_snp()) { >> + pfns = kcalloc(buf_size / HV_HYP_PAGE_SIZE, sizeof(unsigned long), >> + GFP_KERNEL); >> + for (i = 0; i < buf_size / HV_HYP_PAGE_SIZE; i++) >> + pfns[i] = virt_to_hvpfn(net_device->recv_buf + i * HV_HYP_PAGE_SIZE) + >> + (ms_hyperv.shared_gpa_boundary >> HV_HYP_PAGE_SHIFT); >> + >> + vaddr = vmap_pfn(pfns, buf_size / HV_HYP_PAGE_SIZE, PAGE_KERNEL_IO); >> + kfree(pfns); >> + if (!vaddr) >> + goto cleanup; >> + net_device->recv_original_buf = net_device->recv_buf; >> + net_device->recv_buf = vaddr; >> + } > > This probably wnats a helper to make the thing more readable. But who > came up with this fucked up communication protocol where the host needs > to map random pfns into a contigous range? Sometime I really have to > wonder what crack the hyper-v people take when comparing this to the > relatively sane approach others take. Agree. Will add a helper function. > >> + for (i = 0; i < page_count; i++) >> + dma_unmap_single(&hv_dev->device, packet->dma_range[i].dma, >> + packet->dma_range[i].mapping_size, >> + DMA_TO_DEVICE); >> + >> + kfree(packet->dma_range); > > Any reason this isn't simply using a struct scatterlist? I will have a look. Thanks to reminder scatterlist. > >> + for (i = 0; i < page_count; i++) { >> + char *src = phys_to_virt((pb[i].pfn << HV_HYP_PAGE_SHIFT) >> + + pb[i].offset); >> + u32 len = pb[i].len; >> + >> + dma = dma_map_single(&hv_dev->device, src, len, >> + DMA_TO_DEVICE); > > dma_map_single can only be used on page baked memory, and if this is > using page backed memory you wouldn't need to do thee phys_to_virt > tricks. Can someone explain the mess here in more detail? Sorry. Could you elaborate the issue? These pages in the pb array are not allocated by DMA API and using dma_map_single() here is to map these pages' address to bounce buffer physical address. > >> struct rndis_device *dev = nvdev->extension; >> struct rndis_request *request = NULL; >> + struct hv_device *hv_dev = ((struct net_device_context *) >> + netdev_priv(ndev))->device_ctx; > > Why not use a net_device_context local variable instead of this cast > galore? > OK. I will update. Thanks. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-07 15:21 UTC|newest] Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-30 15:06 [RFC PATCH V3 00/11] x86/Hyper-V: Add Hyper-V Isolation VM support Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 01/11] x86/HV: Initialize GHCB page in Isolation VM Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-06-07 6:41 ` Christoph Hellwig 2021-06-07 6:41 ` Christoph Hellwig 2021-06-07 8:14 ` Tianyu Lan 2021-06-07 8:14 ` Tianyu Lan 2021-06-09 12:38 ` Joerg Roedel 2021-06-09 12:38 ` Joerg Roedel 2021-06-10 14:13 ` Tianyu Lan 2021-06-10 14:13 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 02/11] x86/HV: Initialize shared memory boundary in the " Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 03/11] x86/Hyper-V: Add new hvcall guest address host visibility support Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-05-30 18:25 ` Borislav Petkov 2021-05-30 18:25 ` Borislav Petkov 2021-05-31 4:08 ` Tianyu Lan 2021-05-31 4:08 ` Tianyu Lan 2021-06-10 9:47 ` Vitaly Kuznetsov 2021-06-10 9:47 ` Vitaly Kuznetsov 2021-06-10 14:18 ` Tianyu Lan 2021-06-10 14:18 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 04/11] HV: Add Write/Read MSR registers via ghcb Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-06-09 12:46 ` Joerg Roedel 2021-06-09 12:46 ` Joerg Roedel 2021-06-10 14:15 ` Tianyu Lan 2021-06-10 14:15 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 05/11] HV: Add ghcb hvcall support for SNP VM Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-06-09 12:49 ` Joerg Roedel 2021-06-09 12:49 ` Joerg Roedel 2021-05-30 15:06 ` [RFC PATCH V3 06/11] HV/Vmbus: Add SNP support for VMbus channel initiate message Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 07/11] HV/Vmbus: Initialize VMbus ring buffer for Isolation VM Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 08/11] swiotlb: Add bounce buffer remap address setting function Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-06-07 6:43 ` Christoph Hellwig 2021-06-07 6:43 ` Christoph Hellwig 2021-06-07 14:56 ` Tianyu Lan 2021-06-07 14:56 ` Tianyu Lan 2021-06-10 14:25 ` Tianyu Lan 2021-06-10 14:25 ` Tianyu Lan 2021-06-14 7:12 ` Christoph Hellwig 2021-06-14 7:12 ` Christoph Hellwig 2021-06-14 13:29 ` Tom Lendacky 2021-06-14 13:29 ` Tom Lendacky via iommu 2021-06-14 13:37 ` Tianyu Lan 2021-06-14 13:37 ` Tianyu Lan 2021-06-14 13:42 ` Tianyu Lan 2021-06-14 13:42 ` Tianyu Lan 2021-06-14 13:49 ` Robin Murphy 2021-06-14 13:49 ` Robin Murphy 2021-06-14 15:32 ` Christoph Hellwig 2021-06-14 15:32 ` Christoph Hellwig 2021-06-15 15:24 ` Tianyu Lan 2021-06-15 15:24 ` Tianyu Lan 2021-07-12 9:40 ` Tianyu Lan 2021-07-12 9:40 ` Tianyu Lan 2021-05-30 15:06 ` [RFC PATCH V3 09/11] HV/IOMMU: Enable swiotlb bounce buffer for Isolation VM Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-06-02 1:16 ` Boris Ostrovsky 2021-06-02 1:16 ` Boris Ostrovsky 2021-06-02 15:01 ` Tianyu Lan 2021-06-02 15:01 ` Tianyu Lan 2021-06-02 16:02 ` Boris Ostrovsky 2021-06-02 16:02 ` Boris Ostrovsky 2021-06-03 15:37 ` Tianyu Lan 2021-06-03 15:37 ` Tianyu Lan 2021-06-03 17:04 ` Boris Ostrovsky 2021-06-03 17:04 ` Boris Ostrovsky 2021-06-07 6:44 ` Christoph Hellwig 2021-06-07 6:44 ` Christoph Hellwig 2021-05-30 15:06 ` [RFC PATCH V3 10/11] HV/Netvsc: Add Isolation VM support for netvsc driver Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-06-07 6:50 ` Christoph Hellwig 2021-06-07 6:50 ` Christoph Hellwig 2021-06-07 15:21 ` Tianyu Lan [this message] 2021-06-07 15:21 ` Tianyu Lan 2021-06-14 7:09 ` Christoph Hellwig 2021-06-14 7:09 ` Christoph Hellwig 2021-06-14 14:04 ` Tianyu Lan 2021-06-14 14:04 ` Tianyu Lan 2021-06-14 15:33 ` Christoph Hellwig 2021-06-14 15:33 ` Christoph Hellwig 2021-06-15 14:31 ` Tianyu Lan 2021-06-15 14:31 ` Tianyu Lan 2021-06-10 9:52 ` Vitaly Kuznetsov 2021-06-10 9:52 ` Vitaly Kuznetsov 2021-05-30 15:06 ` [RFC PATCH V3 11/11] HV/Storvsc: Add Isolation VM support for storvsc driver Tianyu Lan 2021-05-30 15:06 ` Tianyu Lan 2021-06-07 6:46 ` Christoph Hellwig 2021-06-07 6:46 ` Christoph Hellwig 2021-06-07 14:59 ` Tianyu Lan 2021-06-07 14:59 ` Tianyu Lan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=279cb4bf-c5b6-6db9-0f1e-9238e902c8f2@gmail.com \ --to=ltykernel@gmail.com \ --cc=Tianyu.Lan@microsoft.com \ --cc=akpm@linux-foundation.org \ --cc=arnd@arndb.de \ --cc=boris.ostrovsky@oracle.com \ --cc=bp@alien8.de \ --cc=brijesh.singh@amd.com \ --cc=cai@lca.pw \ --cc=dave.hansen@linux.intel.com \ --cc=davem@davemloft.net \ --cc=decui@microsoft.com \ --cc=haiyangz@microsoft.com \ --cc=hannes@cmpxchg.org \ --cc=hch@lst.de \ --cc=hpa@zytor.com \ --cc=iommu@lists.linux-foundation.org \ --cc=jejb@linux.ibm.com \ --cc=jgross@suse.com \ --cc=joro@8bytes.org \ --cc=kirill.shutemov@linux.intel.com \ --cc=konrad.wilk@oracle.com \ --cc=krish.sadhukhan@oracle.com \ --cc=kuba@kernel.org \ --cc=kys@microsoft.com \ --cc=linux-arch@vger.kernel.org \ --cc=linux-hyperv@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=luto@kernel.org \ --cc=m.szyprowski@samsung.com \ --cc=martin.petersen@oracle.com \ --cc=mingo@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=peterz@infradead.org \ --cc=robin.murphy@arm.com \ --cc=rppt@kernel.org \ --cc=saravanand@fb.com \ --cc=sstabellini@kernel.org \ --cc=sthemmin@microsoft.com \ --cc=sunilmut@microsoft.com \ --cc=tglx@linutronix.de \ --cc=thomas.lendacky@amd.com \ --cc=vkuznets@redhat.com \ --cc=wei.liu@kernel.org \ --cc=will@kernel.org \ --cc=x86@kernel.org \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.