All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Cc: "J. Bruce Fields"
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Linux NFS Mailing List
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v2 2/7] svcrdma: Clean up RPC-over-RDMA Reply header encoder
Date: Wed, 1 Feb 2017 14:39:08 -0500	[thread overview]
Message-ID: <27A37972-64DA-4300-874A-DF980D150D6B@oracle.com> (raw)
In-Reply-To: <20170201182518.GA32532-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>


> On Feb 1, 2017, at 1:25 PM, Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
> 
> I'm always confused when a cleanup adds more line than it removes,
> but it seems to be just comments in this case and some other
> patches in the series.
> 
>> + * svc_rdma_xdr_encode_reply_header - Encode Reply's fixed header fields
>> + * @rdma: controlling transport
>> + * @rdma_argp: Call's transport header
>> + * @rdma_resp: Reply's transport header
>> + * @rdma_type: procedure number
>> + *
>> + */
>> +void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *rdma,
>> +				      __be32 *rdma_argp, __be32 *rdma_resp,
>> +				      __be32 rdma_type)
> 
> To me it would seem much cleaner to just take the few lines of encoding
> into the only caller.

Fair enough, that's what is done in the backchannel.


--
Chuck Lever



--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	linux-rdma@vger.kernel.org,
	Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 2/7] svcrdma: Clean up RPC-over-RDMA Reply header encoder
Date: Wed, 1 Feb 2017 14:39:08 -0500	[thread overview]
Message-ID: <27A37972-64DA-4300-874A-DF980D150D6B@oracle.com> (raw)
In-Reply-To: <20170201182518.GA32532@infradead.org>


> On Feb 1, 2017, at 1:25 PM, Christoph Hellwig <hch@infradead.org> wrote:
> 
> I'm always confused when a cleanup adds more line than it removes,
> but it seems to be just comments in this case and some other
> patches in the series.
> 
>> + * svc_rdma_xdr_encode_reply_header - Encode Reply's fixed header fields
>> + * @rdma: controlling transport
>> + * @rdma_argp: Call's transport header
>> + * @rdma_resp: Reply's transport header
>> + * @rdma_type: procedure number
>> + *
>> + */
>> +void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *rdma,
>> +				      __be32 *rdma_argp, __be32 *rdma_resp,
>> +				      __be32 rdma_type)
> 
> To me it would seem much cleaner to just take the few lines of encoding
> into the only caller.

Fair enough, that's what is done in the backchannel.


--
Chuck Lever




  parent reply	other threads:[~2017-02-01 19:39 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-31 18:52 [PATCH v2 0/7] Server-side NFS/RDMA changes for v4.11 Chuck Lever
2017-01-31 18:52 ` Chuck Lever
     [not found] ` <20170131184623.14185.35480.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-01-31 18:52   ` [PATCH v2 1/7] svcrdma: Another sendto chunk list parsing update Chuck Lever
2017-01-31 18:52     ` Chuck Lever
2017-01-31 18:53   ` [PATCH v2 2/7] svcrdma: Clean up RPC-over-RDMA Reply header encoder Chuck Lever
2017-01-31 18:53     ` Chuck Lever
     [not found]     ` <20170131185302.14185.10775.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:25       ` Christoph Hellwig
2017-02-01 18:25         ` Christoph Hellwig
     [not found]         ` <20170201182518.GA32532-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-01 19:39           ` Chuck Lever [this message]
2017-02-01 19:39             ` Chuck Lever
2017-01-31 18:53   ` [PATCH v2 3/7] svcrdma: Clean up RPC-over-RDMA Call header decoder Chuck Lever
2017-01-31 18:53     ` Chuck Lever
     [not found]     ` <20170131185310.14185.76931.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:28       ` Christoph Hellwig
2017-02-01 18:28         ` Christoph Hellwig
2017-01-31 18:53   ` [PATCH v2 4/7] svcrdma: Clean up backchannel send header encoding Chuck Lever
2017-01-31 18:53     ` Chuck Lever
     [not found]     ` <20170131185318.14185.90053.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:29       ` Christoph Hellwig
2017-02-01 18:29         ` Christoph Hellwig
     [not found]         ` <20170201182957.GC32532-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2017-02-01 19:48           ` Chuck Lever
2017-02-01 19:48             ` Chuck Lever
2017-01-31 18:53   ` [PATCH v2 5/7] svcrdma: Remove unused sc_dto_q field Chuck Lever
2017-01-31 18:53     ` Chuck Lever
     [not found]     ` <20170131185326.14185.48454.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:30       ` Christoph Hellwig
2017-02-01 18:30         ` Christoph Hellwig
2017-01-31 18:53   ` [PATCH v2 6/7] svcrdma: Combine list fields in struct svc_rdma_op_ctxt Chuck Lever
2017-01-31 18:53     ` Chuck Lever
     [not found]     ` <20170131185335.14185.80060.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:30       ` Christoph Hellwig
2017-02-01 18:30         ` Christoph Hellwig
2017-01-31 18:53   ` [PATCH v2 7/7] svcrdma: Poll CQs in "workqueue" mode Chuck Lever
2017-01-31 18:53     ` Chuck Lever
     [not found]     ` <20170131185343.14185.76984.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
2017-02-01 18:31       ` Christoph Hellwig
2017-02-01 18:31         ` Christoph Hellwig
2017-02-06 22:39   ` [PATCH v2 0/7] Server-side NFS/RDMA changes for v4.11 J. Bruce Fields
2017-02-06 22:39     ` J. Bruce Fields
     [not found]     ` <20170206223918.GE19704-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2017-02-06 22:48       ` Chuck Lever
2017-02-06 22:48         ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27A37972-64DA-4300-874A-DF980D150D6B@oracle.com \
    --to=chuck.lever-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
    --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.