From: "Ramirez Luna, Omar" <omar.ramirez@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
Hiroshi Doyu <Hiroshi.DOYU@nokia.com>,
Ameya Palande <ameya.palande@nokia.com>,
Felipe Contreras <felipe.contreras@nokia.com>,
"Guzman Lugo, Fernando" <x0095840@ti.com>,
"Ramos Falcon, Ernesto" <ernesto@ti.com>
Subject: RE: [PATCH 6/8] DSPBRIDGE: Use dspbridge to initialize platform data
Date: Fri, 8 Jan 2010 10:48:27 -0600 [thread overview]
Message-ID: <27F9C60D11D683428E133F85D2BB4A53042DC9524E@dlee03.ent.ti.com> (raw)
In-Reply-To: <4B469884.1080209@ti.com>
>From: Menon, Nishanth
>
>Ramirez Luna, Omar had written, on 01/07/2010 07:00 PM, the following:
>> Include dspbridge compilation whenever bridge driver is selected to
>> be compiled, either as a module or part of the kernel. This will
>> initialize platform data specific PM functions.
>?? are you intending to state that dspbridge.c can now not be a module?
Yes, if bridge is selected it will include dspbridge as part of the kernel, leaving bridgedriver to be installed depending on selected option (module or built in)
>can you elaborate more as to why?
Lately EXPORT_SYMBOL has been removed from pm functions, bridge depends on those symbols and now that they can't be resolved at runtime (or insmod time), then dspbridge driver needs to be compiled as part of the kernel to resolve them on its platform data structure, otherwise linking will break.
>
>>
>> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>
>> ---
>> arch/arm/mach-omap2/Makefile | 4 +++-
>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile
>> index d1cf986..0881470 100644
>> --- a/arch/arm/mach-omap2/Makefile
>> +++ b/arch/arm/mach-omap2/Makefile
>> @@ -75,7 +75,9 @@ obj-y += $(i2c-omap-m) $(i2c-omap-y)
>> # Debobs
>> obj-$(CONFIG_OMAP3_DEBOBS) += debobs.o
>?? I dont find this in l-o master/2.6.32.. something I am missing?
>
>>
>> -obj-$(CONFIG_MPU_BRIDGE) += dspbridge.o
>> +ifneq ($(CONFIG_MPU_BRIDGE),)
>> +obj-y += dspbridge.o
>> +endif
>
>>
>> # Specific board support
>> obj-$(CONFIG_MACH_OMAP_GENERIC) += board-generic.o
>
>
>--
>Regards,
>Nishanth Menon
next prev parent reply other threads:[~2010-01-08 16:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 1:00 [PATCH 6/8] DSPBRIDGE: Use dspbridge to initialize platform data Omar Ramirez Luna
2010-01-08 2:29 ` Nishanth Menon
2010-01-08 16:48 ` Ramirez Luna, Omar [this message]
2010-01-08 16:51 ` Nishanth Menon
2010-01-08 17:58 ` Ramirez Luna, Omar
2010-01-08 19:05 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27F9C60D11D683428E133F85D2BB4A53042DC9524E@dlee03.ent.ti.com \
--to=omar.ramirez@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=ameya.palande@nokia.com \
--cc=ernesto@ti.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.