All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Hostetler <git@jeffhostetler.com>
To: Jeff King <peff@peff.net>, Duy Nguyen <pclouds@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	"René Scharfe" <l.s.r@web.de>,
	wink@saville.com, "Ramsay Jones" <ramsay@ramsayjones.plus.com>,
	"Jeff Hostetler" <jeffhost@microsoft.com>
Subject: Re: [PATCH v4] json_writer: new routines to create data in JSON format
Date: Mon, 4 Jun 2018 05:41:23 -0400	[thread overview]
Message-ID: <27b02292-9434-edfb-fa43-549973bf7b93@jeffhostetler.com> (raw)
In-Reply-To: <20180602051344.GA28311@sigill.intra.peff.net>



On 6/2/2018 1:13 AM, Jeff King wrote:
> On Sat, Jun 02, 2018 at 06:41:06AM +0200, Duy Nguyen wrote:
> 
>> On Mon, Mar 26, 2018 at 4:31 PM,  <git@jeffhostetler.com> wrote:
>>> +static inline void assert_in_array(const struct json_writer *jw)
>>> +{
>>> +       if (!jw->open_stack.len)
>>> +               die("json-writer: array: missing jw_array_begin()");
>>
>> When you reroll, please consider marking all these string for
>> translation with _(), unless these are for machine consumption.
> 
> Actually, these are all basically asserts, I think. So ideally they'd be
> BUG()s and not translated.

Yes, these are basically asserts.  I'll convert them to BUG's and send
up another version this week.

Thanks
Jeff


      reply	other threads:[~2018-06-04  9:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 14:31 [PATCH v4] routines to generate JSON data git
2018-03-26 14:31 ` [PATCH v4] json_writer: new routines to create data in JSON format git
2018-03-27  3:18   ` Ramsay Jones
2018-03-27 10:28     ` Jeff Hostetler
2018-03-27 15:45     ` Ramsay Jones
2018-03-27 17:14       ` Jeff Hostetler
2018-03-27 17:43         ` Wink Saville
2018-03-27 18:00           ` Randall S. Becker
2018-03-28  5:22             ` Junio C Hamano
2018-03-27 18:05         ` Ramsay Jones
2018-03-28  1:22       ` Junio C Hamano
2018-06-02  4:41   ` Duy Nguyen
2018-06-02  5:13     ` Jeff King
2018-06-04  9:41       ` Jeff Hostetler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27b02292-9434-edfb-fa43-549973bf7b93@jeffhostetler.com \
    --to=git@jeffhostetler.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jeffhost@microsoft.com \
    --cc=l.s.r@web.de \
    --cc=pclouds@gmail.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsayjones.plus.com \
    --cc=wink@saville.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.