From: Ramsay Jones <ramsay@ramsayjones.plus.com>
To: git@jeffhostetler.com, git@vger.kernel.org
Cc: gitster@pobox.com, peff@peff.net, l.s.r@web.de, wink@saville.com,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v4] json_writer: new routines to create data in JSON format
Date: Tue, 27 Mar 2018 16:45:17 +0100 [thread overview]
Message-ID: <ad15ccab-088d-b827-a9fa-c83d397c3479@ramsayjones.plus.com> (raw)
In-Reply-To: <ce076d5e-f30f-006e-a25e-ff1a900562bf@ramsayjones.plus.com>
On 27/03/18 04:18, Ramsay Jones wrote:
> On 26/03/18 15:31, git@jeffhostetler.com wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
> [snip]
>
> Thanks, this version fixes all issues I had (with the compilation
> and sparse warnings).
>
> [Was using UINT64_C(0xffffffffffffffff) a problem on windows?]
BTW, I forgot to mention that you had some whitespace problems
with this patch, viz:
$ git log --oneline -1 --check master-json
ab643d838 (master-json) json_writer: new routines to create data in JSON format
t/helper/test-json-writer.c:280: trailing whitespace.
+ */
t/t0019-json-writer.sh:179: indent with spaces.
+ "g": 0,
t/t0019-json-writer.sh:180: indent with spaces.
+ "h": 1
$
ATB,
Ramsay Jones
next prev parent reply other threads:[~2018-03-27 15:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 14:31 [PATCH v4] routines to generate JSON data git
2018-03-26 14:31 ` [PATCH v4] json_writer: new routines to create data in JSON format git
2018-03-27 3:18 ` Ramsay Jones
2018-03-27 10:28 ` Jeff Hostetler
2018-03-27 15:45 ` Ramsay Jones [this message]
2018-03-27 17:14 ` Jeff Hostetler
2018-03-27 17:43 ` Wink Saville
2018-03-27 18:00 ` Randall S. Becker
2018-03-28 5:22 ` Junio C Hamano
2018-03-27 18:05 ` Ramsay Jones
2018-03-28 1:22 ` Junio C Hamano
2018-06-02 4:41 ` Duy Nguyen
2018-06-02 5:13 ` Jeff King
2018-06-04 9:41 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad15ccab-088d-b827-a9fa-c83d397c3479@ramsayjones.plus.com \
--to=ramsay@ramsayjones.plus.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=wink@saville.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.