* [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter
@ 2020-07-31 7:45 Patrice Chotard
2020-07-31 17:47 ` Marek Vasut
0 siblings, 1 reply; 4+ messages in thread
From: Patrice Chotard @ 2020-07-31 7:45 UTC (permalink / raw)
To: u-boot
node varaible is used as iterator into ofnode_for_each_subnode()
loop, when exiting of it, node is no more a valid ofnode.
Use dwc3_node instead as parameter of ofnode_valid()
Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Cc: Kever Yang <kever.yang@rock-chips.com>
---
drivers/usb/host/dwc3-sti-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/dwc3-sti-glue.c b/drivers/usb/host/dwc3-sti-glue.c
index a72ab20168..3e6c1429d6 100644
--- a/drivers/usb/host/dwc3-sti-glue.c
+++ b/drivers/usb/host/dwc3-sti-glue.c
@@ -159,7 +159,7 @@ static int sti_dwc3_glue_bind(struct udevice *dev)
dwc3_node = node;
}
- if (!ofnode_valid(node)) {
+ if (!ofnode_valid(dwc3_node)) {
pr_err("Can't find dwc3 subnode for %s\n", dev->name);
return -ENODEV;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter
2020-07-31 7:45 [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter Patrice Chotard
@ 2020-07-31 17:47 ` Marek Vasut
2020-08-03 7:37 ` Patrice CHOTARD
0 siblings, 1 reply; 4+ messages in thread
From: Marek Vasut @ 2020-07-31 17:47 UTC (permalink / raw)
To: u-boot
On 7/31/20 9:45 AM, Patrice Chotard wrote:
> node varaible is used as iterator into ofnode_for_each_subnode()
> loop, when exiting of it, node is no more a valid ofnode.
> Use dwc3_node instead as parameter of ofnode_valid()
>
> Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
Looks OK to me, feel free to pick it via ST tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter
2020-07-31 17:47 ` Marek Vasut
@ 2020-08-03 7:37 ` Patrice CHOTARD
2020-08-13 10:03 ` [Uboot-stm32] " Patrice CHOTARD
0 siblings, 1 reply; 4+ messages in thread
From: Patrice CHOTARD @ 2020-08-03 7:37 UTC (permalink / raw)
To: u-boot
On 7/31/20 7:47 PM, Marek Vasut wrote:
> On 7/31/20 9:45 AM, Patrice Chotard wrote:
>> node varaible is used as iterator into ofnode_for_each_subnode()
>> loop, when exiting of it, node is no more a valid ofnode.
>> Use dwc3_node instead as parameter of ofnode_valid()
>>
>> Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
> Looks OK to me, feel free to pick it via ST tree.
Ok thanks
Patrice
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Uboot-stm32] [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter
2020-08-03 7:37 ` Patrice CHOTARD
@ 2020-08-13 10:03 ` Patrice CHOTARD
0 siblings, 0 replies; 4+ messages in thread
From: Patrice CHOTARD @ 2020-08-13 10:03 UTC (permalink / raw)
To: u-boot
On 8/3/20 9:37 AM, Patrice CHOTARD wrote:
> On 7/31/20 7:47 PM, Marek Vasut wrote:
>> On 7/31/20 9:45 AM, Patrice Chotard wrote:
>>> node varaible is used as iterator into ofnode_for_each_subnode()
>>> loop, when exiting of it, node is no more a valid ofnode.
>>> Use dwc3_node instead as parameter of ofnode_valid()
>>>
>>> Fixes: ac28e59a574d ("usb: Migrate to support live DT for some driver")
>> Looks OK to me, feel free to pick it via ST tree.
Applied on u-boot-stm/master
Thanks
> Ok thanks
>
> Patrice
> _______________________________________________
> Uboot-stm32 mailing list
> Uboot-stm32 at st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-13 10:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31 7:45 [RESEND][PATCH] usb: host: dwc3-sti-glue: Fix ofnode_valid() parameter Patrice Chotard
2020-07-31 17:47 ` Marek Vasut
2020-08-03 7:37 ` Patrice CHOTARD
2020-08-13 10:03 ` [Uboot-stm32] " Patrice CHOTARD
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.